- 19 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5e8f6b40233..1400dda5de60 2020-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 04bd4d8e4ece to df17a76102df (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I994be689013cf27e166a8ca605546651df3cb81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818363}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/89eeef5150cb..87dd38763359 2020-10-19 dberris@chromium.org chromeperf: Remove Mac testing from presubmit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1132884 Tbr: wenbinzhang@google.com Change-Id: I8edece296ed84952c990c0023305050704df2dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483527Reviewed-by:
-
Jérémie Boulic authored
Tests crrev.com/c/2423448. Bug: chromium:912236 Test: browser_tests --gtest_filter=FileManagerJsTest.FileTasks Change-Id: Iefca4742d6fb154c5c1a392d0da14af796a792a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467162Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#818361}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a9da93c46a90..64d02136b235 2020-10-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib348125d88c8c2a951dba18b491af12b0bad1625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484126Reviewed-by:
-
Shik Chen authored
This CL updates the version for env and parser, and removes some unnecessary globals in the config. Bug: 1139102 Test: Presubmit checks Change-Id: I9b916b0a3a7fa32a744b84ef78bcd333efa85e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483736 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#818359}
-
Christopher Lam authored
Bug: 1110666 Change-Id: I5968ba3db606fb07e15bf8972556a80642e8c8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483715Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#818358}
-
Melissa Zhang authored
This reverts commit 1ac9a1da. Reason for revert: Breaking UI Original change's description: > Change ButtonPressed overrides to callbacks: c/b/ui/views/sharesheet/ > > This allows converting |targets_| from a member to a parameter that's > passed around. I also did some other cleanup while there. > > Bug: 772945 > Change-Id: Iaa7f70594ba109d1598da3566856e90c8b09629d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481246 > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Reviewed-by: Melissa Zhang <melzhang@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818324} TBR=pkasting@chromium.org,melzhang@chromium.org Change-Id: Ief930a27f44caef219bf782a7534ef8bc76d83ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483745Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818357}
-
Ramin Halavati authored
A function is added to create Guest test browsers and existing use cases are updated. Bug: 1125474, 1061637 Change-Id: I56c8a11d409f5b0fb2a6baf25447f4e7c535b644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474697Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#818356}
-
Xianzhu Wang authored
This reverts commit bc2f9ba0. Reason for revert: The test is still flaky. Original change's description: > Reenable scroll-animations/element-based-offset tests > > The underlying source of the test flakes was likely addressed in > recent changes to the handling of play and pause for scroll-linked > animations. > > https://chromium-review.googlesource.com/c/chromium/src/+/2386339 > > This patch also contains a cleanup to remove the unnecessarily > convoluted way of hiding the scrollbar for the clamped offset test. > > Tested with 1000+ retries of the two tests in a virtual threaded > environment. > > Bug: 1080609 > Change-Id: If9097b0a2017a9c87a359b61ba93f35bae56b512 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475935 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Kevin Ellis <kevers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817568} TBR=kevers@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1080609 Change-Id: Ic31eede5561182d78e7bf805cd1f112edfd5379c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483585Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818355}
-
Alice Boxhall authored
TBR=joonbug@chromium.org Bug: 1139523 Change-Id: I03307649b4d5eb833650d578313e3a37645fe947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484024Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#818354}
-
Adam Rice authored
The WenSocket web_tests connect-error-by-no-websocket-server-closeonclose.html connect-error-by-no-websocket-server-closeonerror.html connect-error-by-no-websocket-server-noclose.html have been failing on Windows 10 1909. In this version of Windows the delay on connecting to a closed localhost port has increased from 1 second to 3 seconds. Adjust the timeout in the tests to match. BUG=1132194 Change-Id: I11b69ea3ed15daa9ab9dff2ce22672c706867da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483717 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#818353}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iaf5562a64bf812cf289f37288538b1e78e91961b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483884Reviewed-by:
-
Noel Gordon authored
Instead of "fake_test_name", collect coverage for the given test_name, which would be the browser test fixture name in practice. Tbr: benreich Bug: 1113941 Change-Id: Ib6b4a30cc09a37def86d3f0267a2596cda370602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483731Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#818351}
-
Nicholas Hollingum authored
This infrastructure is being built, but for now we can proceed without it. Until it is completed, users may have to retry actions while the vm is actually still starting up. Bug: b/162562622 Change-Id: I093647b931b8d33ba598054d29aea3b69e8aa670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472679 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#818350}
-
Noel Gordon authored
Add a using directive: a C++ shorthand to describe the contents of the of agent hosts to devtools listener map. Tbr: benreich Bug: 1113941 Change-Id: Iea4b34b056654315d8e0e1382f584326b50122a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484027Reviewed-by:
-
Shik Chen authored
Bug: 1139102 Test: Pass ESLint with https://crrev.com/c/2478884 Change-Id: I2a443b1e13ab72bb24616acb10cb191564ff71b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480102 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
-
Wei Lee authored
This CL fixes a bug which will happen when renaming a folder name which is displayed with its i18n name. The underlying folder name will be unexpectedly renamed to its i18n name even when there is no actual modification for rename input. Bug: 1139205 Test: Manually Change-Id: I6059b7158bc01a457ca7888572c40ffdf0fa6413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477056Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4394032b4d4b..b74a39b2dc30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aboxhall@google.com Change-Id: I2390f5ced4027d1e85ed9c589bff89d835dae731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483883Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818346}
-
Ken Rockot authored
Bug: 1004256 Change-Id: I69c86f126dfe7c24e326f23848b26de71de7bf4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459570Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#818345}
-
Bartek Nowierski authored
Continuation of crrev.com/c/2466007 Change-Id: I6efbfb1113bcf8ffd0d31fe510ee229bc9133893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482226 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#818344}
-
Noel Gordon authored
Not used (since CollectCodeCoverage creates its own coverage_store) so we can remove this DevToolsListerBrowserTest member. Tbr: benreich Bug: 1113941 Change-Id: Iebe50b99bc3a0652b8c845c7311e69c5855979fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483545Reviewed-by:
-
Noel Gordon authored
Only CollectCodeCoverage() needs tmp_dir_ so create it there (when the browser test is collecting code coverage). Tbr: benreich Bug: 1113941 Change-Id: Ib92b271ec76f8c6f42f4f704467bc00cbf3b688a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483984Reviewed-by:
-
Bartek Nowierski authored
Continuation of crrev.com/c/2466007 Change-Id: Idde6926a2dc186fe843052b5f312c16576a641fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482563 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
Add the Stadia label to the DefaultAppName enum in enums.xml. Bug: 1125414 Change-Id: I31a66972a0a7705e6b3bcac32b4674611fd9365b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474079 Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#818340}
-
Amin Hassani authored
Added four error codes missing. BUG=None TEST=None Change-Id: I880450af8f18b1dc9f8c555ffe1b89b35e7f5708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472596 Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Amin Hassani <ahassani@chromium.org> Cr-Commit-Position: refs/heads/master@{#818339}
-
Jing Wang authored
This is required for cl/336785311 Bug: 1137621 Change-Id: I099244a1f754955969b68b3c6478fb72e4b99db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473617Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#818338}
-
Kent Tamura authored
We should assume a percent-height fieldset is HasDescendantThatDependsOnPercentageBlockSize() because the fieldset content box has a kind of a percent-height if the fieldset has a percent-height. Bug: 1138204 Change-Id: Ic9307c190e5aacb8bc47485059d1bdeefa0fedd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479482Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#818337}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603040487-eaa3c4357e49dc6962268bee93995df4eace45df.profdata to chrome-linux-master-1603064915-c9f8d0200bc967fb7a01c85287c3d990be09cab2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iaa26a4a2b8995be7bedb4d6186b5f3362887a386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484124Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c4e97da9c2d..4394032b4d4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aboxhall@google.com Change-Id: I5d84055ee27a0a8d8a31ac1ec4093118e9a41a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483574Reviewed-by:
-
Zhaoliang Ma authored
memcpy is used to copy a linear buffer to the dst linear buffer, this CL replaces it with libyuv::CopyPlane. Bug: None Change-Id: I2741aed2defe526bdba9106695933037a541bcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474913Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/master@{#818334}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/188d0fe69b67..2be35682cd67 2020-10-18 m.maiya@samsung.com Add sRGBOverrideFormats end2end test 2020-10-18 m.maiya@samsung.com Vulkan: Implement EXT_texture_sRGB_decode 2020-10-18 jmadill@chromium.org Fix VertexAttributeTest.DrawArraysWithBufferOffset. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: GLES31/functional_android_extension_pack_extensions_ext_texture_srgb_decodeTest: Test: GLES31/functional_debug_negative_coverage_*_srgb_decode_*Test: Test: GLES31/functional_state_query_sampler_*_srgb_decode_*Test: Test: GLES31/functional_state_query_texture_*_srgb_decode_*Test: Test: angle_end2end_testsTest: Test: angle_end2end_tests --gtest_filter=SRGBTextureTest.*Vulkan*Test: Test: dEQP.GLES31/functional_srgb_texture_decode_skip_decode_* Change-Id: I1dcb53c11a85cd70be2bd29278fbe2daa8d7e4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483660Reviewed-by:
-
Darren Shen authored
Causes a DCHECK failure when running in debug mode: Check failed: performing_user_action_. Add a test to cover this. Change-Id: I99fc1b8e52056e8dc954abf466e0cfcc9435197b Bug: 952757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483942 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#818332}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603040487-b7e085dfa5b01aa0e050891b4bb7d6888509a540.profdata to chrome-mac-master-1603064915-3fa327824899e1fa6f9fcc538942d9b17661b83b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I498bc12139788953345d95b7445c73ccf136e793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483578Reviewed-by:
-
Peter Kasting authored
* Make ui/views/.clang-tidy additive to the base file, not a replacement. * Hoist the "use equals" config option to the base file, since that's Chromium style. * Update docs for errors or inclarities. Bug: none Change-Id: I7f22db99d9ff11fc91665776887a02f7184427ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483344 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#818330}
-
Noel Gordon authored
Add vmodule logging to log the content of CDP messages received by the devtools listener from the content::DevToolsAgentHost. Add the command line switch --vmodule=devtools_listener=2 to enable vmodule logs. Tbr: benreich Bug: 1113941 Change-Id: I3b91bad8dba44183a1f4a0a0ae8618311f734a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483707Reviewed-by:
-
Joel Hockey authored
Change-Id: I5e3e8fc5c8a4ca0c1bfc1af6dd1076914eab4619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483743 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#818328}
-
Antonio Gomes authored
CL also moves kHideShelfWhenFullscreenKey declaration to //chromeos. Both properties are needed for immersive_mode_controller_ash.cc. This is phase 3 on the design document [1], and it a preparation for making ImmersiveModeControllerAsh also available to LaCrOS. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ R=jamescook@chromium.org, oshima@chromium.org, sky@chromium.org BUG=1113900 Change-Id: I41b68c31cc5857890704d9a2288066be292bb314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477533 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This CL duplicates AppCacheDiskCache{,Entry} into ServiceWorkerDiskCache{,Entry} to remove the AppCache dependency from service workers. See [1] for the reasoning of this duplication. To avoid risks of behavior changes, this CL only makes minimum tweaks which includes: * Address Tricium warnings (use default member initializers, prefer emplace_back). * Follow the current coding style guide. * Remove `use_simple_cache_` flag. It's always true for service workers. * Add a sequence checker. Follow-up CLs will do some refactoring like addressing crbug.com/586174. [1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/ Bug: 1117369 Change-Id: Ia62fe55a23c2c84b569516e97e0059994c7755bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452029 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Victor Costan <pwnall@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818326}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c66973fd885f..2c4e97da9c2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ie94a9fd3104b8dc09d67a81a1de41aad23a1583a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483500Reviewed-by:
-
Peter Kasting authored
This allows converting |targets_| from a member to a parameter that's passed around. I also did some other cleanup while there. Bug: 772945 Change-Id: Iaa7f70594ba109d1598da3566856e90c8b09629d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481246 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
-
