- 13 Nov, 2020 40 commits
-
-
Nico Weber authored
I was very confused by asan not catching an out-of-bounds read of a global. Turns out we turn it off. Let's not do that. Bug: 352073 Cq-Include-Trybots: luci.chromium.try:mac_chromium_asan_rel_ng Change-Id: I299a40a125de6a5addc26fa9d2fbdf39b6f66169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527366 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#827214}
-
Matthias Körber authored
The metric counts the number of total, accepted and corrected fields in a form at submission time. Change-Id: Ie2208dcdde78a4b72f5ffb7e9d980a7719c7a19d Bug: 1146465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523181 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#827213}
-
Alex Tkachenko authored
Change-Id: I6e279db73eefa378d00efc6ebbe6376374023fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526400Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#827212}
-
Hirokazu Honda authored
V4L2VEA::Flush() code doesn't work if it uses ImageProcessor. This CL changes V4L2VEA so that its Flush() works regardless of using ImageProcessor. Bug: 1128768 Test: video_encode_accelerator_tests on kukui Change-Id: Ief9fab611ecd015c0e6e17784f27821809d270bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537515 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#827211}
-
Alice Wang authored
This CL fixes the bug that bottom sheet is sometimes positioned on the top of the screen because the argument width is 0. Bug: 1146429, 1143637 Change-Id: Ic2bc823139b9f5bcd2fcfed435d221a210bde092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526347Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827210}
-
Anupam Snigdha authored
When the inline elements are wrapped around nested block elements or line breaks, |CompositeEditCommand::CloneParagraphUnderNewElement| clones the entire inline element without taking the block elements into consideration and then copies into <div> that is inside a <blockquote> element. This leads to duplication of content. Fix is to check for this scenario and properly split the elements so the contents are not copied incorrectly. Test: web_tests/editing/execCommand/indent/indent_blockquote_with_inline_nested_paragraphs.html Change-Id: I63bf0af34ea2fa8a89003d1a0090a3ad453bf1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536933Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827209}
-
Alice Wang authored
This CL removes the metric DISMISSED_OTHER recording in the web sign-in bottom sheet as this metric is recorded too widely for example when the user actually signed in with the bottom sheet. We should calculate this metric by taking the difference between the total number that bottom sheet shows up and that user has an effective action. Bug: 1148307 Change-Id: I4acd06fed81af86b934ec8eba0f27920c67a3287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534893Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827208}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605225603-3e78f0541b05b7200384abc9a699177331fd68ec.profdata to chrome-linux-master-1605247142-11a98e7e9af1f9b1590d22222c9b4c2fb5a6de28.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I52414d72bc036dac89c0de34513277ab82eb73f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827207}
-
Timothy Loh authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ea8666738ad0..9ec6b6802d3f $ git log ea8666738..9ec6b6802 --date=short --no-merges --format='%ad %ae %s' 2020-11-03 timloh cros-disks: Query the bus and device numbers of udev devices Created with: roll-dep src/third_party/cros_system_api Change-Id: If6c8876ee3535b9f3c23ee474a8c29dd70ea7cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537503 Commit-Queue: Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Timothy Loh <timloh@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827206}
-
dpapad authored
This is no longer necessary, as it was only needed by the unpak_pak.py script, which is no longer used and has been deleted since r819987. Bug: 1132403 Change-Id: I5cd09e4e9c345b649256c3962c0cf0ffddd596a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533648 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827205}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/daab6896e293..90e958b4cd20 2020-11-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cc31f06a..6e17f939 (827051:827170) 2020-11-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 56e88353..cc31f06a (825974:827051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I310a9e9072c106fc5e8bea2e8d973285e084dccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536840Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/79f7371f4fc8..1c8311278ae8 2020-11-13 tsepez@chromium.org Remove most CFXJSE_Value usage from CFXJSE_FormCalcContext. 2020-11-12 tsepez@chromium.org pdfium_test: exit cleanly if V8 snapshot files not found. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ib5b399ec16f10d3e536d441cd932647f85570f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537372Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605225603-5553135a8604afd70a132d716de6c70ddfcfdb1a.profdata to chrome-mac-master-1605247142-4988315bd20c8dff060ce85c8c55840f23094b85.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5e953c619da40f970ea701294c77bfa9ff074ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536835Reviewed-by:
-
Peter Marshall authored
These have been ported to frontend unit tests. Bug: 1148495 Change-Id: Iab9845b29cd1c8fc92d9ab6606c279a613e0abea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536330 Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#827201}
-
Jesse McKenna authored
This change migrates uses of base::Bind to BindOnce/BindRepeating, and uses of base::Callback to OnceCallback/RepeatingCallback. Please see crbug.com/714018 for full details about the migration. Bug: 1147284 Change-Id: Iaca33379eb8d81e667488bbdbc6fb8b053fcfd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534609 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#827200}
-
Gyuyoung Kim authored
This CL migrates FrameHostMsg_SynchronizeVisualProperties IPC message to RemoteFrameHost Mojo interface. To do that, this CL moves FrameVisualProperties struct from //content to //blink. Then, this CL introduces SetSynchronizeVisualProperties function in WebRemoteFrame class in order to make RenderFrameProxy::SynchronizeVisualProperties call SynchronizeVisualProperties in blink. Bug: 1093956 Change-Id: I38088e71df5d1d7743c6ec1826b17301b6bc57b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376766 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#827199}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/334494bde984..fb0a62e988de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yutak@google.com Change-Id: Ic240ee9cee48aae671f1ee373749296dbc0f485d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536834Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827198}
-
Aya ElAttar authored
- Changed the managed icon show in managed toasts to SystemMenuBusiness icon. - Attached in the bug screenshots of how the previous and the current icons look in toasts. Bug: 1148285 Change-Id: Idbb2737d0b6dd4a13028786b5d4ae1939566b50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532081Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827197}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8343d0cf8953..2dd866e9ca87 2020-11-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I29b8e44d449cb3eb580e06842fa9774b657a5f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536939Reviewed-by:
-
Michael Lippautz authored
Reuse the WTF macro in platform/heap/ to avoid maintaining two macros. Bug: chromium:1056170 Change-Id: I3c3867c798ff76eeed72050674c6709a39d5f018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533776 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 96dd7ef2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: If27c52942450284367f443483054640d9bf246a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536492Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827194}
-
Rakina Zata Amni authored
To use memory more efficiently, we're using a deque of chunks so that sent can be removed immediately after we're finished sending it. Also, protects the buffering behind a flag (later on we'll do it only when we're deferring due to bfcache, when it's possible to know that). Bug: 1148064 Change-Id: I13902906675a337bf8e02653f0a7f23e4f579ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531803 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827193}
-
Xing Liu authored
Currently bookmark root node has 4 children instead of 5. The DCHECK is never ran. The java code calling into this is probably dead code, added a comment. Bug: 1148498 Change-Id: I20630b20ba8454665a8d1721f62e2baa312263b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535923Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827192}
-
Alan Ding authored
Update union tag bindings to support C++ code style recommendation. Keep previous style until there is enough support for camel case to deprecate *_VALUE enums. This CL was done as part of Chrome U 2020 codelabs exercise. BUG=chromium:1093757 TEST=builds, deployed, and git cl try. Change-Id: Ifbab11199dd64354be8fb84d2f8ee173c572ef5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533323Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alan Ding <alanding@chromium.org> Cr-Commit-Position: refs/heads/master@{#827191}
-
Fergal Daly authored
This reverts commit 1b3c1be9. Reason for revert: This is causing timeouts for lots of PDF tests on many dbg builders (see bug). I don't understand why but I have reproduced it locally and bisected and confirmed that this CL is culprit. Original change's description: > Add field trial config for HighPriorityBeforeUnload. > > Change-Id: Ia274d2e51503514c3fc98420fa4eee5eb040e1fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490782 > Commit-Queue: Katie Dillon <kdillon@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826894} TBR=sky@chromium.org,kdillon@chromium.org Change-Id: Id2c0f05304e515034efa769ded1bd38c61b1a53f BUG: 1148674 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537275Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#827190}
-
Frank Tang authored
1. Memory READ by ASAN in ListFormatter when there are >= 9 items in the list. 2. Intl.Locale ASAN problem when there are 9 or more Unicode extensions. 3. Windows default Timezone Detection bug https://chromium.googlesource.com/chromium/deps/icu.git/+log/c2a4cae..7db579a7 7db579a Fix windows TZ detection code for New York by Frank Tang · 10 minutes ago master efc5885 Fix Locale::setKeywordValue bug found by fuzzer by Frank Tang · 8 hours ago 3d57452 Fix memory READ by ASAN in ListFormatter by Frank Tang · 31 hours ago c7eaeed Fix memory READ by ASAN in ListFormatter by Frank Tang · 2 days ago TBR=jshin@chromium.org Bugs: 1147305, 1146468, 1146068 Change-Id: Iad839ac77d487d5e1b396bcdbc29bc7cd58a7ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536432Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827189}
-
Mason Freed authored
The [1] CL again changed the opt-in interface for declarative Shadow DOM, and I forgot to update the perf test. This CL makes that update. I wish there were perf bots in the CQ. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2530222 Bug: 1042130 Fixed: 1148583 Change-Id: Icee204fd4fecc2926dbe50ab7c08b36643d11c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536451Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#827188}
-
Christopher Cameron authored
This adds a side-channel through which a gfx::HDRMetadata can be attached to an IOSurface. In practice this can be written by the software decoder in the renderer process and read by the compositor in the GPU process. Bug: 1101041 Change-Id: I36a8f0cc8562fe1daa2e3e4c131aa7f305644aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531655 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827187}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8d69298d9b29..b6f4d53126d3 2020-11-13 brandon1.jones@intel.com Only Increment Serials When Necessary On D3D12 2020-11-13 enga@chromium.org dawn_wire: Protect against large allocations in ChunkedCommandHandler If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1145204 Tbr: sarahmashay@google.com Change-Id: I46a43ad37e3828214e3585d775c582b820687f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536832Reviewed-by:
-
Noel Gordon authored
Testing noted the bug was already fixed. Changed tack here therefore, to use the correct closing </cr-action-menu> tag. No need for a role= menu on this <cr-action-menu> element: WAI in M88 testing. Bug: 1134438 Change-Id: I78ea53e34324bfdcffa53927d6a72136f4edb7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534423Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827185}
-
Alan Cutter authored
This CL adds chrome/browser/resources/preinstalled_web_apps/internal to .gitignore in preparation for adding it to src-internal: https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/3402544 No-Try: true Bug: 1147692 Change-Id: I2b42c5c9b1b6c5da267366dbf6354be7fafc6859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537274Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827184}
-
Fergus Dall authored
Currently AppServiceAppWindowLauncherController assumes that whether or not crostini is allowed won't change at runtime, which is incorrect. In particular, trying to launch an app after crostini was allowed at runtime will cause a null pointer deref because the CrostiniTracker won't be created. Instead don't try to check enterprise policy here, let that be enforced by the crostini restarter code and web UI. Bug: 1015345 Change-Id: I5f0c3e450ff9f2f62b7eb643207508182ea3747e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505701Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#827183}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2a9b38f2dacd..f92a7636da65 2020-11-13 bsheedy@chromium.org [typ] Fix ResultSink expectations 2020-11-13 cduvall@chromium.org Fork WebView startup metric to use for WebLayer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1146438,chromium:998329 Tbr: zhanliang@google.com Change-Id: Ic4ea9eef3f240fd43f5a0b58270c0a2658d2bbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537092Reviewed-by:
-
Xiaoqian Dai authored
- Change the fullscreen string to be consistent in image capture and video capture scenarios - Click/Tap anywhere can start fullscreen capture TODO: - cursor change will be done in a following up cl. Bug: 1142937 Change-Id: Ife37530245cbc48f8c75be0756d4d45157aac874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536081Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#827181}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605203985-641ad6c9d1aaad676b930873880400e5a1a9a471.profdata to chrome-win64-master-1605214676-526d40dc9a19a8d8de1faf37cfb00f9c1ab93ead.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I27f99c49989f976ec43e0c4e456fa187efa66406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536892Reviewed-by:
-
Mason Freed authored
This ensures Trusted Types are aware of setInnerHTML as a powerful sink. Bug: 1042130 Change-Id: I292acc3081e26aa42f101442fb778635d0c79649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536082 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
-
Peter Marshall authored
These have been ported to frontend unit tests. Bug: 1148495 Change-Id: I3b5dc67f52a19a099d9c0a5708249812fb4f4699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536271 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Alan Cutter authored
We must store this icon in a separate repository. Bug: 1147692 Change-Id: I02ff6f5994ebf0b7e630c8109b01cc242ea10eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531595Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827177}
-
Michael Thiessen authored
Ran into this crash when changing the timing of Activity finishing in tests. TabModelSelectorTabObserver#tabRemoved posts a task, and then uses the Tab after it's possibly been destroyed. Changes to CriticalPersistedState were also necessary to avoid the observer leak that would happen in this case. Change-Id: I152a2d08cee86af51517f5708e57f8dc7fad4f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535559 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#827176}
-
Luciano Pacheco authored
VolumeManager from background page Refactor FilteredVolumeManager() to not depend or reach to the background window/page, instead it just receives a promise that resolves to the `VolumeManager` which is what `FilteredVolumeManager()` needs. This is a preparation for JS modules to avoid the foreground using global variables from the background, this case is avoiding the `volumeManagerFactory` from FilteredVolumeManager(). For the SWA is the same concept, centralize the interaction with background page via the `BackgroundPage` interface. No change in the behavior, so Closure and current tests cover this. Bug: 1148545, 1133186, 1113981 Change-Id: I81b87534b26d10946dfa1dc0e287c63f003ea203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534553 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
