GitLab

I was ambitious in r325585 to remove this behavior, asserting that the Port's
owner should clear its own listeners. This is an optimistic expectation, and a
backwards incompatible one at any rate.

BUG=486715
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1135123002

Cr-Commit-Position: refs/heads/master@{#329265}

BUG=486488
Test=Check some link that has search term, e.g.
https://developer.chrome.com/extensions/browsingData#samples
click on the "on the samples page" link.

Review URL: https://codereview.chromium.org/1124343004

Cr-Commit-Position: refs/heads/master@{#329264}

Also remove unused data reduction pref from preferences API.

BUG=442494

Review URL: https://codereview.chromium.org/1130863002

Cr-Commit-Position: refs/heads/master@{#329263}

Two independent but related fixes here:

1. IPCSupportInitializer could previously outlive its IO
   runner, resulting in Mojo not being shut down in time.
   The EDK posts tasks directly to a MessageLoopForIO
   pointer because it's assumed to remain valid until
   EDK shutdown. This CL limits IPCSupportInitializer's
   lifetime to that of the IO thread, regardless of
   ScopedIPCSupport lifetime.

2. In single-process mode, the child IO thread cannot be
   used to create the client ChannelMojo, because all channels
   in-process must be created on the EDK IO thread. This problem only
   surfaced in practice because #1 above changed some shutdown
   ordering and tickled a DCHECK in EDK shutdown.

   This CL has ChannelMojo hop to its IO runner (only if
   necessary) before creating underlying messaging pipes.

BUG=None
R=morrita@chromium.org

Review URL: https://codereview.chromium.org/1130413002

Cr-Commit-Position: refs/heads/master@{#329262}

Adds support for multiple thumbnail files on Single iframe NTP, fallback to the best one that opens.

BUG=486879

Review URL: https://codereview.chromium.org/1129383003

Cr-Commit-Position: refs/heads/master@{#329261}

BUG=471536

Review URL: https://codereview.chromium.org/1125213005

Cr-Commit-Position: refs/heads/master@{#329260}

Summary of changes available at:
https://chromium.googlesource.com/chromiumos/platform/system_api/+log/789778e..f2d7a9a

BUG=486738
TBR=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/1128803005

Cr-Commit-Position: refs/heads/master@{#329259}

It's not used anymore.

Review URL: https://codereview.chromium.org/1139483002

Cr-Commit-Position: refs/heads/master@{#329258}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f2af598..ff93a86

TBR=yosin@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1134583004

Cr-Commit-Position: refs/heads/master@{#329257}

* Use the standard integer types from stdint.h instead.
* Use macros.h for the DISALLOW_COPY_AND_ASSIGN macro.

BUG=138542
TEST=sql_unittests
R=shess@chromium.org

Review URL: https://codereview.chromium.org/1133053004

Cr-Commit-Position: refs/heads/master@{#329256}

If rendering code that is shared with GrContext changes any GL state,
then skia caches need to be notified.  This adds InvalidateGrContext()
method that will call private pure virtual method.  InvalidateGrContext
default argument will clear all state in GrContext.

Updated classes that derive from ContextProvider.

R=piman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1131723002

Cr-Commit-Position: refs/heads/master@{#329255}

BUG=486780

Review URL: https://codereview.chromium.org/1131513003

Cr-Commit-Position: refs/heads/master@{#329254}

BUG=369661
TEST=All navigation tests remain green.

Review URL: https://codereview.chromium.org/1129913004

Cr-Commit-Position: refs/heads/master@{#329253}

R=inferno@chromium.org
BUG=450268

Review URL: https://codereview.chromium.org/1131293005

Cr-Commit-Position: refs/heads/master@{#329252}

Based on the crash dump, the crash occurs while loading a Nacl module in the renderer process. The Nacl translate
thread has a valid file handle which is created by the Nacl host in the browser. It then calls into the Nacl loader
to load the module which fails. The Nacl loading code in LaunchSelLdr function is closing the file handle which is
passed in. Based on comments in the PnaclTranslateThread class, ownership of the file handle is only transferred on success.

Thus when the call returns the PnaclTranslateThread code tries to close the file handle which is already closed. In the
meantime the Windows handle is reused to something else which is tracked by our handle tracker. The second CloseHandle
attempt causes a CHECK to fire because we are closing a handle which is being tracked.

Fix is to not close the file handle in the PnaclTranslateThread class as ownership is transferred on
call to LaunchSelHdr.

BUG=426582, 475872

Review URL: https://codereview.chromium.org/1137833003

Cr-Commit-Position: refs/heads/master@{#329251}

This consists of the following pieces:
. html_viewer now uses ResourceProvider to get resources.
. html_viewer no longer directly uses java.
. The java support for mojo_runner/shell has been mode pluggable:
  . You specify the name of the .so to load by way of a meta-tag in
    the manifest. This way mandoline can specify it's own.
  . Android's main function calls to an InitContext() function that
    mandoline plugs in.
  . The apk can include resources to extract. These are listed in the
    file 'assets_list.' The gn template rule
    generate_mojo_shell_assets_list does this for you given a
    directory.
. Changed around scripts to work with both mojo_shell/runner and
  mandoline.

BUG=481698
TEST=covered by tests
R=ben@chromim.org, jcivelli@chromium.org

Review URL: https://codereview.chromium.org/1130763004

Cr-Commit-Position: refs/heads/master@{#329250}

Such that they are based on the same base class.

BUG=452524

Review URL: https://codereview.chromium.org/1009403002

Cr-Commit-Position: refs/heads/master@{#329249}

Using https://crrev.com/15679025 as template, but with some complication
involving base::CancelableTaskTracker.

BUG=467712

Review URL: https://codereview.chromium.org/1122103003

Cr-Commit-Position: refs/heads/master@{#329248}

Render frames can use this service to verify platform on ChromeOS.

BUG=479836

Review URL: https://codereview.chromium.org/1053773007

Cr-Commit-Position: refs/heads/master@{#329247}

BUG=485656,477137

Review URL: https://codereview.chromium.org/1132473003

Cr-Commit-Position: refs/heads/master@{#329246}

BUG=

Review URL: https://codereview.chromium.org/1137033004

Cr-Commit-Position: refs/heads/master@{#329245}

Renaming sync_state to username.

BUG=None

Review URL: https://codereview.chromium.org/1117453002

Cr-Commit-Position: refs/heads/master@{#329244}

Known issues:
-Cancel confirmation dialog and backdrop style should be according to crbug/482962
-Cancel confirmation dialog doesn't cover "account creation" case
-Fatal error does not use 'notification-card' element.

BUG=467119,469428
TEST=Manual
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/1115993002

Cr-Commit-Position: refs/heads/master@{#329243}

When an application is linked against an OSX 10.9+ SDK, a blit will fail if the
source and destination color formats do not match.

BUG=484203

Review URL: https://codereview.chromium.org/1133163003

Cr-Commit-Position: refs/heads/master@{#329242}

The only change in ICU since the last roll is:
  Brings defines for the GN build in line with GYP.

TBR=jungshik@chromium.org

Review URL: https://codereview.chromium.org/1139783004

Cr-Commit-Position: refs/heads/master@{#329241}

Revert of bluetooth: Android adapter can be created with and without Bluetooth permission. (patchset #2 id:110001 of https://codereview.chromium.org/1129683002/)

Reason for revert:
Failing on the main waterfall: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27824

Original issue's description:
> bluetooth: Android adapter can be created with and without Bluetooth permission.
>
> This enables unit tests to run with Bluetooth permission,
> by adding the Bluetooth permission to native_test.
>
> Non-test applications will not have the Bluetooth permission,
> and unit tests should also verify behavior
> when the permission is not given. To enable this
> createWithoutPermissionForTesting is added and
> results in a state equivalent to when the permission
> is not available.
>
> Unit tests will be built in parallel for both when Bluetooth
> permission exists and doesn't.
>
> BUG=471536
>
> Committed: https://crrev.com/30e81472dc168ea1c331a8779b3f6a14f684c54b
> Cr-Commit-Position: refs/heads/master@{#329212}

TBR=tedchoc@chromium.org,armansito@chromium.org,scheib@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471536

Review URL: https://codereview.chromium.org/1137083002

Cr-Commit-Position: refs/heads/master@{#329240}

BUG=483288

Review URL: https://codereview.chromium.org/1130253003

Cr-Commit-Position: refs/heads/master@{#329239}

Another fix for https://codereview.chromium.org/1127153004/. Hooray for
non-recipe bots.

BUG=
TBR=perezju@chromium.org

Review URL: https://codereview.chromium.org/1131143003

Cr-Commit-Position: refs/heads/master@{#329238}

BUG=441392

Review URL: https://codereview.chromium.org/1089903003

Cr-Commit-Position: refs/heads/master@{#329237}

BUG=369661
TEST=All tests remain green.

Review URL: https://codereview.chromium.org/1129893005

Cr-Commit-Position: refs/heads/master@{#329236}

This puts all heap allocated values into scoped_ptrs in
value_unittest.cc and json_writer_unittest.cc. This way
ownership is explicit in the code and we don't use raw
pointers to change owners of an object.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1138103002

Cr-Commit-Position: refs/heads/master@{#329235}

Refactor the API for CertVerifier::Verify() and the implementation of MultiThreadedCertVerifier::Verify().

* CertVerifier::Verify() fills a |scoped_pointer<Request>*| rather than a |void*|

* CertVerifier::CancelRequest(void*) has been removed. Requests are instead cancelled by resetting the scoped_ptr<Request>.

* Refactored memory ownership in MultiThreadedCertVerifier so there are no manual calls to "delete".

* Removed locking and the CertVerifierWorker in favor of using WorkerPool::PostTaskAndReply()

BUG=475153,479336
TBR=pneubeck@chromium.org,zea@chromium.org,sergeyu@chromium.org

Review URL: https://codereview.chromium.org/1115903002

Cr-Commit-Position: refs/heads/master@{#329234}

BUG=477084
TEST=new tests
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1126233004

Cr-Commit-Position: refs/heads/master@{#329233}

This patch ensures that the pending layer is informed of scroll
updates that happen on the active tree. That way the information
can propagate down to wherever it is used (such as tilings)

BUG=483638
R=aelias, enne

Review URL: https://codereview.chromium.org/1135833002

Cr-Commit-Position: refs/heads/master@{#329232}

We always draw window contents using a compositor, so we can remove the windows desktop aura code that handles GDI painting.

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1125193004

Cr-Commit-Position: refs/heads/master@{#329231}

Found by Scythe.

Review URL: https://codereview.chromium.org/1127163004

Cr-Commit-Position: refs/heads/master@{#329230}

- remove cancel utterance logic which incorrectly calls endCallback causing unexpected continuation of speech on stop().
- adds mapping for continuous read in compat mode.
- fixes continuous read test which is still prefixed manual.

TEST=verify continuous read works in ChromeVox Next and compat. Passes BackgroundTest.MANUAL_ContinuousRead

Review URL: https://codereview.chromium.org/1138813002

Cr-Commit-Position: refs/heads/master@{#329229}

Revert of [Chromoting] Add GN build support for ar_sample_app target. (patchset #1 id:1 of https://codereview.chromium.org/1135933002/)

Reason for revert:
Broke GN bots, eg.:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28281

Original issue's description:
> [Chromoting] Add GN build support for ar_sample_app target.
>
> This adds GN build rules for the AppRemoting sample app.
> Some DesktopRemoting build rules were prettified as part of this
> process (to make the App- and Desktop- remoting build rules more
> similar).
>
> This re-lands crrev.com/1126393002 without any additional changes
> required. The issues with the GN clobber builds are fixed in
> crrev.com/1137753002.
>
> BUG=471916
>
> Committed: https://crrev.com/581797d8f76d5855b7f0bed1fe912a038d1d7d25
> Cr-Commit-Position: refs/heads/master@{#329206}

TBR=jamiewalch@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471916

Review URL: https://codereview.chromium.org/1136673003

Cr-Commit-Position: refs/heads/master@{#329228}

This is a reland of https://codereview.chromium.org/1106103003/ with fixes to
ensure callers never pass in a null slot.

Currently some NSS platform integration logic transits private keys through
RSAPrivateKey on CrOS. This prevents incrementally switching RSAPrivateKey to
BoringSSL while keeping platform integrations on NSS.

The intent of this change is to clarify RSAPrivateKey as a BoringSSL vs NSS
internal crypto library (use_openssl=0 vs use_openssl=1) abstraction. It's
primarily to be used with SignatureCreator. Code which uses NSS based on
use_nss_certs rather than use_openssl because the underlying platform is NSS
should call NSS routines directly, or introduce different abstractions.

Remove the problematic RSAPrivateKey methods and instead add
crypto/nss_key_util.h which contains some helper functions for manipulating NSS
keys. This is sufficient to allow consumers of the removed methods to use NSS
directly with about as much code. (This should not set back migrating that
logic to NSS as that code was already very NSS-specific; those APIs assumed
PK11SlotInfo.)

nss_key_util.h, like nss_util.h, is built whenever NSS is used either
internally or for platform integrations. This is so rsa_private_key_nss.cc can
continue to use the helper functions to implement the NSS-agnostic interface.

With this, the chimera CrOS configuration should build. The RSAPrivateKey logic
is functional with the exception of some logic in components/ownership. That
will be resolved in a future CL.

BUG=478777,483606

Review URL: https://codereview.chromium.org/1128153003

Cr-Commit-Position: refs/heads/master@{#329227}

Review URL: https://codereview.chromium.org/1133163002

Cr-Commit-Position: refs/heads/master@{#329226}