GitLab

Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (patchset #2 id:20001 of https://codereview.chromium.org/659753003/)

Reason for revert:
Possible cause of gpu telemetry bot flake

Original issue's description:
> [Telemetry] Set the number of attempts to retry a test to 1
>
> **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted.
>
> BUG=422339
>
> Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03
> Cr-Commit-Position: refs/heads/master@{#299716}

TBR=tonyg@chromium.org,dtu@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=422339

Review URL: https://codereview.chromium.org/661303002

Cr-Commit-Position: refs/heads/master@{#300218}

And stop mis-using user metrics action.

BUG=424689

Review URL: https://codereview.chromium.org/659333003

Cr-Commit-Position: refs/heads/master@{#300217}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0a8c931..bc9a196

TBR=

Review URL: https://codereview.chromium.org/656793003

Cr-Commit-Position: refs/heads/master@{#300216}

Cr-Commit-Position: refs/heads/master@{#300215}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d1f9de7..0a8c931

TBR=

Review URL: https://codereview.chromium.org/668503002

Cr-Commit-Position: refs/heads/master@{#300214}

BUG=424216,420994
NOTRY=true

Review URL: https://codereview.chromium.org/661943002

Cr-Commit-Position: refs/heads/master@{#300213}

To allow the chromium WebView to build unbundled, we need to stop
linking to system libraries and instead link to the prebuilt libraries
in the NDK.

This change rolls gyp to include the required makefile generation
changes, and adjusts the chromium side to match:

1) Stop setting use_system_stlport and instead use the NDK stlport by
   specifying LOCAL_NDK_STL_VARIANT := stlport_static

2) Remove support for the use_system_stlport flag entirely as WebView
   was the only user.

3) Don't try to link standard libraries like -lc -lm as the NDK does
   this automatically.

4) Don't include the OpenAL headers from frameworks/wilhelm; these are
   already part of the NDK with no special include path needed.

BUG=409851

Review URL: https://codereview.chromium.org/571953002

Cr-Commit-Position: refs/heads/master@{#300212}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0a93e49..d1f9de7

TBR=

Review URL: https://codereview.chromium.org/644203003

Cr-Commit-Position: refs/heads/master@{#300211}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/38b0e5f..0a93e49

TBR=

Review URL: https://codereview.chromium.org/664823002

Cr-Commit-Position: refs/heads/master@{#300210}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c8c9c60..38b0e5f

TBR=

Review URL: https://codereview.chromium.org/665723002

Cr-Commit-Position: refs/heads/master@{#300209}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2b06b87..c8c9c60

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/663943002

Cr-Commit-Position: refs/heads/master@{#300208}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c6d24c6..2b06b87

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/659793006

Cr-Commit-Position: refs/heads/master@{#300207}

The real changes are in mojo_url_resolver*.

The rest are renames that were generated with the following commands:

git grep -l 'mojo:mojo_' | xargs perl -pi -e 's|mojo:mojo_|mojo:|g'
git grep -l 'mojo://mojo_' | xargs perl -pi -e 's|mojo://mojo_|mojo://|g'
git cl format

Review URL: https://codereview.chromium.org/668483002

Cr-Commit-Position: refs/heads/master@{#300206}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7265cd..c6d24c6

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/662933002

Cr-Commit-Position: refs/heads/master@{#300205}

REJ or an SHLO to count. This should mean that anytime confirmation is
required, the handshake should be at most 1 effective RTT whereas
currently they can be 2 RTT.

Review URL: https://codereview.chromium.org/656303004

Cr-Commit-Position: refs/heads/master@{#300204}

BUG=angle:799

Reenables OES_texture_npot on AMD Windows7+ in D3D9.

Review URL: https://codereview.chromium.org/665543003

Cr-Commit-Position: refs/heads/master@{#300203}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8bd25a0..c7265cd

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/662823003

Cr-Commit-Position: refs/heads/master@{#300202}

GetShortData() and IOHIDElementGetUsage() both return uint32s, so raise the size
of various containing types to uint32.

I tried to look in the USB HID spec to see if any of the affected fields here
were limited to e.g. <2^16, meaning that it'd be safe to just cast down to the
existing uint16s instead, but I couldn't find any limits.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/656583003

Cr-Commit-Position: refs/heads/master@{#300201}

TestingAutomationProvider is dead, Jim.

BUG=154997
TBR=jam,sky

Review URL: https://codereview.chromium.org/660353002

Cr-Commit-Position: refs/heads/master@{#300200}

Previously, the logic for history swiping depended on the relative Y distance
of the gesture's current location from the gesture's start location. Gestures
which consisted of a large up motion, followed by a large down motion, followed
by a horizontal motion could still cause history swiping. The new logic depends
on the total Y distance of the gesture, which fixes this problem.

This CL also includes a change to allowed the gesture recognizer state machine
to enter the state kCancelled directly from the state kPending. Previously, it
was possible for the history overlay to show for a very brief period of time
even if the gesture was about to be cancelled.

This CL also includes a minor refactor:
 - Renamed several methods to better reflect their intended purpose.
 - Removed lastProcessedGestureId_ and currentGestureId_, which did not cause a
 functional change.

BUG=421629

Review URL: https://codereview.chromium.org/657323003

Cr-Commit-Position: refs/heads/master@{#300199}

The python wrapper CL just landed. I'd like to see it work as expected for some iterations on Linux, before starting to use it on Windows as well. So for now, just fixing the path to the file used on Windows.

BUG=

Review URL: https://codereview.chromium.org/661193003

Cr-Commit-Position: refs/heads/master@{#300198}

BUG=

Review URL: https://codereview.chromium.org/667523002

Cr-Commit-Position: refs/heads/master@{#300197}

BUG=422727

Review URL: https://codereview.chromium.org/644323002

Cr-Commit-Position: refs/heads/master@{#300196}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/49386a6..8bd25a0

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/653763003

Cr-Commit-Position: refs/heads/master@{#300195}

This extracts the signing/verification functions, so the subsequent RSA-PSS changelist is easier to follow.

BUG=399090

Review URL: https://codereview.chromium.org/662533002

Cr-Commit-Position: refs/heads/master@{#300194}

BUG=424680

Review URL: https://codereview.chromium.org/661073003

Cr-Commit-Position: refs/heads/master@{#300193}

* New ContainerParams
 -  default_parent to specify the default parent when no
    transient parent is specified.
 - modal_container_priority now controls the modal container
   used for a modal window created for the given container.
 - if not specified, it will fallback downwards to find one.
 - if window is specified as always_on_top, it will use top
   most modal container.

* Changed network selector/shutdown dialog to use the new API.

* Other change:
 Separated test windows to athena/test/base/test_windows.h

BUG=410499
TBR=sky@chromium.org,reed@chromium.org
TEST=coverd by unit tests

Review URL: https://codereview.chromium.org/662763002

Cr-Commit-Position: refs/heads/master@{#300192}

Using this option causes the tests to fail immediately with an
exception, so this option has been removed in order to fix the tests.

BUG=423916

Review URL: https://codereview.chromium.org/667463003

Cr-Commit-Position: refs/heads/master@{#300191}

are allowed to opt-in to having embedded options pages and/or chrome style.

The flag --enable-embedded-extension-options makes the default for embedding
options pages true unless extensions opt-out. This is still useful for
development.

BUG=414920
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/667453003

Cr-Commit-Position: refs/heads/master@{#300190}

Currently the message is reshown if the animation is not finished. However,
since the video is changed and the text message is related to the previous
video, it's the best to just hide it immediately when switching videos.

TEST=Tested manually by playing multiple videos and clicking play with the
     CTRL key pressed.
BUG=422120

Review URL: https://codereview.chromium.org/649073004

Cr-Commit-Position: refs/heads/master@{#300189}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7839915..d12af70

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/666633002

Cr-Commit-Position: refs/heads/master@{#300188}

Adds a QuotaClient for the ServiceWorkerCache system.

* Calls to the QuotaManagerProxy like (NotifyStorageAccessed/StorageModified/OriginInUse/etc..) will be in an upcoming CL.

* The ServiceWorkerCacheQuotaClient is registered by the ServiceWorkerCacheStorageManager.  The QuotaClient holds a WeakPtr to the ServiceWorkerCacheStorageManager since the manager is destroyed before the QuotaClient.

* Added a number of unittests.  They fit better into the StorageManager tests file than in their own file as they rely on a lot of the StorageManager infrastructure.

* In order to support QuotaClient the ServiceWorkerCacheStorageManager needs to be able to list the origins it supports. This data is not currently stored so an "origin" member has been added to the CacheStorage index protobuf.  We won't report the origins of existing caches (if any even exist at this point) until their index is next written.

BUG=420159

Review URL: https://codereview.chromium.org/651983002

Cr-Commit-Position: refs/heads/master@{#300187}

Several of these are cruft (the entries don't exist to suppress), and
the rest are all small (<20MB) so there's no real value in avoiding the
pull.

BUG=None

Review URL: https://codereview.chromium.org/663763003

Cr-Commit-Position: refs/heads/master@{#300186}

wow_helper.exe is needed by the sandbox.

BUG=414808
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/667513002

Cr-Commit-Position: refs/heads/master@{#300185}

(We want to remove it, but there are currently some uses in Blink. We
can stop it from reappearing in Chromium.)

R=thestig@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/647433004

Cr-Commit-Position: refs/heads/master@{#300184}

On Windows the default UDP send buffer size is 8192. OSX default is
9216. On Linux default is 212992. The values are too small on Windows
and OSX. This cannot make good use of the A-MPDU of 802.11n (64KB),
which is the most common network for Cast Streaming.

We have also seen strong evidence that the default buffer size is
limiting, e.g. long packet queuing delay on Windows, p2p socket seeing
a lot of EWOULDBLOCKs.

This code uses pacer maximum burst size (in bytes) as the send buffer
size. Also added an option "send_buffer_min_size" to allow application
to choose an even larger value for send buffer size.

BUG=423545

Review URL: https://codereview.chromium.org/654843007

Cr-Commit-Position: refs/heads/master@{#300183}

R=dtu@chromium.org,tonyg@chromium.org,nednguyen@google.com
BUG=423563

Review URL: https://codereview.chromium.org/659673002

Cr-Commit-Position: refs/heads/master@{#300182}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/664783002

Cr-Commit-Position: refs/heads/master@{#300181}

The main user (and the immediate reason for the change) is to improve handle
ownership in content::ChildProcessLauncher.

This CL is not enforcing clean ownership beyond ChildProcessLauncher; that is
to be covered by subsequent CLs.

BUG=417532
TEST=base_unittests
R=scottmg@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/651253002

Cr-Commit-Position: refs/heads/master@{#300180}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/50e6008..49386a6

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/656533005

Cr-Commit-Position: refs/heads/master@{#300179}