- 02 Aug, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1de8d3d..cdda2f0c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3f211f368f637f48a6f09bf252d0945ef6f190d3 Reviewed-on: https://chromium-review.googlesource.com/1161020Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580317}
-
akaba authored
This CL removes Child to Parent relationship is in SurfaceReference as a cleanup step toward making Viz more clean and efficient. This relationship is not contributing to any logic so it's safe to be removed. Bug: 868925,869444 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I458ca17de868ef31eada09b5ff23c09c13c22523 Reviewed-on: https://chromium-review.googlesource.com/1155095 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580316}
-
Quan Nguyen authored
This CL moves LoginUserMenuView::EnsureWidgetInWorkArea to LoginBubble::EnsureBubbleInWorkArea and adds handling for the case where the bubble extends past the right side of the screen. Bug: 827599 Change-Id: I29de2ac035e2a641250a047283cf0b5aa66a55ea Reviewed-on: https://chromium-review.googlesource.com/1160933Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580315}
-
Ramya Nagarajan authored
Only the first experiment entry gets covered by perf waterfall, so adding this item ensures better test coverage. Also, the existing experiment, NewTabPageAllBirthday_Enabled, could not be re-used since go/revising-finch-configs recommends creating a new experiment when changing size or behavior of existing groups. Bug: 831910 Change-Id: I95ebc6f2768fe25d34993c05c71e35c22e2bdcc5 Reviewed-on: https://chromium-review.googlesource.com/1160925Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580314}
-
akaba authored
This CL fixes SurfaceRange::IsInRangeExclusive in the case when the embed tokens are different by comparing with either ends of the range. In addition, it adds 2 extra utility functions to SurfaceRange which are needed to make the code cleaner for following work. Bug: 867531 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia542e94b13c566989f3764c32cad4016bfddd32b Reviewed-on: https://chromium-review.googlesource.com/1159100 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
This reverts commit 9a6c55fc. Reason for revert: Linux CFI and Android CFI both breaking on bluetooth tests after this landed: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9368 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2352 Original change's description: > [Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set > > BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of > std::set_union in order to merge advertised uuids and service uuids. > However, std::set_union requires sorted ranges as input, which wasn't > necessarily guaranteed before this change. When using a > std::unordered_set the order of elements is not specified and > std::set_union is not guaranteed to work correctly. Using a > base::flat_set for UUIDSet instead fixes this issue. In order to prevent > future regressions this change also replaces the usage of std::set_union > with base::STLSetUnion performing an explicit IsSorted() check in Debug > builds. > > Bug: 821766, 870208 > Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0 > Reviewed-on: https://chromium-review.googlesource.com/1159374 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580198} TBR=ortuno@chromium.org,jdoerrie@chromium.org Change-Id: I6e3ce514af12bc718a2b759d73086d24d3446c9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766, 870208 Reviewed-on: https://chromium-review.googlesource.com/1161022Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#580312}
-
akaba authored
GetLatestInFlightSurface should return the primary if it exists and active. There is no reason for it not to do so and this will make working with it easier. Bug: 869507 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Icae9da8527de69555e8c925740c08b187f827b02 Reviewed-on: https://chromium-review.googlesource.com/1157140 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
-
Majid Valipour authored
WorkletAnimations which have a ScrollTimeline need to be animated and ticked every time that scroll offset is changed on compositor thread. This ensures their output is in sync with scrolling. Scroll animations on compositor (e.g., smooth wheel animations) are a source of scroll offset change on compositor. So to make sure scroll-linked worklet animations can respond to latest scroll offset we need to tick these animations **after** cc scroll animations produce their output. Previously our approach was to tick mutator (update all worklet animations) once before ticking all animations and every time a cc scroll animation change the scroll offset. However, ticking mutator updated worklet animation without actually applying their output which meant worklet animation can fall behind cc scroll animation. Further more this causes mutator to be ticked multiple times (once per each scroll animation). This patch changes our behavior as follows: - Tick regular animations which including cc scroll animations. - Tick mutator which sends update to AnimationWorklet and receive its new output. - Tick worklet animations to apply the new output. This ensures we see the scroll animation and any linked worklet animation output in the same frame. Also it avoid excessively ticking mutator since we only need to do it once after all cc scroll animations are ticked. TEST:AnimationHostTes.LayerTreeMutatorUpdateReflectsScrollAnimations Bug: 844436 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ica09a4779ae3b78af9f0f93125a43846d91e8bc1 Reviewed-on: https://chromium-review.googlesource.com/1152899 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580310}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b07deb3fc1f5..8ed949d3dcdc git log b07deb3fc1f5..8ed949d3dcdc --date=short --no-merges --format='%ad %ae %s' 2018-08-02 thestig@chromium.org Remove some checks in IsLinearizedHeaderValid(). Created with: gclient setdep -r src/third_party/pdfium@8ed949d3dcdc The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7a15c4c8c68c5b0a4667c44baab6cf6e06c1fa9d Reviewed-on: https://chromium-review.googlesource.com/1160794Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580309}
-
Jun Choi authored
Currently resident key option in CTAP MakeCredential request parameter is set to false regardless of what the relying party sets in AuthenticatorSelectionCriteria. Add resident key option to CTAP MakeCredential request accordingly. Bug: 870153 Change-Id: I3c964c0e036008f3d38d60a5ab3c6610eb80085b Reviewed-on: https://chromium-review.googlesource.com/1159825 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#580308}
-
Sarah Hu authored
This fix the linux-chromeos-dbg compile error by export class PublicAccountWarningDialog. TBR=xiyuan@chromium.org,msw@chromium.org Bug: 864549 Change-Id: Ibf7e0b14a17460114563bf40bc562294b86993cb Reviewed-on: https://chromium-review.googlesource.com/1145864 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#580012} Reviewed-on: https://chromium-review.googlesource.com/1161082 Cr-Commit-Position: refs/heads/master@{#580307}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a31f4e51d559..20ee171b98bd git log a31f4e51d559..20ee171b98bd --date=short --no-merges --format='%ad %ae %s' 2018-08-02 robertphillips@google.com Revert "Update GrTextureStripAtlas for DDLs" 2018-08-02 kjlubick@google.com Productionize PathKit 2018-08-02 fmalita@chromium.org [skottie/sksg] Move source files list to .gni 2018-08-02 robertphillips@google.com Update GrTextureStripAtlas for DDLs 2018-08-02 stani@google.com Prototype an Android lottie player 2018-08-02 halcanary@google.com tests: Move SkUTF tests to their own file. 2018-08-02 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9e22c542d6be..dd4c8631343f (1 commits) 2018-08-02 jvanverth@google.com Fix minimization function for offset code 2018-08-02 benjaminwagner@google.com [infra] Ensure Mac xSAN backfill tasks can find Xcode. 2018-08-02 bsalomon@google.com Move mip map regen from GrGLProgram to GrGLGpu Created with: gclient setdep -r src/third_party/skia@20ee171b98bd The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Icecbe92f71210720d4f37bae7fe8352f71039fe0 Reviewed-on: https://chromium-review.googlesource.com/1160788Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580306}
-
Dan Sinclair authored
This will pull in the SPIRV-Tools fuzzers. TBR=piman@chromium.org Change-Id: I16112846d862dbeb385cd2d22fe639376d63629f Reviewed-on: https://chromium-review.googlesource.com/1161090Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#580305}
-
Dan Elphick authored
Use v8::Value::SameValue instead which does not require a Context and works just as well (if not faster) when both arguments are v8::Strings. Change-Id: I41f4e2b78f94671b4408c45b97c0e7b22ba554fb Reviewed-on: https://chromium-review.googlesource.com/1150524Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#580304}
-
Cathy Li authored
Bug: 867488 Change-Id: Ibb67a81cfef555e93128ae395fe6a9f0081a45ed Reviewed-on: https://chromium-review.googlesource.com/1157183 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#580303}
-
Christopher Cameron authored
Consider the sequence: 1. We query the number of displays using CGGetActiveDisplayList and get |display_count| as 0. 2. We allocate a vector |displays| with that size, so it's nullptr. 3. We populate that vector with a call to CGGetActiveDisplayList, but, because |displays| is nullptr, that populates |display_count| with the number of displays on the system. 4. BUT, it so-happens that between steps 1 and 3, we added an active display, so |display_count| is now non-zero. 5. We now index into |displays|, which is empty, and blow up. Early-out if our initial |display_count| is zero to avoid this situation. Bug: 870320, 869570 Change-Id: Ibeec67ce430faccb6e350af3fb335f1770e7b072 Reviewed-on: https://chromium-review.googlesource.com/1160769 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#580302}
-
Jared Saul authored
Bug: 868566 Change-Id: Icf41453cc6b4528463e32338d30eef0c037ce6b4 Reviewed-on: https://chromium-review.googlesource.com/1159738 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580301}
-
Matthew Jones authored
This patch re-adds some of the code that was removed during Chrome Home cleanup to correctly position the overflow menu when anchored to the bottom of the screen (removal patch fround here: https://chromium-review.googlesource.com/c/chromium/src/+/934978). Bug: 866265 Change-Id: I4e4341b138cd9315f9a7fae8cbf47487923a0086 Reviewed-on: https://chromium-review.googlesource.com/1161174Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#580300}
-
Danyao Wang authored
This is to ensure that BrowserViewController's |updateToolbar| never mistakes the pending back/forward navigation item for the last committed item and prematurely hides adaptive toolbar. Bug: 842151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I22e8358c1127878a983a657ad1373ed98303d6f7 Reviewed-on: https://chromium-review.googlesource.com/1157915Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580299}
-
Hector Carmona authored
Bug: 832938 Change-Id: I4d3c11c20bcd0ee529d64907d277f25c5fae873e Reviewed-on: https://chromium-review.googlesource.com/1159691Reviewed-by:
-
Chris Palmer authored
A last-ditch sanity check in case of memory corruption. Bug: 680657 Change-Id: I79934eceb4fcb6ce64422cee5004f057d40a6cab Reviewed-on: https://chromium-review.googlesource.com/1134523Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#580297}
-
Mohamed Amir Yosef authored
This CL add the logic to merge the local model with the remote model upon first enable sync. Bug: 516866 Change-Id: I8c53c5167b1bc3305f9339a9a0e2a8ffb1702ffb Reviewed-on: https://chromium-review.googlesource.com/1150523 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580296}
-
Gang Wu authored
Implement logging API skeleton Bug:831638 Change-Id: I3b4d1f520fe0073bb81bbebc77765c3c76409cbd Reviewed-on: https://chromium-review.googlesource.com/1160591Reviewed-by:
-
Daniel Rubery authored
We shouldn't cache a verdict if the URL is not valid for reputation computation. As a particularly bad case, about:blank can be safe in some cases, and phishing in others. Change-Id: I9ece3084f6a732003783e7db6db49345c73bfd59 Bug: 865625 Reviewed-on: https://chromium-review.googlesource.com/1161086Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#580294}
-
mrefaat authored
- Make PreloadController conform to CRWWebStatePolicyDecider protocol. - Add the preloadController as a policy decider directly after the webstate is created (in StartPrerender) and make sure it's removed when the webstate is not in the prerender state anymore. - Use ShouldAllowRequest of CRWWebStatePolicyDecider to block the navigation, if the request url can be handled by either ITunesUrlHandlerTabHelper, or AppLauncherTabHelper. - Update CRWWebController, so it doesn't use isAppLaunchingAllowedForWebState to cancel prerender navigation. - Remove isAppLaunchingAllowedForWebState WebState delegate method and all its usages. Bug: 674991, 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I96721de983f74834b0d5a6d8977849e995523e98 Reviewed-on: https://chromium-review.googlesource.com/1157692Reviewed-by:
-
Sam Maier authored
We don't need to use AsyncTask here since we don't use any onPreExecute or onPostExecute. Webview cannot have a UI thread set during CookieManager startup, so having AsyncTask post to the UI thread when it runs onPostExecute is not going to work. Bug: 542151 Change-Id: I289722205588c86bcc9fbde6206447223426e5d8 Reviewed-on: https://chromium-review.googlesource.com/1161043Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#580292}
-
Nicolas Pena authored
Bug: 673775 Change-Id: Id385dfce82e2a31da523a0dd41c656ce0c648c6f Reviewed-on: https://chromium-review.googlesource.com/1157262Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#580291}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/fa95e2a7489d..0a6e2d0dcbc5 git log fa95e2a7489d..0a6e2d0dcbc5 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 hinoka@google.com Whitespace change to kick off luci jobs Created with: gclient setdep -r src/native_client@0a6e2d0dcbc5 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: I6407dfe743c2a9080085b3ce8c723a23cc1fe2ad Reviewed-on: https://chromium-review.googlesource.com/1160792Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580290}
-
bsheedy authored
Adds VrBrowserControllerInputTest#testDragRefresh, which tests that clicking and dragging the webpage down while at the top of the page triggers a refresh. A similar test that tests scroll refreshing will be added once the functionality is fixed and doesn't require swipes at inhuman speeds to perform. Bug: 861949 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5cd56e8289b137fb78c0ad8731022373928f6132 Reviewed-on: https://chromium-review.googlesource.com/1153830 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#580289}
-
Johannes Henkel authored
There's just one field for the enabled bit so this one's trivial; I made an InnerEnable to avoid having multiple fields. For reference the PR that introduced the new InspectorSessionState / InspectorAgentState / Fields was https://chromium-review.googlesource.com/c/chromium/src/+/1149201. We're migrating things from state_ to this new mechanism, which allows incremental updates to flow back to the browser process. Change-Id: I57b45ccb2595fc9167390361715cc9d795941699 Reviewed-on: https://chromium-review.googlesource.com/1159730Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580288}
-
Elad Alon authored
Compress remote-bound WebRTC event logs while writing them to disk. * Logs for which the file size budget did not allow covering the entire call, can now get more coverage. * Short calls, for which we could log the entire call anyhow, benefit from a lower cost in bandwidth when the log is uploaded. Compression takes place incrementally over the duration of the call, avoiding a spike in resource utilization. The file-size limit is very strictly abided by. Before compression takes place, an estimation is made over whether the compressed string will fit in the file without exceeding the budget. If not, the file is terminated (as it would for the uncompressed version). In the unlikely case that the estimation is mistaken, and we've compressed to the point that writing to the file would make it exceed its allotted maximum size, the file is dicarded. (It is infeasible to write a compression footer at that point.) Bug: 775415 Change-Id: Iab6b91815c4e9e855ced16668dbfd65ed64ad9f0 Reviewed-on: https://chromium-review.googlesource.com/1142147 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#580287}
-
Chris Hamilton authored
This samples metrics regularly, which will provide a better understanding of time spent in each state, and reasons preventing state transitions. BUG= Change-Id: I5677a64615931e52234a439a4e2565c8b4fc363a Reviewed-on: https://chromium-review.googlesource.com/1153135 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#580286}
-
Peter Collingbourne authored
It looks like we always need to call SetUpBundleOverrides no matter what the process type is, so we can just call it from ChromeMain. This will save us from needing to call this function from browser-specific code in a later change. While here, also remove a dead declaration. Bug: 855193 Change-Id: I449d92ef9c7d80d066d4cfefb3015014bd407cc1 Reviewed-on: https://chromium-review.googlesource.com/1159335Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580285}
-
Scott Violet authored
It's assumed clients are running their own gesture recognizers, so there is no need to forward gesture events. It's possible this code is unnecessary. I say that as in theory ServerWindow stops-propagation on touchs, which should mean gestures aren't recognized, but there may be some other code paths I'm not aware of, so I'm adding early outs, and a DCHECK. And I'm also adding an explicit test. BUG=867035 TEST=covered by test Change-Id: I13d78133b87d07164bf3265788fd0298832d6a2c Reviewed-on: https://chromium-review.googlesource.com/1161058 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Travis Skare authored
Bug: 869513 Change-Id: Idd1db8f01eb27cb5b5cfdc063ee23b0dc09feb15 Reviewed-on: https://chromium-review.googlesource.com/1157167 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#580283}
-
Chase Phillips authored
This is the next step in removing IO thread hopping from the renderer-side non-Blink IDB code. Bug: 717812 Change-Id: I4f0bfc8d98ad7bd9d041954f74215f75271702f9 Reviewed-on: https://chromium-review.googlesource.com/1155794Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580282}
-
Sandra Sun authored
The previous code doesn't check nullptrs thoroughly, causing clusterfuzz pages to crash. This patch adds the checks for those cases to make sure they don't crash. Bug: 863338 Change-Id: Ibed005057fa376cb65200ad51e6dbb16bafa2c6a Reviewed-on: https://chromium-review.googlesource.com/1142457 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580281}
-
John Delaney authored
Take the PageLoadMetricsWaiter and separate it from the PageLoadMetricsBrowserTest so it can be used for specific observer tests. Rename to PageLoadMetricsTestWaiter to reflect is is only intended for testing purposes. Change-Id: Id506c194ab658eba2b5364f201db140023baae72 Reviewed-on: https://chromium-review.googlesource.com/1158973 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#580280}
-
Jan Wilken Doerrie authored
This change implements subscribing to Gatt Notifications for WinRT and enables corresponding tests. Bug: 821766 Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7 Reviewed-on: https://chromium-review.googlesource.com/1156686Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580279}
-
Yiming Zhou authored
This change refactors the captured sites automation framework code out of autofill_captured_sites_interactive_uitest. By completing this refactor, other Chrome teams can leverage the captures sites automation framework to test their team's features on real-world sites. Also included in this change are a few minor fixes: 1. Fixed the captured sites autofill test to work with EventWaiters. 2. Modified a few test recipe files to address test breaks caused by removing the client name parameter from autofill server queries. Bug: 866152 Change-Id: Iee47cee8bd038ce0920caf6d63440c90c94b6285 Reviewed-on: https://chromium-review.googlesource.com/1147512 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
-
