- 14 May, 2020 40 commits
-
-
shrekshao authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4f3976e..204abd2 Bug: 1081973, 1018028, 1082448, 1056830, 1082455 Bug: 1082525, 1082533, angleproject:4242, angleproject:4417, 1060012, Bug: 1082559, 1082565, 1082592, 1082826 TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I6230ee0916a0f105fe80e9b54ebdf6504bec5656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197156 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#768915}
-
Tomasz Wiszkowski authored
This CL addresses the problem where AutocompleteController sends unchanged list of suggestions to present. Bug: 1082619 Change-Id: I78a7fb2652f45eafadb891720131b355a0649a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202383 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#768914}
-
Greg Thompson authored
ImportantFileWriter has been leaking .tmp files in cases where third-party software prevents them from being used and/or deleted. This CL introduces ImportantFileWriterCleaner, an object in a browser process that cleans up any such .tmp files left behind by previous executions. BUG=1075917 R=gab@chromium.org Change-Id: I7516824bd7dfe884ca447642224bc340edfd3cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181276 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#768913}
-
Badhri Ravikumar authored
When user tabs over links and invokes context menu using Shift + F10, link related context menu items are not shown since link url under cursor value isn't set. This CL finds out the link url from the focused annotation and updates link under cursor value. Added unit test to test link under cursor value whenever focused annotation changes. Bug: chromium:994500 Change-Id: Iedb5db7fafcaeb47d1e1e5094b5f7e0553260cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173855 Commit-Queue: Badhri Ravikumar <bravi@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#768912} -
Daniel Rubery authored
This CL adds logic to retry getting the FCM token when the result is ASYNC_OPERATION_PENDING. This fixes the use case of uploading multiple files at once. Fixed: 1078895 Change-Id: I36c1f04f54e2b3f0780d8d6be332300dd7944443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194352Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#768911}
-
Yoav Weiss authored
This CL turns on the feature flags for User-Agent Client Hints, as well as the Client Hints Feature Policy infrastructure. I2S: [1] One test [2] was impacted by a combination of this change and an issue related to the Client Hints infrastructure (but not to this change in particular). It is being tracked in [3] and fixed by [4], which we'll rebase and land once this CL lands (and both change the test). Bug: 928669 Change-Id: I0056827b739b0f6773a49fc8cffe456e5de21803 [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/A4wxFpvqUfA/g7iccl9ICgAJ [2] https://chromium-review.googlesource.com/c/chromium/src/+/2199266/8/chrome/browser/client_hints/client_hints_browsertest.cc#1879 [3] https://bugs.chromium.org/p/chromium/issues/detail?id=1082674 [4] https://chromium-review.googlesource.com/c/chromium/src/+/2201976 Change-Id: I0056827b739b0f6773a49fc8cffe456e5de21803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199266Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#768910}
-
Justin DeWitt authored
This updates the bytecode verifier as well as the various android rules required to make this available to android_aar_prebuilt rules. Change-Id: I631c3133ef63e60c7d825c9ca2c5699e3b1c9c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199929 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#768909}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/46b3bc6c24c2..2b7d96959916 git log 46b3bc6c24c2..2b7d96959916 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 handellm@webrtc.org RtpVideoSender: remove lock recursions. 2020-05-14 handellm@webrtc.org RtpSenderEgress: remove lock recursions. 2020-05-14 handellm@webrtc.org AudioProcessingImpl: remove lock recursions. 2020-05-14 titovartem@webrtc.org Revert "Make sure that "current" rtc::Thread instances are always current for TaskQueueBase." 2020-05-14 titovartem@webrtc.org Revert "Revert back to using the task_queue_ for guarding access." 2020-05-14 danilo.bargen@threema.ch objc: Export RTCStatistics and RTCStatisticsReport 2020-05-14 tommi@webrtc.org Revert back to using the task_queue_ for guarding access. 2020-05-14 rgl@google.com Reland "Add an optional override for AudioRecord device" Created with: gclient setdep -r src/third_party/webrtc@2b7d96959916 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4b9d23a21861b0794f3d966ab598cbb936f44872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768908}
-
Sammie Quon authored
This will improve fade in performance by delaying the creation of the heavy view until needed. It will transfer some delay to the tabbing animation but I think the tradeoff is worth it as, for example with 7 initially offscreen windows: 1) The performance drop will be split 7 ways (not exactly but rough estimate). 2) Fade in performance is about 3x worse right now and arguably more noticeable. Ran the test below (modified a bit) for 8 and 16 windows, 20 times each in a loop. Values are first fade in/average fade in/average container, machine is krane. Though would need to check the dashboards for the real truth. Before 8: 6/15/90 Before 16: 4/5/50 After 8: 18/61/89 After 16: 10/58/50 Test: Tast test ui.WindowCyclePerf Bug: 1078159 Change-Id: I2e7252089b7686b109cd5b196ba847eac29e97bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197145 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#768907}
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include HTML Imports tests, which appear to be fairly specific to testing the HTML Imports feature, and nothing else. The two folders that are moved here are: - fast/html/imports - custom-elements/imports This folder couldn't be moved because it relies on being in the http folder for served results: - http/tests/htmlimports Bug: 937746 Change-Id: I81949c567352054d9c3e1d90fc25018ed5ce6984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198460 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#768906}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/75ef5963b477..983211974bc4 git log 75ef5963b477..983211974bc4 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 enga@chromium.org Reland "Support depth32float sampling on D3D12" Created with: gclient setdep -r src/third_party/dawn@983211974bc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iab4b702072843a48c5d6155a482b1685ced97716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202005Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768905}
-
Caitlin Fischer authored
Bug: 1047474 Change-Id: I51c040faeed7d94d5f9c5d15889fcd2517095e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198929 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#768904}
-
Ken Rockot authored
This introduces a new MojoDedicatedThread feature to Content which, when enabled, changes Mojo to use a dedicated background thread for receiving incoming IPCs rather than using Content's IO thread. The feature is disabled by default. Bug: 1082761 Change-Id: Ia68f288309a316be14b5254e9c4f006b6f8c74cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202143Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#768903}
-
Rodney Ding authored
- Instead of passing multiple return values through pointers, return a struct that contain actual values. - The struct contains validation status, feature_name, expiry_time, is_third_party flag. Bug: 1073918 Change-Id: I8c41ff80ade4a88141118b26da70cc3131cf3559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192675Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#768902}
-
Jacobo Aragunde Pérez authored
Add a DCHECK to prevent alert events happening on non-alert objects. It's located in auralinux code but hopefully should help detect general issues of this kind. Bug: 1082217 Change-Id: I21b91036635102cf555a2dc51530805c428fe343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160989Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#768901}
-
haozhe authored
The test Pass the local blink test, but failed in the browser. The failure in the browser is because microtask::PerformCheckpoint could be called from multiple places such as event_loop causing finish promise to be resolved before removing the finished animation. Bug: 1049372 Change-Id: I1bed4c934d200d66f71eea14d5f94c878add82f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185230 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#768900}
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: I9929a24dcea27b8a2fd43ad95b2327454301aacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159537 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#768899}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4fa68edd6819..08a05bc2b9d1 git log 4fa68edd6819..08a05bc2b9d1 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 duke.acacia@gmail.com Move to newer version of SPIRV-Tools Created with: gclient setdep -r src/third_party/glslang/src@08a05bc2b9d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@chromium.org Change-Id: I89b29f8281e65bb06382d1e173a26992e5581cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202002Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768898}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/7e51f6b2fe28..f6ba532e3e4f $ git log 7e51f6b2f..f6ba532e3 --date=short --no-merges --format='%ad %ae %s' 2020-05-14 dschinazi Disable AckNotifierWithPacketLossAndBlockedSocket in Chrome 2020-05-13 nharper Allow --host and url to refer to different hosts in quic_client_interop_test_bin Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Bug: 1082609 Change-Id: I6baf7fb4cca567d0b466ba9ff3187445fe01d5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202103 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#768897}
-
Harkiran Bolaria authored
Delta: fix flakey testing failures on linux-chromeos-dbg trybot From previous submit: Bfcache is disabled for documents and frames when picture-in-picture functionality is used because the functionality does not close and the video continues to be displayed even while the page is in the cache. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1073224 Change-Id: Icea97b3f3f408ad9b677a39ad4d3bfe924c69309 TBR=haraken@chromium.org Change-Id: Icea97b3f3f408ad9b677a39ad4d3bfe924c69309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188654 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768896}
-
Yue Zhang authored
This CL fixes an issue in conditional tab strip. When switching between normal/incognito tab model by creating new tabs through toolbar menu, there can be two types of misbehavior: 1) The strip doesn't correctly reflect the tab model switch. 2) New tab creation while switching tab model will lead to wrong number of tabs in tab strip. To resolve above problems, this CL 1) Resets the strip if needed when there is a tab model switch. 2) Adds one extra check in TabListMediator so that when reset and add happens at the same time, we don't do redundant addition. Bug: 1081841 Change-Id: Ied7f9e2ee7513b77567b8e7331053d1398342070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197417Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#768895}
-
Matthias Körber authored
Relaxed requirements for BR to ZIP and for TR to ZIP_OR_STATE. With this change, logging the import success is not conditioned on having a LINE1 entry anymore. Since not needing a LINE1 entry is a very rare case, it is not part of combined requirements histogram, yet. Change-Id: I2103a5b4f7d54216e5ea210faee03f91460d60fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199105 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#768894}
-
Ramin Halavati authored
DatabaseTracker uses the term 'incognito' with the meaning of 'in-memory'. This is used for all profile types that are OffTheRecord (including incognito, guest, and non-primary OTRs). To fix the possible misinterpretation, 'incognito' is replaced with 'OffTheRecord'. This CL does not make any behavioral change and is just for better code readability. Bug: 968028 Change-Id: Ifce346865d9d054883ab45679fd3a87144e88bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201377 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768893}
-
Mugdha Lakhani authored
A layout weight of 1 is a good way to make the TextView take up the rest of the remaining width of the parent view, but it is causing issues with centering of the view. This CL removes that. It also centers the contents of the UrlBarView to match the current use case. Here's a video of what the UI looks like after this change: https://drive.google.com/file/d/1fRzackboMhZW5mMAkiLyKs9zKbll35Ei/view?usp=sharing Bug: 1052375, b/156453601 Change-Id: Iecf4b03aacc2ebb60253c6e437031de1320f644a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199277Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#768892}
-
Shakti Sahu authored
Bug: 1081559 Change-Id: Id0e0bbb4d2d0ea1dc2b44bd9cfb4dc1ebd245af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200076 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#768891}
-
David Tseng authored
This change also adds missing param traits for ui::AXEventIntent which was already part of ui::AXEvent. The Blink renderer -> browser IPC has been fully transitioned to mojo, but the browser -> extension renderer hasn't, so we need to keep maintaining legacy IPC including param traits in ui/accessibility/ax_param_traits*. It was missed previously because no clients of this member existed from the extension renderer. R=akihiroota@chromium.org, nektar@chromium.org AX-Relnotes: n/a Test: manually verify intents appear as part of typing into a text field. Change-Id: Iba4bdafbfd56399c7467721faf845baf393cdda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185511 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#768890}
-
Christian Dullweber authored
Disable deletion of cookies through the cookies tree model for supervised users on ChromeOS. Bug: 2201756 Change-Id: I9a5057f94ab61ba85a91f572f1592d36733fcd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202236Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#768889}
-
Kuo Jen Wei authored
Bug: b:155938542 Test: Manually Change-Id: I20a71f1292d85ba2595e20a0ec33e0668df0a203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190466 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#768888}
-
Kurt Horimoto authored
The SafeBrowsing URL checker strips refs and uses canonicalized URLs, so responses with the same canonicalized URL as a previous request should use the same decision. Bug: 1079493 Change-Id: Id696ce278dc0235bb677b4762a7a33c9fce490b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202496 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#768887}
-
Ayu Ishii authored
This change adds a UMA histogram for the MatchType option to measure if it is useful for users or if it is an unnecessary option. [1] Github issue: https://github.com/WICG/cookie-store/issues/128 Tested locally: chrome://histograms/Blink.CookieStore. Change-Id: Ic38f1e6469855bec88cbda11bcfd01ba79ce9be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195442 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768886}
-
Ted Meyer authored
This makes the original chrome://url function as normal while simultaneously enabling the sending of events to devtools. Bug: 1018414 Change-Id: I5555d97df5456e65bed56240f3713586203d8a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197818Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#768885}
-
Philipp Hancke authored
BUG=chromium:921041,chromium:840659 Change-Id: I78b85c0dedd15ecf46300f114620c896c4851c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196396 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#768884}
-
Lutz Vahl authored
This is a roll-back to 8.4.371. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=machenbach@chromium.org,vahl@chromium.org Change-Id: Ieeda8c6c93c5746014cf213f2ca7ab4028f8783a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201376Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#768883}
-
Rakib M. Hasan authored
import_notifier.py requires WPTExpectationsUpdater.write_test_expectations to return a dictionary mapping test names to lists of test expectation strings. This CL makes sure that it returns that dictionary. The fix for WPT imports can be seen in the diff between patchset 1 and patchset 2. Test: crrev.com/c/2200009 does a full run of wpt_import.py. Expectations are created for the imported tests and are written to the file. Bug: 1050760, 1050754 Change-Id: I138ab91408e52b450e47bf0b38b10158b5677c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199998Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#768882}
-
Victor Fei authored
Refactored AXPlatformNodeWinUnittests test names to drop *Test in order to comply with standards. There is no functionality changes. For example: BEFORE: TEST_F(AXPlatformNodeWinTest, TestIAccessibleLocation) AFTER: TEST_F(AXPlatformNodeWinTest, IAccessibleLocation) Change-Id: Ic90e1d8dbfd1fb8fc4e4e400ba0aba27929e70e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199022Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#768881}
-
Wei-Yin Chen (陳威尹) authored
The differences in web rendering can be ignored. Bug: 1025241 Change-Id: I7f34e51ebdd22b0be97d35ccb9257bc8387ffa8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198640Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768880}
-
John Smith authored
When kColorId_TableBackgroundAlternate got added, it didn't have a mapping in Windows high contrast or gtk. This change adds those mappings, using the same colors as kColorId_TableBackground, as intended on non-Mac platforms. Bug: 1082538 Change-Id: Iceaa51d4af602b45213da54d20233e5eafbcd4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200090 Commit-Queue: Joan Barnett <johnsm@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#768879}
-
Wenyu Fu authored
This work involves: 1. Moving ImpressionTracker from //chrome/metrics to //component/browser_ui as it could be beneficial for widgets that wants integrate tracking impression within. 2. Add another API for ImpressionTracker to adjust the impression threshold with a ratio, rather than the default 2/3 if pixel level threshold is not set; 3. Track impression for the primary button for HomepagePromo with ratio as 75%. Bug: 1068831 Change-Id: Ia7366cfa4b7d53dcea03d2b9143c59203f604302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199360 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#768878}
-
Wei Li authored
Since the majority of use cases is to let Widget to own its content view, and we are moving towards removing those cases otherwise, this CL adds a new API to make the ownership transfer clearer. In the followup CL, we should move most of current use cases to adopt this new API. BUG=1044687 Change-Id: Ie21fd78cda1c74252171d543f1840405b8d48a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198363Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#768877}
-
Erik Jensen authored
Due to a GDM bug, affected users can't log in locally via GDM while Chrome Remote Desktop is running. This CL attempts to warn users of the situation by (1) indicating the system is unsupported to disable the web-based setup flow, and (2) by printing a warning at startup, which will also appear if the user works around (1) by using the headless setup flow. Bug: 1082584 Change-Id: I933c181852d8736cca2b9387c934cf74215ecb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200457Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#768876}
-