- 01 Oct, 2019 40 commits
-
-
Austin Tankiang authored
File transfers of hosted drive files should be blocked when: - Transferring to outside of drive. - Transferring to another profile's drive. Also change to using URLsToEntriesWithAccess, as URLsToEntries does not work with files from a different profile. The code is covered by existing tests, however some tests are changed to copy non-hosted files from drive to downloads, as hosted files cannot be copied this way anymore. Bug: 1008328 Change-Id: I9cc86035d7955c9ca34d53587affd5786367a608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830491Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#701441}
-
Alan Cutter authored
Web apps that sync across devices are not considered locally installed for non-Chrome OS devices. This CL ensures we don't accidentally install them as part of manifest updating. Bug: 926083 Change-Id: I34ba3610b04a3cf62e6c7bd362bed2fd770d7b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831737 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#701440}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c6278001533..86a375c756f2 Created with: gclient setdep -r src-internal@86a375c756f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ie4e7d0e1ea1bef16b58ca39de1def0dd759e370f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701439}
-
Anand K. Mistry authored
BUG=972551,977313 Change-Id: Icdc9f46e31f779156ea66b4b3091f786150c08da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827266 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701438}
-
Gyuyoung Kim authored
This CL converts old Mojo types to new Mojo types in CdmProxy interface. CdmProxy::Initialize applies pending_associated_remote to the first argument. Bug: 955171 Change-Id: I6d777b123809c9e56bd25d8204d71ee4d0c8999c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827102Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#701437}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d6a4a0164d45..c2a6ac81ca46 git log d6a4a0164d45..c2a6ac81ca46 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 dtor@chromium.org usergroup_baseline: note that pluginvm belongs to cups-proxy group Created with: gclient setdep -r src/third_party/chromite@c2a6ac81ca46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I45187ae57cd3e0743aa3bd69445ead4fe6eebce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701436}
-
Dan Beam authored
R=tangltom@chromium.org Bug: 1009445 Change-Id: I75f51a6b3b4e22cc06a130e953d47cfd7fccf203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832264 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701435}
-
Sadrul Habib Chowdhury authored
NOTIFICATION_BOOKMARK_CONTEXT_MENU_SHOWN is used to schedule a callback right before the bookmark context menu is run. This is used only in interactive tests. Instead of using this notification, use a more explicit API to register callbacks to run before running the context menu. BUG=268984 Change-Id: I43c78118d6fd7ef53f0b7e7c70aefc85670cf78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831275 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#701434}
-
Jinsuk Kim authored
Moves the internal job handling API to Profile class where it suits better. The API is still present; it will be refactored by updating the call sites to use a helper method in other CL. Bug: 925242, 995903 Change-Id: I292adc2bb9d4bddaccc6857ad33d7b9444c51b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830255Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#701433}
-
Alan Cutter authored
This CL re-enables updating for web app manifests targeting 79. Bug: 926083 Change-Id: Id94c2d74d833a3d9a7d7fbe857018ac4827657b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831661Reviewed-by:
-
Hiroki Nakagawa authored
FileSystemClient is used for checking permissions to access Filesystem APIs. The client is now used only from LocalFileSystem, and no longer has to be a separate class. Bug: 1009854 Change-Id: I8aa25d1e6c41d1114f7bd9904d53ae20dc089e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833002 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#701431}
-
rbpotter authored
There's no reason for the longer name, and we want to be consistent when we add ScalingType in a future CL. Change-Id: Ieeb4e00fb9faeea03a6b82ac46627d175b181e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832471Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701430}
-
nancy authored
BUG=1009248 Change-Id: I16d4549b6a48002b288cfb89a4eefc609d7a6271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830248Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c28e7f784c33..d6a4a0164d45 git log c28e7f784c33..d6a4a0164d45 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 chrome-bot@chromium.org Update config settings by config-updater. 2019-10-01 jclinton@chromium.org Always sync chrome Created with: gclient setdep -r src/third_party/chromite@d6a4a0164d45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6c7c70972947a874cd0e6eecc2dbe7df9ec8a41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833104Reviewed-by:
-
Nicholas Verne authored
One usage in CHROMEOS was missed in https://chromium-review.googlesource.com/c/chromium/src/+/1829625 TBR=tapted@chromium.org Bug: 1003602 Change-Id: I8d43dd6c92023482c5b0ddc92e3fb058bc3a0265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833009 Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#701427}
-
Jeevan Shikaram authored
This CL removes the notification view from tests, store and deletes assets related to notification view. There are no user facing changes. Bug: 1005051 Change-Id: Icefff925c2e1469a167158b461cb0e4006bf5a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809135 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701426}
-
Jeremie Boulic authored
Bug: 993292 Change-Id: I77b8cdc58812f97a69741b0d7bf9364a7ee0f4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833010 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701425}
-
Yutaka Hirano authored
We forgot to attach a KeepAliveHandler to a request with keepalive set is intercepted to a service worker. Fix that. Bug: 1008494 Change-Id: Ia3c2056b65aaedf2b9f865a324ea3f99d0f55506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830249Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#701424}
-
Anand K. Mistry authored
This change also adds a loading message to be displayed next to the spinner. BUG=916506,972551 Change-Id: I0ea753d7c594fc9b62ae73b8c8c7449cd72b6571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819092 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2533afa3f8c6..cb6de9f661f3 git log 2533afa3f8c6..cb6de9f661f3 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 herb@google.com Add maxGlyphCount to SkGlyphRunList Created with: gclient setdep -r src/third_party/skia@cb6de9f661f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I832ba8b1ae9700725bf4c0cfaf13317d27837d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833102Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1945f397. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" ab4b7009 "[Native File System] Aborting a directory iteration succeeds" 8be89ae0 "Update emulated position on each XRFrame" a9f9aa4e "Port opacity-interpolation.html to wpt" dbc7244f "Port order-interpolation.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ibe587256b0dddd6fa3527ff99973019441cbd410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833081Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701421}
-
Alexey Baskakov authored
This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. - Implement WebAppSyncBridge::GetClientTag and GetStorageKey to infer them from launch_url. On Init, pass sync metadata from WebAppDatabase to WebAppSyncBridge's change_processor. Read WebAppRegistrar apps data to implement WebAppSyncBridge::GetData (GetData is the sync "view" for our model data). Unit tests and browser tests will be added later in a follow up CL. An MVP implementation of the bridge needed first. This CL follows "Implementing ModelTypeSyncBridge: Initialization" section described here: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/sync/model_api.md#Initialization In next CLs: Implement: MergeSyncData, ApplySyncChanges, "Local changes" sections. Sync-initiated installs/uninstalls will be an interesting case. Bug: 860583 Change-Id: If8c6e78e48031f4caf9eb39ef68f9de65ec65c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797824Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#701420}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5f4659d6f7a8..ca0d0564630e git log 5f4659d6f7a8..ca0d0564630e --date=short --no-merges --format='%ad %ae %s' 2019-10-01 simonhatch@chromium.org Pinpoint - Switch back to using google-signin Created with: gclient setdep -r src/third_party/catapult@ca0d0564630e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1007043 Change-Id: Ideec25f53fe92b42b156f09ee047672ce522cbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833101Reviewed-by:
-
ccameron authored
This reverts commit 174dd932. Reason for revert: fixed by crrev.com/700989 Original change's description: > Skip tab_capture_end2end_tests on Mac FYI GPU ASAN Release > > TBR=kbr > > Bug: 1008508 > Change-Id: I2c1b3ba59535e7aa29c4ba174c737d7f0ca4630f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827776 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700538} TBR=ynovikov@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1008508 Change-Id: Id32e6c5d6c9013bec430abc4ce009eea0d155d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829876Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#701418}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I343760f44036efe2a5f208f2f9f93f24a1fdf645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832314Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701417}
-
Peter Kotwicz authored
This CL changes the WebAPK host browser selection logic to launch a non-Chrome browser if: - there is no installed Chrome browser AND - the non-Chrome browser is the default browser BUG=1008716 Change-Id: Id14860628d6d170c0aee2e843ca719c1e94652d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828351 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#701416}
-
nancy authored
After install the ARC app, update the equivalent Chrome app to add the badge on the icon. When the ARC app is removed, update the equivalent Chrome app to remove the badge on the icon. Bug: b/141388525 Change-Id: I075cc0c585bbb89a32e88a25d5509c4375b22fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833006Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a9dc7707d610..3044c24181e9 git log a9dc7707d610..3044c24181e9 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 chrisforbes@google.com Use GL_RGB as implementation color read format for GL_RGB565 Created with: gclient setdep -r src/third_party/swiftshader@3044c24181e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I2bf9bdb05ca2aae6804eb2c63393650421e40702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832707Reviewed-by:
-
http://browserbench.org/JetStream/Oystein Eftevaag authored
TBR=perezju@chromium.org Bug: 1009843 Change-Id: I31a331a31978f50c773674a0e3ab130d80b6667f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832474Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701413}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/55a00c7a1f9a..e06f01be719a git log 55a00c7a1f9a..e06f01be719a --date=short --no-merges --format='%ad %ae %s' 2019-09-30 enga@chromium.org dawn_wire: Forward client-generated errors to the server Created with: gclient setdep -r src/third_party/dawn@e06f01be719a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:1004368 Change-Id: I87b85592187ad9da66f1928daf754443073b1099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832635Reviewed-by:
-
Sidney San Martín authored
Use Cocoa UI Preservation to encode and restore window state, like its space and fullscreen state. Like other Mac apps, windows will be restored with full fidelity (i.e. space and all) after a system restart or Chrome relaunch (via chrome://restart, an update, etc.), or will be created on the active space if Chrome is quit and relaunched. AppKit drives this behavior. This change calls encodeRestorableStateWithCoder: and restoreStateWithCoder:, as advised by Apple in https://crbug.com/74812#c56, even though those methods are minimally documented and have warnings in the headers that they're okay to override but you should never call them yourself. Issues I ran into in using them: 1. Encoding can fail and throw an exception if done at the wrong time. Only encoding state on the main thread, in the default run loop mode, and making sure the window is ready by calling (undocumented) -[NSWindow _isConsideredOpenForPersistentState], seem to cover those cases. 2. The window tries to encode some objects that can't be encoded, like itself when it's the first responder, or NSViews. AppKit appears to solve this with a custom encoder that knows what to skip, but being an NSKeyedArchiverDelegate does the trick, too. Things to keep an eye on: 1. I made a small change to window activation during session restore. Without it, session restore tries to activate windows on other spaces, which can cause switches as different windows appear. If this impacts other platforms, it can be restricted to macOS with a #define. It should be fine because the last-used browser still gets activated at the end of the process. 2. Window state gets encoded and stored in NativeWidgetMacNSWindowHost every time it changes. AppKit is much more gentle and only saves state after specific events/times. This might be worth looking into. 3. Windows which get restored miniaturized are blank until the first time they're un-miniaturized. Bug: 74812 Change-Id: Id6fc50151f2762f5428f9e40877b089f7b475078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808708 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#701411}
-
Alexei Filippov authored
The earlier we start heap profiler the more startup allocations it will be able to record. It is now started right after field trial flags become available. Bug: 1007491 Change-Id: Ia25d8c9134f2e17f135d5731a0d5ed0b35905ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827476Reviewed-by:
-
Manu Cornet authored
Change-Id: I9ba9016fdf48fab67a929cbb49ca380045a0fb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832981 Commit-Queue: Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701409}
-
rbpotter authored
This was removed in https://crrev.com/c/1790641 since there is no more chromium code that uses Templatizer directly. However, Templatizer is still used by iron-list, so this needs to be restored in order to compile pages that use iron-list (e.g. chrome://extensions). This causes a 438 byte increase in size in polymer_bundled.min.js (from 147272 to 147710). Bug: 1004967 Change-Id: I51235bde1daf3155f0951f85d4ae4111af9d7bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832629 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#701408}
-
Alexei Filippov authored
It allows us to evaluate how much memory is unaccounted by heap profiler. Bug: 1007491 Change-Id: Iafd70ddfb65e62a5c038a8b244654ef66c3a795f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829739Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#701407}
-
Miyoung Shin authored
This change converts SerialService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482, 1005079 Change-Id: Ia6eb610f76c16f51ced8c5a5d96b3ec3f221e3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821499 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#701406}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33217c214665..8c6278001533 Created with: gclient setdep -r src-internal@8c6278001533 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I43959a59b268785d78b6abc18cdeda729f0a12cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832927Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2b79be398f3e..c28e7f784c33 git log 2b79be398f3e..c28e7f784c33 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 vapier@chromium.org cros_build_lib.run: rename error_code_ok to check 2019-09-30 saklein@chromium.org chroot_lib: add USE_GOMA env var. Created with: gclient setdep -r src/third_party/chromite@c28e7f784c33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iee1a1f2381830db38e8ea4972af6b2e97af5d487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832925Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4aded80e0498..894eb8b0c9ba git log 4aded80e0498..894eb8b0c9ba --date=short --no-merges --format='%ad %ae %s' 2019-09-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1d84c1e7..a9354743 (701137:701308) Created with: gclient setdep -r src/third_party/webrtc@894eb8b0c9ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I6faf4c7a9fd90a0923f40bb4f558cc65653e76e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832928Reviewed-by:
-
Manu Cornet authored
The spec is at https://guidelines.googleplex.com/crosux-spec/feature-specs/shelf-tablet.html#shelf-tablet-home (in-app shelf) but should only apply when the hotseat flag is on. Bug: 1009367 Change-Id: If176d7f14a8573f06a5c37c0cb2b5ae95179a761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832654 Auto-Submit: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#701402}
-
