GitLab

BUG=chromium:927840
TEST=Manual

Change-Id: I2911433cf2b69b4ef5c658194d8c1f13d0a53c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611610Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659511}

The new address sheet will use a similar system as the password and the
credit card fallback sheet. This CL provides only the ViewBinder, Views,
tests and layout for the sub component. Due to missing bindings, this is
no user-visible change.

This CL provides the anticipated views for initially supported fields.
They are grouped as follows:

  NAME_FIRST, NAME_MIDDLE, NAME_LAST
  COMPANY_NAME
  ADDRESS_HOME_LINE1
  ADDRESS_HOME_LINE2
  ADDRESS_HOME_STATE, ADDRESS_HOME_CITY, ADDRESS_HOME_ZIP
  ADDRESS_HOME_COUNTRY
  PHONE_HOME_WHOLE_NUMBER
  EMAIL_ADDRESS

A screenshot will be linked in the bug below.

The translation screenshots are available here:
opening announcement: https://photos.app.goo.gl/RjpT9TaBuYBpt4ad6
title: https://photos.app.goo.gl/6ApwJJdZbgYTu1U9A
toggle: https://photos.app.goo.gl/PdcaQUVCMMB7puWA7

Bug: 962548
Change-Id: Icb40fe9fcae2f0417b65ce790621ae5863cc2bc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609833Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659510}

Basically it's just a copy of the Tests above for AddPendingExtension,
with additional test that there is a version set in the request.

Bug: 959140
Change-Id: Icc49a4c391ad1e6de7e1bb8cc3beed416ec7159c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611892Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Askar Aitzhan <askaraitzhan@google.com>
Cr-Commit-Position: refs/heads/master@{#659509}

Many of the current tests, including PDFExtensionsTest rely on the assumption
that navigating to a PDF will create an <embed>. To ensure all these tests pass
and to keep the old behavior (of having <embed> to avoid breaking an existing
dependencies) this CL makes the following changes:
  * Instead of <iframe>, <embed> is injected and used for attaching MHVG.
  * A scriptable object is generated to support postMessage.
  * To uniquely identify the injected <embed> (vs user generated ones), an
  unguessable token is passed as the <embed>'s internal ID attribute.

This CL makes the behavior of frame-based MHV very similar to the BrowserPlugin
version.

Note that this CL fixes several tests which currently fail (or timeout) with
--enable-features=MimeHandlerViewInCrossProcessFrame (the list of such tests
is included in the linked bug). This CL fixes some of those tests and together
with https://crrev.com/c/1606769 should make most tests including all of the
PDFExtensionTest* pass (with the flag).

Bug: 961786
Change-Id: I3a7940ae71e565e1ffd882b32d8aee7d86060837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607425Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659508}

The macro is outdated. MakeGarbageCollected<T> takes care of requiring
eager finalization from non-leftmost classes throuhg static inheritance
of typedefs.

Change-Id: I6451d67c39e7ccf98efe2fa1638f14da498da9d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611616
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659507}

The documentation on base::Callback<...> (src/docs/callback.md)
recommends against using base::Passed(...) with base::BindOnce.

> Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()`
> does the same thing and is more familiar.

This CL was uploaded by git cl split.

Bug: none
Change-Id: Iaaac8a18757bde124f45cecfd5e99991a19bf8bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611882
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659506}

The OverlayManager didn't actually have any functionality other than
setting up the presenter, so the extra layer of indirection is not
necessary.  Moreover, OverlayPresenter is a better name for the
functionality provided.

This CL also moves the observer and UI delegate classes into
OverlayPresenter's public interface and cleans up the UI delegate to
use requests rather than WebStates, decoupling UI presentation
from WebStateList changes.

Bug: 941745
Change-Id: Ic989843b183cc07a9fbfa1c29fe05598d9934e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599668Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659505}

The documentation on base::Callback<...> (src/docs/callback.md)
recommends against using base::Passed(...) with base::BindOnce.

> Avoid using `base::Passed()` with `base::BindOnce()`, as `std::move()`
> does the same thing and is more familiar.

This CL was uploaded by git cl split.

Bug: none
Change-Id: I5acc8f5c20d32b09780dac376fa92be0395257ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611886Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659504}

DEPS change made with:
  gclient setdep -r src/third_party/perfetto@0ee3cd37199bffdfe162e51bd96e58bcf93f8bee

$ git log aa3f478c06dc..0ee3cd37199bf --date=short --no-merges --format='%ad %ae %s'
2019-05-14 rsavitski@google.com fix fuzzer build & signedness of a test comparison (for chrome)
2019-05-14 fmayer@google.com Allow to not get versionCode with heap_profile script.
2019-05-14 primiano@google.com gn: fix build file generation on macos
2019-05-14 primiano@google.com Fix tools/gen_tracing_cpp_headers_from_protos for mac
2019-05-14 primiano@google.com Fix minor nits in SnapshotClocks() and fix mac build
2019-05-13 primiano@google.com Travis: upgrade vm from trusty to xenial
2019-05-13 fmayer@google.com Document support for SIGUSR1.
2019-05-13 rsavitski@google.com process stats: clear more incremental state, and write marker
2019-05-13 hjd@google.com traced: Add initial timestamp
2019-05-13 fmayer@google.com Use UPIDs for heap profiles.
2019-05-13 lalitm@google.com trace_processor: make slice tracker double check ordering of events
2019-05-13 fmayer@google.com Remove unused scripts from tools.
2019-05-13 rsavitski@google.com traced_probes: process tree - handle ClearIncrementalState()
2019-05-13 rsavitski@google.com Make test trace writer keep its buffer as proper trace packet protos
2019-05-13 rsavitski@google.com tracing service: add support for issuing periodic ClearIncrementalState ipcs.
2019-05-13 rsavitski@google.com Producer: add ClearIncrementalState() call/ipc
2019-05-10 hjd@google.com Reduce field id for test trace packet
2019-05-10 rsavitski@google.com incremental state invalidation: trace config & data source descriptor protos
2019-05-10 fmayer@google.com Remove check that can be triggered by misbehaving clients.


Change-Id: I57f5829e0b6568bd14ee58abf08916f7ffad9784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610757
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659503}

The bot recipe is now passing this flag, and run.py passes unrecognized
flags along to the app under test. Some test apps fail when passed
invalid flags, so have the run.py script accept and ignore --host-app to
prevent it from being passed along to the app under test.

BUG=939373

Change-Id: Ie4b2456c19e96653b30b241fef958c27ede89228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611900
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659502}

https://skia.googlesource.com/skia.git/+log/c2aea5938d0d..bcbd30b7dcaf


git log c2aea5938d0d..bcbd30b7dcaf --date=short --no-merges --format='%ad %ae %s'
2019-05-14 herb@google.com Trivial code cleanup
2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@bcbd30b7dcaf

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Change-Id: Ib5a4f58786f0d673172a35561c5f19056273726b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611661Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659501}

With this change, the background and highlight border colors of the
overlay can be controlled through the parameter OVERLAY_COLORS. This
allows choosing the appropriate overlay color for a given website before
the "loading <website>.." prompt and overlay are displayed for the first
time.

The parameter OVERLAY_COLORS should contain a colon-separated list of
colors in format #aarrggbb. The first color is the background color, the
second color the border color.

Bug: b/131633897
Change-Id: Ia9b34cc25b2ac59dc55a334078254ffa6a4dc381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611613
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659500}

This reverts commit 786fad53.

Reason for revert: might have caused failures in layout tests. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20(retina)/14152

Original change's description:
> Revert "Skip MISSED frames in browser compositor"
> 
> This reverts commit 1374013c.
> 
> Reason for revert: causes jank https://crbug.com/947587
> The original reason for landing this CL does not apply anymore. It is
> no longer the case that viz skips a BeginFrame if an undrawn frame
> exists. See https://crrev.com/c/1521967
> 
> Original change's description:
> > Skip MISSED frames in browser compositor
> > 
> > This CL fixes a dropped frame issue when a scroll transitions from
> > dragging to a momentum "fling" phase. When the user is scrolling and
> > lifts their finger with velocity, the scroll continues according to a
> > decelerating animation curve. When this happens, the FlingController
> > receives a FlingStart instead of a ScrollUpdate and it uses that to
> > create an animation curve.
> > 
> > When this happens the browser process registers itself as an animation
> > observer so that it begins to receive BeginFrame signals. However, the
> > display service issues a MISSED BeginFrame for the frame in which the
> > animation was registered. This will frequently miss submission in the
> > current frame, so it submit next frame and won't receive a BeginFrame
> > then. This leads to a frame without the browser ticking the fling
> > animation. See https://crbug.com/882907#c50 for a diagram and more
> > complete explanation of the issue.
> > 
> > The browser process shouldn't require processing MISSED frames so in
> > this CL we simply drop MISSED frames if we're in the browser compositor
> > (commit_to_active_tree is true). Longer term, the display scheduler
> > should make these decisions but this is an immediate fix for the fling
> > issue.
> > 
> > Bug: 882907
> > Change-Id: Ieb6d14051dc05c5e177da1920dbd27684f941d29
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517164
> > Commit-Queue: David Bokan <bokan@chromium.org>
> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#640172}
> 
> TBR=bokan@chromium.org,sunnyps@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 947587,882907
> Change-Id: I216a0aa63a39f5046879e49209702c1bc318bbd6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610853
> Reviewed-by: Saman Sami <samans@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Commit-Queue: Saman Sami <samans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#659479}

TBR=bokan@chromium.org,sunnyps@chromium.org,samans@chromium.org

Change-Id: I4324ee568a61831a3bfae898c7c2141da009c385
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 947587, 882907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611508Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659499}

This reverts commit f19a4c81.

Reason for revert:

Breaks https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg

Sample failure line:
[ RUN      ] AppMenuModelTest.Basics
[31511:31511:0513/150125.044037:3461088700:FATAL:window.cc(91)] Check failed: env || !g_env_arg_required_string. Within ash you must supply a non-null aura::Env when creating a Window, use window_factory, or supply the Env obtained from Shell::Get()->aura_env()

Causes ~1000 tests to fail.

Original change's description:
> views: random cleanup from removing support for mus
> 
> This functionality was added purely for mus and is no longer necessary.
> 
> BUG=958241
> TEST=purely dead code removal
> 
> Change-Id: I856576f9adef9728d837d56e82f94a87aeea040b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610497
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#659207}

TBR=sky@chromium.org,estade@chromium.org

Change-Id: I7bbf97863986000679890e2076dbb2b0e5fdaf46
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 958241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610709Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659498}

These should synchronously work, so allow them in extension Service
Worker contexts.

Also add tests for these.

Bug: None
Change-Id: I2d1f181bbbe8991546bc79e48ca51ed181d6a260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610855Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659497}

Properly initialize ActionInfo::default_state to the appropriate value
based on the type of action (default enabled for browser actions and
the generic "action" key, default disabled for page actions). Use this
value (instead of inferring from the action type) on ExtensionAction
to initialize the enabled/visible state.

Also move the restriction for default_state from ExtensionActionHandler
to ActionInfo, where the rest of the action validation is.

Finally, add unittests for the parsing of the default_state key in the
manifest, and move the existing tests that verify it isn't allowed for
page/browser actions to the extension_action_handler_unittest.cc file.

Bug: 893373

Change-Id: I14c2f8f92b7cac52fa3e6bcbb10420480a853486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584718
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659496}

Bug: 956495
Change-Id: If86a4618eb2865e3bf63a6bfdc3d92096d7f747b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591839Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659495}

Previous to this CL, overlap checking was incorrect for layers
that had a pixel-moving backdrop-filter applied. The WPT test
external/wpt/css/filter-effects/backdrop-filter-paint-order.html
was the best indicator of this bug - a backdrop-filter painted
*after* adjoining but not overlapping content would be improperly
merged, and blurred content would be observed. This is now fixed.

Bug: 622128
Change-Id: I07539f5fbdc9c6e9cfaf6d4116b8de3dd62d1e94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607101
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659494}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/94454d8433df..69d66c506c56


Created with:
  gclient setdep -r src-internal@69d66c506c56

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com

Change-Id: I1c5378a8db60fe3cf4cdcaf3146515d7266294d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610201Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659493}

These were mistakenly not marked as obsolete when crrev.com/c/1574281
landed.

Bug: 829042
Change-Id: I1061f521b00f9a3c936902153fdd1432dcdac198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611282Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659492}

It is preferred to use the method IsUnifiedConsentFeatureEnabled()
instead of using the kUnifiedConsentFeature feature directly. This CL
replaces all explicit usages kUnifiedConsentFeature with
IsUnifiedConsentFeatureEnabled.

Bug: None
Change-Id: I09a18a7592466774d703baab6e0dd50f08ddace0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599016
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659491}

Non-behavior changing refactoring.

Split visitors into:
- MarkingVisitorBase and MarkingVisitor
- UnifiedHeapMarkingVisitorBase and UnifiedHeapMarkingVisitor

The *Base classes are supposed to be used in concurrent settings while
the ones without suffix are main-thread only. The main-thread versions
also provide write barriers.

Bug: 945806
Change-Id: I01f45b381b328b6b10c62394444c9e7a989b6085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609916
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659490}

This will be used to assess compatibility risk for Payment Request API
changes.

Bug: 821771
Change-Id: I727c0b986c24bd8c741907abdbaa8cd1b4e3c276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607406Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659489}

Changes the font of the text fields to a preffered font in order to
support dynamic type fonts.

Bug: 959764, 951300
Change-Id: I785a5c577d69e33018a7de5403a0e96751b3d455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611601
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659488}

This makes Voice Over not read the siblings views of the alert when
presented. That is the content behind the chrome and the alert.
Everything outside or above the alert view will be read.

Bug: 959764, 951300
Change-Id: Idb932e1fcc251899bccbb7b834e022432c740973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611607
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659487}

With BlinkGenPropertyTrees shipping, we can update the paint
documentation to remove references to the old system (SPV175).
This patch has the following changes:
*) Improved overview section (about 1/3 from the top)
*) Removed the SlimmingPaintV175 section
*) Removed references to BlinkGenPropertyTrees
*) Swapped the order of "Paint invalidation" and "Building paint property trees"
*) A short description of how paint works (there was none before)
*) Typeo fixes

Change-Id: I7a45bb7daefd44642cc000e268e0808faf80e633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604462
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659486}

This reverts commit 4c019ae1.

Reason for revert: Broken compile step on Windows debug GPU bot, see https://crbug.com/962942.

Original change's description:
> Roll src/third_party/pdfium 726ece1b5340..2169a778183b (1 commits)
> 
> https://pdfium.googlesource.com/pdfium.git/+log/726ece1b5340..2169a778183b
> 
> 
> git log 726ece1b5340..2169a778183b --date=short --no-merges --format='%ad %ae %s'
> 2019-05-14 thomasanderson@chromium.org Move pdfium sources into fpdfsdk
> 
> 
> Created with:
>   gclient setdep -r src/third_party/pdfium@2169a778183b
> 
> The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> 
> BUG=chromium:960288
> TBR=pdfium-deps-rolls@chromium.org
> 
> Change-Id: I41be15646bb372865d104d30144a6f90eec5ae61
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610890
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#659360}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,pdfium-deps-rolls@chromium.org

Change-Id: I1c404aca96ac1028cd48b5d8d042fc26d68443f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:960288, chromium:962942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611743Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659485}

Bug: 962677,960322
Change-Id: I6c33767531b7416469cb1766b41299d15398885b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610764
Auto-Submit: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659484}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ca6dbeca..9cbdd437

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If6b84d38173f913bf52239448020790709903048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611250Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659483}

SyncSettingsTableViewController is only used pre-Unified Consent and
DCHECKs that Unified Consent is disabled. This CL ensures that
SyncSettingsTableViewControllerTest runs with Unified Consent disable.

This is a pre-requisite for enabling Unified Consent by default on iOS.

Bug: 960260
Change-Id: I0499985052763eeac1fb640701b341ccdcdfc949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611605Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659482}

https://skia.googlesource.com/skia.git/+log/136ad09848f5..c2aea5938d0d


git log 136ad09848f5..c2aea5938d0d --date=short --no-merges --format='%ad %ae %s'
2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial).


Created with:
  gclient setdep -r src/third_party/skia@c2aea5938d0d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Change-Id: Ie277cbba56e98c7ae0f920d1915b6ad87560895f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611759Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659481}

Adding comments for ChromeIdentityService to accept nil as |callback| for
ChromeIdentityService::GetAvatarForIdentity().
And Adding support for nil callback in FakeChromeIdentityService.

Related to: crrev.com/i/1296954

Change-Id: I0d96d8a3abcd934705ec7743d7711b760ea1b459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609842
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659480}

This reverts commit 1374013c.

Reason for revert: causes jank https://crbug.com/947587
The original reason for landing this CL does not apply anymore. It is
no longer the case that viz skips a BeginFrame if an undrawn frame
exists. See https://crrev.com/c/1521967

Original change's description:
> Skip MISSED frames in browser compositor
> 
> This CL fixes a dropped frame issue when a scroll transitions from
> dragging to a momentum "fling" phase. When the user is scrolling and
> lifts their finger with velocity, the scroll continues according to a
> decelerating animation curve. When this happens, the FlingController
> receives a FlingStart instead of a ScrollUpdate and it uses that to
> create an animation curve.
> 
> When this happens the browser process registers itself as an animation
> observer so that it begins to receive BeginFrame signals. However, the
> display service issues a MISSED BeginFrame for the frame in which the
> animation was registered. This will frequently miss submission in the
> current frame, so it submit next frame and won't receive a BeginFrame
> then. This leads to a frame without the browser ticking the fling
> animation. See https://crbug.com/882907#c50 for a diagram and more
> complete explanation of the issue.
> 
> The browser process shouldn't require processing MISSED frames so in
> this CL we simply drop MISSED frames if we're in the browser compositor
> (commit_to_active_tree is true). Longer term, the display scheduler
> should make these decisions but this is an immediate fix for the fling
> issue.
> 
> Bug: 882907
> Change-Id: Ieb6d14051dc05c5e177da1920dbd27684f941d29
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517164
> Commit-Queue: David Bokan <bokan@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#640172}

TBR=bokan@chromium.org,sunnyps@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 947587,882907
Change-Id: I216a0aa63a39f5046879e49209702c1bc318bbd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610853Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659479}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/394095a0eb17..94454d8433df


Created with:
  gclient setdep -r src-internal@94454d8433df

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com

Change-Id: I4705c623f188abde12b2121c9e7b920c37543dcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611761Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659478}

Since the platform-independent code doesn't support scrolling a node to
a particular location in the window, we calculate the appropriate offset
for each type of scroll and scroll using the ScrollTo API.

Bug: 932708
Change-Id: I2428a40815e276ffe51620496d7782b6340347ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602713Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#659477}

Proguard mapping files are necessary for java_deobfuscate to be useful,
so make sure to list them as data dependencies.

Bug: 962540
Change-Id: Iecf24da4904943f4307679c993b213f1e556d823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609846
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659476}

Bug: 962126

We typically lock this mutex before reading or writing to
decode_failed_. Do so in one more place to avoid a data race.

Change-Id: I0248e4dd99defc5ad3d09575096847e6455adfc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610085Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Leon Scroggins <scroggo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659475}

The render_view_termination_status_ is assigned, but never referenced.
This CL removes it, as it is unused code.

Bug: 566116
Change-Id: I40363c1fa9bf028c2fcd44e5e37e26efd4ec1a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611245Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659474}

Or mark them as platform-specific.

Change-Id: I9f02c101b3df5306ea8d18fc3b3041573510c86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1420275
Commit-Queue: sebsg <sebsg@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659473}

Bug: 962290
Change-Id: Ia7e3ee0e72fc3acecf8246fc2c28ef3ca604e206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609829
Commit-Queue: Anastasiia Nikolaienko <anastasiian@google.com>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659472}