GitLab

Using 'cache = ...' always assigns ... to the local scope, while it
should be stored in the parent scope instead. Because of this oversight,
the cache only contained one list of revisions at any time, namely the
list of revisions for the current settings (e.g. "-a linux64" or "-l -a
linux64").
This patch fixed the issue by iterating over the cached dictionary and
copying the keys and values to the variable (in the parent scope).

R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/1131403003

Cr-Commit-Position: refs/heads/master@{#330374}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5df6fee..9b77796

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1133533005

Cr-Commit-Position: refs/heads/master@{#330373}

Revert of Revert of Use BoringSSL in the implementation of ClearKey for Chromecast. (patchset #1 id:1 of https://codereview.chromium.org/1141243003/)

Reason for revert:
OK to replay now

Original issue's description:
> Revert of Use BoringSSL in the implementation of ClearKey for Chromecast. (patchset #1 id:1 of https://codereview.chromium.org/1130893008/)
>
> Reason for revert:
> Temporary revert until Monday (blocked on some other internal changes).
>
> Original issue's description:
> > Use BoringSSL in the implementation of ClearKey for Chromecast.
> > (Previously, this was used only with the "Chrome" branding).
> >
> > BUG= 488572
> >
> > R=gunsch@chromium.org
> >
> > Committed: https://crrev.com/defd2af08f3753687cb2d86b34bbec9da31ccbab
> > Cr-Commit-Position: refs/heads/master@{#330156}
>
> TBR=ddorwin@chromium.org,dougsteed@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 488572
>
> Committed: https://crrev.com/564d81833f28f73b9413c6d01725530ff91de64c
> Cr-Commit-Position: refs/heads/master@{#330230}

TBR=ddorwin@chromium.org,dougsteed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 488572

Review URL: https://codereview.chromium.org/1148433002

Cr-Commit-Position: refs/heads/master@{#330372}

This patch re-enables loading from APK on Samsung devices where the mmap
exec check is skipped (due to
https://code.google.com/p/chromium/issues/detail?id=448084).

BUG=489267

Review URL: https://codereview.chromium.org/1129223007

Cr-Commit-Position: refs/heads/master@{#330371}

It's not used in net, and net/ knowing about frames is a layering
violation.  External consumers that depended on it now use the
corresponding ResourceType instead.

BUG=426442

Review URL: https://codereview.chromium.org/1134733004

Cr-Commit-Position: refs/heads/master@{#330370}

BUG=489239

Review URL: https://codereview.chromium.org/1141583006

Cr-Commit-Position: refs/heads/master@{#330369}

This CL lands server change 93655511 by bnc.

BUG=488484

Review URL: https://codereview.chromium.org/1132423003

Cr-Commit-Position: refs/heads/master@{#330368}

BUG=345769

Review URL: https://codereview.chromium.org/1143773002

Cr-Commit-Position: refs/heads/master@{#330367}

WebRTC 9189:9205
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/872cf25..3c9a06a

Libjingle 9186:9198
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/a8c7824..87e6b84

TBR=sergeyu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1129783004

Cr-Commit-Position: refs/heads/master@{#330366}

If overriding cert errors is disabed by policy, users shouldn't be able
to use the "danger" command to bypass it.

BUG=440949
R=meacer@chromium.org

Review URL: https://codereview.chromium.org/1119963004

Cr-Commit-Position: refs/heads/master@{#330365}

BUG=None

Review URL: https://codereview.chromium.org/1139903003

Cr-Commit-Position: refs/heads/master@{#330364}

This CL lands server change 92358475 by bnc.

BUG=488484

Review URL: https://codereview.chromium.org/1141473003

Cr-Commit-Position: refs/heads/master@{#330363}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b19d3aa..f6e36c6

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1142073002

Cr-Commit-Position: refs/heads/master@{#330362}

BUG=429756

Review URL: https://codereview.chromium.org/1147703002

Cr-Commit-Position: refs/heads/master@{#330361}

Review URL: https://codereview.chromium.org/1144613002

Cr-Commit-Position: refs/heads/master@{#330360}

BUG=480652
TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/1124293003

Cr-Commit-Position: refs/heads/master@{#330359}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5b5ddd7..5df6fee

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1141483003

Cr-Commit-Position: refs/heads/master@{#330358}

BUG=488302

Review URL: https://codereview.chromium.org/1142783002

Cr-Commit-Position: refs/heads/master@{#330357}

ios/chrome/browser/chrome_url_util.{h,mm} provides some URL utilities for
use on iOS.

Add missing link dependency on UIKit framework.

BUG=429756

Review URL: https://codereview.chromium.org/1139383002

Cr-Commit-Position: refs/heads/master@{#330356}

Update swipe recognizer to differentiate between edge/non-edge
swipes.

BUG=None

Review URL: https://codereview.chromium.org/1137623007

Cr-Commit-Position: refs/heads/master@{#330355}

BUG=429756

Review URL: https://codereview.chromium.org/1133203003

Cr-Commit-Position: refs/heads/master@{#330354}

Logs test cases which will be run, which helps to catch cases when you
misspell config parameter name and run all test cases instead of
specified once.

BUG=369521
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1142803002

Cr-Commit-Position: refs/heads/master@{#330353}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4657068..5b5ddd7

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1147683002

Cr-Commit-Position: refs/heads/master@{#330352}

Revert of Reland: Lazily initialize MessageLoop for faster thread startup (patchset #5 id:160001 of https://codereview.chromium.org/1129953004/)

Reason for revert:
Massive data race reports, see https://crbug.com/489263

Original issue's description:
> Reland: Lazily initialize MessageLoop for faster thread startup
>
> Original review: https://codereview.chromium.org/1011683002/
>
> Reverted because it's suspected for following flakiness issues:
> http://crbug.com/485157 - Windows race
> http://crbug.com/485091 - Android ThreadWatcher
> http://crbug.com/485178 - interactive_ui_tests Menu* tests
>
> PS1 is the original patch set that gets reverted.
>
> BUG=465458, 485157, 485091, 485178
> TBR=jam
>
> Committed: https://crrev.com/8b6133a69f16702a32a3c3104630c4d9ac393b7a
> Cr-Commit-Position: refs/heads/master@{#330329}

TBR=thakis@chromium.org,toyoshim@chromium.org,jam@chromium.org,kinuko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=465458, 485157, 485091, 485178

Review URL: https://codereview.chromium.org/1140363002

Cr-Commit-Position: refs/heads/master@{#330351}

Improved logging in chrome code in case of error in policy fetching.

BUG=489230

Review URL: https://codereview.chromium.org/1140333002

Cr-Commit-Position: refs/heads/master@{#330350}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/36757d61..b19d3aa

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1139093003

Cr-Commit-Position: refs/heads/master@{#330349}

Revert of [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost (patchset #1 id:1 of https://codereview.chromium.org/1132913004/)

Reason for revert:
See crbug.com/489135

Original issue's description:
> [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost
>
> BUG=483693
>
> Committed: https://crrev.com/1771428fefada2d24fab5970b915b941a5014cc1
> Cr-Commit-Position: refs/heads/master@{#330286}

TBR=dgozman@chromium.org,pfeldman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=483693

Review URL: https://codereview.chromium.org/1140603004

Cr-Commit-Position: refs/heads/master@{#330348}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8e110e4..36757d61

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1144793002

Cr-Commit-Position: refs/heads/master@{#330347}

This test has been flaky in the last 2 weeks on Mac bots.
(Adding NOTRY as everything is currently red on the perf waterfall)

BUG=489214
NOTRY=true
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1129833005

Cr-Commit-Position: refs/heads/master@{#330346}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6137460..8e110e4

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1139233003

Cr-Commit-Position: refs/heads/master@{#330345}

BUG=263527

Review URL: https://codereview.chromium.org/1127143003

Cr-Commit-Position: refs/heads/master@{#330344}

Move GetHumanReadableOrigin method to affliation utils in order
to make it available in ios. This CL requires  GetHumanReadableOrigin
on ios: https://chromereviews.googleplex.com/191547013/

BUG=486736

Review URL: https://codereview.chromium.org/1130213004

Cr-Commit-Position: refs/heads/master@{#330343}

This patch fixes the regression by https://codereview.chromium.org/1134603002/diff/1/ui/file_manager/video_player/css/video_player.css

BUG=488213
TEST=none

Review URL: https://codereview.chromium.org/1141183004

Cr-Commit-Position: refs/heads/master@{#330342}

Make sure jinja2 from third_party is used.

Review URL: https://codereview.chromium.org/1138383003

Cr-Commit-Position: refs/heads/master@{#330341}

This is to ensure that threading is not the cause of http handler crashes.

BUG=none
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1138323003

Cr-Commit-Position: refs/heads/master@{#330340}

The change complements Breakpad's crrev.com/1125153008 and introduces
the ability of attaching production information and build id to
microdumps.

The DEPS roll pulls in the following change:
r1456 d7e4030  [microdump] Add build fingerprint and product info metadata.

Summary of all changes available at:
https://chromium.googlesource.com/external/google-breakpad/src/+log/9fcbe25..d7e4030

BUG=456494,410294

Review URL: https://codereview.chromium.org/1019663003

Cr-Commit-Position: refs/heads/master@{#330339}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/739db8a..6137460

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/1145673002

Cr-Commit-Position: refs/heads/master@{#330338}

With "--log_time" optional arg, we can see each logged event's
timestamp to know how long does a task spend.

BUG=None
TEST=manual ./run_benchmark with "-v --log_time" args added.

Review URL: https://codereview.chromium.org/1079443002

Cr-Commit-Position: refs/heads/master@{#330337}

glBindTexImage2DCHROMIUM and glReleaseTexImage2DCHROMIUM will force the
texture format in the level info to GL_RGBA regardless of the internal
format used by the GLImage.

This CL address this by adding a GetFormat function to GLImage that
glBindTexImage2DCHROMIUM and glReleaseTexImage2DCHROMIUM will use when
updating the level info.

BUG=

Review URL: https://codereview.chromium.org/1140683002

Cr-Commit-Position: refs/heads/master@{#330336}

Rules for invariant varying (or in/out variable) matching are different
for ESSL 3 and ESSL 1. Use a recently added ANGLE API to choose which
rules to use based on shader version.

Tested by WebGL 2 test deqp/data/gles3/shaders/qualification_order.html

BUG=488372
TEST=WebGL 2 conformance tests

Review URL: https://codereview.chromium.org/1135733006

Cr-Commit-Position: refs/heads/master@{#330335}