- 27 Nov, 2019 40 commits
-
-
Michael van Ouwerkerk authored
Bug: 1021150 Change-Id: Ia3c3c49bbcbcf614fafbc9c46246cc124c4bbbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940170Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719632}
-
chrome://flagsMounir Lamouri authored
kOnDemand mode isn't being used by default since M75. We are using the opportunity to deprecate the chrome://flags. SurfaceLayerMode is still needed because some targets need to disable the feature. Bug: 901513 Change-Id: Iaf55a1b583d080ce04379566aaf03deb0b9a9123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756396Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#719631}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b6f642d9c3b..9d27d96fff72 git log 5b6f642d9c3b..9d27d96fff72 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 buss@google.com Fix android x64 compilation using Ninja. Created with: gclient setdep -r src/third_party/perfetto@9d27d96fff72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I574c031fd5313aecfa31611f31a8203005087b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719630}
-
jongdeok.kim authored
Change-Id: I7d6162c2dee31d1776d8ec36175ade1b360f0a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918787 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#719629}
-
Tommy Li authored
For historic reasons, LocationBarView "dug into" OmniboxViewViews and triggered some additional actions on focus. This CL moves those actions into OmniboxViewViews to reduce the need for LocationBarView to be concerned with OmniboxViewViews' behavior. Also this CL deletes a feature flag that's been Enabled by default for a long time, and exists just as an unused killswitch. Bug: NONE Change-Id: Id29abca060b5e8b7f1cd8b31b6c202833303a849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937773Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#719628}
-
Miyoung Shin authored
This CL converts WebSocketConnector mojom interface client in content and blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I4177c048fa87cc18bffbcd31b1cd9d74825fc267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935291 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#719627}
-
Ryan Harrison authored
BUG=dawn:285 Change-Id: I4d05df0baa8dadf4b52f908eab29176c9c50eabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940547 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719626}
-
Sam Maier authored
Change-Id: I299e3e6515afae265f24aa3330140e1958a887a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940528 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Josh Nohle authored
Bug: 951969 Change-Id: If303af7a91b01692e99c5b10cfafa8435262df17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913180Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#719624}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/74cebd68792d..2559fc0b842c git log 74cebd68792d..2559fc0b842c --date=short --first-parent --format='%ad %ae %s' 2019-11-27 rharrison@chromium.org Removing for_fuzzers target Created with: gclient setdep -r src/third_party/dawn@2559fc0b842c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I38c59d366aa0841674d911b2034047cdfef5bb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939953Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b5a297f389e0..df0056acafd6 git log b5a297f389e0..df0056acafd6 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 vapier@chromium.org tast_test_stages_unittest: handle json failure messages in Python 3 2019-11-27 vapier@chromium.org fake_cidb: fix sorting logic 2019-11-27 vapier@chromium.org report_stages: use utf-8 encoding with commands 2019-11-27 vapier@chromium.org cbuildbot: manifest_version: fix encoding when writing 2019-11-27 shaochuan@chromium.org Revert "chromeos_config: Disable betty-pi-arc-release VM Tests" 2019-11-27 vapier@chromium.org swarming_lib: sort --tags when adding 2019-11-27 vapier@chromium.org sdk_stages_unittest: fix test under Python 3 2019-11-27 vapier@chromium.org deploy_unittest: fix tests under Python 3 2019-11-26 ahassani@chromium.org paygen: disable payload verification 2019-11-26 victorhsieh@chromium.org setup_adb: remove unnecessary mtp config from adb trigger 2019-11-26 vapier@chromium.org avoid deprecated dict has_key method 2019-11-26 vapier@chromium.org buildbucket_v2/ts_mon: change protobufs imports to relative 2019-11-26 vapier@chromium.org cbuildbot: delete DetectRelevantChangesStage 2019-11-26 vapier@chromium.org artifact_stages_unittest: fix old exception message usage 2019-11-26 vapier@chromium.org puppet_metrics_unittests: switch to io.StringIO 2019-11-26 ahassani@chromium.org payload-tryjobs: Run uprev before initsdk 2019-11-26 vapier@chromium.org config: delete all CQ/paladins 2019-11-26 seanabraham@chromium.org lib: remove Legacy-Commit-Queue references 2019-11-26 vapier@chromium.org loman/repo_manifest: change ElementTree.tostring return to unicode Created with: gclient setdep -r src/third_party/chromite@df0056acafd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ic4847dc55581cfb023937319dca70808051d822d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939952Reviewed-by:
-
Marc Treib authored
On Android, Sync only subscribes for SESSIONS invalidations while the Recent Tabs page is open. Before this CL, the corresponding *un*subscription was delayed by one hour, to avoid subscription/unsubscription churn. However, this task was not persisted, i.e. it got lost if Chrome was shut down within that hour. The new FCM-based invalidations system does not do any cleanup on startup (in contrast to the old Tango system), meaning such an unsubscription would then never actually happen. This CL removes the unregistration delay, as a quick fix to avoid most of the "dangling subscriptions". It also adds a feature "SyncUseSessionsUnregisterDelay" (disabled by default) to go back to the previous behavior. Bug: 1024817 Change-Id: Iaaf1afca3ba8719a3837dd760e4bd169d4d3c3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919209Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#719621}
-
behdad authored
Coping the strings used in tracing is not necessary because the used strings are static literals. Also this is not necessary in case of values (not category/event/argument names) passed to trace events. Bug: chromium:1025973 Change-Id: Iabd03e8bf54353663d886c9bb53b7daaa4001919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934772Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719620}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<SVGViewElement> as new downcast helper 2. Use IsA<SVGViewElement>(element) in place of IsSVGViewElement(element) Bug: 891908 Change-Id: Ib22d10d67dfa70323919a4d3fdc03d85bbfde055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936689Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719619}
-
Stephen Chenney authored
I believe a patch landed to fix this issue, so the change is expected. TBR: chrishtr@chromium.org Bug: 946532 Change-Id: If1d27ee3508ce6ddbf3fad9ca9eaf408c00d1288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940508Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#719618}
-
Takumi Fujimoto authored
CastMediaSessionController receives media action commands from CastMediaNotificationItem and forwards them to a media controller in Media Router, which then sends the command to the Cast device. Bug: 987479 Change-Id: Ib7ce9b7be603d47f866e34e8c23154daf36bfeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927377Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#719617}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b5843d2..2e0e0a78 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I48a9dc62e22a2431655e14399750313b0e5073e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940427Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719616}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a64e0786130f..0a672dd089c5 Created with: gclient setdep -r src-internal@0a672dd089c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I210359c7fd271ea2a5eeeea9b42100b49ae280c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719615}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<SVGScriptElement> as new downcast helper 2. Use IsA<SVGScriptElement>(element) in place of IsSVGScriptElement(element) Bug: 891908 Change-Id: I74d59ca2549e7e19291f205b37b721e4eb3da5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936690Reviewed-by: -
jongdeok.kim authored
This CL changes to use SetRoundedCornerRadius, and removes mask layer. Bug: 1005390 Change-Id: Id3b913ea2b20cb68c94ecda1d4cd14fa6e969283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936694 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#719613}
-
Roman Sorokin authored
Also center similar to other illustrations Bug: 1019879 Change-Id: I864c425d46694d9370d48636daf996c8b27d657e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939407Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719612}
-
Tim Schumann authored
Bug: 1028594 Change-Id: If251adbf93f56a674a1247d3ae20deb403eac9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936769Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#719611}
-
kylechar authored
The existing RunOnceClosure<N> implementation wouldn't compile if the Nth argument was a OnceClosure passed by value. Use the same action machinery as RunOnceCallback<N> to fix this. Bug: none Change-Id: I4fe5fe187ead7bedd084b26575e74da7fab3f7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925556Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/03e4c95c31e6..c241b5896524 git log 03e4c95c31e6..c241b5896524 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 bsalomon@google.com Make fragment processor iterators work with range for loops. 2019-11-27 egdaniel@google.com Handle failures in VkCommandBuffer creation. Created with: gclient setdep -r src/third_party/skia@c241b5896524 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Iad0bea6f72f2c4a983b320f7ac7fa46225a1344d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939951Reviewed-by:
-
Corentin Wallez authored
This reverts commit 8834f5a3. Reason for revert: Likely culprit for consistent failure on Linux FYI Debug (NVIDIA): both GpuProcess_swiftshader_for_webgl and GpuProcess_feature_status_under_swiftshader fail DCHECK(gpu_feature_info_.IsInitialized()) Original change's description: > Replace GPU Compositing feature with GL > > GPU compositing is never specifically blacklisted in > software_rendering_list.json, only when all are disabled, so remove it, > and add GPU_FEATURE_TYPE_GL. Use this as a proxy for GPU compositing for > now. This will need to be fixed to support the case where GL is > blacklisted, but Vulkan is still enabled. > > Bug: 1005383 > Change-Id: I0330021cfa59c6c4cf2719785f7931e53ec50f80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917753 > Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719399} TBR=zmo@chromium.org,kylechar@chromium.org,sgilhuly@chromium.org Change-Id: I65f801a3d790f864367101cbaabc7991308ffe03 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940172Reviewed-by:
-
Ioana Pandele authored
Setting the policy to enabled will only cause credential checking to be performed if Safe Browsing is also enabled. Bug: 1028095 Change-Id: I30f5a777cf055997d379d40fefb97db7b2b8dcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937032 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#719607}
-
David Jean authored
This is a reland of c273c91d Original change's description: > [ios] Move password settings tests to EG2 > > Bug: 987646 > Change-Id: I9e21ec812293136797b80af8c4b189331941a111 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903363 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: David Jean <djean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715258} Bug: 987646 Change-Id: I9bdce59f16eb10493b69f43133bd2316396c51e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917218 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#719606}
-
Alex Turner authored
Improves histogram documentation by adding note warning that sums may substantially differ from the true value due to per-sample rounding. For example, if many tiny resources are loaded, each sample will have a recorded size of 0 KB. The error between the sum of these and the true value will thus accumulate. Change-Id: I5c72b770ed4ad3e9649666d31e64d1e0a68e7924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937772Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719605}
-
Bret Sepulveda authored
This patch moves PermissionsBubbleDialogDelegateView out of permission_prompt_impl.cc, renames it to PermissionPromptBubbleView, changes most methods on PermissionPromptImpl to delegate to the bubble class instead of manipulating it directly, and rewrites the bubble code to be more idiomatic. This patch also deletes permission_prompt_impl_views.cc and moves the function inside it to permission_prompt_impl.cc, since the latter is now much simpler. Bug: 1019129 Change-Id: I21293657d020cddb61c992b8c34ea90b1b6023de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890337 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#719604}
-
Ioana Pandele authored
The icon is set to appear above all the items in the dialog when enough space to display the image is available and next to the title, when there isn't enough space. There are screenshots at https://crbug.com/1028095#c24 Bug: 1028095 Change-Id: I4e0b363ccea48ecf9588dc5764a61ef7f330639e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937175 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719603}
-
Mikel Astiz authored
https://chromium-review.googlesource.com/c/chromium/src/+/1886898 has recently switched to reading favicons on demand from a dedicated server, so the traffic caused by sync-ing history favicons can be spared. This patch achieves so by enabling an existing feature toggle. One additional aspect is addressed, overlooked previously in https://chromium-review.googlesource.com/c/chromium/src/+/1653428: the local copy of favicons as persisted by sync (pseudo-USS) must be cleaned up to avoid indefinitely leaking such data locally. Bug: 978775 Change-Id: I7bf0c8d05348b5399cd3c5bc9f8675cd013d600e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917173 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719602}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fff69a79f984..d1cfda327db2 git log fff69a79f984..d1cfda327db2 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 tvanderlippe@chromium.org Migrate text_editor/ and cm_web_modes/ to ESM 2019-11-27 liviurau@chromium.org [devtools] Whitespace to test devtools recipe 2019-11-27 aerotwist@chromium.org Migrates layer_viewer/ to esm Created with: gclient setdep -r src/third_party/devtools-frontend/src@d1cfda327db2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1018837,chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06e0c39403f8f8c3871b6cd2458eb27118832f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940290Reviewed-by:
-
Akihiro Ota authored
This change fixes a bug where single letters that appeared after numbers get replaced by units. In the example listed in the bug report, text such as "Join the 5g Network" would get announced as "Join the 5 grams Network". To prevent this behavior, we look for the pattern [number + single letter] and capitalize the letter; this prevents the TTS engine from replacing the letter with units. Bug: 1005933 Change-Id: Ic5251926d7e78796d4de45632dd817e9a0ac7f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930690Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#719600}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b1ccae253e0b..9f9e20a3dc68 git log b1ccae253e0b..9f9e20a3dc68 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 mbonadei@webrtc.org Fix errorprone issues preventing Chromium Roll. 2019-11-27 phoglund@webrtc.org Turn off Goma for Linux GCC. 2019-11-27 peah@webrtc.org Corrected the aggregation of AGC choices and add fallback solution 2019-11-27 peah@webrtc.org Adding parametrization of the AEC3 howling mitigation behavior 2019-11-27 jonaso@webrtc.org make Connection::port() protected Created with: gclient setdep -r src/third_party/webrtc@9f9e20a3dc68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None,chromium:b/145243047 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7dcc90277b8e4dfb32f43af4e04e92e903883da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940289Reviewed-by:
-
Chris Sharp authored
This reverts commit 4acb3251. Reason for revert: Tests are very flaky on linux-chromeos-dbg. See crbug.com/1029019 Original change's description: > [directorytree] Add a keyboard horizontal scroll test > > CL:1924341 limited the horizontal scroll of the directorytree to 0, to > resolve issue 1025581, and needs a test of this behavior. > > Test: create a nested set of test folders, and use keyboard arrow-left > (provided by expandSelectedFolderInTree, note) to navigate to the last > of those folders. Post navigation, verify the navigation, and that the > directory tree is not horizontally scrolled. > > This new test passes with CL:1924341, and fails before that CL (good). > The CL used requestAnimationFrame (rAF) to limit the scroll. Add async > test rAF helper and call it to ensure the scroll rAF is done, and that > expandSelectedFolderInTree events have been processed. > > Test: browser_tests --gtest_filter="*TreeKeyboardHorizontalScroll*" > Bug: 1025581 > Change-Id: Iff79b963559d282841f1d2045aadcee7e5840cea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936579 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719411} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org Change-Id: I8a9957779fd6fddc8f53f45cb6118bcfa10b2360 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940507Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719598}
-
Yuki Shiino authored
Implements attribute get callback; [CachedAttribute], [SaveSameObject], [CheckSecurity=ReturnValue] Bug: 839389 Change-Id: I1982e5aee40d4800c870e15c5d83b702bcb5945a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940308 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#719597}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ia31c0b27ee034e697551d170a961b131cf8415e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939989Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGLinearGradientElement> as new downcast helper 2. Use IsA<SVGLinearGradientElement>(element) in place of IsSVGLinearGradientElement(element) Bug: 891908 Change-Id: I3f775ab96a3fab152b797aa29d9f7db3ae962b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936609Reviewed-by:
-
Hans Wennborg authored
CLANG_SVN_REVISION is prefixed with an 'n' these days, e.g. 'n331734'. Bug: 1015315 Change-Id: I6ed404f230be71f745f7febab10a222f8d6c6cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939973Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719594}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I5da0e1c07c06f17ff9c40ec8ba9fac55b540f875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939083Reviewed-by:
-
