- 02 Aug, 2019 40 commits
-
-
Lutz Justen authored
The presubmit told me so. TBR=rsorokin@chromium.org BUG=b/138287069 TEST=None Change-Id: I6e32ff7e4cc74e044e949e09a75d8fffbd271c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731835Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#683505}
-
Takuto Ikuta authored
Change-Id: Ie171df6c108992ecaf417f95de24bb43e1d79967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732076 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#683504}
-
Alan Cutter authored
PendingAppManagerImplBrowserTest.BypassServiceWorkerCheck tests whether the pending app installation installs the app as a PWA rather than a shortcut app. This can be determined by the presence of a scope. The function FindAppWithUrlInScope() uses a default scope if there isn't one present so its return value can't be used as an indication of the app having/not having a scope. This CL improves the check by explicitly checking GetAppScope(). Change-Id: Ieeb0c9dfb911cf3af5657e53ed86f65b60a8f07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732516 Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#683503}
-
Makoto Shimazu authored
This reverts commit f37f7fde. Reason for revert: Let me revert this so that crrev.com/c/1728889 can create throttles on the IO thread. Original change's description: > Remove unused members of ProfileIOData > > These are no longer used after http://crrev.com/c/1731919 > > Bug: 824840 > Change-Id: I7163336861c227fb7fa7aab9fe297898d92067c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731180 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683474} Change-Id: I2b5c64dd5d5548dfe472352a6a1313bee7fa8770 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732519 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683502}
-
Ramin Halavati authored
Incognito window counter has been enabled by default since M66. Removing the kEnableIncognitoWindowCounter flag. Bug: 896235 Change-Id: Ib52d17f652f8c77e42496732e74efefc3edab79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729224 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#683501}
-
Hiroki Nakagawa authored
This is a preparation CL for removing WorkerShadowPage. Before this CL, shared worker's user agent is supplied by WorkerShadowPage's Document. After this CL, it's supplied from SharedWorkerHost in the browser process. This is aligned with service workers. Bug: 538751 Change-Id: I16a4c51077ed04563c9bba4609f821b704d59ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730490 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683500}
-
Hitoshi Yoshida authored
In processing interface inheritance, we make a copy of unforgeable member defined in recursively inherited interfaces. Bug: 839389 Change-Id: I7ad45a90c0540f75aed39982f0831424a3459181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728511 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#683499}
-
Matthias Körber authored
[PasswordManager] Fixed linter issues / style guide violations in |FormStructure| caused by using non-const references instead of pointers. Change-Id: I44623a3c24d353a82c9745d0c1ed222afd242876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731114Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#683498}
-
Anders Hartvoll Ruud authored
Change-Id: I7e4b2b61214ccb74a14a7bffb4a4b64eb9d80f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724525 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#683497}
-
Dominic Battre authored
R=dvadym@chromium.org Change-Id: I9cdd44e714d07344743f8886bc22d801ceb119bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732071 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Nigel Tao authored
Change-Id: I3b6c93cc61d66922b92ac12cfcc31e4e528000c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731637 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#683495}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/574b951188bb..c1583a558c58 git log 574b951188bb..c1583a558c58 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 idanr@google.com Create CommandRecordingContext Created with: gclient setdep -r src/third_party/dawn@c1583a558c58 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:976495 Change-Id: Ic3bc1f5dfed56b289efba9c5ed0a045a8d1a1d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683494}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9532972a16bb..87ba747e956d git log 9532972a16bb..87ba747e956d --date=short --no-merges --format='%ad %ae %s' 2019-08-02 yyanagisawa@chromium.org Allow to set Goma client used for build package. Created with: gclient setdep -r src/third_party/chromite@87ba747e956d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I79a05fdadc1ddc3a0d5d622fcb3074d9a32c175f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732510Reviewed-by:
-
nancy authored
BUG=988321 Change-Id: I71583875adc8297fa632eb1caedc08e925d50235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731639Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#683492}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0390f88f270..e1cff9e2ff2c Created with: gclient setdep -r src-internal@e1cff9e2ff2c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I40100397071ec8b43b943b5a8d6f5415560dd19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732715Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683491}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1d7d96a9. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6790530d "[WPT/common/security-features] Make subresourceContext unmodified" 219bce7d "Worker: Add upgrade-insecure-requests tests for top-level classic shared worker script loading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I54029a61a648c79becb0cdd82a816dab20cac127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731452Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683490}
-
Jinsuk Kim authored
This CL replaces the gray outline of the navigation bubble with a shadow. Also fixes a bug on Kitkat where the bubble appears in dark gray which was a side effect from RippleBackgroundHelper. Bug: 979499, 988341 Change-Id: Ibea69d60834d916f99ec7add54e1d4ae7484c5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722581Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#683489}
-
Nigel Tao authored
This reverts commit 536bae08. Reason for revert: unit_tests failure fixed by crrev.com/c/1732110 Original change's description: > Revert "Flip the AppServiceAsh feature default to enabled" > > This reverts commit 1b08fa8e. > > Reason for revert: suspect causing unit_tests failure on linux-chromeos-dbg. > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/13673 > deterministic failures: > ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 > ArcAppLauncherForDefaultAppTest.AppIconUpdated/1 > ... > E.g. > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906357365557383728/+/steps/unit_tests/0/logs/Deterministic_failure:_ArcAppLauncherForDefaultAppTest.AppIconUpdated__x2f_0__status_CRASH_/0 > [ RUN ] ArcAppLauncherForDefaultAppTest.AppIconUpdated/0 > Received signal 11 <unknown> 000000000000 > #9 0x7f40f3cfd40b base::ThreadCheckerImpl::CalledOnValidThread() > #10 0x5611fbac0319 arc::internal::ConnectionNotifier::RemoveObserver() > #11 0x5611f8ea55e9 arc::ConnectionHolder<>::RemoveObserver() > #12 0x5611ff697745 apps::ArcApps::~ArcApps() > #13 0x5611ff69786c apps::ArcApps::~ArcApps() > ... > #22 0x7f40e9d8e740 KeyedServiceFactory::Disassociate() > #23 0x7f40e9d8e834 KeyedServiceFactory::ContextDestroyed() > #24 0x7f40de6a3503 BrowserContextKeyedServiceFactory::BrowserContextDestroyed() > #25 0x7f40de6a3677 BrowserContextKeyedServiceFactory::ContextDestroyed() > #26 0x7f40e9d8b145 DependencyManager::DestroyFactoriesInOrder() > #27 0x7f40e9d8b1f5 DependencyManager::PerformInterlockedTwoPhaseShutdown() > #28 0x5611fe3b3fc3 TestingProfile::~TestingProfile() > #29 0x5611fe3b43cc TestingProfile::~TestingProfile() > ... > > Original change's description: > > Flip the AppServiceAsh feature default to enabled > > > > BUG=826982 > > BUG=989789 > > > > Change-Id: I49bd3793bf9fcfc89726fd2f7df690421996e0fd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728411 > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683064} > > TBR=dominickn@chromium.org,nigeltao@chromium.org > > Change-Id: Iec931954750b6a58d2274c6479507e99efd2467a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 826982, 989789 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731091 > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#683108} TBR=tasak@google.com,dominickn@chromium.org,nigeltao@chromium.org Change-Id: I0f8e2a335011012df144a02cf75fe943f6196171 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826982, 989789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731373Reviewed-by:
-
Gabriel Charette authored
This (PS1) passes all existing tests as-is but ParkableStringTest.ReportTotalUnparkingTime. This failure happens because samples of Now() within the same task no longer have any delta under MOCK_TIME regardless of how CPU expensive the operation actually is. That test was using a state of the art approach, base::ElapsedTimer, MOCK_TIME, base::HistogramTester, etc. But base::ElaspedTimer is neutered by the change to MOCK_TIME in this CL. There are two potential solutions: 1) Have ElapsedTimer play a role in auto-advancing mock-time. 2) Mock timings returned by ElpasedTimer. (1) is undesirable because it would make it possible for delayed tasks to run as part of a basic RunUntilIdle() which takes control of delayed tasks away from the ScopedTaskEnvironment owner and is highly undesired. (2) is more explicit but also easier to control. This CL does that by adding base::ScopedMockElapsedTimersForTest. This actually makes ParkableStringTest.ReportTotalUnparkingTime cleaner because it can now test for a specific timing instead of just "has a non-zero timing". Bug: 905412 Change-Id: I91fab300b4005fd7802ce837733665e77766d4b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707870 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683487}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/39dda0fe6aa0..0e04cdf70fe2 git log 39dda0fe6aa0..0e04cdf70fe2 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 27e2873765fa..f63c4e51101a (3 commits) Created with: gclient setdep -r src/third_party/skia@0e04cdf70fe2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: I3b4376d8693c7bb183efaae8fb97a83df3bd1d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732654Reviewed-by:
-
Kenichi Ishibashi authored
There were some DCHECK(IsMainThread()) in ServiceWorkerGlobalScopeProxy. When we move service worker startup off the main thread, these DCHECKs will start failing. Use |parent_task_runner_| instead. Bug: 692909 Change-Id: I92c788184b9b3753bf6eb2eec5393471e70e439e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732669Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683485}
-
Melissa Zhang authored
This CL adds metrics to record the types of schemes that users click on and then how they proceed, whether that's opening an app with persistence, without persistence, or clicking out of the dialog. BUG=984840 Change-Id: Ie6de5f6c31812edeb403138f7bac947ce087337b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718600 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#683484}
-
Jesse Schettler authored
Move CustomTabSessionImpl to its own file. Also, factor out code that can be used by other classes that create and manage an ARC Custom Tab. BUG=b:64863368 TEST=Deploy Chrome to DUT and verify ARC Custom Tabs work correctly R=djacobo@chromium.org, hashimoto@chromium.org, oshima@chromium.org Change-Id: Ib11a233aa04ac52cfe73abaa9ecbb145791aa263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728446Reviewed-by:
Mitsuru Oshima (Slow - traveling) <oshima@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#683483}
-
Christopher Lam authored
This CL adds the default positions of the Settings and OS Settings PWAs. Bug: 989833 Change-Id: I32a5400b87a810d4e06137c57d44ec1b0360427f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728512 Auto-Submit: calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change renames TryToShowTouchToFill To ShouldSuppressKeyboard in WebLocalFrame and WebAutofillClient. This is because Touch To Fill is a password manager feature, which Blink doesn't need to know about. ShouldSuppressKeyboard describes the actual behavior better. Bug: 957532 Change-Id: I866145d0b63bb2242ab1c575299a95aac7009e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728650Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#683481}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/367a491d5bc1..9532972a16bb git log 367a491d5bc1..9532972a16bb --date=short --no-merges --format='%ad %ae %s' 2019-08-02 briannorris@chromium.org repo_manifest: update manifest-format doc link Created with: gclient setdep -r src/third_party/chromite@9532972a16bb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6bdfda7a997b6b523f1a6ee0e4ed0f92a2c1721b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732810Reviewed-by:
-
Kenichi Ishibashi authored
blink::MemoryCache can be accessed only from the main thread. Before this CL WorkerGlobalScope used ParentExecutionContextTaskRunners to post a task to remove an item from MemoryCache. This worked because the task runners were always bound to the main thread. However, when we start a service worker on the IO thread, there would be no "parent execution context" and thus no ParentExecutionContextTaskRunners. Using task runners which are bound to the IO thread violates the assumption MemoryCache has. This CL changes to use the main thread task runner instead of ParentExecutionContextTaskRunners. Thread::GetTaskRunner() is a deprecated method but it's hard not to use because alternatives are bound to execution contexts and there is no parent execution context for service workers. Bug: 692909 Change-Id: Ieb9b97bcc06398b323c2a78d8bbc0755533580a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731832Reviewed-by:
-
Kenichi Ishibashi authored
MemoryPressureListenerRegistry is a garbage collected object and was instantiated lazily. This could be a problem when we start a service worker on the IO thread because blink::scheduler::WorkerThread tries to get the instance of the registry during worker start up. Since the IO thread runs without Oilpan and thus can't create garbage collected objects, MakeGarbageCollected() would fail when the instance hasn't been instantiated. This CL ensures the instantiation happens on the main thread. This moves the instantiation earlier than before but it wouldn't affect overall performance because it just creates a garbage collected object and instantiation eventually happens as blink loads resources. Bug: 988335 Change-Id: I3c2fa3f2be5bd1de913bd916b761548fbff4dda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732111Reviewed-by:
-
Yutaka Hirano authored
In order to deal with mojo message ordering uncertainty between WebSocketHandshakeClient and WebSocketClient, this CL has WebSocketHandleImpl::binding_as_client_ binds when OnConnectionEstablished is called. mojom.WebSocketClient.OnFailChannel is replaced with InterfacePtr::ResetWithReason because |client_| may not be available when network::WebSocket::WebSocketEventHandler::OnFailChannel is called. Bug: 989406, 967524 Change-Id: Ic14357133a85317a07271a3615a21ff3e61fe37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728917Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#683477}
-
Bartek Nowierski authored
4 consecutive bools + 1 enum + an unsigned overflow the 8-byte alignment boundary by 1. Packing these bools into a bitfield saves 8 bytes which reduces the size of TransformPaintPropertyNode from 96B to 88B on a 64-bit release build. Bug: 969531 Change-Id: I30879972bfd097162e92d79299f167dc2e57ea3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728036 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683476}
-
Nigel Tao authored
It is incorrect to cache the value of ArcAppListPrefs::Get(profile). The value returned can change over the lifetime of the profile. Also move observer clean-up from the ArcApps destructor to its KeyedService::Shutdown method, since the ArcApps keyed service depends on the AALP keyed service. This fixes the ArcAppLauncherForDefaultAppTest.* unit_tests in debug mode, when combined with --enable-features=AppServiceAsh. The tests passed in release mode, both before and after this commit. In the unit_tests, ArcAppModelBuilderRecreate::StartArc calls ArcAppListPrefsFactory::GetInstance()->RecreateServiceInstanceForTesting, which destroys the existing ArcAppListPrefs and creates a new one. Meanwhile, ArcApps code continues to follow the old pointer. In the release build, there's the (un)happy coincidence that the new AALP's pointer value is exactly the same as the old one: the memory is re-used and that 'dangling' pointer still points to a valid AALP object. In the debug build, malloc/free behavior is presumably different (the pointer value is certainly different), and the latent bug surfaces. BUG=826982 Change-Id: Ie77fb2ab8c65662d66faff8947901414d9cb1892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732110 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
-
Clark DuVall authored
These are no longer used after http://crrev.com/c/1731919 Bug: 824840 Change-Id: I7163336861c227fb7fa7aab9fe297898d92067c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731180 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#683474}
-
Marialicia Villarreal Garcia authored
This change adds back method accessibilityAttributeNames that was removed as part of a migration to NSAccessibility API. Despite being deprecated, this is still called internally by AppKit, and the need for this method was found because keyboard focus and VO focus were not in sync anymore while navigating through the browser frame. This issue is due to setAccessibilityFocused not being called because accessibilityAttributeNames is the method in charge of returning the attributes supported and one of them is NSAccessibilityFocusedAttribute. The unit tests for setAccessibilityFocused are already handled in ui\views\widget\ax_native_widget_mac_unittest.mm. Original change: http://crrev.com/c/1508580 Bug: 990014 Change-Id: I505be15afae809690c5cea7599af96a7ce6ca691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728043 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#683473}
-
Hirokazu Honda authored
TBR=xhwang@chromium.org Bug: None Test: None Change-Id: I215889e5ab8c25577c04e164a657c3b6f027a5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731638 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#683472}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3bd52c2334a0..367a491d5bc1 git log 3bd52c2334a0..367a491d5bc1 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 shaochuan@chromium.org chromite: Temporarily move betty-arcnext-pi-android-pfq to experimental Created with: gclient setdep -r src/third_party/chromite@367a491d5bc1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id13ee4344073abcb452263d6ee46f960feb3d3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732631Reviewed-by:
-
Liquan(Max) Gu authored
Currently, ImagePaintTimingDetector and TextPaintTimingDetector each has their own paint-time callback. Two callbacks are unnecessary since if they are registered from the same (animated) frame, they would get the same paint-time. Therefore, they should be combined into one callback. Combining the callbacks also creates a chance for LCPCalculator to hook to "either text records or image records have been changed", i.e., the end of the combined callback. This hook would enable us to remove the intermediate state between two callbacks, and thus fixed the out-of-sync issue in crbug.com/982307. Bug: 982307 Change-Id: Ic9bc3076d163b471d91e6414da70bd6d7af0fd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730517 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#683470}
-
Matt Giuca authored
This reverts commit b0caaa35. Reason for revert: Suspect introduces flake (https://crbug.com/990225). LayoutSubtreeRootList::RandomRoot is crashing in about 50% of builds since this landed. Original change's description: > Call PaintLayer::UpdateLayerPositionsAfterLayout only from layout roots. > > Previously, it always called it from the LayoutView, regardless of what > layout changed. > > This will be more efficient in typical cases of non-root layouts. It > may be more inefficient in the following cases > a. Two layout roots are present, of which one is an ancestor of the other > (in this case, the new code will update the overlapping layout tree > portions twice). > b. Cases when LocalFrameview::UpdateLayout recurses, due to NeedsLayout > being true after the first one. > > If we consider these cases sufficiently rare, then this CL is ok as-is. > Handling (a) and (b) is possible but is harder to implement. > > Bug: 462719,970224 > Change-Id: Ie65dc73a70bb9362dfa20ff9ad4070e3945d3c56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728717 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683409} TBR=szager@chromium.org,chrishtr@chromium.org,eae@chromium.org Change-Id: I50a9d9861dae814d0c564e072df8a1c66a9b5898 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 462719, 970224, 990225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732809Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#683469}
-
Alexey Baskakov authored
Delegate CanReparentAppTabToWindow/ReparentAppTabToWindow to WebAppUiManager since this is UI-related business. In next CLs: We will get rid of chrome/browser/extensions/bookmark_app_extension_util.cc completely. That's the last bookmark_app* prefixed file in extensions/. TBR=ortuno@chromium.org Bug: 901226 Change-Id: I1fb9658d0671d9ca9509280625911371aed95fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732670Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#683468}
-
Ethan Jimenez authored
This CL relands the following change: https://chromium-review.googlesource.com/c/chromium/src/+/1718064 Which was reverted by this other change: https://chromium-review.googlesource.com/c/chromium/src/+/1728130 Reason for revert: suspect causing content_browsertests failure on Windows bots: E.g. https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/39015 Fixing issues with `ComPtr` being incorrectly handled as return values. Original change's description: > Add trailing whitespace and punctuation to UIA Move(TextUnit_Word) > > 1. Changing the behavior of `ITextRangeProvider` methods `Move` and > `ExpandToEnclosingUnit` with `TextUnit_Word`. > > Previously we relied on both, word start and end offsets, computed > from Blink, but such approach didn't matched every AT's expectations. > > Updated logic makes use of start offsets only, this forces movement > by word to include whitespace and punctuation characters before the > next word start; the only special case being the last word, whose end > offset will be located after the last character on the document. > > 2. Removing `AXPosition`'s methods `AsLeafTextPositionBeforeCharacter` > and `AsLeafTextPositionAfterCharacter` in favor of refactoring > `AsPositionBeforeCharacter` and `AsPositionAfterCharacter`. > > This is a follow-up optimization since the former methods called > their `AsLeafTextPosition` equivalents, but reverted the result if > the position was not adjusted to another anchor. > > 3. Adding a new browser test to cover some AT's expectations. > > Rebaselining `AXPlatformNodeTextRangeProviderWin` unit and browser > tests to account for the new word movement behavior. > > Bug: 928948 > Change-Id: Iab689fde2a2ea973e86f7cdb10c1c22cf1af1704 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718064 > Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682564} Bug: 928948 Change-Id: I62022f54fb236d3ffe638b6ef17648891da4aef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731750Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c711a8649301..39dda0fe6aa0 git log c711a8649301..39dda0fe6aa0 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1ebe6014389e..1dbbc7b3e232 (5 commits) 2019-08-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-01 fmalita@chromium.org Reland: SkColorfilters::HSLAMatrix 2019-08-01 mtklein@google.com bigger channel buffers in fm_bot 2019-08-01 bsalomon@google.com Renove GrPixelConfig from GrGLGpu::uploadTexData 2019-08-01 mtklein@google.com sketch SkVMBlitter 2019-08-01 reed@google.com remove unneeded bitmapprovider abstraction 2019-08-01 mtklein@google.com Revert "let color filters tell us their alpha format" 2019-08-01 mtklein@google.com Revert "SkColorfilters::HSLAMatrix" 2019-08-01 bsalomon@google.com Make read/write/transfer pixels functions take surface color type 2019-08-01 mtklein@google.com make presubmit failures clearer 2019-08-01 robertphillips@google.com Add a means of printing out the GrBackendFormat 2019-08-01 nifong@google.com Add a kind of asset for MSKPs so the skpbench bot can read them. 2019-08-01 robertphillips@google.com Make GrGLCaps::getYUVAColorTypeFromBackendFormat also map R8 to GrColorType::kGray_8 2019-08-01 bsalomon@google.com Use GrConvertPixels in GrOpFlushState::doUpload 2019-08-01 stani@google.com Allow to rebind GL texture if AHB content has changed 2019-08-01 fmalita@chromium.org SkColorfilters::HSLAMatrix 2019-08-01 reed@google.com make bicubic decision logic shareable 2019-08-01 egdaniel@google.com Remove use of isConfigRenderable. 2019-08-01 mtklein@google.com let color filters tell us their alpha format Created with: gclient setdep -r src/third_party/skia@39dda0fe6aa0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None,chromium:b/138674291 Change-Id: Idcd7aab9fc79b8c0e6c1f479880356b0ec794363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732630Reviewed-by:
-
