Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 25 May, 2018 4 commits
    • Scott Violet's avatar
      chromeos: introduces Embedding class in ws2 · 1caf60ef
      Scott Violet authored 
      Embedding owns the embedded WindowServiceClient (child). The ClientWindow
the embedding is in owns the Embedding. This fixes a bug where destroying
the root of an embedding didn't destroy the embedded WindowServiceClient.

I will have to change this to support re-embedding, but until then I think this
makes things clearer.

BUG=837684
TEST=covered by tests

Change-Id: I9e3b1d144ec63c80b660dabf1dd50fdb6c20c568
Reviewed-on: https://chromium-review.googlesource.com/1072806
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561701}
      1caf60ef
    • Esmael El-Moslimany's avatar
      WebUI: set initial values for padding so there is a default value · 1350b7a5
      Esmael El-Moslimany authored 
      When a polyer element style is overridden and there is no explicitly set
style, all the other usages of that polymer element will erroneously
try to override the style with an undefined variable and no default.

Example: |padding-bottom: var(--cr-dialog-body_-_padding-bottom);|

This is only happens when |optimize_webui=true| is set in the build
arguments.

Bug: 846254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I010c560e80f89c0473722351dce346d481cd3113
Reviewed-on: https://chromium-review.googlesource.com/1072236Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561700}
      1350b7a5
    • Sahel Sharify's avatar
      Reland "Touchpad fling bubbling doesn't generate extra GSB." · 7c8dfc2e
      Sahel Sharify authored 
      This is a reland of 63049f46

I reverted the original cl since I missed nit comments on the newly
added test, this cl includes the changes for those comments.

Original change's description:
> Touchpad fling bubbling doesn't generate extra GSB.
>
> With browser side touchpad fling, the fling controller processes a GFS
> and schedules fling progress. On flingProgress the controller generates
> wheel events which get queued in the mouse wheel event queue(MWEQ).
>
> When we start wheel scrolling on an out of process iframe while it is
> already at its extent the wheel events get processed in the MWEQ of the
> child view but the generated gesture scroll events including the GFS get
> bubbled to the parent view. When the GFS gets processed by the parent
> view, the generated wheel events get queued in the MWEQ of the parent.
> The MWEQ will generate a GSB for the first wheel event generated from
> processing the fling since it is not aware of the GSB that is bubbled to
> this view and it causes hitting this DCHECK:
> https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc?q=render_widget_host_impl&dr=C&l=1256
>
> This cl changes the MWEQ to ask for the state of wheel scrolling from
> RWHI rather than keeping its own state, this change will be also useful
> for enabling touchpad fling boosting.
>
> Bug: 249063
> Test: SitePerProcessBrowserTest.TouchpadGestureFlingStart
> Change-Id: I0c6faa81faa7f009517393440d6e37c7e7e6a053
> Reviewed-on: https://chromium-review.googlesource.com/1064792
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561550}


TBR=kenrb@chromium.org,tdresser@chromium.org,nzolghadr@chromium.org

Bug: 249063
Change-Id: Ic146479e5d8c5531f80d9babdb4ef8adfcc8dc72
Reviewed-on: https://chromium-review.googlesource.com/1072708Reviewed-by: default avatarSahel Sharifymoghaddam <sahel@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561699}
      7c8dfc2e
    • Michael Lippautz's avatar
      [wrapper-tracing] Allow tracing wrappers from ScriptWrappable · 68d0a5f0
      Michael Lippautz authored 
      This CL duplicates SW::TraceWrappers into SW::Trace which is require to
rely solely on Trace.

Bug: chromium:841830
Change-Id: I27ef0b4590b1bb1ba26bd59308fa718a06ab6936
Reviewed-on: https://chromium-review.googlesource.com/1071028Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561698}
      68d0a5f0
  3. 24 May, 2018 36 commits