- 12 Aug, 2019 40 commits
-
-
yilkal authored
Updates chromium_strings.grd, google_chrome_strings.grd, browser_resources.grd to use "enable_supervised_users" flags. Bug: 969748 Change-Id: I43ef65083d80eafb18c580613746bb399a363fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731911 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686224}
-
Jesse Schettler authored
Add a new test to verify that the Add button of the manufacturer dialog is disabled after clicking it. Bug: 990755 Test: browser_tests --gtest_filter=OSSettingsPrintingPageTest* Change-Id: Id7cb8014595ae1a6c6abd1dd1cbd3dcbb403c79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749823Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#686223}
-
Caitlin Fischer authored
Bug: 991988 Change-Id: I08c6e5a06a09a0c52963e42e9b9f106b15d2ae9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744332 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#686222}
-
Mike Frysinger authored
The syntax for raising a custom exception with all three args is different between Python 2 & Python 3 to the point where we can't even do it inline because an incompatible version throws syntax errors during parsing. Utilize six's reraise helper for it. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I2489dfe588c4c650661ece327c5d86e8754269ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700504Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686221}
-
Peter Kotwicz authored
BUG=None Change-Id: I828b22e468bb1b7b0c0aeb7f76869b9be00aa5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750104 Auto-Submit: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686220}
-
Francois Doray authored
A developer reported a failure in the DCHECK that verifies that LocalSiteCharacteristicsDataStore::OnURLsDeleted() receives details for the origin of all deleted URLs. This CL transforms the DCHECK into a CHECK to determine whether this can happen in production. Bug: 966059 Change-Id: Ia3328ca7d832935ee906ddb5570aa3035a65c0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749248 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#686219}
-
Vlad Tsyrklevich authored
The chrome_app_unittests target was missing a dependency on //components/gwp_asan. Bug: 993092 Change-Id: I9bb082156a810487333974745a61995ef9423a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745573 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#686218}
-
François Beaufort authored
Following WebGPU spec change at https://github.com/gpuweb/gpuweb/pull/388, this CL removes some unnecessary nullables, specifically in resolveTarget from GPURenderPassColorAttachmentDescriptor. Bug: 877147 Change-Id: Ib24b76ba65c22273b2d7bfef50ef8cc22e09daad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748666 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#686217}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f815301b1ad2..913dbe6a85c5 git log f815301b1ad2..913dbe6a85c5 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-12 bsalomon@google.com Don't use color type derived from GrPixelConfig to determine proxy texture swizzle. 2019-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-12 mtklein@google.com inline helpers in SkDashPath.cpp cull_path() Created with: gclient setdep -r src/third_party/skia@913dbe6a85c5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: Ib98c6f73c382fc819270c7782331409448c09d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686216}
-
John Lee authored
This CL also removes some accessibility features as tabs are not focusable only through the keyboard, and overall accessibility is still being decided on. Bug: 989131 Change-Id: I4aae2fd35000866dca0c641ce59c93a05e191a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747732Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#686215}
-
Dave Tapuska authored
Some configurations fail to build, limits should have been included. BUG=992832 Change-Id: I894ba0543bfcef101c93259e39a31d12ae6d035c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747981 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#686214}
-
Clark DuVall authored
This is no longer used now that NavigationLoaderOnUI is default. Bug: 824840 Change-Id: I364ff25df3d32ba2b4e0265f8231619460b72b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747985Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#686213}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c90cf387b1a9..a37676d2be1c git log c90cf387b1a9..a37676d2be1c --date=short --no-merges --format='%ad %ae %s' 2019-08-12 tsepez@chromium.org Move TEXTPOS_* from cpdf_formcontrol.h to cpdf_apsettings.h Created with: gclient setdep -r src/third_party/pdfium@a37676d2be1c The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Id4a57cca2ea80f4c2c629173a806b6ebaf6edd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686212}
-
Kristyn Hamasaki authored
Disabling instead of reverting as the revert is not possible without reverting a chain of changes. https://chromium-review.googlesource.com/c/chromium/src/+/1750102 Disabling currently failing test. Bug: 993097 TBR: weili@chromium.org Change-Id: I88c176f1aa4fe64419e54b88ebb29d775a1e1574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748119Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#686211}
-
Manas Verma authored
Updating GetRealPan response to include FIDO Creation Options in order to initiate enrollment for the user into FIDO Authentication for card unmasking. Bug: 949269 Change-Id: I9041ba2ebe27668b0c8db39ef9138056044a1703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719971Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#686210}
-
Brandon Wylie authored
I expect this to have a positive impact on Feed's memory usage. Bug: 914597 Change-Id: I98b482fdbbf3f3a230902d7764cc32931c2c5784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749459 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#686209}
-
Ian Prest authored
Chrome implements its own Minimize, Maximize, and Close buttons, and the default buttons that UIA adds for all windows are therefore unnecessary. Adding the `RefuseNonClientSupport` flag to ProviderOptions prevents UIA from duplicating the window controls. Bug: 928811 Change-Id: I1341b57b97a9f5a7131394bacb75dbec9f296676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747738 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686208}
-
Peter Boström authored
This is gated by both the buildflag |enable_webui_tab_strip| and a new kWebUITabStrip feature flag. The change adds toggle button and new-tab button next to the toolbar as well. This is still rough (has no animation, shows scroll bars), but checking this in should make it easier to iterate on. There are also placeholder icons and hard-coded colors in use for now. Bug: chromium:989131 Change-Id: I5bc2a20e85c8b98ca882d536f2f7937233304de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742934 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686207}
-
Avery Musbach authored
The present CL updates a comment in the body of OverviewController::OnOverviewButtonTrayLongPressed, describing what happens when the overview button is long pressed. Change-Id: Ic2c92e53f9522d6156a5105d263ce16264f38a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749825 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#686206}
-
Taylor Bergquist authored
Bug: 958173 Change-Id: Ida39f1e8a9f10c2e8d90e99e91c0f5758c4f90d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738653 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#686205}
-
Charlene Yan authored
ExtensionsMenuItemView will be a View container to hold a horizontal extensions menu item (currently the label, pin button, and ... button). Bug: 985382 Change-Id: I28e637731e506122b797fcb25a544909defd4b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749788 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#686204}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d6186f993681..3c814957ee53 git log d6186f993681..3c814957ee53 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 ehmaldonado@chromium.org depot_tools: Run Python scripts using vpython (Part 2) Created with: gclient setdep -r src/third_party/depot_tools@3c814957ee53 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I0687fcecc7799501003da3402e03b9ad1186461d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686203}
-
Will Harris authored
BUG=993005 Change-Id: I83b905f9027c903076cd304b6176573aaf8749a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749717Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#686202}
-
Jenna Himawan authored
Bug: 990550 Change-Id: I72b8629a1b5bebe29921425036f67f3412ffadcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749443Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jenna Himawan <jhimawan@google.com> Cr-Commit-Position: refs/heads/master@{#686201}
-
Jenna Himawan authored
Bug: 990534 Change-Id: Id3ac7d55cbf19c380d02a9c13ef1eeb7d71aea2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749212 Commit-Queue: Jenna Himawan <jhimawan@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#686200}
-
Elly Fong-Jones authored
This is a re-upload of <https://chromium-review.googlesource.com/c/chromium/src/+/1728718>, which got reverted because of <https://crbug.com/990664>. This change adds a new top-level menu to the system menu, used to manipulate and select tabs in the current window. This menu contains some static items, moved from the Window menu, and then a list of entries corresponding to open tabs in the current window. Specifically, this change: 1) Adds a new class, TabMenuBridge, which binds a TabStripModel to a NSMenu; 2) Adds a new menu item to the main menu named "Tab"; 3) Creates a TabMenuBridge for any tabbed browser window in the app controller The motivation for this change was twofold: first, to allow easier access to commands that are currently only present in the tab's context menu, and second, to allow easier access to tabs in crowded tabstrips. The first purpose is well-defined and understood but the second is very much experimental. Testing: Build, run, and enjoy the new Tab menu :). There are some unit tests in TabMenuBridgeTest.* as well. Future work: * Renaming the static items to better fit their new context. This was not done here to avoid breaking existing user key equivalents, which identify items by their full name. * Exploring other orderings of tabs in this menu. * Adding other tab actions to this menu, like "Bookmark" or possibly page actions. * Adding a search bar to search within tab titles/origins? * Adding key equivalents for the static actions (which will resolve the actual accessibility bug this commit is for) Bug: 818261 Change-Id: I61987f7a64907a3d6ff32a06c0c67b1c2601e055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728718 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#683682} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736976 Cr-Commit-Position: refs/heads/master@{#686199}
-
Patrick Monette authored
Bug: 993029 Change-Id: I63969aab07a22023a4df7c7b1064d68421b8cbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729397 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#686198}
-
Karan Bhatia authored
The chrome-extension-resource scheme was added in https://chromiumcodereview.appspot.com/9909019/ but was never used. The code for it was eventually removed in https://codereview.chromium.org/2574763003. This CL removes any remaining references to it. Behavior changes: - Any extensions using the scheme in their CSP will get an install warning as the token will be recognised as an unsafe token. Note we don't show install warnings for packaged extensions. - The default CSP for apps and extensions now excludes the scheme. However this should not be an issue since the scheme isn't a valid scheme and can't be used. BUG=674272 Change-Id: I4494e901d147627adebc62c59ce0e021876786a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719333Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686197}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3b3fe83788c5..9e14a19bb82f git log 3b3fe83788c5..9e14a19bb82f --date=short --no-merges --format='%ad %ae %s' 2019-08-12 lujc@google.com EVENT trace to print GLenum as string reland 2019-08-12 m.maiya@samsung.com Vulkan: Enable a few integer state query tests in dEQP Created with: gclient setdep -r src/third_party/angle@9e14a19bb82f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: Ie1fe498363c54da7aac8a4441c3657d040913636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749607Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686196}
-
Tommy Li authored
Disable SystemNetworkContextManager.MaxConnectionsPerProxyBrowsertest Flaking since it was landed. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests?limit=200 TBR=niarci@microsoft.com Bug: 993059 Change-Id: Ibd624f36f712ef0a314532ae2bef4bd8406285b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747984Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#686195}
-
Xiaohan Wang authored
Currently in NewSessionCdmResultPromise::reject(), we missed the |key_system_uma_prefix_| when reporting UMA. As a result, all failure cases are reported to a wrong UMA name. For the record, the bug was first introduced in: https://codereview.chromium.org/2691673002/ This CL is manually tested as follows: 1. Update ClearKeyCdm::CreateSessionAndGenerateRequest() to unconditionally reject the promise with system code 111. 2. Build browser_test and run the following: out/Debug/browser_tests --gtest_filter=MSE_ExternalClearKey*Playback_VideoOnly_MP4_VP9/0 -v=1 where -v=1 will print out all histograms at the end. 3. Made sure we have the following: Histogram: Media.EME.Unknown.GenerateRequest recorded 1 samples, mean = 2.0 (flags = 0x41) 0 ... 2 ------------------------------------------O (1 = 100.0%) {0.0%} 3 ... Histogram: Media.EME.Unknown.GenerateRequest.SystemCode recorded 1 samples (flags = 0x41) 111 -----------------------------------------------O (1 = 100.0%) Bug: 690722 Test: See above Change-Id: I81a81a7e8a0e650494209dc1c7dd0e6d950d8353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747045 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#686194}
-
Min Qin authored
Sandboxed iframes has an opaque origin, so the DownloadPermissionRequest popup and the download omnibox decoration cannot show the URL of the download correctly. Also querying the content setting won't work either. This CL change the default setting for all opaque URLs to be blocked, so that only one download can be performed. And it switches DownloadRequestLimiter to use url::Origin instead of GURL to handle opaque origins. Omnibox decoration and DownloadPermissionRequest popup won't be shown for opaque origins. BUG=991617 Change-Id: I72599c9fa35bbe92637ef6a7165564d4584581b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746957Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686193}
-
Xiaohui Chen authored
Extended a couple assistant feature flags which are still in use. Bug: None Test: locally build and test Change-Id: Ic614695e8c9973431666db778600c9e0e74386a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748077Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#686192}
-
Sammie Quon authored
The new scrolling may be a fairly heavy operation, add a test so we can catch regressions and optimize it later on. Test: interactive_ui_tests OverviewScrollTest.Basic Bug: 978112 Change-Id: Ia77b1548ae8ce5dd95a222db2c8aef4bee3c468c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742118 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#686191}
-
Bo Liu authored
Add a boolean uma that's recorded each draw. Bug: 956709 Change-Id: Iaf6b2027562e0ab75602a8f476f18689cfec32f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745428Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686190}
-
Pavol Marko authored
This CL contains two changes that are necessary to enable extension-scoped policy-provided certificates in the Chrome OS sign-in profile. Change 1: Move the responsibility of deciding whether and which policy-provided certificates should be used to the PolicyCertService. Allow a PolicyCertService on the Chrome OS sign-in profile, but without profile-wide certificate. Change 2: Make PolicyCertService receive a StoragePartition path when retrieving certificates from it, so it can customize certificates based on StoragePartition. Currently it doesn't care about the StoragePartition path, but this will be used in a follow-up CL. Bug: 939344 Test: browser_tests --gtest_filter=*PolicyProvidedTrustAnchors* Change-Id: I9c7ed89aa30fa48d921f09f5a0fd56313ebb03ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689190Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#686189}
-
Suzy Li authored
Bug: n/a Change-Id: Iff18d329e97129219e45f1387bc05f992a2983ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744543 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#686188}
-
Anastasia Helfinstein authored
Previously, Switch Access used the setSwitchAccessKeys function to specify which keycodes were selected as switches by the user. Now that we have migrated to the new Settings page, that information no longer needs to be communicated between the extension and the chrome/ code. Bug: 958081 Change-Id: I749fd7e5fcb99fa567805c211f4f130cfbaf0706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729566Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#686187}
-
Derek Schuff authored
Bug: 918374 Change-Id: I1087df5974f531c8ecb2ae3aa3cd45578d977eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747373 Auto-Submit: Derek Schuff <dschuff@chromium.org> Commit-Queue: Sam Clegg <sbc@chromium.org> Reviewed-by:
Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#686186}
-
James Cook authored
The compiler can count our arguments for us. go/totw/164 This also revealed an unused mock method for exo::KeyboardDelegate. Bug: none Test: ash_unittests Change-Id: I8b864c2766986c8df5b0fd74f9ac2eb28de3def7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749708Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#686185}
-