GitLab

appropriate) to use it. Hopefully this will help isolate why tests are
failing on bot.

BUG=none
TEST=none; test only change.

Review URL: http://codereview.chromium.org/3117030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57064 0039d316-1c4b-4281-b951-d872f2087c98

This is to avoid a deadlock on Windows. It will be replaced by a handler
on the I/O thread in a subsequent patch.

BUG=38475
TEST=None

Review URL: http://codereview.chromium.org/3142029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests --gtest_filer=TemplateURL*.*

Review URL: http://codereview.chromium.org/3161038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57062 0039d316-1c4b-4281-b951-d872f2087c98

Stuart fixed this in http://codereview.chromium.org/2147002 and I regressed it in http://codereview.chromium.org/3010054

Note that the reduced testcase on the bug is still broken. Since it's broken in Safari too, that's a WebKit problem.

BUG=52914,51748
TEST=See bug

Review URL: http://codereview.chromium.org/3125033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:5762, chromium-os:5761
TEST=Enter wrong password on Chrome OS login screen.

Review URL: http://codereview.chromium.org/3201003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57060 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

http://codereview.chromium.org/3107030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57059 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52593,51748
TEST=Right-click a youtube video. Should get context menu.

Review URL: http://codereview.chromium.org/3117035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57058 0039d316-1c4b-4281-b951-d872f2087c98

NO CODE CHANGE.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57057 0039d316-1c4b-4281-b951-d872f2087c98

no longer needed.  (I thought we had a warning for that?)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3199013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57056 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57055 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3122034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:2265
TEST=Make and run out/Debug/browser_tests

Review URL: http://codereview.chromium.org/3130044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57053 0039d316-1c4b-4281-b951-d872f2087c98

Location provider using the MAC address of a router the user is connected to via Ethernet to find a position fix.
BUG=NONE
TEST=Unit test

Review URL: http://codereview.chromium.org/3153031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57052 0039d316-1c4b-4281-b951-d872f2087c98

encoded strings.

BUG=none
TEST=Added new unit tests for each.

Review URL: http://codereview.chromium.org/3133028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57051 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig
TEST=none
BUG=53076
Review URL: http://codereview.chromium.org/3142031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53073
TEST=see list

Review URL: http://codereview.chromium.org/3130046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57049 0039d316-1c4b-4281-b951-d872f2087c98

(Changed review name, because the solution has changed)

BUG=53041
TEST=On a mac, install a browser action and a page action, right click on each icon, select "Inspect Popup".

Review URL: http://codereview.chromium.org/3176021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

TBR=dumi

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

TBR=dumi

Review URL: http://codereview.chromium.org/3132034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57045 0039d316-1c4b-4281-b951-d872f2087c98

- making the include path lower case in renderer_webidbransaction_impl.cc,
- adding a newline at the end of indexed_db_dispatcher.cc
- fixing the initialization order of member variables in
indexed_db_callbacks.h

Revert "Revert 56862 - Add transaction coordinator. Allow idle transactions to be aborted when their parent JS context finishes executing."

This reverts commit 6b25a433481c9127f8dbcbadc7f0685dc643d6de.

Review URL: http://codereview.chromium.org/3163028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57042 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52418
TEST=unit tests

Review URL: http://codereview.chromium.org/3156040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57038 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3180017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57037 0039d316-1c4b-4281-b951-d872f2087c98

Provider provides its registered observers with device orientation data
by finding and polling a DataFetcher on a background thread.

BUG=44654
TEST=unit_tests --gtest_filter="DeviceOrientationProviderTest.*"

Review URL: http://codereview.chromium.org/3136008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

TBR=dumi

Review URL: http://codereview.chromium.org/3200005

TBR=rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/3164033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

TBR=dumi

Review URL: http://codereview.chromium.org/3200005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57034 0039d316-1c4b-4281-b951-d872f2087c98

Original CL: http://codereview.chromium.org/3191007

Initial change that allows to disable bookmarks in Chrome for Chrome OS
(BWSI mode). Added disable-bookmarks flag and disabled some UI elements.

BUG=chromium-os:4302
TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and
verify that the corresponding UI is disabled. Verify that BWSI mode runs
with this flag.

Review URL: http://codereview.chromium.org/3156035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57033 0039d316-1c4b-4281-b951-d872f2087c98

ChromeThread::IO will be used to cancel URLFetcher request and
clean up URLRequestContextGetter.

BUG=52562,52826
TEST=valgrind passes

Review URL: http://codereview.chromium.org/3176028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57032 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

TBR=dumi

Review URL: http://codereview.chromium.org/3111025

TBR=rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/3108039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51055
TEST=no bug_51055 suppressions used in memory test:net

Review URL: http://codereview.chromium.org/3175029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

TBR=dumi

Review URL: http://codereview.chromium.org/3111025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=46153
TEST=manual

Patch by morrita@google
Original code review: http://codereview.chromium.org/3139007/show

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57025 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr
BUG=53044
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3134025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57024 0039d316-1c4b-4281-b951-d872f2087c98

The fix uncovers a few things.  Previously, when we had an unclaimed
push stream, we'd leave it as an "active" stream, even if the EOF had
already been received on that stream.  I changed it so that the push
stream is removed from the active stream as soon as it is inactive,
but it remains on the unclaimed_pushed_streams list.  This seems more
correct.

The hardest part of the test was getting the test to verify the fix.
To verify the fix, I modified the Push tests so that we leave the
session open (e.g. terminate the list of reads with an ERR_IO_PENDING
rather than an EOF so that it sits open), which gives us the opportunity
to check if there are active streams left on the session when we 
completed the test.  If so, then we'll pop an error.

BUG=52898
TEST=Updated existing tests.


Review URL: http://codereview.chromium.org/3108038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57023 0039d316-1c4b-4281-b951-d872f2087c98

It's a bit hardcoded (port 443, NPN/SPDY2), but it is just for
testing purposes.

To use this mode, run chrome with:
   chrome.exe --use-spdy=npn,force-alt-protocols

BUG=none
TEST=http_alternate_protocols_unittest.cc

Review URL: http://codereview.chromium.org/3195015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57022 0039d316-1c4b-4281-b951-d872f2087c98

- This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16
  instead of a wstring.
- This entailed changing the base class, ComboboxModel, and shaving a herd of
  yaks.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3159031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=good spellers are slightly happier

Review URL: http://codereview.chromium.org/3143037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57020 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3061044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57019 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57017 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57015 0039d316-1c4b-4281-b951-d872f2087c98