GitLab

Views are owned by their parent, so having an additional scoped_ptr to them in the associated item/model is confusing and misleading.

BUG=124269
TEST=Test status area


Review URL: http://codereview.chromium.org/10269017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123219
TEST=existing tests suffice


Review URL: http://codereview.chromium.org/10257026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134709 0039d316-1c4b-4281-b951-d872f2087c98

SessionService. This comes from crash data. Only way I could see this
happening is if between the time we request the data from the backend
and the time we get it the service is destroyed.

BUG=95125
TEST=none
R=marja@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10265010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134708 0039d316-1c4b-4281-b951-d872f2087c98

Change LauncherContextMenu::ToggleAutoHideMenu to just return the toggled auto
hide behavior and make the behavior change go through ChromeLauncherDelegate,
which would persist the new behavior.

Also removed no longer in use kAlwaysAutoHideShelf pref.

BUG=124083
TEST=Verify fix for issue 124083.

Review URL: https://chromiumcodereview.appspot.com/10273012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125725
TEST=NONE


Review URL: http://codereview.chromium.org/10262032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134706 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10270002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134705 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to show a nicer placeholder when loading a plug-in fails then the one coming from WebKit.

BUG=123580
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134620
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=134630

Review URL: http://codereview.chromium.org/10093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134704 0039d316-1c4b-4281-b951-d872f2087c98

TBR=enal@chromium.org
BUG=125728
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10271031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134703 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134702 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134701 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vsevik

Review URL: https://chromiumcodereview.appspot.com/10274028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134700 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org
BUG=125724

Review URL: https://chromiumcodereview.appspot.com/10271030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134699 0039d316-1c4b-4281-b951-d872f2087c98

Since r134147 (https://chromiumcodereview.appspot.com/10213009), startup prefs migration is more complex and may trigger the protector for users on M19.


BUG=122936
TEST=ProtectedPrefsWatcherTest.*


Review URL: http://codereview.chromium.org/10170046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134698 0039d316-1c4b-4281-b951-d872f2087c98

TBR=enal@chromium.org
BUG=125723

Review URL: https://chromiumcodereview.appspot.com/10269027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134697 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134696 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10274011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134695 0039d316-1c4b-4281-b951-d872f2087c98

They are currently in their minimal form. The proper dependencies will be added
afterward. This makes the whole process simpler.

R=rogerta@chromium.org
BUG=98834
TEST=GYP_DEFINES="$GYP_DEFINES tests_run=check" build/gyp_chromium \
     ninja -C out/Release browser_tests_run ui_tests_run

Review URL: https://chromiumcodereview.appspot.com/10262028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29242
TEST=Checkbox to disable drive should be visible in the downloads section of advanced settings. Selecting this should disable drive in the filemanager (requires restart in M20).

Review URL: http://codereview.chromium.org/10270019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134692 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111275
TEST=Open a new window while hovering over a Flash instance that hides the cursor; the cursor should re-appear as soon as the mouse moves.


Review URL: http://codereview.chromium.org/10169003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134691 0039d316-1c4b-4281-b951-d872f2087c98

The pattern get() ? true : false isn't widely used and after this patch has no
more occurrences across chromium/src/ codebase.

R=tommi@chromium.org


Review URL: http://codereview.chromium.org/10262014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134690 0039d316-1c4b-4281-b951-d872f2087c98

Revert r134670 "Revert 134667 "Revert r134508 "Revert 134507, broke the main builders:""

This CL's going to get in at whatever cost. I moved more optional files to be untracked.

The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py.

Manual edits:
- Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck.
- Removed testserver.log and unit_tests.log.
- Added copyright.
- Removed *.db-journal files.

TBR=rogerta@chromium.org
BUG=98636
TEST=

Review URL: https://chromiumcodereview.appspot.com/10263018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134689 0039d316-1c4b-4281-b951-d872f2087c98

It broke multiple browser_tests like
ExtensionWebstorePrivateApiTest.InstallAccepted and
ExtensionNoConfirmWebstorePrivateApiTest.InstallTheme on multiple OSes.

TBR=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10274026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134688 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134685 0039d316-1c4b-4281-b951-d872f2087c98

Add commas between array elements and remove extra spaces at end.

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/10264022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134683 0039d316-1c4b-4281-b951-d872f2087c98

This CL sets the image scale factor for data packs.

This will be used by the DOM UI code to look up encoded PNG data for images with a specific scale factor.

BUG=114311
TEST=


Review URL: http://codereview.chromium.org/10151025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134682 0039d316-1c4b-4281-b951-d872f2087c98

In preparation for making FindEntryByPathAsync() private.
The new function is not used in production code yet.

BUG=chromium-os:30251
TEST=add unit tests

Review URL: https://chromiumcodereview.appspot.com/10271026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134681 0039d316-1c4b-4281-b951-d872f2087c98

Instead use GetFileInfoByPathAsync(). This is in preparation for
making FindEntryByPathAsync() private.

BUG=chromium-os:30251
TEST=gdata in the file manager works as before (ex. pinned files are shown as pinned)

Review URL: https://chromiumcodereview.appspot.com/10271016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134680 0039d316-1c4b-4281-b951-d872f2087c98

These functions will be used in an upcoming patch, when
we extract file info from GDataFileProto/GDataDirectoryProto
(i.e. in some places, we need PlatFormFileInfo).

BUG=chromium-os:30251
TEST=GDataFileSystemTest.CachedFeedLoading

Review URL: https://chromiumcodereview.appspot.com/10270027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/10148001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10255020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134677 0039d316-1c4b-4281-b951-d872f2087c98

Will stop open windows from staying around while other unit tests run.

TBR=jhawkins@chromium.org
BUG=122152
TEST=


Review URL: http://codereview.chromium.org/10048005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134676 0039d316-1c4b-4281-b951-d872f2087c98

but not yet played). Underlying code expects per-logical-stream pending bytes,
while all mixer gets when called for more data is pending bytes per combined stream.

Fix is to keep track of
* amount of data in every buffer
* buffers for every logical stream
and manually calculate per-logical-stream pending bytes.

That is last CL in initial audio mixer implementation, after it go through mixer
should be ready for full testing.

Review URL: http://codereview.chromium.org/10154007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134675 0039d316-1c4b-4281-b951-d872f2087c98

JSON schema compiler now supports having strings as types.

Similar to http://crbug.com/122075

BUG=124771
TEST=cpp_type_generator_test.py


Review URL: http://codereview.chromium.org/10206034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134674 0039d316-1c4b-4281-b951-d872f2087c98

for extensions that have a homepage url

BUG=105858
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10103015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123685
TEST=


Review URL: http://codereview.chromium.org/10261019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110212
TEST=Will be testable via subsequent API-consumer CL.


Review URL: http://codereview.chromium.org/10262019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134671 0039d316-1c4b-4281-b951-d872f2087c98

it broke the linux x64 bulder.

> Revert r134607 "Revert r134508 "Revert 134507, broke the main builders:""

> Overall, this reapplies r134507.

> The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py.

> Manual edits:
> - Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck.
> - Removed testserver.log and unit_tests.log.
> - Added copyright.
> - Removed *.db-journal files.

> TBR=rogerta@chromium.org
> BUG=98636
> TEST=


> Review URL: http://codereview.chromium.org/10269019

TBR=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10264027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134670 0039d316-1c4b-4281-b951-d872f2087c98

Revert r134607 "Revert r134508 "Revert 134507, broke the main builders:""

Overall, this reapplies r134507.

The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py.

Manual edits:
- Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck.
- Removed testserver.log and unit_tests.log.
- Added copyright.
- Removed *.db-journal files.

TBR=rogerta@chromium.org
BUG=98636
TEST=


Review URL: http://codereview.chromium.org/10269019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134667 0039d316-1c4b-4281-b951-d872f2087c98

Added a new automation hook ExecuteJavascriptInOOBEWebUI() to permit executing abitrary javascript prior to login on chromeos.

Change-Id: If96d94bb22ac5bd25fa4ab1e3a4c3ba52ea47370

BUG=chromium-os:29466,chromium-os:20709
TEST=functional/chromeos_login.py (testExecuteJavascriptInOOBEWebUI)

Review URL: http://codereview.chromium.org/10257015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125568
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10274022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134665 0039d316-1c4b-4281-b951-d872f2087c98