- 14 May, 2018 40 commits
-
-
Charlie Andrews authored
This reverts commit b8b2dcd2. Reason for revert: Problem has since been fixed. Original change's description: > Disable failing wasm stories > > NOTRY=true > TBR=nednguyen@chromium.org > CC=bradnelson@chromium.org > > Bug: 840935 > Change-Id: I99ec329b99822a800d70da48dcea4a085fe71e56 > Reviewed-on: https://chromium-review.googlesource.com/1050577 > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556924} TBR=nednguyen@google.com,charliea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOTRY=true TBR=nednguyen@chromium.org Bug: 840935 Change-Id: If27b317e19ae8bfa876b16338102a181868c69f4 Reviewed-on: https://chromium-review.googlesource.com/1057365 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#558297}
-
Vasilii Sukhanov authored
This is a preparation CL for removing some code from PasswordAutofillAgent. Most of the tests in the file do not test the real behavior. We fill the username/password using JavaScript and it's a different code path from typing them manually. The tests changed here are necessary to update. Let's land them first and observe if it introduces some flakiness before proceeding. Bug: 842643 Change-Id: I4dd593c829c25e8f45ad816f6a3ddd3b941d76af Reviewed-on: https://chromium-review.googlesource.com/1054675 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#558296}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b06a1eb4e579..5140f9a8e424 $ git log b06a1eb4e..5140f9a8e --date=short --no-merges --format='%ad %ae %s' 2018-05-11 robertphillips Minor refactoring to image filters Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I6c3a1d580b1e2b0b4cac269489d0e7b081928f34 Reviewed-on: https://chromium-review.googlesource.com/1057428 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558295}
-
Charlie Harrison authored
Now that tab-unders can be controlled via the popup setting, admins can simply use the popup enterprise policy to also control tab-unders. Since tab-under blocking was never actually launched in versions <M68, this CL also drops policy support for them completely. Bug: 842306 Change-Id: Ie7b7d41b2caeaf1e26bc931777a25ec113c03dc4 Reviewed-on: https://chromium-review.googlesource.com/1056170Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#558294}
-
Biao She authored
PlatformUiInputDelegate is used by PlatformUiElement and ContentInputDelegate is used by ContentElement. ContentInputDelegate is a PlatformUiInputDelegate. It has extra responsiblity to handle focus and text input in web content. PlatformUiInputDelegate generates/sends WebInputEvent to platform UI (i.e. view on Android platform). Bug: 838925 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I18c90b656e5e0f341666f4eb22d5a5ac2252c2ef Reviewed-on: https://chromium-review.googlesource.com/1050809 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#558293}
-
Alexis Hetu authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bf58b98..2a0def7 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iba8c17d2cbaf8524c726f74765f0ba8de01ccf92 Reviewed-on: https://chromium-review.googlesource.com/1057408Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558292}
-
Rayan Kanso authored
The dependencies in the build rule use the name of the idl file containing the dictionary defintion. For the cases where ImplementedAs is used, the build rule will fail since the generated file matches the ImplementedAs value. This CL changes the file name of the generated dictionary implementation to match the idl name rather than the ImplementedAs name. Bug: 839847 Change-Id: Ic5d9dfc82ba90188e26f1206465eb790dc8a193b Reviewed-on: https://chromium-review.googlesource.com/1044217 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#558291}
-
Patrick Monette authored
This reverts commit 381d19a1. Reason for revert: Crashes on canary Original change's description: > Fix a startup performance issue with the ModuleDatabase feature > > The ModuleEventSink interface was bound on the UI thread, which caused > cross-process IPC to retrieve information about a loaded module in the > renderer process. > > A new sequence with background priority is instead used so that it > doesn't impact startup. > > Bug: 832286 > Change-Id: I5ab50bc45386c9a1ddb2888f80293d78bd768a88 > Reviewed-on: https://chromium-review.googlesource.com/1037935 > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558010} TBR=sky@chromium.org,chrisha@chromium.org,pmonette@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 832286, 842506 Change-Id: I95befdad542c085e83e2ba5e292ae43f0545430e Reviewed-on: https://chromium-review.googlesource.com/1056687 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#558290}
-
Michael Lippautz authored
Remove template parameter for observed objects, making it impossible to cast an marking worklist item to that type. This was a source of UBSAN errors in the tests. Bug: chromium:757440 Change-Id: I35843b1bcfd81c404e840790bb00a7911e2bc3aa Reviewed-on: https://chromium-review.googlesource.com/1057234Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558289}
-
Noel Gordon authored
This test fails on bots. Mark is DISABLED directly, rather than by the DISABLE_SLOW_FILESAPP_TESTS macro used to control DEBUG/MSAN/ASAN (the CopyBetweenWindows test is the only remaining test using this macro). Add comment (conjecture about why this test is failing) and retain the reference to issue 500966. Tbr: fukino No-Presubmit: true Bug: 836254 Change-Id: I79aaac465b0fdd255a10d251cd474940c6692eb5 Reviewed-on: https://chromium-review.googlesource.com/1057548Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558288}
-
Randy Rossi authored
Part of ongoing effort to get automation tree working in chromecast. PS 1 is baseline for copied files. Modifications on top of that in PS >= 2. Duplicated code will be refactored into common /extensions later. Bug: b/73383411 Test: None Change-Id: I33c032e1b8d0a78b14797b26e021e0b612f0b5ec Reviewed-on: https://chromium-review.googlesource.com/1044278 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558287}
-
Patrick Meenan authored
This fixes the logic that updates style and layout to not consider in-body CSS as render-blocking when the CSSInBodyDoesNotBlockPaintEnabled experiment is enabled. It also fixes the logic to also look at pending imports (which are always render-blocking wether in body or head) and treat them the same as render-blocking stylesheets. It also removes the logic that would ignore pending stylesheets deep in the style engine when HaveScriptBlockingStylesheetsLoaded was called. It wasn't necessary because IsRenderingReady already checks for the ignore flag and led to a lot of inconsistent logic. This is an update of the unsbmitted CL from last year: https://codereview.chromium.org/2823873002/ BUG=707747 Change-Id: Id88b945334d8d029a654e2619004b077b47055ab Reviewed-on: https://chromium-review.googlesource.com/1053878Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Patrick Meenan <pmeenan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558286}
-
Chris Nardi authored
https://github.com/w3c/csswg-drafts/pull/2666 and https://github.com/w3c/csswg-drafts/pull/2671 updated the spec so that elapsedTime as a member of AnimationEvent and TransitionEvent is specified as a double instead of a float. Remove the TODOs as our implementation is now correct. Change-Id: I1c7abf14765fdbd46e37b4f8c506fed574cecdd0 Reviewed-on: https://chromium-review.googlesource.com/1056787Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558285}
-
Takuto Ikuta authored
Add warning suppression flag to where it is necessary instead. Bug: 428099 Change-Id: Ief28527a0e5dc3c7281b5857e3ce9dec5b5bf921 Reviewed-on: https://chromium-review.googlesource.com/1029290Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#558284}
-
chrome://sync-internalsMarc Treib authored
This updates a few strings on chrome://sync-internals that were misleading: "Backend Initialization" becomes "Engine State". "Backend" was renamed to "Engine" long ago, and the value in the "everything is fine" state is "Started", which was confusing when applied to "Initialization". "Syncing" becomes "Sync Cycle Ongoing", because "Syncing: false" was similarly misleading. Bug: none Change-Id: I1e0cddc9b4a74277d67cf69aba83b7695bb8fa07 Reviewed-on: https://chromium-review.googlesource.com/1054671Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#558283}
-
jonross authored
Updating Viz testing filters based on new Mac failures. TBR=fsamuel@chromium.org TEST=viz_browser_tests, viz_content_browsertests Bug: 76018 Change-Id: I8ad81d565ad57a92ec92d0bd8482f5e8205bc81f Reviewed-on: https://chromium-review.googlesource.com/1057352Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#558282}
-
Ian Vollick authored
They are large and no longer necessary with new environment colors. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I37cfd71a712d0eafe2d08e592e728d04e47e1558 Reviewed-on: https://chromium-review.googlesource.com/1057387Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#558281}
-
gogerald authored
Test: 1, open 'https://rsolomakhin.github.io/pr/bob/' 2, clock 'Buy' 3, choose 'Just-in-time Bobpay' 4, click 'Pay' 5, click 'Navigate to mixed content page', which opens 'https://mixed.badssl.com' 6, Payment request should abort. Bug: 828431 Change-Id: I38a1725b6265b6450b0cfa88d8234eed2949bb2c Reviewed-on: https://chromium-review.googlesource.com/1056012 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#558280}
-
Jan Wilken Doerrie authored
This change turns BluetoothAdapter::InitCallback into a OnceClosure and updates the corresponding subclasses. Bug: 834319 Change-Id: I3ac35b38919320a30c332fbd156eb787c203db9f Reviewed-on: https://chromium-review.googlesource.com/1050125 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#558279}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8f2f785df9c9..195c52dc7098 $ git log 8f2f785df..195c52dc7 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 perezju [soundwave] Fetch timeseries data in parallel! Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I8e8ae17b20bc299e1eb82b0f4dfc81945510ba56 Reviewed-on: https://chromium-review.googlesource.com/1057429 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558278}
-
nednguyen authored
NOTRY=true Bug: 841864 Change-Id: Ia4e6e910bf19975aa96e0f9374ebded995a4a61d Reviewed-on: https://chromium-review.googlesource.com/1057349Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#558277}
-
Biao She authored
Previously, we use a heuristic to estimate the time a fence finished. We now have the ability to get the status change time from a fence. This CL removed the heuristic and use the status change time. It is more accurate. Bug: NONE Change-Id: Iff2f45aa84078301bf3029b31b689936f41d4f4f Reviewed-on: https://chromium-review.googlesource.com/1053788 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#558276}
-
Ulan Degenbaev authored
This patch adds a new Blink feature flag - BloatedRendererDetection. When the flag is enabled, Blink uses the new V8 API to install a callback that is invoked when V8's heap reaches the heap limit. The callback notifies the BloatedRendererDetector controller that in future will dispatch a message to the browser process for reloading the tab and showing an infobar explaining that the tab ran out of memory. The patch also adds a new UMA histograms - "BloatedRenderer.V8.NearV8HeapLimitHandling" Bug: 835806 Change-Id: I2f1bcefaaf8a553517de9a1bb2dc9d084f4eca4b Reviewed-on: https://chromium-review.googlesource.com/1024033 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Jan Wilken Doerrie authored
This change makes PublicKeyCredentialDescriptor credential_type to be of enum type CredentialType instead of std::string, increasing type-safety. Bug: 780078 Change-Id: I570e698ecb9b13d7cc988eb52293a65f466c8115 Reviewed-on: https://chromium-review.googlesource.com/1041951 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#558274}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 836410 Change-Id: Iefcfd45fd251b0931d958b6b9d77a69d42930b1e Reviewed-on: https://chromium-review.googlesource.com/1002793 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the FindMatchRects function to mojo. Mojoifying doc: https://goo.gl/JenyGm Previous CL: Add FindInPage mojo interface with ClearActiveFindMatch crrev.com/c/1027393 Future CLs: Mojoify other find-in-page functions Bug: 819919 Change-Id: I63dd966ac8008460dce796e2c2405df353416fd0 Reviewed-on: https://chromium-review.googlesource.com/1049770 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558272}
-
David Bokan authored
TBR=wangxianzhu@chromium.org Bug: 841567 Change-Id: Ia47fb7c9a988f60f0f5a378338e560b21a26fe38 Reviewed-on: https://chromium-review.googlesource.com/1057348Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558271}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e8221d09..162ca8aa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I79604db2a26aeb4180d1242d80c2680cb57846a5 Reviewed-on: https://chromium-review.googlesource.com/1056810Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558270}
-
Noel Gordon authored
Drop the "On" prefixing of the volume type (like all the other tests). Tbr: fukino No-Presubmit: true Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If891b0d4fc5baf1445ca892f6490fe20b44d4d67 Reviewed-on: https://chromium-review.googlesource.com/1057208Reviewed-by:
-
Henrik Boström authored
This reverts commit 3b6de800. Reason for revert: Win10 Tests x64 are failing after this CL, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/540, 541, 542, 543. Speculative revert based based on CL changing "Quartc" and the failing tests are: QuartcSessionTest.ClientRejection QuartcSessionTest.GetStats QuartcSessionTest.CloseConnection QuartcSessionTest.WriterGivesPacketNumberToTransport QuartcSessionTest.CloseQuartcStream QuartcSessionTest.BundleWrites QuartcSessionTest.ServerRejection QuartcSessionTest.StreamConnection QuartcSessionTest.StopBundlingOnIncomingData QuartcSessionTest.CancelQuartcStream Original change's description: > Remove the extra layers of abstraction around QuicClock and QuicAlarm in Quartc. > > QuicClock is already part of the QUIC platform API. It's an abstraction for a > clock. We don't gain anything by creating another clock abstraction and > wrapping that up in a QuicClock. > > QuicAlarms are currently implemented using a task runner interface. There's no > reason to change the abstraction from alarms to a task runner. > > Eliminating the task runner interface and using the QUIC alarm abstraction > directly makes it easier to use the Quartc QUIC wrappers in a setting with an > existing alarm implementation (eg. chromium). This might be useful in > implementing RTCQuicStream. > > Quartc itself would like to use at least one alarm (see b/78013844). > Implementing QuicAlarms directly in Quartc makes this easy. > > Merge internal change: 195335187 > > Change-Id: I2a0a60044e03c1d1893714ebe13492932ed87baf > Reviewed-on: https://chromium-review.googlesource.com/1055938 > Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558191} TBR=rch@chromium.org,zhongyi@chromium.org Change-Id: Ic819dc26330a12cfbba26f192aee207926ec3130 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1057470Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#558268}
-
Jan Wilken Doerrie authored
This change implements talking to the UWP APIs to obtain an instance of the system's default adapter. Furthermore, it introduces logic to obtain the adapter's address and name. Lastly, it also provides necessary test framework to integrate with the existing BluetoothAdapter unittests. Bug: 507419, 821766 Change-Id: I1235d441fd8708e6280d1eecbed45afdc6c42a11 Reviewed-on: https://chromium-review.googlesource.com/973620 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Takayoshi Kochi authored
Found some media control elements accidentally using V0 shadow root instead of User-Agent shadow root, and this fixes the cases. To avoid further misuses, I'll rename the API in the following CL https://chromium-review.googlesource.com/c/chromium/src/+/1057047 Bug: 787717, 776656 Change-Id: I45274ccb399ae57ea7207402323f49efd2188d9c Reviewed-on: https://chromium-review.googlesource.com/1056939Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558266}
-
Tsuyoshi Horo authored
Bug: 680046 Change-Id: Idbd670dea3fb228e1ce8ed7a53001f7d0d422de4 Reviewed-on: https://chromium-review.googlesource.com/1046485Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#558265}
-
Harald Alvestrand authored
This enables the "sdpSemantic" element of RTCConfiguration, which allows to create an RTCPeerConnection that uses the Unified Plan SDP format. Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/B1Yr62txfwQ Bug: 799030 Change-Id: Ifef01e4d3b65f013a49b17693da0ed6f8364e16d Reviewed-on: https://chromium-review.googlesource.com/1056528Reviewed-by:
-
Simon Zünd authored
This CL adds a counter for sorting non-packed JSArrays where Object.prototype was modified, or the prototype of the instance differs from Array.prototype. This is the Chromium side of the change. The V8-side CL: https://crrev.com/c/1051650 R=jgruber@chromium.org Bug: v8:7382 Change-Id: I46f0963b8b79380fe5c5defa50dba517df77b72c Reviewed-on: https://chromium-review.googlesource.com/1051651Reviewed-by:
-
arthursonzogni authored
This test is a bit flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=headless_browsertests&tests=FocusOfHeadlessWebContents_IsIndependent Furthermore, I am working on https://crbug.com/831155. It causes the frame to commit a navigation more quickly. As a result the frame may stop loading sooner. It causes this test to become even flakier. Why this test is flaky? It waits for the main frame to stop loading by calling WaitForLoad(). Then it waits for the main frame to gain focus by calling WaitForFocus(). In reality, it may gain focus before it stops loading. Since WaitForFocus() doesn't check whether or not the main frame is already focused before waiting, it may wait forever. The CL makes the tests wait for both event to happen, no matter the order. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/1026993 Bug: 831155 Change-Id: Id9002b3ee2a06ef17d670858688d28959f334e03 Reviewed-on: https://chromium-review.googlesource.com/1053777 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#558262}
-
Bence Béky authored
Bug: 831536 Change-Id: I4d0d859eafdcc89457e5d2224ddc42908e5b41d8 Reviewed-on: https://chromium-review.googlesource.com/1055949 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#558261}
-
Adam Rice authored
The Great Blink Move resulted in a header file named "web_socket_handshake_throttle.h". Since "WebSocket" is one word, it should be "websocket_handshake_throttle.h". Rename it. BUG=834596 TBR=boliu@chromium.org TBR=kinuko@chromium.org TBR=jialiul@chromium.org TBR=thestig@chromium.org Change-Id: Ifc154d6942b691b70b4d5e7366bebc1bfa3c4218 Reviewed-on: https://chromium-review.googlesource.com/1056892 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Olivier Robin authored
On iOS10, when dismissing the keyboard, there is a short time when the scroll view containing the suggestion is offset. This cause the omnibox to not be unfocused automatically because of the test in https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm?l=516 Fix the issue by always unfocus the omnibox when displaying QR scanner. Bug: 842072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie94884a18335753e919c0cd974c26e4a53abac8b Reviewed-on: https://chromium-review.googlesource.com/1055394Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558259}
-
Marc Treib authored
https://crrev.com/c/996072 removed the files from the build, but failed to actually delete them. Bug: 828890 Change-Id: Ic3adda0fcf5bf051bf7e427018d4732ea2c98c07 Reviewed-on: https://chromium-review.googlesource.com/1057108Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#558258}
-
