- 02 Oct, 2019 40 commits
-
-
Anthony Vallee-Dubois authored
This reverts commit d22c818c. Reason for revert: Internal assets rolled out, this should not cause any more breakages. Original change's description: > Revert "Reland "Google Translate branding on desktop translate bubble"" > > This reverts commit 59a03dc3. > > Reason for revert: Causing desktop perf build failures > > Original change's description: > > Reland "Google Translate branding on desktop translate bubble" > > > > Change-Id: Id2972c13c2da888a4c7f2974b933ae190fdfe2fd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756147 > > Reviewed-by: Alexandre Frechette <frechette@chromium.org> > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Commit-Queue: anthonyvd <anthonyvd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#687664} > > TBR=oshima@chromium.org,anthonyvd@chromium.org,frechette@chromium.org,crouleau@chromium.org > > Bug: 994787 > > Change-Id: I799fb9416fa57c47c52364314b0f016cea529742 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758510 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687697} TBR=oshima@chromium.org,anthonyvd@chromium.org,johnchen@chromium.org,frechette@chromium.org Bug: 994787 Change-Id: Ibdc33d9549c7b079dd65283e53ee72a5de3f27cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835198Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#702064}
-
Marialicia Villarreal Garcia authored
When navigating in the frame, the "first responder" that has focus is the view. So when trying to move from frame to web content, the first responder does not get updated, which makes VO not respond to the focus events being fired within web content. This fix is so that when a focus event is fired for the web content, set it as the first responder if it has not been set yet. This only gets called by screen readers when navigating with scan mode (arrow keys). This change has been verified in Mac with VO and in Windows with NVDA and Narrator (IA2 and UIA). AccessibilityActionBrowserTest.FocusAction already tests the main action of BrowserAccessibilityManager::SetFocus. Bug: 990014 Change-Id: Iaec036a14743c77b26f68ef10b0515aa7034cdf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809943Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702063}
-
Manu Cornet authored
This applies the same change made in CL 1814222 (for the _visibility_ chain of events), to the _target visibility_ chain of events and observers. This fixes tests that are failing with pending CL 1832634. Bug: 1006013 Change-Id: I6992f16d79393b16d3813090ec3d69090335fe14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834653 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#702062}
-
Kush Sinha authored
Chrome OS Account Manager has been turned on by default on ToT, and has been launched via Finch for some time now. Clean up its flag's usages in Active Directory credentials manager. TBR=rsorokin@chromium.org Bug: 1009960 Change-Id: Id81addd05162e2bd911b555ab47f24248a9312e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832212Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#702061}
-
Sammie Quon authored
Replace GetTransformForRect with gfx::TransformBetweenRects. Test: manual Bug: none Change-Id: I0e699c1caa28a8c8decca18b579070cc90aa5d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834643 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#702060}
-
Ioana Pandele authored
Bug: 986317 Change-Id: I9d799cd24551f13bc58eac91c843d2da19aa7851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832267Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#702059}
-
Boris Sazonov authored
Use for TouchToFill the same triggering logic that is used for regular suggestions. Bug: 1010233 Change-Id: I111d4eac4ce94dd94b86097b6b6c98e08875e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834230 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#702058}
-
Sigurdur Asgeirsson authored
This breaks up some of the dependencies in preparation for a move to //components. Bug: 953031 Change-Id: I7955635a348d051c73178536caa8bd31b840645c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835199 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#702057}
-
Adithya Srinivasan authored
Wait for adoption to complete before ending test. Bug: 990717 Change-Id: I0c4a969f89893c31872bd0fe31f66fb63397adc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834270 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702056}
-
John Budorick authored
This is a reland of crrev.com/c/1797004 Bug: 922145 Change-Id: Ic388afd4cd4303c25057ca77b38cea39d965d3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827248Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#702055}
-
Yun Liu authored
asm 7.0 is needed for Robolectric using jdk 10 or 11 https://github.com/robolectric/robolectric/issues/4085 Bug: 965286, 693079 Change-Id: Ic0979741c8279601befc7508d7d055c9eb395f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832931Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#702054}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf0a9a628490..a1ea0a96f490 git log cf0a9a628490..a1ea0a96f490 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 chinmaygarde@google.com Don't build the minimal Metal app when building for Flutter. Created with: gclient setdep -r src/third_party/skia@a1ea0a96f490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I4f1edca819bc50a2fa74ad8bedea8395d2772667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702053}
-
Mikel Astiz authored
There's no point in remembering very old cache GUIDs since features anyway filter for recent devices, so let's implement a garbage-collection logic for the cache GUIDs stored in prefs. Bug: 989340 Change-Id: I1b1f84e3026471f8f687caa54922e2ea43bafaba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827435Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#702052}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I4252236d9cbd4452026111eaa4fbe91c5e30c890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830013Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702051}
-
Yusuke Sato authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9488a16bbe3d..9b9ccf7ac88a $ git log 9488a16bb..9b9ccf7ac --date=short --no-merges --format='%ad %ae %s' 2019-09-27 yusukes system_api: Add num_cores_disabled to StartArcMiniContainerRequest 2019-09-23 nverne vm_host_tools, system_api: Add top level methods for container upgrade. 2019-09-23 lepton vm_tools: arcvm: Add support for Android fstab. 2019-09-25 ejcaruso power: add method for checking the presence of a color ALS 2019-09-06 smbarber system_api: permission_broker: add methods for loopback TCP lockdown 2019-09-24 smbarber system_api: permission_broker: remove unused VPN methods 2019-09-25 ejcaruso power: add AmbientColorTemperatureChanged signal Created with: roll-dep src/third_party/cros_system_api BUG=b:139752657 TEST=ninja Change-Id: Ie549b477b5cedf526c13c7c62c9406e5545900be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834874 Auto-Submit: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#702050}
-
Willie Koomson authored
This change addresses a comment in the previous ThrottleService CL, fixing the class definition by making the destructor virtual. Bug: 997397 Test: Run ThrottleService unit test Change-Id: Ied2f28781075f4a766aee5243698a93acb5a122b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834568Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#702049}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dbfa96532ab0..4cb8240aaec0 git log dbfa96532ab0..4cb8240aaec0 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 dberris@chromium.org Refactor all Tasks/Evaluators to new module Created with: gclient setdep -r src/third_party/catapult@4cb8240aaec0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:988912 Change-Id: Ia2276849b921a53f9a3d99a59afe102b7e98c5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702048}
-
Chris Lu authored
Whenever there are multiple non-fullscreen badges, a blue dot will show on the top right corner of the overflow badge if the menu has not been opened yet. Once it is opened, the blue dot will disappear. The dot reappears if a new badge is added. A new BadgeConsumer method markDisplayedBadgeAsRead() is added to allow for the mediator to tell the view controller when to hide/show the dot. Screenshot: https://drive.google.com/open?id=13TMm0r1mtm_tz55hiMWkr77R0rMEijPp Bug: 976901 Change-Id: I220cb865e117b19520c37cea2287757b46803df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832157 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702047}
-
Alex Clarke authored
This is needed for implementing PostTaskHere and base::CurrentThread traits. In a follow on patch SimpleTaskExecutor will be added for blink threads. Bug: 835323 Change-Id: Ice25d2a93fc7a6a10c0a4d4e43aa82a97462e3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832280 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#702046}
-
Fernando Serboncini authored
TBR=khushalsagar Bug: 995235 Change-Id: Icd9cc8165836cf97a852869e296599f887ed9a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835197 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#702045}
-
Lily Chen authored
This fixes a slight inaccuracy in the tooltip string describing why a cookie was blocked for being SameSite=None but not Secure. Bug: 856777 Change-Id: I529eaa67380045fa86fd421664c2824638b851c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832522Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#702044}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3dc289df..f45ddb9b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I68f290577ebefc754542902c48fb526d7107229d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835812Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702043}
-
Kush Sinha authored
Chrome OS Account Manager has been launched to Stable channel and enabled on ToT. Cleanup the flag in Chrome signin code. Bug: 1009960 Test: unit_tests --gtest_filter="*ChromeSigninHelperTest*" Change-Id: I012a6967f890febba66e1ce8e19764b46e357aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833609 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#702042}
-
Brett Kilty authored
It is possible an AudioOutputDevice is created and waiting for authorization when destruction happens. Add a stop call to ensure it gets cleaned up. Bug: b/141012708 Test: Local build, before/after manual testing. Change-Id: If454095f2d3d44d20b84a9135151248372b0a574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832727Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#702041}
-
Allen Bauer authored
Change-Id: I93162b75b817fdf8488b33009e13775da3a890df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825620 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#702040}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1e470360678b..3ad1e2151d99 git log 1e470360678b..3ad1e2151d99 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 lalitm@google.com Merge "trace_processor: add benchmark for resize of bitvector" 2019-10-02 lalitm@google.com Merge "trace_processor: add benchmark for sparsevector Get calls" Created with: gclient setdep -r src/third_party/perfetto@3ad1e2151d99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I038e5dd52eac5d6a35455c700824320616040d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702039}
-
David Van Cleve authored
Following some earlier Onion Soup refactoring, blink::PrivacyPreferences has no usage---only a couple scary comments in renderer_preferences.mojom warning to keep fields "in sync" with PrivacyPreferences. This change deletes the dead PrivacyPreferences code and the scary comments. R=shimazu Bug: 869748 Change-Id: If95f5da0fe40ec6507d34b8985b8c13f5685f3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833707 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#702038}
-
Stephen McGruer authored
This test was assuming that the iframe load event could not fire during appendChild, which it does on Chrome. To fix this, setup the promise before calling appendChild, but only await on it afterwards. Bug: None Change-Id: Ie5ebdd7cec0fe0c276621033afaa8e8a5699dad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833902Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#702037}
-
chrome://flagsJeffrey Chen authored
This reverts commit 3f622b5a. Reason for revert: This was an improper fix. Proper fix is here: https://chromium-review.googlesource.com/c/chromium/src/+/1835274 Original change's description: > Fix chrome://flags search box placeholder visibility in dark mode > > Default placeholder text color in input boxes was changed to a color with > transparency, which may cause placeholder text to be unreadable by default > if the input box background is a dark color. This change adds explicit > styling to the placeholder color. > > Bug: 1001957 > Change-Id: I7b24ab1e01a96cc5b7caa0f22ade8ab712951fe9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799997 > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Jeffrey Chen <jeffreyca16@gmail.com> > Cr-Commit-Position: refs/heads/master@{#696060} TBR=asvitkine@chromium.org,blundell@chromium.org,jeffreyca16@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1001957 Change-Id: Ia470faa1c7193dbdb2643348d7c8b421e2c1b416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835276Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#702036}
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The conversion also required converting unit tests to use the new JNI mocking approach provided by JniMocker. Also removed a couple of unused methods. Bug: 929661 Change-Id: Ic34608693e7c48313512c8ef7e48943023de2af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833078Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#702035}
-
Harald Alvestrand authored
While waiting for "connected" state on PC2, PC1 may sometimes have time to transit to "completed" state. This CL accepts both event sequences. Due to the bug on not completing, this will only happen in plan B. Delete the mac-specific expectations files. Bug: 997201 Change-Id: I7aab5566c7868990d840bda9afc16516cf147425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834225 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702034}
-
Maksim Moskvitin authored
Old implementation of GetData() encrypted keystore_decryptor_token with current default encryption key, which is wrong for backward compatible keystore Nigori, since it uses non-keystore key as the default encryption key. Now we always use most recent keystore key to encrypt keystore_decryptor_token. The old behavior shouldn't cause any issues, since it should be impossible to reach GetData() in commit codepath, while Nigori is in backward compatible keystore mode. But it's still better to fix, to avoid data corruption in case it overlaps with other bugs and to not violate invariants. Bug: 922900 Change-Id: Ic2455b5e1875cb18c4a9278598999dc47025bc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834081Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#702033}
-
James Cook authored
The user is likely to try re-entering their passphrase, so ensure focus stays in the input field. Convert the Print Preview PIN settings element to use the same approach to focus, so callers aren't depending on internal implementation details of cr-input. Bug: 805829 Test: See bug. sign in to account with sync passphrase, enter incorrect phrase, focus returns to input field. Tested with both Chrome OS and Linux. Change-Id: I012f5b5368654c8b0f36b66f9fd07124d394c9a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832632Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#702032}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8c3bb48f5870..f03259ad7205 git log 8c3bb48f5870..f03259ad7205 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 courtneygo@google.com Vulkan: lineloop support for DrawElementsIndirect 2019-10-02 ianelliott@google.com Vulkan: Divide 3188 KHR failures into 2 known root causes + cleanup. Created with: gclient setdep -r src/third_party/angle@f03259ad7205 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I7d40b569c62dfcb74a3a32704a6d51f0849b8ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834975Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702031}
-
Eric Seckler authored
To aid debugging data loss issues. Bug: 914092, 1008424 Change-Id: I06b91acd892970b6bba251c1893247debf61b16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835577Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#702030}
-
Alex Chau authored
- device_last_updated is unused after https://crrev.com/c/1742158, but still causing prefs::kSharingSyncedDevices to update on every reboot Bug: 1006153 Change-Id: I62e86791a58e8c5ca63ae9127895ecb4b813b1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835578 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#702029}
-
Henrik Boström authored
See bug. TBR=sky@chromium.org NOTRY=True Bug: 1010182 Change-Id: I7017fbb995398a4a1d43caa7acac78c72fd00612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835368Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702028}
-
Antonio Gomes authored
The use seems pointless now that the class uses Mojo for IPC. This CL prepares to Onion souping this class. BUG=787254 R=guidou@chromium.org Change-Id: If36a51b8ff724d6a70aecc884f296e594d3fd2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834362 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#702027}
-
Peter Collingbourne authored
We can allow generate_jni_registration targets to appear in multiple toolchains by moving the default_toolchain dependency into the template. This will eventually be needed to build bundles that include HWASAN splits, which will employ three toolchains (32-bit, 64-bit and HWASAN) instead of the usual two. Bug: 916828 Change-Id: I4edb22263d6feb432034be41f2cfea5cafafc60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832713 Auto-Submit: Peter Collingbourne <pcc@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702026}
-
Arthur Hemery authored
Filter content_unittests crashing on android_bfcache_debug fyi bot. Bug: 1007276 Change-Id: I7510c423da49fc9821e9910b3e2b51b63017edc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835366Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#702025}
-