- 17 Jul, 2017 40 commits
-
-
Nico Weber authored
This reverts commit 95ebf5a5. Reason for revert: Weekend is over, and the tot bots are red while this is in (https://crbug.com/727447) Original change's description: > Test changing default Windows compiler to VS2017 > > Doing another VS2017 test over the week end now with the newly packaged > VS 2017 Update 3 Preview 4 (was Preview 2 last time). > > This CL is currently purely for testing purposes and will be reverted by > the end of the weekend. > > R=dpranke@chromium.org > BUG=683729 > > Change-Id: Ie5c2e92b789b1dcbd51d4e0028230b5b72ce9eb9 > Reviewed-on: https://chromium-review.googlesource.com/572500 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486999} TBR=dpranke@chromium.org,brucedawson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 683729 Change-Id: I95eba007031776caacf6595485ecc47d131def45 Reviewed-on: https://chromium-review.googlesource.com/574434Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#487129}
-
xiaohuic authored
BUG=b:35624617 TEST=build and flash locally, saw the new animation Review-Url: https://codereview.chromium.org/2972923002 Cr-Commit-Position: refs/heads/master@{#487128}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/f768baf129fc..185312303814 $ git log f768baf12..185312303 --date=short --no-merges --format='%ad %ae %s' 2017-07-14 npm Simplify CJBig2_Context::huffman_assign_code Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ifce70100befc5ba275a7347dfb2fa84ec2b8d0a4 Reviewed-on: https://chromium-review.googlesource.com/574671 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487127}
-
Alexander Timin authored
Make renderer scheduler aware of a completed task. This will enable us to record per-task metrics. R=alexclarke@chromium.org BUG=702318 Change-Id: Iaff9ca2c8f8398847c854dfc569db90176cdb7c6 Reviewed-on: https://chromium-review.googlesource.com/574538Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487126}
-
Steven Bennetts authored
This updates the Settings layout to match the new UX design. (New images will be introduced in a followup, behind a flag) Bug: 730031 Change-Id: I023e58aca969eb2aaa9ccbf5f7ad4a787c5c3fff Reviewed-on: https://chromium-review.googlesource.com/571309 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487125}
-
Owen Min authored
Bug: 642059 Change-Id: I249936e2a03a47f1533ce0e3fea040680a32f4f3 Reviewed-on: https://chromium-review.googlesource.com/568797Reviewed-by:
-
dougt authored
One side effect of this is that we will begin collecting data on API usage from views (on the APIs we've migrated to platform node). BUG=703369 Review-Url: https://codereview.chromium.org/2981023002 Cr-Commit-Position: refs/heads/master@{#487123}
-
Daniel Bratell authored
ElementVisibilityObserverTest, HTMLMediaElementEventListenersTest and VideoPainterTest all use a local StubLocalFrameClient class for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes. R=fs@opera.com Change-Id: I47c7088486456e22ca776419a836f4e5d18be39c Reviewed-on: https://chromium-review.googlesource.com/574605Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#487122}
-
Tommy C. Li authored
Adding match_in_subdomain and match_after_host to support Omnibox UI experiments. We have UI experiments that elide parts of the subdomain and the path, query, and ref. These shouldn't be elided if they are part of the match to the user-typed terms. This CL has no immediate effect, but adds the match_in_subdomain and match_after_host fields to be later integrated into the Omnibox UI experiments. Bug: 732582 Change-Id: I870d0192eabeae17c79f842bb51928646a3c504e Reviewed-on: https://chromium-review.googlesource.com/568636Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487121}
-
Matthew Jones authored
Previously, omnibox suggestions could be scrolled down, but when scrolling back up, the bottom sheet would intercept the scroll and defocus the omnibox. This change adds a special case to the bottom sheet event handler. If the suggestions are showing and scrolled any amount, the sheet will not take the scroll event (unless it is in the toolbar area). This allows the suggestions to be freely scrolled and only when they reach the top can the sheet be pulled down. BUG=735319 Change-Id: Icaf373d573b8c2380452d2b5e272aa1ed578f4ca Reviewed-on: https://chromium-review.googlesource.com/562667Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#487120}
-
Morten Stenshorne authored
Moved the rarely used Blend() overload to a new file ColorBlend.h, since it requires heavy stuff to be included. This change caused Image.h to lose its inclusion of FloatSize.h. Removed the default value from a FloatSize parameter. Change-Id: I9b32e425c86b237b4c3a69ec53e601faa713f56f Reviewed-on: https://chromium-review.googlesource.com/553139 Commit-Queue: Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487119}
-
Mounir Lamouri authored
With all the media controls code moved the modules, there is no need to cast from the MediaControls interface to the its modules' implementation. The few remaining static_cast<> are from code calling the GetMediaControls() method defined on the HTMLMediaElement. Bug: 662761 Change-Id: Ic72baca68f1c54d6117ea47efdf9a808b3d02aea Reviewed-on: https://chromium-review.googlesource.com/571820Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#487118}
-
Hidehiko Abe authored
This CL migrates ArcImeService. BUG=672829 TEST=Ran try. Change-Id: I88a3e2bcf2e5ffa4ba2cb4a96a9c1dbcf26ab0ec Reviewed-on: https://chromium-review.googlesource.com/572470 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#487117}
-
Ian Vollick authored
This should let us confirm our URL behavior on NTP and friends. It also provides a convenient place to do more testing of native UI in VR. Bug: 738583 Change-Id: I983016bdcef62ab83e0265929e7b00230a1a661f Reviewed-on: https://chromium-review.googlesource.com/571948 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#487116}
-
Fady Samuel authored
SurfaceIds are large and so they should always be passed by const-ref. Bug: none Change-Id: I0836c43fe782ac925a070e650a9a1680afa6a2d8 Reviewed-on: https://chromium-review.googlesource.com/574649Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487115}
-
Daniel Bratell authored
It is fairly common to have a help struct with test data and a fair portion of the code call that struct TestCase and put it in a fairly global namespace. In jumbo builds those structs will collide so this patch renames them to more specific names such as MediaQuerySetTestCase or SizesCalcTestCase. R=fs@opera.com Change-Id: Ic02ef5062782a0ec3862ad3bffdc462574ca8a61 Reviewed-on: https://chromium-review.googlesource.com/574600Reviewed-by:
-
Miriam Gershenson authored
This fixes the flake. BUG=740207 Change-Id: I68fd807c8bb9effc1c0e9e15e744146c4b1f15c0 Reviewed-on: https://chromium-review.googlesource.com/574571Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#487113}
-
Matthew Jones authored
JNI method registration is now automatic. This change removes manual registration methods in android/compositor. BUG=740208 Change-Id: I18ac4a41b60fe0c347eeedd379b370affc826a38 Reviewed-on: https://chromium-review.googlesource.com/563826 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#487112}
-
Bruce Dawson authored
This reverts commit 95ebf5a5. Reason for revert: Testing is done - VS 2017 canary should appear? Original change's description: > Test changing default Windows compiler to VS2017 > > Doing another VS2017 test over the week end now with the newly packaged > VS 2017 Update 3 Preview 4 (was Preview 2 last time). > > This CL is currently purely for testing purposes and will be reverted by > the end of the weekend. > > R=dpranke@chromium.org > BUG=683729 > > Change-Id: Ie5c2e92b789b1dcbd51d4e0028230b5b72ce9eb9 > Reviewed-on: https://chromium-review.googlesource.com/572500 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486999} TBR=dpranke@chromium.org,brucedawson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 683729 Change-Id: I65044b790dd7415e380381a47d204a838c7bd837 Reviewed-on: https://chromium-review.googlesource.com/573623Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487111}
-
Koji Ishii authored
When elements wraps, 'line-height: normal' should take used fonts of each line into account, but it was talking used fonts of the element instead. This patch implements this case using the ShapeResult from ShapingLineBreaker. This patch also fixes a case where ShapeResult was not set. BUG=636993 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idf11e7b4676ec0639aa3ffa94890619502064070 Reviewed-on: https://chromium-review.googlesource.com/572603Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#487110}
-
Vaclav Brozek authored
The password settings EG tests currently try to enable saving passwords in PrefService. This is not necesary, because saving passwords is enabled by default (see PasswordManager::RegisterProfilePrefs). It is also harmful, because it: (1) Won't catch if the default setting being "enabled" regresses, or some other tests start failing to clean-up. (2) Increases the complexity of the code. Therefore, this CL removes the code which enables the password setting in the passwords settings EG tests. Bug: 744058 Change-Id: I315935319cbaacb871ba6214b832c04902afffa9 Reviewed-on: https://chromium-review.googlesource.com/572903Reviewed-by: -
Ned Nguyen authored
Bug: 730036 Change-Id: Id7e081e62853b7497e7c6e6c43aac3063bf4dd67 Reviewed-on: https://chromium-review.googlesource.com/574456Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#487108}
-
Alexandr Ilin authored
This CL adds an implementation for PreconnectManager class together with tests. PreconnectManager is responsible for preresolving and preconnecting to origins based on the input list of URLs. Other changes: - Modification of argument type of methods content::{Preconnect,Preresolve}Url from context::ResourceContext* to net::URLRequestContextGetter*. - Adding missing LoadingPredictor::Shutdown() call in unittests + DCHECK that Shutdown() was actually called. Bug: 699080 Change-Id: I5c6a303e5d22c9027da59b266a7537194b286c0b Reviewed-on: https://chromium-review.googlesource.com/567189 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487107}
-
Dirk Pranke authored
This adds sdefresne@ to //tools/gn/OWNERS, and also redundantly adds dpranke@ (even though he's in //tools/OWNERS) to make it clearer that people other than brettw@ can review things. R=brettw@chromium.org, sdefresne@chromium.org Change-Id: I4cbbf8b2382e452312c38feff3843f6888651d5d Reviewed-on: https://chromium-review.googlesource.com/570352Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/e3e9628ecf86..263cef7b5f4b $ git log e3e9628ec..263cef7b5 --date=short --no-merges --format='%ad %ae %s' 2017-07-17 mtklein quote $windk to make copy-and-paste easy 2017-07-17 reed runtime check for in-range colortypes Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I74508cbbe98fd344797f5efea2f98d94d9d4f2c2 Reviewed-on: https://chromium-review.googlesource.com/574627Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487105}
-
Ian Vollick authored
The change in https://chromium-review.googlesource.com/567384 did not have exactly the same behaviour as the change in https://codereview.chromium.org/2944453002. This CL moves the content move suppression as per the previous CL and introduces a testing framework for the UiInputManager. Bug: 741020, 743014 Change-Id: Idd8fb0a1c6fb3f74c24dc555b1a72e0c7c3bc611 Reviewed-on: https://chromium-review.googlesource.com/573100 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
-
Dirk Pranke authored
Bug: Change-Id: I5c9448c739e21c05177b12d9d86a6b84561968df Reviewed-on: https://chromium-review.googlesource.com/572432Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#487103}
-
Devlin Cronin authored
IPC messages related to extension bindings (such as API method calls or event listener changes) sent by the renderer differ depending on if it's a call for a main thread context or a service worker context. The call sites differ based the context type as well as whether or not native bindings are enabled. This makes these messages confusing, and causes duplicate logic. Introduce an IPCMessageSender class to handle sending the IPC messages to the browser. There are two flavors of IPCMessageSender - one for the main thread, and one for the worker thread. This message sender can be used from both the native bindings implementation as well as the js implementation, allowing us to abstract out more of the details. In this first patch, introduce the IPCMessageSender class (in its two flavors) and use it for API method request dispatching. This allows us to perform a couple of cleanups: - We get rid of the SendRequestIPC method we curried into the NativeExtensionBindingsSystem, and - We get rid of the ServiceWorkerRequestSender (instead of subclassing the RequestSender, we can pass in the IPCMessageSender, which can be either for the main thread or a worker thread). Bug: 653596 Change-Id: I406aba07945f6da4b7a8ab0b9d1788aa21385f96 Reviewed-on: https://chromium-review.googlesource.com/570947Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487102}
-
Mohamad Ahmadi authored
- Correctly validates and deduplicates the URL-based payment methods according to the specs: https://www.w3.org/TR/payment-method-id/#dfn-validate-a-url-based-payment-method-identifier - Also captures the canonical text of the URL instead. Bug: 602666 Change-Id: I3ba0a8684be1e2e4f769ca551f9cbbf82e3eed36 Reviewed-on: https://chromium-review.googlesource.com/572853 Commit-Queue: mahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#487101}
-
Tao Bai authored
- Add flag to indicate whether secure context is required in autofill_agent. - Set flag for WebView autofill. BUG=741809 Change-Id: Ibd3e896cfc96f0498fb47a2fb59cc52be6a25feb Reviewed-on: https://chromium-review.googlesource.com/568406Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Selim Gurun <sgurun@chromium.org> Cr-Commit-Position: refs/heads/master@{#487100}
-
Peter Kotwicz authored
BUG=None Change-Id: I640ee75a03a6b9bce6a5200b50b2d3baad47e482 Reviewed-on: https://chromium-review.googlesource.com/574568Reviewed-by:
-
Tommi authored
BUG=689520 Change-Id: Ib34ee776f40c25b4d4306d54a7bd50756107e13c Reviewed-on: https://chromium-review.googlesource.com/570998 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487098}
-
Yash Malik authored
The transient security warnings would show when WebVR mode was set but before the first WebVR frame which meant that the warnings would show on top of the splash screen. Bug: 743196 Change-Id: I15d5e77b5f853e3d3654ff187c7dcb08327a5bbf Reviewed-on: https://chromium-review.googlesource.com/572283Reviewed-by:
-
Yash Malik authored
Bug: 740259 Change-Id: Ida1bcb3796359b09bed88143f339fae3c00edda1 Reviewed-on: https://chromium-review.googlesource.com/571946Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#487096}
-
Eric Seckler authored
Bug: 696439 Change-Id: Ib57bd3c95ce734d8a26c798f43fbfa94fcf3a67a Reviewed-on: https://chromium-review.googlesource.com/574531 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
Ran Ji authored
Apk size reduces 2kb compare with previous. Bug: 736039 Change-Id: I4fe73fda4e9771cf34b830c3df16e3bca9a468c8 Reviewed-on: https://chromium-review.googlesource.com/570515Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
This CL migrates ArcNetHostImpl. BUG=672829 TEST=Ran try. Change-Id: I4236b93a52b45b4e0ef34fe0fc72ceb124aac063 Reviewed-on: https://chromium-review.googlesource.com/572671Reviewed-by:
-
Leonard Grey authored
Looks like dladdr is quite slow on macOS[1]. Previously, we were calling it on every frame when walking the stack, which led to sampling tasks taking longer than the sampling interval. Because of this, a full burst of samples took longer than the actual exercise of most browser tests, but continued activity on the sampling task runner kept the browser alive on each test. This change caches the address range of modules, and uses this to look up the module for a given IP, only falling back to dladdr on miss. On my machine, this is roughly a 50% improvement (sample individual test goes from 3.3s to 1.8s, whole suite is hard to judge because of how long it takes, but it's quite a bit faster.) Hopefully, this will allow us to turn browser tests back on. [1] Possible reason: https://bugzilla.mozilla.org/show_bug.cgi?id=996802 Bug: 531673 Change-Id: Iad069b0f715c5c7d3b630e9caabf3a8275ef5494 Reviewed-on: https://chromium-review.googlesource.com/571277 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487092}
-
Daniel Bratell authored
Both DocumentTest and HTMLFormControlTest uses a local MockValidationTestClient class for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then they will collide. This patch gives the classes unique prefixes. R=fs@opera.com Change-Id: If1f2d22fca4c5f7b3ad662f6ae746cef4baf48c3 Reviewed-on: https://chromium-review.googlesource.com/574174 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Daniel Bratell authored
LocalFrameViewTest, HTMLVideoElementPersistentTest and PaintLayerScrollableTests all use a local MockChromeClient class for testing. That is normally no big deal but in jumbo builds they can be compiled in the same translation unit and then the classes will collide. This patch gives the classes unique prefixes. R=fs@opera.com Change-Id: Ibd6c9d17e1e8dfbe42cbb254344e52a81ce48788 Reviewed-on: https://chromium-review.googlesource.com/574176 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
