- 03 Oct, 2018 40 commits
-
-
Robert Liao authored
No code checks for this feature or experiment anymore. BUG=876090 Change-Id: I3b190857043ea067e28842458d2343a08c9d3920 Reviewed-on: https://chromium-review.googlesource.com/c/1255893Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#596353}
-
Adam Klein authored
WebAssembly has been enabled by default for a long while now. Bug: 642912, v8:8015 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I50fdf1a15f5183e91fdafa5cf921aa33493a9a7c Reviewed-on: https://chromium-review.googlesource.com/c/1239212 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#596352}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/devtools. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=caseq@chromium.org, nasko@chromium.org Bug: 890902 Change-Id: I20c6bbcc7bab10107f7557d1e5f6cffe0c0d0d94 Reviewed-on: https://chromium-review.googlesource.com/c/1257887Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596351}
-
Tom Anderson authored
BUG=737995,881371 R=pkasting Change-Id: Icc068573b4b10e618ee9bce39cc6970b8b077152 Reviewed-on: https://chromium-review.googlesource.com/c/1258252 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#596350}
-
Olivier Robin authored
Bug: 881364 Change-Id: I6cef5aa5a8acc32bc797c3abbef0869a2f094e66 Reviewed-on: https://chromium-review.googlesource.com/c/1259782 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596349}
-
Tommy Martino authored
When initially adding the footer functionality to the dropdown, the possibility that the footer would have a greater width than the rest of the dropdown was not considered. This CL updates the width calculation in the base level dropdown class. Screenshots: https://docs.google.com/presentation/d/168Uk8_itrZTvf5RfsmCmpkFUebMJo2h61bBZBYQ70i8/edit?usp=sharing Bug: 874077 Change-Id: I08051ac7302f476ee82ac5e077e49c4cdd00ef88 Reviewed-on: https://chromium-review.googlesource.com/c/1258051Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#596348}
-
Nasko Oskov authored
This CL borrows code and layout from chrome://inspect to allow us to have multiple ways to view internals of the process model. Subsequent CLs will fill in the actual data on those extra panes. Bug: 850087 Change-Id: Ia2891804dd61346e86c44c4aca32daf57302aed4 Reviewed-on: https://chromium-review.googlesource.com/c/1255599 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596347}
-
Alexey Kozyatinskiy authored
On browser side we suspend message dispatching during provisional load, so it is not possible to resume if pause happens. R=dgozman@chromium.org Bug: chromium:812091 Change-Id: Id9f7015febfb5ec868af2266aa8e3ca76eb7dd3d Reviewed-on: https://chromium-review.googlesource.com/c/1252802Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596346}
-
Theresa authored
Once the simplified NTP is enabled for everyone, the ContentSuggestionsScrollToLoad flag will be the only thing controlling whether users have scroll-to-load behavior. We're not ready to roll out scroll-to-load, so default disabling it for now. BUG=865216 Change-Id: I55bb1fe63ee34adee2d40513c0c1c5296b3b83a7 Reviewed-on: https://chromium-review.googlesource.com/c/1259474Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#596345}
-
Xiyuan Xia authored
User adding screen does not wait for user switching animation with Window Service (crbug.com/875111). But we are still observing the animation and the screen is dismissed when the animation ends. This could cause the user adding screen being dismissed unexpectedly as shown in the single process mash browser tests. The CL fixes the issue by not observing the animation in such case. Bug: 891383 Change-Id: I21d8735d517f7cbd8a17c2902dd73d9f05e282cc Reviewed-on: https://chromium-review.googlesource.com/c/1259296 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#596344}
-
Quan Nguyen authored
Full handling of authentication response as well as enrollment will arrive in later CLs. Bug: 890912 Change-Id: I9c55403462494d3c188b8ba07fc2d210b2a97a9e Reviewed-on: https://chromium-review.googlesource.com/c/1255023 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#596343}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6af3aa854956..684313d6a319 git log 6af3aa854956..684313d6a319 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 oprypin@webrtc.org gclient setdep doesn't need to update_depot_tools 2018-10-03 abenner@google.com Add non --full support to python git cl format Created with: gclient setdep -r src/third_party/depot_tools@684313d6a319 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:836566,chromium:846432 TBR=agable@chromium.org Change-Id: I7686bb5d7f4d16aa8badf940b3b9f6bc104f4ee6 Reviewed-on: https://chromium-review.googlesource.com/c/1259489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596342}
-
Etienne Pierre-doray authored
Main issue: TaskTraits constructor is not robust; any signature is part of the overload set, even if it may not compile. Because of that, it may not possible to hold TaskTrait in a tuple (depending on implementation). Fix: Expose a single constructor that checks if all traits are valid, or if an extension can accept all traits. Caveat: An extension has to redefine base TaskTrait::ValidTraits as valid (through inheritance). This CL also simplifies querying traits thanks to C++14 relaxed constant expressions. This reduces compile time complexity of TaskTraits constructor from O(n^3) to O(n^2). Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I73f993f6be837f1ac665b4b09c78d9d7272435a8 Reviewed-on: https://chromium-review.googlesource.com/c/1194687Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#596341}
-
Zach Helfinstein authored
Bug: 864796 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie299534b069a83dc38012468f547810f7b83b0b0 Reviewed-on: https://chromium-review.googlesource.com/c/1227501Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#596340}
-
yusukes authored
BUG=b:116761000 TEST=None Change-Id: I183b22eaa8c1bebad3f2797604bf7a98712c958d Reviewed-on: https://chromium-review.googlesource.com/c/1252385Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596339}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1709049243e..bfa76f20bfcf git log f1709049243e..bfa76f20bfcf --date=short --no-merges --format='%ad %ae %s' 2018-10-03 robertphillips@google.com Add GM for less common YUV formats (take 2) Created with: gclient setdep -r src/third_party/skia@bfa76f20bfcf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I107c872f19588728980df853ca7e5d470d6a9e33 Reviewed-on: https://chromium-review.googlesource.com/c/1259402Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5cc52fbcc765..18c0a2b44777 Created with: gclient setdep -r src-internal@18c0a2b44777 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icdd628529a8ce0c45c9d2697f187464ad6eda22b Reviewed-on: https://chromium-review.googlesource.com/c/1259482Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596337}
-
Timothy Loh authored
While the other classes in chrome/browser/chromeos/crostini are in the crostini namespace, the crostini_util functions are currently in the global namespace. For consistency, this CL moves these to the crostini namespace. Change-Id: Idf46afb76f1196a6a0ab961ea53195e536623bc4 Reviewed-on: https://chromium-review.googlesource.com/c/1250263Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596336}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7988589e4858..59021ba4e1dc git log 7988589e4858..59021ba4e1dc --date=short --no-merges --format='%ad %ae %s' 2018-10-03 sprang@webrtc.org Refactoring of VP8 TemporalLayers interface. Created with: gclient setdep -r src/third_party/webrtc@59021ba4e1dc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I711ec23882236e0eaeacb79d40d2d93d036d6da9 Reviewed-on: https://chromium-review.googlesource.com/c/1259106Reviewed-by:
-
Benjamin Ackerman authored
Removing everything associated with inline installation as it is deprecated per the announcement in https://blog.chromium.org/2018/06/improving-extension-transparency-for.html Bug: 882045 Change-Id: Ia24cb4076a841d9b37febe68cad89db7ea1ce1c8 Reviewed-on: https://chromium-review.googlesource.com/c/1220299Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Benjamin Ackerman <ackermanb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596334}
-
Jun Mukai authored
This is phase-1 of tab-dragging with touch on Mash. This CL adds GestureRecognizerObserver class, which will be used in upcoming CLs. BUG=867074 TEST=events_unittests Change-Id: I7a8c50ac16b58e1c3e31c7f0d8df097489ee49c3 Reviewed-on: https://chromium-review.googlesource.com/c/1247101 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
rbpotter authored
(1) Increase line height for destinations items (2) Remove "Advanced" label for printer options button (3) Remove margin on paper-icon-button so Print with system dialog... does not wrap (for English + normal font size) (4) Change pages per sheet label to sentence case (5) Fix alignment of "Destinations" label with printer names, particularly for printers that do not have a status/location displayed. Bug: 891375, 891378, 891379, 891395, 891577 Change-Id: I13fbcd167e2e9ee513ef056ce5c9e471248dd3d8 Reviewed-on: https://chromium-review.googlesource.com/c/1257370 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: -
Ryan Sturm authored
This CL moves the state of whether DRP can skip the long term blacklist checks for Previews from DRPConfig to PreviewsDecider. This happens through some thread Posts, and will eventually move to one thread PostTask instead of 2 when Previews is on the UI thread. Bug: 842233 Change-Id: Id8129338eeb1b2401f8f70ab2d02aebcbbd5c0e1 Reviewed-on: https://chromium-review.googlesource.com/c/1252783 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#596331}
-
Bailey Berro authored
This change adds a GetWindowsUNCString method to the SmbUrl class so that Windows style UNC can be displayed rather than the smb:// style URL. Bug: chromium:889289 Change-Id: If7f9d3235a7cd38ac854d6bd186ea4af257de6be Reviewed-on: https://chromium-review.googlesource.com/c/1256107Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#596330}
-
Scott Graham authored
This is the very initial stages of writing a bindings generator to allow interop to/from JS with FIDL. The main pieces are: - the build time generator which consumes the JSON IR from `fidlc` and outputs a fidl.js - integration with gn in fidl_library.gni - a JS runtime support library (mostly helps with message encoding) - new unittest binary (which also currently holds some Zircon integration points that will eventually be moved to a C++ runtime support library.) There are many, many things it does not yet handle, e.g. responses (either sync or async), events, passing structs, passing unions, ... For reference, test/simple.fidl generates this https://gist.github.com/sgraham/3935c64d5bc1b67eea1f6e3b38fef6f1 Bug: 883496 Change-Id: I58e5d2b81213f20a3198b68cbd2bc01660ba58f7 Reviewed-on: https://chromium-review.googlesource.com/c/1222697Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596329}
-
Reilly Grant authored
This change updates RemoveSafeBrowsingCookieTester and its base class RemoveCookieTester to use the CookieManager Mojo interface instead of the net::CookieStore interface directly. These tests now pass however I am leaving them marked as disabled until issue 812589 is investigated more thoroughly. Bug: 721395,812589 Change-Id: Iaadf98b31969bd159dfda5f5ff0802b8c8dd3239 Reviewed-on: https://chromium-review.googlesource.com/c/1257785 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#596328}
-
Antonio Gomes authored
This is a preparation CL for bug 879777, where data_reduction_proxy::WarmupURLFetcher is being migrated away from URLFetcher in favor of SimpleURLLoader. WarmupURLFetcher unittests' correctness relies on checking whether the appropriate net::ProxyServer instance is used. This CL makes this information available through network::ResourceResponseInfo. Note that, because it is a non-trivial c++ object, an specific IPC trait was implemented, so that the object can be passed across mojo pipes. BUG=879777 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I3728ba3173a23ad59dd3bf00877d7b1131944488 Reviewed-on: https://chromium-review.googlesource.com/c/1251642Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: I62c9193ac74ea77280197438b1d91fa252200f1e Reviewed-on: https://chromium-review.googlesource.com/c/1257149 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch reverts a part of crrev.com/367a97eb. This seems to have caused DCHECK failures on one of the telemetry tests. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Bug: 891270 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib99768154470fe69796e3a47645ffb1c981661a9 Reviewed-on: https://chromium-review.googlesource.com/c/1259298Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596325}
-
Clark DuVall authored
After crrev.com/c/1242296, we no longer need to proxy browser initiated requests with webRequest. This cleans up the proxy for the URLLoaderFactory used for browser initiated requests. Bug: 888672 Change-Id: I96c55fa5849285ae8f86c4b6d7c24d47c8ac4c19 Reviewed-on: https://chromium-review.googlesource.com/c/1254725 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596324}
-
Tom Sepez authored
Change-Id: I91e90d653c45fc7a8bebd433f10907a7c35caa0b Reviewed-on: https://chromium-review.googlesource.com/c/1258976Reviewed-by:
-
Aaron Colwell authored
Change-Id: Ib4f291702a3e0c388c12b112724c735b808251d1 Reviewed-on: https://chromium-review.googlesource.com/c/1259464Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#596322}
-
erikchen authored
Layout test initialization is non-deterministic. WidgetInputHandler::OnFocus() races against the contents of the layout test, which may also attempt to set/unset focus -- the ordering between the two is non-deterministic. This CL adds a FlushForTesting() message to WidgetInputHandler to make the ordering explicit. Bug: 889036, 889952 Change-Id: I26adca82915e75a9941c93b60a555f0c16084014 Reviewed-on: https://chromium-review.googlesource.com/c/1255782Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596321}
-
Stephen McGruer authored
These tests are failing flaky with crashes. TBR=pnoland@chromium.org Bug: 891419 Change-Id: I99d699e29e3be1f0d167531fe702011bbf2c3c9e Reviewed-on: https://chromium-review.googlesource.com/c/1259422 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596320}
-
Leonard Grey authored
flagsChanged: is under-documented, but in Apple's examples, the actual key which causes the change flag is provided in the |keyCode| property and |modifierFlags| is used to determine whether it's a keyup or keydown. When sending command key combinations via AppleScript (and possibly other methods), the system feeds us a flags changed event with modifier flags set correctly for "Command down" but an unset key code. Since key code 0 is A, we interpret this as Cmd+A (select all) when no such thing was intended. The correct event is sent as well (with, for example, key code 55 for left command), so we should drop the key code 0 event instead of trying to intepret it. Hopefully this change also fixes https://crbug.com/885163 Bug: 889618 Change-Id: Ibc8fe0216b917cc50a23c252209f2ac09a10edf9 Reviewed-on: https://chromium-review.googlesource.com/c/1259243Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a1c846c4cf3f..f9e0498bb1ce git log a1c846c4cf3f..f9e0498bb1ce --date=short --no-merges --format='%ad %ae %s' 2018-10-03 thestig@chromium.org Simplify CFX_FontSourceEnum_File's file iterator. Created with: gclient setdep -r src/third_party/pdfium@f9e0498bb1ce The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I820449983fba5cf85c8263619a988e24d245ad37 Reviewed-on: https://chromium-review.googlesource.com/c/1259105Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/22300e1fb562..6af3aa854956 git log 22300e1fb562..6af3aa854956 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 brucedawson@chromium.org Support omitting the space after -C Created with: gclient setdep -r src/third_party/depot_tools@6af3aa854956 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:890744 TBR=agable@chromium.org Change-Id: Icd16a680abeca3e8c534c04e6ad6a0e743a06bbd Reviewed-on: https://chromium-review.googlesource.com/c/1259103Reviewed-by:
-
Caleb Rouleau authored
This fixes the exception: File "/b/s/w/ir/testing/scripts/run_telemetry_benchmark_as_googletest.py", line 176, in run_benchmark if rc == 0: UnboundLocalError: local variable 'rc' referenced before assignment TBR=nednguyen Bug: 891332 Change-Id: I81b8502f8f95bf8db070d8ccc062a343b062e880 Reviewed-on: https://chromium-review.googlesource.com/c/1258978 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596316}
-
Ian Clelland authored
Bug: 888668 Change-Id: I2ca249628b9395480f5dfcaaf2b300046dba9b2c Reviewed-on: https://chromium-review.googlesource.com/c/1243503Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#596315}
-
Ian Clelland authored
Bug: 888668 Change-Id: Iddc72d0638ddebbab044f070237d6bd885c557aa Reviewed-on: https://chromium-review.googlesource.com/c/1243523Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#596314}
-
