- 24 Nov, 2020 40 commits
-
-
Elly Fong-Jones authored
The original change assigned "N" as the accelerator for this item, but that is already in use by "minimize"; have "Name Window" use "W" instead, which is free in this menu. Bug: 1152079 Change-Id: Ibebe8331c3580a6db76808791056677550d293c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558748 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830766}
-
Andreas Papacharalampous authored
the extension mentioned should be a better alternative than the existing files.association workaround Bug: 1144959 Change-Id: Ie912519b00e5c74af0634fc85a09610ec09175c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515285Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#830765}
-
Mike Jackson authored
In preparation for run on os login support for linux, I'm adding tests to validate the existing functionality of the linux shortcut code. There are minimal product code changes, primarily to help facilitate testing, or to remove dead code that was only previously used by the old test code. Bug: 897302 Change-Id: I8e08632227da675f19082c72d6fa611747d1f15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528877Reviewed-by:
-
Yi Gu authored
The test has been flaky (score > 1400): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests%20(with%20patch)&tests=All%2FCrossOriginOpenerPolicyBrowserTest.CrossOriginIsolatedSiteInstance_MainFrame https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVydQsSBUZsYWtlImpjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BDcm9zc09yaWdpbk9wZW5lclBvbGljeUJyb3dzZXJUZXN0LkNyb3NzT3JpZ2luSXNvbGF0ZWRTaXRlSW5zdGFuY2VfTWFpbkZyYW1lDA TBR=ahemery@chromium.org Bug: 1125998 Change-Id: I991e18b0d74e08db3fe0360c6f43b2a284921be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559006 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830763}
-
Nicolás Peña Moreno authored
Currently, InsertPerformanceEntry receives a ref PerformanceEntry as parameter, so push_back may be creating a copy of the object. We make sure this does not happen by passing a raw pointer to push_back so it creates a Member out of it to retain ownership and there's no risk of cloning the object. Change-Id: I3315e394a30baa6cb7627f935f4b83e560fe2a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558739Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#830762}
-
Yi Gu authored
The test has been flaky (score > 1400): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=ExtensionWebRequestApiTest.RedirectToAppCacheRequest https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEV4dGVuc2lvbldlYlJlcXVlc3RBcGlUZXN0LlJlZGlyZWN0VG9BcHBDYWNoZVJlcXVlc3QM There are other instances on Mac but not as many as on Linux ATM. TBR=cduvall@chromium.org Bug: 1094834 Change-Id: I28ff7697b3cd7cbd8f81ced7f0dd4cfb4d53103f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559005Reviewed-by:
-
Andreea Costinas authored
Add a new policy for Chrome OS that will be used to control whether reusing the Chrome OS login credentials for network authentication is allowed. Only used for managed proxies secured with NTLM authentication. Bug: b/173097096 Test: presubmit tests; verfied chrome://policy with YAPS Change-Id: I0e352fcac0c2aea434670aeaae13f1f2e86b3f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543349 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830760}
-
Nicholas Hollingum authored
We add a BorealisWindowManager handler which will do the bulk of processing for borealis windows. This handler recognizes borealis windows specifically (i.e. not crostini windows) but otherwise emulates the previous behavior (i.e. it pretends the windows are crostini ones). In a future CL we will add special behavior for borealis windows. Bug: b/172979315 Change-Id: Id4ef5fbb1fe95b1d1e2c79c510870cdd2329d6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554275 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#830759}
-
Rachel Wong authored
This CL links the flag at chrome://flags to trigger the corresponding Suggest experiment to enable rich entity support in the Launcher. The relevant Suggest config can be found at http://google3/googledata/experiments/gws/studies/suggest/cros_suggest_launch.gcl. Bug: 1130372 Change-Id: I0ed17ac19c2ea988e025a743d148aa73ed8e71a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556880Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#830758}
-
Jeffrey Kardatzke authored
There was a previously unknown iHD requirement before that if we want to keep the protected session attached to the decoding context, then we need to submit the encryption parameters for every slice (even if that slice is not encrypted). BUG=b:153111783 TEST=H264 and VP9 works with seeking in/out of encrypted/clear content Change-Id: I6fff69d4b5ce4a0835f898a068e6a9049ab5e3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555469 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#830757}
-
Aleks Totic authored
Bug: 958381 Change-Id: I5dfd967b14adc19da07ea23bb38fe9f8d987dbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559250 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#830756}
-
Andrew Grieve authored
This reverts commit 30f14e92. Reason for revert: official bot breaking https://bugs.chromium.org/p/chromium/issues/detail?id=1144538#c8 Original change's description: > Reland "Android: Enable use_debug_fission for official builds" > > This reverts commit 86befdda. > > Reason for reland: Bugs fixed in other CLs (see issue) > > Original change's description: > > Revert "Android: Enable use_debug_fission for official builds" > > > > This reverts commit 9d3a4611. > > > > Reason for revert: Official builds failing crbug.com/1144538 > > > > Original change's description: > > > Android: Enable use_debug_fission for official builds > > > > > > Bug: 1122182 > > > Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342 > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#822625} > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1122182,1144538 > > Change-Id: I49cb3f0d42027a5e855cf1aa16f8cd1441f46ca9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513206 > > Commit-Queue: Krishna Govind <govind@chromium.org> > > Reviewed-by: Ben Mason <benmason@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823080} > > Bug: 1122182 > Bug: 1144538 > Change-Id: Id3bcf776146a9bd9e66ec50cd8b9529029479faf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541383 > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ben Mason <benmason@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827946} TBR=agrieve@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1122182 Bug: 1144538 Change-Id: Iccd274ff85e12710206105c713a2f3dbc260f1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558781Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#830755}
-
Dave Tapuska authored
Now that WebFrameWidgetImpl is only subclass of WebFrameWidgetBase, the two classes can be merged into one. BUG=1097816 TBR=dcheng@chromium.org Change-Id: Ibe12b5a865355e37cf0d3500fb521779f40574aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552251 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830754}
-
Vasiliy Telezhnikov authored
This is a reland of db7626d6 Changes from the original: check if vk_context_provider not null. Original change's description: > Use GrShaderCache with Vulkan > > VulkanContextProvider is created before GrShaderCache and so cache > wasn't pass to Skia via GrContextOptions. > > This CL defers init of GrContext in VulkanInProcessContextProvider to > SharedContextState::InitializeGrContext to mitigate this. > > Use of cache itself is under feature flag for metrics comparison and > a kill switch purpose. > > Bug: 1151031 > Change-Id: Idc410b9b557f7ca67164eb80d6a37a27ceb0f6d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551245 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829651} Bug: 1151031 Change-Id: Ibd4e7d55fdc56c1ea2cc0e82d6cc6c34459165c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554353Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830753}
-
Francois Doray authored
With this CL, the same histograms are recorded when the BackgroundTabLoadingFromPerformanceManager feature is enabled/disabled. Bug: 1059341 Change-Id: I2a099ef73e71b649d5a927659f9fbe3c052e63cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553287 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#830752}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: If3df892370f81f37fb854eb931741817c11b6ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558670Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#830751}
-
Joon Ahn authored
Applies linear gradient on the chart area and adjusts etc paddings and colors. http://screen/BQXtyTNo9TZgeqb Bug: 1125150 Test: browser_tests --gtest_filter=Diagnostics* Change-Id: I993fc3e2fd0dbbdc74bd0e6ba183a9bcfcc5b379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558913Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#830750}
-
Chris Sharp authored
BUG: b:173720192, b:173642641, b:174060344 Change-Id: Id941a5178fe483a3fc9933beb96924d68f4586c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555258 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830749}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a629d81faa7a..ae003f552e4e 2020-11-24 heiserya@google.com Telemetry-on-lacros fixes: If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1149629 Tbr: oysteine@google.com Change-Id: Ie2341fb8e08ba6b6655f73d8c97e9b911ad748d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830748}
-
Yi Gu authored
The test has been flaky on all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=accessibility/aom-click-action.html TBR=aboxhall@chromium.org NOTRY=True Bug: 1134459 Change-Id: I795f7a7b21eef84a24d5b56e42240604e863ff8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559375Reviewed-by:
-
Liquan (Max) Gu authored
This change is to make shouldSkipShowingPaymentRequestUi ready to be moved into PaymentRequestService so that WebLayer and Chrome can share the logic. Changes: * made the following methods static: - shouldSkipShowingPaymentRequestUi - onlySingleAppCanProvideAllRequiredInformation * adds PaymentUiService#getPaymentAppsInPaymentAppList. Bug: 1025619 Change-Id: I50c0b91b8f2b9ec0886ff43d1978a58d887a5f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556903 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830746}
-
Daniel Cheng authored
Change-Id: Ifed7f2588cbd1dd57af399436e47b01fc5135c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125432 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830745}
-
Gavin Williams authored
On completion of a scan job, return the file path of the last scanned file to the Scanning App. Will be used to open the Files app. Bug: 1059779 Change-Id: Ia3d33155daf472fc65fa2a959c068caddb3bff2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545743Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#830744}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c5dd5d863c4..64e80769c4c7 2020-11-24 ehmaldonado@google.com [owners] Sort owners by distance If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ibae732973b737f07a1a24487391f906c5c918557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559134Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606218923-28e4a6cb560c6a9acc44daf784662f70e5c57403.profdata to chrome-win64-master-1606229875-9be2cd912654833e55877c29390e1b8095877a20.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id21803f250b1732496a7e83ff927510fdd70b79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558770Reviewed-by:
-
Dave Tapuska authored
All methods have been moved into the base object so now we can construct WebFrameWidgetImpl always. This is steps 6-8 in https://goo.gl/7yVrnb. Eventually WebFrameWidgetBase will be colapsed with WebFrameWidgetImpl. BUG=1097816 Change-Id: I364266758390c3b51e12ca5accd74df547ba2d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552551 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Xinghui Lu authored
Bug: 1097310 Change-Id: I5e91dbe8623f796a132671eb23a7a4ef9ce26ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558758 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#830740}
-
Richard Chui authored
This CL introduces animations that change the opacity of the cature bar while in region mode. The opacity is changed based on where the cursor is hovering, and whether or not the selected region intersects with the capture bar. Test: manual, added new test Change-Id: I730617c5ce311309353ededc3850be53ec538dca Fixed: 1150079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545610Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#830739}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Icc41f410f1e81b79d76a80a2653fbc54d4a23890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532994 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830738}
-
Taylor Bergquist authored
The NTB's insets are no longer horizontally symmetric, so they need to be flipped when hit testing. Bug: 1148176 Change-Id: I1d61592221e9b825927a8f16d93c7640642a9bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547310Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#830737}
-
Nick Burris authored
The google_pay drawable will soon be used by the downstream payments component, so the resource first needs to move into components. Bug: 1150971 Change-Id: Ib69b7781b7afe17114a35b25e1e048b2b71bcece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555505Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#830736}
-
Jeffrey Kardatzke authored
BUG=b:153111783,chromium:1152523 TEST=Fuzzer passes Change-Id: I27f353116d6703b065cecef527c24487f627f67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558788 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#830735}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f66650677465..b1da4494cc50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yigu@google.com,ezemtsov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139098 Tbr: yigu@google.com,ezemtsov@google.com Change-Id: Ie2055e1ee7d598c0c4d6e3d56facfa68a50525de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830734}
-
Shuran Huang authored
There will be a follow up CL to replace the current use cases of FromOrigin(). Bug: 1145294 Change-Id: I606d75901f8c4012df285d14627533bbf5dfc20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557224 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#830733}
-
Joel Hockey authored
TBR=jamescook@chromium.org Bug: 1152128 Change-Id: Iaa85708fe65d89099013859416fef2155a04c6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557764 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#830732}
-
Igor Ruvinov authored
Add check for various local sync proto file issues (access, memory, file in use, file/path not existing) prior to serialization. Implement UMA histogram logging and improve debug logging to better communicate errors encountered during opening of the file. Bug: 1049091 Change-Id: I0658e40d0e3a16cc171a3e1523e211151d569315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552888 Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#830731}
-
Erik Staab authored
We're only testing arm64 binaries now and have additional capacity. Bug: 1139038 Change-Id: Id1a5f9d03276f24173af2c42b5abd99db46d9fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557227Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#830730}
-
Alex Ilin authored
This CL makes the following updates to the chrome.identity documentation: - getAuthToken(): clarify that the grantedScopes callback parameter is available since Chrome 87, instead of vague "in future versions of Chrome" - clearAllCachedAuthTokens(): improve list formatting Bug: 1100535, 1125847 Change-Id: I687a27a62e90953647a441e585a69a50f77537b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556522Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830729}
-
tby authored
Now that keys and IDs are associated with projects, not events, the documentation and method signatures in key_data is out of date. I've also changed the name of HashForEventId to HmacMetric, since it was a bit cryptic. Note that HmacMetric still operates on the values of an event, not a project. Bug: 1148168 Change-Id: I4bc8e6360917f4b4f141aaad9a11e5485954871f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554193Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#830728}
-
Alex Turner authored
Scripts can contain a 'sourceURL' to act as the identifier for debugging tools. However, resources fetched with an ad script at top of stack are not tagged as ads when that ad script has a sourceURL. This is because ScriptAtTopOfStack() checks GetScriptNameOrSourceURL() and the sourceURL takes precedence when present. This sourceURL is then compared to the actual resource URLs stored in known_ad_scripts_, resulting in no match. We thus switch to using GetScriptName() instead, which will return the expected resource URLs. We additionally add tests for this case. See crrev.com/c/2550504 for avoiding performance impacts. Bug: 1127391 Change-Id: I9ad24cbfbeaca952c9a2dec951337b6bbe574439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551259 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
-
