- 14 Nov, 2019 40 commits
-
-
Bret Sepulveda authored
Unlike ToolbarActionsBar, ExtensionsToolbarContainer assumes the ToolbarActionsModel always exists. When the feature flag was enabled, this would crash any test that creates a BrowserView. To fix this, TestWithBrowserView initializes ToolbarActionsModel. Bug: 984654 Change-Id: I69df818c72f898dbf2e2bb7c80d3ac5bcc096c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901076Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#715222}
-
Olivier Robin authored
Starting with iOS 13, sourceApplication is only set when openURL is called from an application with the same team identifier. Oddly, it is also nil when calling from extension. Bug: 1020228 Change-Id: I9876647c30350e2242d20da2ab045805a9864932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903349Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715221}
-
Jan Scheffler authored
This patch adds a test to check that all loaded css files are shown in the coverage list view even when not (yet) covered at all. Fixed: chromium:949045 Change-Id: Idda4df73866590010d59f84cd4193c051fe1cc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903359Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#715220}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b52f05868c9..ae55a94ff52c git log 1b52f05868c9..ae55a94ff52c --date=short --no-merges --format='%ad %ae %s' 2019-11-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 88632cac30e1..b2407dd746de (3 commits) Created with: gclient setdep -r src/third_party/angle@ae55a94ff52c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: I555fec9c9e5ad84397a05e245ea3fbdcc4c546d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715219}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ab3cdcaef56e..3da910d55f20 git log ab3cdcaef56e..3da910d55f20 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 dneto@google.com Avoid uninit warning in GCC (#3044) 2019-11-13 bclayton@google.com utils/vscode: Add SPIR-V language server support 2019-11-13 bclayton@google.com utils/vscode: Add go language server packages. Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3da910d55f20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: Ie5023c33ec6f0df4407a634a29375fd7209bfc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916139Reviewed-by:
-
Marc Treib authored
- Add treib@ as new main POC while melandory@ is out. - Remove (comment out) previous owner pavely@. - Reduce duplication: Have chrome/browser/invalidation/OWNERS and ios/chrome/browser/invalidation/OWNERS refer to the "main" owners file instead of explicitly listing the same people. Bug: none Change-Id: I80524388818c26884c07928422b74d70e026076f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913404 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715217}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/32f02045f037..c2f0287a28a4 git log 32f02045f037..c2f0287a28a4 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 bhogeswararao@google.com gwifi GroupEntry line length alignment. 2019-11-14 cjmcdonald@chromium.org Delete parallel_emerge_old Created with: gclient setdep -r src/third_party/chromite@c2f0287a28a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8e4bcb83c04637f2f1aea238a82a474c141c30f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915679Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1024402 Test: Verify switching icon is changed during fps switching. Change-Id: I53e04841094b5439634a3b3c497bbcb4209cbde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915648 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#715215}
-
Mike West authored
This reverts commit b1ea8aae. Reason for revert: PdfCompositorImplTest.CompleteDocumentLackingPrepare and PdfCompositorImplTest.CompositeDocumentAfterPrepare are consistently failing since https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/4546. Original change's description: > PDF compositor generate full document from individual pages > > During print preview when the PDF compositor is used, individual PDFs > for each page are made for the preview. Prior art has the full > document PDF used for printing being generated by sending a separate > metafile blob for all the pages, which is overly large for long > documents. This alters that to have the full document PDF get > composited using the same individual page metafile objects as they are > sent to the utility process for the composition. > > This effectively halves the amount of IPC traffic for Skia metafile > data and eliminates potential huge metafile messages that can > overwhelm IPC limits. > > This is only applicable for print preview scenarios that pass Skia > metafile into PDF compositor. Non-modifiable content and basic > printing are unaffected in behavior. > > Bug: 872935 > Change-Id: I1101846a00498956b18c208ada656e65e4f175a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616461 > Commit-Queue: Alan Screen <awscreen@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715165} TBR=dcheng@chromium.org,thestig@chromium.org,awscreen@chromium.org Change-Id: Ie188aef36f38ea092557a46251507960d33a4ef1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872935, 1024748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916121Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#715214}
-
shrekshao authored
Currently chromium doesn't expose these two extensions on platform without base instance native support (android without EXT_base_instance and Mac). Workaround for this is already implemented in Angle though. We will advertise them when either we implement the workaround in validating command decoder as well, or we start using angle for all platforms. This patch also removes remaining webgl_multi_draw_instanced feature flag in feature_info.h Bug: 890539 Change-Id: I9122f8d323f42e30d21fc081db2150890c953e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888771 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#715213}
-
Mike West authored
This reverts commit 845f18e1. Reason for revert: Both `AccessibilityBridgeTest.CorrectDataSent and AccessibilityBridgeTest.DataSentWithBatching are flakily timing out. See https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64 starting around 44416 (e.g. https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64/44418). Original change's description: > Reland "[Fuchsia] Send Chrome a11y updates to Fuchsia SemanticsManager" > > This is a reland of fc5589ac > > A BUILD.gn dep has been added back, which was causing linker failures. > > Control flow in AccessibilityBridgeBrowsertests has been updated so > tests are no longer failing. > > Original change's description: > > [Fuchsia] Send Chrome a11y updates to Fuchsia SemanticsManager > > > > This change adds functionality to the Accessibility Bridge: > > * Listens for change in AccessibilityMode from Fuchsia > > * Gets the semantic tree from Chrome accessibility and sends it to the > > SemanticsManager > > * Sends live updates when nodes are added, updated or removed > > > > To send updates, this change includes the following: > > * Creates a ViewRefPair and registers it with the SemanticsManager > > * Initialize an AccessibilityBridge > > * Listen for changes in the Chrome Accessibility tree, serializes them > > to Fuchsia data structures and sends that data to the Fuchsia > > SemanticsManager > > > > Testing: Added AccessibilityBridge browsertests. > > > > Bug: 973095 > > Change-Id: I89658288b846b6b9ce84a04e49434ec266b84dfc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787171 > > Commit-Queue: Sharon Yang <yangsharon@chromium.org> > > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#714588} > > Bug: 973095 > Change-Id: Ie6eeb74146682838efaefb0e1051d3e9442f0d86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913569 > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715126} TBR=dtseng@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org Change-Id: Ib78d563cbbf468aaf03f1e6f00f616dc03b758a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973095, 1024745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916120Reviewed-by:
-
Kuo Jen Wei authored
Bug: b/117810572 Test: Pass presubmit check. Pass tast run <DUT> 'camera.CCAUI*' Change-Id: I9d71ab1c68cb435759cb0416667aa3af78ec2121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915645 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Roman Sorokin authored
Bug: 1022328 Change-Id: I967618ab4e2b45b3b1b7a5056600c34ead38efcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912716Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715210}
-
David Van Cleve authored
net/dns: Histogram ESNI DNS transaction success This patch adds a histogram that records successes and timeouts for ESNI transactions. (Instead of recording the ESNI timeout parameters directly, their effects can be observed by bucketing the timeout ratio by study group and associating different values of the parameters with different groups.) Test: Adds unit tests Bug: 1003494 R=ericorth,csharrison Change-Id: I435f5a2f048df1eec46650aabc763e0c4a43a339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900353 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#715209}
-
Noel Gordon authored
- rename the input files to match the names of the existing ui PNG icon files used in Files app - there are svg files in the ui directory so use a *_ng.svg suffix for the files-ng svg version Bug: 992819 Change-Id: I6d71d884b9f26569e4522debf4fa8bb157ed280a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915646 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#715208}
-
Alexey Baskakov authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1914005 CL. The problem was that two IsTrackingMetadata() calls were under DCHECK macro. Those calls didn't happen in release builds with `dcheck_always_on=false` GN arg. The fix: promote DCHECK to CHECK to make it debug/release/dcheck_always agnostic. Original description: Improve WebAppSyncBridge::UpdateSync to use both current_state (before commit) and new_state (to be commit). In the future, it will help to skip local updates which don't touch sync data. Add WebAppSyncBridge::CommitUpdate unit tests (a.k.a. Local Changes). These tests is a promised follow up for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1830494 This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. TBR=treib@chromium.org Bug: 860583 Change-Id: I80a657c0d595bc03bebb8e241b1866daf5aa077e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915647Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#715207}
-
Reilly Grant authored
BluetoothAdapter is a reference counted object and so BluetoothDeviceChooserController should own it using a scoped_refptr. Fixing this requires also fixing BluetoothAdapterFactoryWrapper's AcquireAdapterCallback to take a scoped_refptr rather than a raw pointer. A test for proper ownership has been added. Bug: 1024121 Change-Id: I6342322e059f9cbff2a0d5f073f6bccfb0ca7c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914536Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715206}
-
Yuzu Saijo authored
This CL adds is_in_back_forward_cache_ bit in ServiceWorkerProviderHost instead of each time referring to RenderFrameHost's is_in_back_forward_cache(). Currently, SWPH and RFH have different lifetime and that is why this bit should be kept in SWPH. Once SWPH and RFH have the same lifetime, this bit will not be needed any more. Change-Id: Ie6dfb3608577f663cb37770e4b77166c8fca7e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909059Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#715205}
-
Christopher Cameron authored
When launching a PWA, it should start where the user left off (that is, with the profiles open that the user had open when they quit). In order to do this, we need to save in local storage the list of profiles for which each app was last active. While we are creating local storage for PWAs, we often need to know for what profiles an app is installed. This is currently implemented by poking through the user-data-dir in the filesystem. Putting this in local storage is much simpler. To solve both of these problems, add the AppShimRegistry which maintains the following structure in local storage. "app_shims":{ "<app_id>":{ "installed_profiles":[ "<relative_profile_path_1>", "<relative_profile_path_2>", ], "last_active_profiles":[ "<relative_profile_path_1>", ], } } Add hooks to maintain these |installed_profiles| to AppShortcutManager, because all shim creation and deletion goes through that structure. We will at some point want to move this to a PWA-specific component. Do not yet add hooks to maintain |last_active_profiles| because this patch is getting too big. Do add the code indicating where it will be used in ExtensionAppShimHandler, and update its tests to not crash when using AppShimRegistry. Add lots o tests. Bug: 1001213 Change-Id: I51d931567d9c3a4e1db143aa2b6164dcaa1a0f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910719Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#715204}
-
Takuto Ikuta authored
This reverts commit d21a8cdd. Reason for revert: skeptical revert for https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/25684 Original change's description: > chrome_repack_locales: compress .pak files on Chrome OS > > This CL adds support for compressing .pak files, and adds compression > for locales/*.pak on chromeos. > > Note: We keep the extension for compressed .pak files to avoid > dependency complexity in tests. > > Bug: 1017864 > Change-Id: Ifee472b7e15673fcb835ae75aca768265592460b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912621 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715173} TBR=stevenjb@chromium.org,sky@chromium.org,agrieve@chromium.org Change-Id: I701b27c18bd5db83d078e413c9a14915a83c9329 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915653Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#715203}
-
Dave Tapuska authored
Move FrameHost::FrameFocused and RenderFrameProxyHost::FrameFocused to blink's LocalFrameHost and RemoteFrameHost interfaces. Remove the callbacks on the blink public API as they aren't needed anymore. Also remove WillCommitProvisionalLoad since it is an unused method. BUG=1008432 Change-Id: I7868d4f909db5c9a5e458e56e63a437d1d377c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896770Reviewed-by:
-
Maksim Sisov authored
Watchlist mixes with the review requests I get. Instead, I better subscribe to ozone-reviews group. Change-Id: I8e70941f8f7e8afb5384e153a42251f5b25520e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913245Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#715201}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f520568b0e6a..00fc2231f697 git log f520568b0e6a..00fc2231f697 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 dberris@chromium.org Pinpoint: Backwards compat for '_trace_or_story' 2019-11-14 rmhasan@google.com [typ] Add ability to merge test expectations across multiple files Created with: gclient setdep -r src/third_party/catapult@00fc2231f697 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1024660,chromium:986447 Change-Id: Ibeddf622b634648e63dbe509acee0ab8ef408fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915680Reviewed-by:
-
shrekshao authored
Bug: 890539 Change-Id: Id85f9693b7e3843c449e221afe5ae07760b5c18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888770 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
-
Thanh Nguyen authored
This CL: 1. Add parameters to control experiment through Finch flag 2. Add a simple edit distance algorithm 3. Add unittest for the finch parameters Bug: 990684 Change-Id: I919d1dad0eaeb69b9305b14438eab3c930b425af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913224Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715198}
-
Oksana Zhuravlova authored
This change renames Platform::GetBrowserInterfaceBrokerProxy() to GetBrowserInterfaceBroker() for consistency with document/frame-scoped methods. It also renames content::BrowserInterfaceBrokerProxyImpl to ThreadSafeBrowserInterfaceBrokerProxyImpl for more clarity. Bug: 1004954 Change-Id: Ib4468ae41d28df7295f658bbecc8920c24a763a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914123Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#715197}
-
Asanka Herath authored
Shuttling around authentication scheme names as strings carries with it the overhead of canonicalization everywhere they are used. Scheme names are considered to be case-insensitive, so this means a lot of invocations of base::ToLowerASCII() and others. Instead, this CL introduces two changes: 1. HttpAuthChallengeTokenizer::scheme() is renamed to auth_scheme() to visually disambiguate it from URL schemes. 2. auth_scheme() always returns the lowercase string. 3. Multi-round authentication header parse uses HttpAuth::Scheme enumeration instead of a string. 4. HttpAuthGSSAPI doesn't take an authentication scheme as a string anymore. It doesn't make sense to use any scheme other than "negotiate" with this class Bug: 927182 Change-Id: I501af8e978857302d3893f1b7fb2dcd23d2b7e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907418 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#715196}
-
Dominic Farolino authored
This CL records a network::ResourceRequest::request_initiator in addition to some pre-existing members, upon referrer mismatch DumpWithoutCrash. It will help in debugging crbug.com/1021908. R=yhirano@chromium.org Bug: 1021908 Change-Id: I91e6b1634449658ce42421b83b72ce3bc23783d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908711Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#715195}
-
tby authored
We're trying to debug a tricky issue where Drive QuickAccess results are not appearing in zero state for a very small number (so far, 1) of users. We're not sure how many users this affects, or whether it is principally a ranking issue or a problem with a backend API. This CL adds a ground-truth metric to distinguish between these cases: - Drive QuickAccess results are displayed. - DQA results are being returned from the search backend, but don't have high enough scores to be displayed. - No DQA results are returned. This metric is important for the feature, but I'm worried that it's costly to compute, since it requires re-filtering the results on each SearchResultListView::DoUpdate. jennyz@, is this going to introduce too much UI jank? If so, perhaps we could limit it only to canary/dev/beta? Bug: 1011221 Change-Id: I1f40e817b51c2f49712986f9758d3df51aaf6b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911065Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#715194}
-
Leon Han authored
This is in preparation for supporting writing NDEFRecord#id into a nfc tag. The plan is: 1. Introduces NDEFRecord{Init}#id and supports reading. Already done by crrev.com/c/1861574. 2. Supports writing. This CL is part of the effort of bypassing all helper functions android.nfc.NdefRecord.createXXX() to enable us to write the id when constructing android.nfc.NdefRecord. See discussions at https://github.com/w3c/web-nfc/issues/410. 3. Introduces NFCScanOptions#id and filters records by it when scanning. 4. Removes NDEFMessage{Init}#url and old impl of the author record. The spec changes: https://github.com/w3c/web-nfc/pull/338 https://github.com/w3c/web-nfc/pull/340 BUG=520391 Change-Id: If3c37f59249a6852d0960eac2c3e4319b82a4a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910906Reviewed-by:François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#715193}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2685ecce9083..cca19d9bd441 Created with: gclient setdep -r src-internal@cca19d9bd441 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I93b161e77b40879efb75136ea158e91f18fa65d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915298Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715192}
-
Nicholas Verne authored
Bug: 1024693 Change-Id: I26f242047f68d9a60c4c6637a285f09bbbd2d226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914596 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#715191}
-
David Munro authored
Test: CQ and local build Bug: chromium:930901 Change-Id: I1784683e1ee55ff956d512cc34616a51148ba7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914597 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#715190}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37be7715fdd1..32197f897c73 git log 37be7715fdd1..32197f897c73 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@32197f897c73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: If4a497bc3d45f604992a93b85d3a0aa99c4f285d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914755Reviewed-by:
-
Chih-Yu Huang authored
In VideoDecodePipeline, we set frame metadata POWER_EFFICIENT twice. This CL remove the one at OnFrameDecoded(). Bug: none Test: Play video at crosvideo.appspot.com on kevin Change-Id: I3ef4b45e72d9d1ec52621b993cec12e7a0e65057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914598Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715188}
-
Fergus Dall authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9734c36f2aa6..ce25839e00e5 $ git log 9734c36f2..ce25839e0 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 sidereal crash_reporter: Add new parser to anomaly_detector 2019-11-07 xzhou system_api: add proto definition for fido protocol 2019-11-11 igorcov system_api: Define new constant for StopSessionWithReason Created with: roll-dep src/third_party/cros_system_api Bug: 1018093 Change-Id: Ia8f15eb4141c85958aef92b0df8a6b18dd8c9bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914594 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715187}
-
Keith Lee authored
Changes were based on the call chain of setCompositionRange. Modify setSelectionRange and setCompositionRange to throw an error if the arguments were invalid uint32 values. Changes to third_party/closure_compiler/externs/input_method_private.js were auto generated by running: ``` python tools/json_schema_compiler/compiler.py /usr/local/google/home/keithlee/chromium/src/chrome/common/extensions/api/input_method_private.json --root=. --generator=externs > /usr/local/google/home/keithlee/chromium/src/third_party/closure_compiler/externs/input_method_private.js ``` b/134473433 CRBUG=1024657 Change-Id: I5dfb398bb1ff7a4c3a246c64759437efbc33782b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903227 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#715186}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fa6d4dc30478..f520568b0e6a git log fa6d4dc30478..f520568b0e6a --date=short --no-merges --format='%ad %ae %s' 2019-11-14 dproy@chromium.org Reland "Add origin trial token for vulcanizer" 2019-11-14 agable@chromium.org Reland "Nearly-whitespace change to check mirroring" Created with: gclient setdep -r src/third_party/catapult@f520568b0e6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1021137,chromium:1023392 Change-Id: I2f862620a46aaa5cab8b8ba5ede3c7c57a4647f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914756Reviewed-by:
-
Xianzhu Wang authored
LayoutNG allows an inline to contain floating objects, so the original logic for floating objects escaping inline containers doesn't apply. Bug: 922645 Change-Id: Id736d7051a6356325be92cb7fa25949a21304c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913027Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715184}
-
Michael Spang authored
Chromecast uses views, but does not set toolkit_views=true. Set this to true & remove desktop-oriented code that breaks in this case. This replaces !defined(OS_CHROMEOS) with a new BUILDFLAG(ENABLE_DESKTOP_AURA) flag as necessary throughout views. This is needed because Chromecast doesn't use desktop_aura and uses aura similarly to Chrome OS by creating one WindowTreeHost for the display [alternative suggestions on how to handle this distinction welcome]. This does not enable views in content(_shell) yet. That's left to the next patch as it changes the UI. As of this change, views_unittests passes in Chromecast Linux builds. Bug: 1021770 Test: views_unittests, content_browsertests on is_chromecast=true build Change-Id: I54e79402a761572feb76f122ed846558e84210b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907559Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
