GitLab

BUG=160496


Review URL: https://chromiumcodereview.appspot.com/11659005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175731 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166802


Review URL: https://chromiumcodereview.appspot.com/11647013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175730 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168421


Review URL: https://chromiumcodereview.appspot.com/11826017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175729 0039d316-1c4b-4281-b951-d872f2087c98

Add explicit dependency on WebIDBFactory.h in preparation for removing WebIDBFactory references from upstream WebKitPlatformSupport

Review URL: https://chromiumcodereview.appspot.com/11817004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175728 0039d316-1c4b-4281-b951-d872f2087c98

This removes the OnWindowPaintScheduled() notification from
aura::Window::SetExternalTexture().  Without this change,
the video detector thinks that small webpage updates have
modified the entire window and also double-counts updates
(SchedulePaintInRect() should be called afterwards in most
cases).

BUG=165071


Review URL: https://chromiumcodereview.appspot.com/11819012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175727 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168972
TBR=vangelis@chromium.org

Review URL: https://codereview.chromium.org/11814003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175726 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175725 0039d316-1c4b-4281-b951-d872f2087c98

This CL bumps es-EE and tr-TR spellcheck dictionary versions to 3-0. The updated
dictionaries contain a checksum, which improves reliability.

BUG=168825


Review URL: https://chromiumcodereview.appspot.com/11826006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175724 0039d316-1c4b-4281-b951-d872f2087c98

There are still places in downstream Android code where a negative size
is provided as width or height to the SizeBase template for set_width,
set_height and the constructor.

The DCHECK was added in:
https://chromiumcodereview.appspot.com/11410024

BUG=168927

Review URL: https://chromiumcodereview.appspot.com/11823012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175723 0039d316-1c4b-4281-b951-d872f2087c98

These classes used methods to match the webcore classes and ease
migration. Now they are at odds with the STL versions of these containers.
Rename the methods, and change arguments from indexes to iterators, to
match the STL containers.

isEmpty() => empty()
last() => back()
first() => front()
Peek() => at()
append() => push_back()
insert(index, value) => insert(iterator, value)
remove(index) => erase(iterator) and erase(iterator, iterator)
take(index) => take(iterator)
takeFront() => take_front()
takeBack() => take_back()


Review URL: https://chromiumcodereview.appspot.com/11418108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175722 0039d316-1c4b-4281-b951-d872f2087c98

|visible| value means whole candidate window is visible or not.
So should not shown auxiliary text if the window visibility is false.

BUG=None
TEST=Manually done on lumpy


Review URL: https://chromiumcodereview.appspot.com/11447007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175721 0039d316-1c4b-4281-b951-d872f2087c98

Also disable the test with this flag on 64-bit Windows as well as
32-bit Windows, since we saw a failure on 64-bit Windows too.

BUG=105778
TEST=nacl_integration
TBR=ncbray@chromium.org

Review URL: https://codereview.chromium.org/11818015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175720 0039d316-1c4b-4281-b951-d872f2087c98

This disables the case that has been flaky after the test was added in
r175701.

BUG=105778
TEST=nacl_integration
TBR=ncbray@chromium.org

Review URL: https://codereview.chromium.org/11827014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175719 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168915
TBR=sail

Review URL: https://codereview.chromium.org/11778058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175717 0039d316-1c4b-4281-b951-d872f2087c98

Implement GetResourceList, GetAccountMetadata, GetResourceEntry,
and DeleteResource.

BUG=162350
TEST=none; no changes in production code.

Review URL: https://codereview.chromium.org/11787038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175716 0039d316-1c4b-4281-b951-d872f2087c98

Reverting fix for crbug.com/138309 which caused this problem (Filed bug crbug.com/168910 to re-fix 138309 differently).

The fix for crbug.com/138309 dismisses context menus on ChromeOS when Ctrl or Alt is pressed.
This prevents context menus that allow for Ctrl clicks to work (because they are closed prematurely).

The problem that the fix for 138309 tried to address is that "tab navigation" short-cuts work but leave
context menus up. These types of shortcuts should either be blocked or dismiss the context menu.

For more info see:
crbug.com/167539 (this bug)
crbug.com/139308 (bug fix being reverted)
crbug.com/168910 (replica of 139308)

BUG=167539
TEST=manual:
Create bookmark folder with entries
Click on bookmark folder 
Control Click on an entry

Review URL: https://chromiumcodereview.appspot.com/11826012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175715 0039d316-1c4b-4281-b951-d872f2087c98

This helps cleanly move chrome/app/theme images to ui/resources.

TODO(followup): Cleanup WebUI usage of ui/resources images.
TODO(followup): Use a new handler like chrome://ui/ instead?
(that seems like a bit of work for little tangible benefit)

BUG=166075
TEST=ui/resources/ui_resources.grd IDRs are accessible like chrome://theme/IDR_CHECKMARK
R=oshima@chromium.org,sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11830002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144577


Review URL: https://chromiumcodereview.appspot.com/11824010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175713 0039d316-1c4b-4281-b951-d872f2087c98

Adding a call to clear text composition on tap gestures and also changing
the places where the text updates get sent back to the browser.

BUG=167127


Review URL: https://chromiumcodereview.appspot.com/11741036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175712 0039d316-1c4b-4281-b951-d872f2087c98

4 tests are failing to run.
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/6093/steps/sandbox_linux_unittests/logs/stdio

They were passing on FYI bot but kicking until we figure out why they
are failing here.

BUG=166704
TBR=jln

Review URL: https://codereview.chromium.org/11826019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=150920
TEST=media_unittests pass


Review URL: https://chromiumcodereview.appspot.com/11642054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162081


Review URL: https://chromiumcodereview.appspot.com/11778042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175709 0039d316-1c4b-4281-b951-d872f2087c98

Android webview intercepts download in its resource dispatcher host delegate

BUG=


Review URL: https://chromiumcodereview.appspot.com/11821011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175708 0039d316-1c4b-4281-b951-d872f2087c98

This allows release (non-official) builds to have dchecks enabled.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11644093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175707 0039d316-1c4b-4281-b951-d872f2087c98

Calls from other threads will be ignored. Currently the only DBus calls from other threads are for Geolocation. Supporting statistics gathering across multiple threads is unnecessary overhead that we don't currently need.

BUG=168134


Review URL: https://chromiumcodereview.appspot.com/11761015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175706 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11782024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175705 0039d316-1c4b-4281-b951-d872f2087c98

This adds a field trial for compressed swap.  Chrome OS picks the trial
group to be used, based on the HW address of the wifi controller.  Chrome
assigns a 100% probability to the group picked by Chrome OS.

BUG=chromium-os:37583
TEST=manually tested


Review URL: https://chromiumcodereview.appspot.com/11744024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175704 0039d316-1c4b-4281-b951-d872f2087c98

R=jsbell,dgrogan,Tom Sepez
BUG=161958


Review URL: https://chromiumcodereview.appspot.com/11791009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175703 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp

Review URL: https://codereview.chromium.org/11825020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175702 0039d316-1c4b-4281-b951-d872f2087c98

Use "--crash-test" to generate a crash in the browser process and
check that it produces a Breakpad crash dump.

This is in preparation for compiling Breakpad into Linux Chromium by
default, so that I will be able to check that crash_dump_tester.py
finds crash dumps OK on Linux.

We extend crash_dump_tester.py to launch both 32-bit and 64-bit
versions of crash_service.exe on Windows, so that we can get crash
dumps from the 32-bit browser process even on 64-bit systems.  We
introduce the cleanups_funcs list to make this cleaner.

This is not the best place to put Breakpad tests, but Chrome doesn't
have any other adequate framework for testing Breakpad at the moment.

BUG=105778
TEST=nacl_integration

Review URL: https://codereview.chromium.org/11818007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175701 0039d316-1c4b-4281-b951-d872f2087c98

This is an initial implementation of an experimental extension which
enables apps using the appv2 API to request a transparent window
background through a new flag passed to chrome.app.window.create().

How to use:
  chrome.app.window.create('xeyes.html', {
      width: 500,
      height: 309,
      // Needs "experimental" permission in manifest.json
      transparentBackground: true
  });

Basic Demo: http://codewiz.org/pub/transparent-hello-world-app

Caveats:
 - Transparent windows have a grey bar below the window title, about
   30 pixels high. (http://crbug.com/152838)

BUG=125295
TEST=demo works

R=reveman@chromium.org,mpcomplete@chromium.org,sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10986092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175700 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11746025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175699 0039d316-1c4b-4281-b951-d872f2087c98

Our bash scripts were getting complicated an unwieldy. In this
commit I port the test logic into python, as a precursor to
moving the rest of the file.

I also move the step selection logic into python which offers the following advantages:
- Less files to maintain, easier to change something globally.
- Paves way to moving most factory_properties into 'slave_properties' argument I added.  This will let us change parameters like buildtype (make vs. ninja) without a waterfall restart.  This also moves configuration into a single place.

Also:
- Refactor test runners to not require envsetup.
- Adding test report step

BUG=153707,163476, 168518

Review URL: https://codereview.chromium.org/11666023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175698 0039d316-1c4b-4281-b951-d872f2087c98

1) show hover effect on rows
2) add placeholder resources for menu buttons
3) make clicks on rows pop up the suggestion menu

BUG=157273

Review URL: https://codereview.chromium.org/11785035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175696 0039d316-1c4b-4281-b951-d872f2087c98

Move sandbox_linux_unittests away from the FYI bots and enable them
by default.

BUG=166704
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11828008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175695 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Implement DelegatingRender::drawFrame() method.
> 
> The method sends the render passes it is given to the parent compositor via
> the output surface. It should include a valid frame metadata with it.
> 
> Tests:
> DelegatingRendererTestDraw.runSingleThread
> DelegatingRendererTestDraw.runMultiThread
> DelegatingRendererTestResources.runSingleThread
> DelegatingRendererTestResources.runMultiThread
> 
> R=piman
> BUG=123444
> 
> Review URL: https://chromiumcodereview.appspot.com/11777025

TBR=danakj@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175694 0039d316-1c4b-4281-b951-d872f2087c98

This moves the GTK- and Views-specific code for alerting RenderWidgetHostView keypress listeners of keypress events into the shared method RenderWidgetHostImpl::ForwardKeyboardEvent() that all implementations bottleneck through.

Also updates RenderWidgetHostImpl::KeyPressListenersHandleEvent() to ignore events with the skip_in_browser flag set.

BUG=51644


Review URL: https://chromiumcodereview.appspot.com/11779035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175691 0039d316-1c4b-4281-b951-d872f2087c98

The method sends the render passes it is given to the parent compositor via
the output surface. It should include a valid frame metadata with it.

Tests:
DelegatingRendererTestDraw.runSingleThread
DelegatingRendererTestDraw.runMultiThread
DelegatingRendererTestResources.runSingleThread
DelegatingRendererTestResources.runMultiThread

R=piman
BUG=123444

Review URL: https://chromiumcodereview.appspot.com/11777025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175690 0039d316-1c4b-4281-b951-d872f2087c98

The script has to be aware of MIPS arch, so it can figure out that the libary
is for MIPS.

BUG= https://code.google.com/p/chromium/issues/detail?id=130022
TEST=make chrome


Review URL: https://chromiumcodereview.appspot.com/11819009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175689 0039d316-1c4b-4281-b951-d872f2087c98

cc: Map the clip_rect in the SharedQuadState to include the drawTransform of the hosting delegated renderer layer.

The clip rect is assuming that it draws to its old target space, but it will be
drawing to the target space of the delegated renderer layer, so adjust it
accordingly.

Tests:
cc_unittests:DelegatedRendererLayerImplTestSharedData.SharedData

BUG=123444
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11828011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175688 0039d316-1c4b-4281-b951-d872f2087c98