- 17 May, 2019 40 commits
-
-
Kristina Nelson authored
With this CL, if the visible URL (in the URL bar) is changed while a report is being generated for a suspicious site the original (suspicious) URL is reported. Bug: 237908 Change-Id: I8a12ef6bfabb5a865d83846894d01459a9f3860a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614450 Commit-Queue: Kristina Nelson <krstnmnlsn@google.com> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660929}
-
Sergey Ulanov authored
Previously SysmemBufferCollection could crash if it failed to initialize (e.g. due to Allocator interface missing). Change-Id: I72f83ebe7ad858ab908ad42fb08aeff895327c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614001 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#660928}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f71cccb9dc5..b45ee83cc7c0 git log 4f71cccb9dc5..b45ee83cc7c0 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 mtklein@google.com warmup learning sksl interpreter 2019-05-17 bsalomon@google.com Initial version of rescaling async readback API 2019-05-17 michaelludwig@google.com Refactor complex CTM management for image filters 2019-05-17 jvanverth@google.com Metal: Add check for invalid shader functions 2019-05-17 robertphillips@google.com Switch over to using new direct allocation API in our tests (as much as possible at least) Created with: gclient setdep -r src/third_party/skia@b45ee83cc7c0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:959412 TBR=michaelludwig@google.com Change-Id: I4bd06d7fa57cbf2c6e62a6ad2777f860dde001a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660927}
-
Jun Mukai authored
Bug: 958467 Test: trybot Change-Id: I31d7f169afddbfcef8af983bb71ca81d6b9a0b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617133Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660926}
-
Hector Carmona authored
Bug: 951915 Change-Id: I381227e4ea3719e1df8ad5b6bdffd26daacda54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603526 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#660925}
-
François Beaufort authored
This CL makes sure that Picture-in-Picture window controls bounds are not updated too rapidly, causing UX/UI issues. When a Media Session change happens, controls visibility will still be updated as before but bounds now will be updated all at once after a small delay. Bug: 960164 Change-Id: I6a66e4db76d8aeb2d56277fd46d51db1263e6c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598334Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#660924}
-
Peng Huang authored
This reverts commit 6f2c6671. Original change's description: > Revert "Fix weird artifacts during resizing browser window on Linux" > > This reverts commit 84c7124e. > > Reason for revert: It looks like this caused flakiness in OutOfProcessPPAPITest.FlashFullscreen. > > See: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests > https://findit-for-me.appspot.com/p/chromium/flake-portal/analysis/analyze?key=ag9zfmZpbmRpdC1mb3ItbWVyqAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJyY2hyb21pdW0ubWVtb3J5L0xpbnV4IEFTYW4gTFNhbiBUZXN0cyAoMSkvNjA5NTgvYnJvd3Nlcl90ZXN0cy9UM1YwVDJaUWNtOWpaWE56VUZCQlVFbFVaWE4wTGtac1lYTm9SblZzYkhOamNtVmxiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw > https://findit-for-me.appspot.com/p/chromium/flake-portal/analysis/analyze?key=ag9zfmZpbmRpdC1mb3ItbWVyqQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJzY2hyb21pdW0ubGludXgvTGludXggVGVzdHMvNzc4NjgvYnJvd3Nlcl90ZXN0cyBvbiBVYnVudHUtMTYuMDQvVDNWMFQyWlFjbTlqWlhOelVGQkJVRWxVWlhOMExrWnNZWE5vUm5Wc2JITmpjbVZsYmc9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM > > Original change's description: > > Fix weird artifacts during resizing browser window on Linux > > > > This CL uses _NET_WM_SYNC_REQUEST to synchronize with desktop > > compositor during resize. > > Without this CL, resize steps are: > > 1. Desktop compositor(WM) resizes chrome browser window. > > 2. Desktop compositor draws a new frame with the current browser window > > without waiting chrome to complete handle the ConfigureNotify event. > > For SW rendering, compositor uses the content before resizing. It will > > out of synced size between compositor and chrome. > > For GPU rendering, compositor uses the framebuffer before resizing, the > > behavior is undefined. It cause weird artifacts. > > 4. Desktop compositor go to step 1, to issue a new resize. > > 5. Chrome finished handle the ConfigureNotify and rendered a new frame. > > 6. Desktop compositor draws a new frame again with right size. > > > > With this CL, resize steps are: > > 1. Desktop compositor sends client message _NET_WM_SYNC_REQUEST to notify > > about the incoming resize > > 2. Desktop compositor WM resizes chrome browser window. > > 3. Desktop compositor waits on an alert on value change of a XSYNC counter > > on chrome window. > > 4. Chrome handles the ConfigureNotify event, and renders a new frame. > > 5. Chrome increases the XSYNC counter on chrome window. > > 6. Desktop compositor gets the alert of counter change, and draws a new > > frame with new content from chrome. > > 7. Desktop compositor responses user mouse move events, and starts a new > > resize process, go to step 1. > > > > > > Change-Id: I51aafe03b8aac73ce6570976bbe36c6f4d86531a > > Bug: 961858 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602285 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: kylechar <kylechar@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#660532} > > TBR=penghuang@chromium.org,sky@chromium.org,kenrb@chromium.org,kylechar@chromium.org,piman@chromium.org,thomasanderson@chromium.org > > Change-Id: I863ea3a4bb6b39fd3c65c4ea1dbbb56072988a26 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 961858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616384 > Reviewed-by: Collin Baker <collinbaker@chromium.org> > Commit-Queue: Collin Baker <collinbaker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660669} TBR=penghuang@chromium.org,sky@chromium.org,kenrb@chromium.org,kylechar@chromium.org,piman@chromium.org,thomasanderson@chromium.org,collinbaker@chromium.org Change-Id: I07808d24f4ada85b923aafb8898be3c3431a17b7 Bug: 961858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617681Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#660923}
-
Stephen Chenney authored
The Blink.ForcedStyleAndLayout.UpdateTime metric has too many samples and sometimes overflows the sample counter in a 30 minute period. So randomly choose to sample with 1/100 probability. The Blink.Compositing.LayerPromotionCount.IndirectComposited UMA has a bigger range than the histogram, so increase the max value and the number of buckets. Bug: 950600,950540 Change-Id: I8bd9bf30ed73c4ef61742ab4664c6eb4e5c8ae18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613748 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#660922}
-
Yulun Wu authored
Bug: 963648 Change-Id: Ib5a5519b712b1c850edf2be2ac3e311a3fcecdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614000 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#660921}
-
Sean Gilhuly authored
Unify LayerTreePixelTest::PixelTestType and CopyRequestTestType, move to LayerTreeTest, and replace |use_skia_renderer_| and |use_software_renderer_| with checks to |renderer_type_|. Bug: 948128 Change-Id: Iacce32ebfb5a57fc28819f5e6a6346ebcc4d5bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606573 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#660920}
-
Sunny Sachanandani authored
Bug: 953970 Change-Id: I76e43baaaa66ce83377113cee878afbb7696bfb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615433Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#660919}
-
Lucas Furukawa Gadani authored
This is also enforced with a renderer kill in case the browser receives a non-HTTP navigation request. Bug: 962500 Change-Id: Id7c122ba80ef1cc00620d07d5ecdb1f268b04d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615499 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660918}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8da525341e22..cd707e6f223e git log 8da525341e22..cd707e6f223e --date=short --no-merges --format='%ad %ae %s' 2019-05-17 bclayton@google.com Kokoro: Build macOS builds with debug info 2019-05-17 bclayton@google.com Fix warning treated as error Created with: gclient setdep -r src/third_party/swiftshader@cd707e6f223e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:963658 TBR=swiftshader-team+autoroll@google.com Change-Id: Ic294638c31bc1df774eb78e4527b6252c64b8998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616731Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660917}
-
Tina Wang authored
Change the confirmation string from "Sending tab..." to "Sending to [target device name]". Bug: 953357 Change-Id: I5a0083859c17c8fd318158510749a863bc442b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616944Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#660916}
-
Eric Roman authored
Bug: 959020 Change-Id: Iaf1c0e39105297271c2ec10356985507e565c82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616010 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#660915}
-
David Bokan authored
This reverts commit d77c5029. Reason for revert: Causing issues in 962784 and 951901 Original change's description: > Move Viewport reset into DirectManipulationEventHandler > > The crash report shows DirectManipulation may call > DirectManipulationEventHandler OnViewportStatusChanged > to READY state after DirectManipulationHelper Destroyed > then crash because we called Reset to invalidate DMHelper. > > In this CL, we pass the viewport size to DMEventHandler > and use it to reset viewport at gesture end. Also > DMEventHandler does not need to store pointer of DMHelper. > > Bug: 951293 > Change-Id: I39a3402659b9ae117ab45288b68dd5d595e58457 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562153 > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649712} TBR=sky@chromium.org,chaopeng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 951293 Change-Id: I5174d7045b5c1f369c3c8c1f259dd057928c1bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617685Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660914}
-
Thomas Anderson authored
This reverts commit 77bee671. Reason for revert: Causing build failure on Linux CFI: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/13589?blamelist=1#blamelist-tab Original change's description: > Update V8 to version 7.6.208. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/92b8322b..aee77b6e > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Iedd56b02146c60d8bb3bed26c81f0402ef834fe4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617683 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#660886} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I372ba3cdb7200ba852a86fd7154bc39976f3d6af No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617909 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#660913}
-
Tom Anderson authored
This change just removes some non-source files from the sources of some static libraries. No behavior changes. BUG=964411 R=rdevlin.cronin Change-Id: Ib34546f665940111da23cf89d7ada8854b79a03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615678 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#660912}
-
Sebastien Marchand authored
The new metrics will indicate the state of the tab Chrome is switching to (loaded/frozen) and will give more information about the impact of tab freezing on tab switch time. All the functions that takes a |tab_switch_start_time| argument have been updated to accept a newly defined TabSwitchStartState structure instead, this allows passing more information about the tab switch event to the TabSwitchTimeRecorder class. Change-Id: I56e1697dcc78b46a6f680b1ef1a8a483289a26e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594924 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#660911}
-
Xiyuan Xia authored
Bug: 958208 Change-Id: I61bc4788f7ffac45d8d264881ff28c8420866836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617705Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660910}
-
Alex Cooper authored
In order to make the input sources list into a live object, which can be updatd in place, we needed to make it no longer return a FrozenArray. This requires changing it to it's own XRInputSourceArray type, and changing how it is accessed from a getter to an attribute. Note that this change does not actually make the inputSources object a "live" object just yet, but is simply all of the idl/interface changes necessary for that work to happen. Bug: 962809 Change-Id: I343d80f8473699df29cf2e1c56742286a2cacabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614700Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#660909}
-
Victor Fei authored
- Implemented firing property changed event for UIA_AriaPropertiesPropertyId and associated unit and browser dump tests for the following AriaProperties: - setsize - sort - valuemax - valuemin - valuenow - valuetext - Breakdown of UI Automation AriaProperties need to be implemented: atomic [part 1] busy [part 1] channel [part 2] checked [part 1] disabled [part 3] dropeffect [part 2] expanded [part 1] grabbed [part 2] haspopup [part 1] hidden [not implemented] invalid [part 1] level [part 3] live [part 3] multiline [part 1] multiselectable [part 3] posinset [part 4] pressed [part 4] readonly [part 4] relevant [part 4] required [part 1] secret [part 2] selected [part 1] setsize [part 5, this cl] sort [part 5, this cl] tabindex [part 2] valuemax [part 5, this cl] valuemin [part 5, this cl] valuenow [part 5, this cl] valuetext [part 5, this cl] - Documentation on UI Automation AriaProperties (see the second table's last column for AriaProperties properties): https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification - Link to part 1, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1574834 - Link to part 2, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1576280 - Link to part 3, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1589100 - Link to part 4, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1592640 - Link to part 5, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1591487 Bug: 928949 Change-Id: I88a4f1e8c53ab8f05f34ae2036e99e276305091b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591487Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660908}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b1d937f4218e..6ea34ccba4c6 git log b1d937f4218e..6ea34ccba4c6 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 jbudorick@chromium.org Split out gn configurations for devil, gsutil, telemetry, and typ. (RELAND 2) Created with: gclient setdep -r src/third_party/catapult@6ea34ccba4c6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:790202 TBR=simonhatch@google.com Change-Id: I9bf9e3b5b342e65a493148767fa83f5a1edc58cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616727Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660907}
-
rajendrant authored
There is some difference with M74 and M75, that the WarmupURLFetcherCallback.SuccessfulFetch.*.Core is recorded in M75 and *.NonCore. The test is fixed to expect on any of the histograms. Also fixes a logic typo in video test. Bug: 964156 Change-Id: I5408b10cac26dc616980177bdbd317e3e90a3da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617202 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#660906}
-
Philip Rogers authored
The render throttling code is very complex and is poorly understood (see recent bugs: https://crbug.com/963782, https://crbug.com/962382, and https://crbug.com/942022). This patch simplifies this code by removing a special-case for invalidating touch action rects in RenderThrottlingStatusChanged which was different from the other invalidations in the function. Touch action rects are now calculated in the paint lifecycle step and do not need special invalidation logic. This special touch action rect invalidation was added in https://crrev.com/388479, which pre-dated PaintTouchActionRects: https://docs.google.com/document/d/1ksiqEPkDeDuI_l5HvWlq1MfzFyDxSnsNB8YXIaXa3sE/view Change-Id: Ie5172918dc4de7935372ebc91b9f71f7a37be824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617630 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#660905}
-
Tao Bai authored
This patch sends updated content from renderer to browser processs, and notifies ContentCaptureConsumer of the update. Bug: 952973 Change-Id: I88c704e1ac0532326f52ccc1db727943992cb5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610033Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660904}
-
Collin Baker authored
virtual/threaded/external/wpt/css/css-scroll-snap/scroll-margin.html is flaky. TBR=lukebjerring@chromium.org Bug: 964239 Change-Id: I301934437f21cd732e5ad8956e615ee6a1047943 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617094Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#660903}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/23e25e0bb4dc..819795047c32 git log 23e25e0bb4dc..819795047c32 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 dburger@chromium.org Remove reef from postsubmit. Created with: gclient setdep -r src/third_party/chromite@819795047c32 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ia93186ea7272e8e6d0178d59732075624c3a524d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660902}
-
Daniel Rubery authored
Currently, nobody calls GenerateFileHash(), and GenerateFileHash() is the only caller of DownloadBinHashNeeded(). So both methods can be safely removed. Change-Id: I6f2849c022f1646cc9ce5bcfb45f33e154307118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614439Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#660901}
-
Eugene But authored
Files in this target are not used in Chrome for iOS app. Bug: 585700 Change-Id: Ib3a6b497a200f8c5afadf07b36a29c067b574f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614462Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#660900}
-
Gayane Petrosyan authored
When user selects new custom background, use thumbnail from image collections to fetche and calculate calculate the most frequent color on the image. The calculated color is then stored in prefs with the rest of the background info. Bug: 874325 Change-Id: I5905b583f22174a491749543e922512e6b47caf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612235 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#660899}
-
Amr Aboelkher authored
Bug: 934920 Change-Id: I42bf20d65f9dec5dd02775439e10843b3f3fa02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617494 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#660898}
-
Mohammad Refaat authored
Change-Id: I1120f0b982b28f7854098fbdd91190ccd9c82a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614964Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#660897}
-
Patrick Monette authored
This is a reland of I2158afd065fe81cb5350711653359983d9b790e5 Original change's description: > Move chrome/browser/conflicts to chrome/browser/win/conflicts > > This allow us to remove all the _win suffixes to every files in the > directory. > > This CL contains no functional change. In addition to the directory > move, I only fixed file names (removing the _win suffix) and formatted > the resulting CL. > > Change-Id: I2158afd065fe81cb5350711653359983d9b790e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593724 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659208} Change-Id: I54ab2aa05e5fb55b5e61cb691617522e6b07fcac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610499Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#660896}
-
Boris Sazonov authored
Disables testDisabledNoDownloadBookmark and testDisabledNoUploadBookmark tests as they are flaky. Failed builder link: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester/13072. TBR=treib@chromium.org Bug: 964342 Change-Id: I88d188a9933ddade6bcd8e607af7b08af524bba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617765Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#660895}
-
Mike Dougherty authored
In order to enable persistent histograms on iOS, the code needs to be moved to components. The only dependancy on //chrome was the path to store the metrics which was moved to a function parameter. Bug: 963504 Change-Id: Id2240a1ae1c1bfb4124d783b210a59caa1fcc0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614294Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#660894}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cafd7736490e..09eabed99d0e git log cafd7736490e..09eabed99d0e --date=short --no-merges --format='%ad %ae %s' 2019-05-17 cnorthrop@google.com Allow attribute linking for ES2 Created with: gclient setdep -r src/third_party/angle@09eabed99d0e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I13749562b6e2c9d7ab0d8f63acf662c3aeda04c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617555Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660893}
-
Mark Mentovai authored
In the old layout, most of the application exists at Google Chrome.app/Contents/Versions/76.0.3797.0. Google Chrome Framework.framework and others are present in that directory. In the new layout, most of the application exists at Google Chrome.app/Contents/Frameworks/Google Chrome Framework.framework/Versions/76.0.3797.0. A single build of Chrome creates and supports running from only one of these layouts, controlled by the new_mac_bundle_structure GN argument, currently defaulting to false, but defaulting to true in the future, and being removed entirely farther in the future. The updater, which is mostly keystone_install.sh, needs do the following: 1. Update the old layout to the new layout, for transitions. 2. Update the new layout to the new layout, for subsequent updates. 3. “Update” the new layout to the old layout, to handle the possibility that we may switch to the new layout and then need to (temporarily) switch back. 4. Update the old layout to the old layout, to decouple this change from the layout switch, so that this can land independently and, if a layout revert is needed, so that this doesn’t need to be reverted. Of these four possibilities, this is the only one that the updater previously implemented. This change adds full support to keystone_install.sh for all four of these scenarios. This also needs to function for both full and differential updates. To that end, support is added not only to keystone_install.sh but also to dmgdiffer.sh, the script responsible for creating diff updates. dmgdiffer.sh is also updated to support all four scenarios above. Layout-changing diff updates are not true diffs for the vast majority of an update package, although we hope to only ship one diff per channel for scenario 1, and we hope not to need to exercise scenario 3 at all. Despite not being true diffs, updaters produced by dmgdiffer.sh will still be bettter-compressed than the traditional full installers due to the use of tighter xz compression on entire files, compared to the disk image’s bzip2 blocks. keystone_install.sh will correctly consider both old and new layout locations when removing old versions of Chrome. When all versions using the old layout have been removed, the old layout’s versions directory will also be removed, paving the way for removal of the codesigning resource rule exception (bug 496298) and proper notarization (bug 850199). Bug: 964023, 958976 Change-Id: I6bc3edc501824873d15344ee718ae08948e7fb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615450Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#660892}
-
Nicolas Ouellet-payeur authored
Bug: 963930 Change-Id: I481bda4248d6e354cacd9e4c7ee20e6d4076136d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614754Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#660891}
-
Chandani Shrestha authored
Preferences pane had following accessibility issues and is fixed as follows: - The top heading was in h3. Fix: Updated h3 to h1 - Subcategories was missing heading role of h2 and group roles for subcategories was missing Fix: Added role heading of level 2 Fix: Added role group to each sub categories - Label for drop-downs were not linked with select element so, screen reader wasn't reading out for drop-downs. Fix: Added 'for' attribute in label with id value of drop-down select element Change-Id: I64d433522c814b8f65ced29958524ac175d987ac Bug: 963183 Video showing Preferences pane after this change https://imgur.com/caUMd46 Change-Id: I64d433522c814b8f65ced29958524ac175d987ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600533Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660890}
-