GitLab

Implicit initialization of the global FeatureList via accessor is always
triggered by some specific Feature, so note the Feature and alias its
name to be included in CHECK crash reports, on failure.

Bug: 1031427
Change-Id: Id37466205b4beb0c408ebeabe29196c2c1b467fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956362
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723264}

Originally, when we reset VaapiVD and V4L2SVD when we need to change
resolution, we would cancel setting the frame pool the new resolution.
Also, the state of V4L2SVD would stay at kFlushing, and V4L2SVD won't
decode the coming buffers after reset.

This CL fixes this issue by updating V4L2SVD's state after reset is
done. We also re-create the AVD. With that, AVD will ask the client to
update the resolution when decoding the first bitstream after reset.

Bug: 1018817
Bug: 1028406
Test: pass tast.video.SeekVDSwitchH264 on Kevin and Eve for 10 times
Test: pass video_decode_accelerator_tests on Kevin and Eve

Change-Id: I486e4368c3a4b249af16e44319c916da781066d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948010
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: David Staessens <dstaessens@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723263}

Per recent discussions in scheduler-dev@ [1], we do not want to expose
the current task runner because it's easy to hold it wrong.

tl;dr is that library code doesn't know who called it and from which
context, so it should use default task runner as a safe option.

Remove the few usages that managed to find its way into the codebase.

[1] https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit

R=gab@chromium.org,darin@chromium.org
TBR=asanka@chromium.org
CC=​alexclarke@chromium.org,qinmin@chromium.org,xingliu@chromium.org
BUG=1026641

Change-Id: I30d09995d89f5db31ae431fdf52264b16c9eddaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958424Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723262}

This CL converts InputEngineManager mojom interface clients for
extensions in chrome to use BrowserInterfaceBroker.

Bug: 936482
Change-Id: Iecc57f2a8c15a9523f08e4ab49156273a2ba4677
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952623
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#723261}

Generated using:
~~
directories="content chrome components"
regex="DisableForRenderFrameHost(\(([^\(\)]++|(?1))*\))"
label=$(grep -Pzoh $regex -r $directories \
         | tr -d '\000' \
         | grep -Po '\"[^"]+"' \
         | tr -d '"' \
         | sort -u
)

echo "<enum name=\"BackForwardCacheDisabledForRenderFrameHostReason\">"
for i in $label
do
  hash=$(echo -n $i | md5sum | tr -d ' -')
  hash=${hash^^}
  hash=$(echo $hash | head -c 16)
  hash=$(echo "ibase=16; $hash" | bc)
  hash=$(echo "($hash + (2^31)) % (2^32) - 2^31" | bc)
  echo "  <int value=\"$hash\" label=\"$i\"/>"
done
echo "</enum>"
~~

R=carlscab@google.com

Change-Id: I8e63dc2f5509eb0c5b954219286e5a0dabeb8fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946053
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#723260}

There are some crashes where it seems that
GuestOsSharePath has been destroyed when
FileWatcher callbacks run.

This change fixes all code which runs in the
FileWatcher sequence to not access the
GuestOsSharePath object, but rather
post tasks to the UI thread where a WeakPtr
is used before running any code on the
GuestOsSharePath object.

Bug: 1031080
Change-Id: Ia8acae392eabf4f3d13847dbd7331c3321fba410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956981Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723259}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I9dd1ac85b0bfd63aeb4f67cd271314f73ea36d3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959836Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723258}

This CL fixes text size to match more with NTP feed articles.
1 - The text size of prefetch and content indexing cards to 16sp
2 - The line height is set to 24dp

Bug: 1031798
Change-Id: I7ae77e48d230a0226ca3b0ed0d27acaa1cf313f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956532Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723257}

FooForSubtree -> Foo
FooForSubtreeInternal -> FooForSubtree

R=dmazzoni,akihiroota

Change-Id: Id518f3bf1c3f9a06f78be76b95068d29d0032630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949813
Commit-Queue: Chris Hall <chrishall@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723256}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f3d5744f68c..f8b5d7b892f1


Created with:
  gclient setdep -r src-internal@f8b5d7b892f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I329cbac95e6ae4d63d7e203063f16fb89292bf53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959835Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723255}

Bug: 1032421
Change-Id: Ifc218eefd1eb4ac8eeb201586e54bca9193302bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959236Reviewed-by: Jay Harris <harrisjay@chromium.org>
Commit-Queue: Robert Woods <robertwoods@google.com>
Cr-Commit-Position: refs/heads/master@{#723254}

Bug: 647430
Change-Id: I275a01c5f310b5fee0bc40d06d0ffaf24c3486e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959225Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723253}

The plan is:
1. Introduces NDEFRecord{Init}#id and supports reading.
   Already done by crrev.com/c/1861574.

2. Supports writing.
   crrev.com/c/1928891 is focused on impl in Blink, with the following
   CLs focused on impl in Device Service.
     crrev.com/c/1910906
     crrev.com/c/1911385
     crrev.com/c/1915940
     crrev.com/c/1916261

3. Introduces NFCScanOptions#id and filters records by it when scanning.
   Done by crrev.com/c/1936187.

4. Removes NDEFMessage{Init}#url and old impl of the author record.
   This CL.

The spec changes:
https://github.com/w3c/web-nfc/pull/338
https://github.com/w3c/web-nfc/pull/340
https://github.com/w3c/web-nfc/pull/446

BUG=520391

Change-Id: Id1c29d980426a5559fd6e30aa0fc95b268d8e96c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938835
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#723252}

Finding layer by index is not reliable in core tests (though acceptable
in platform tests). Now use the functions in find_cc_layer.h in core tests
to replace PaintArtifactCompositor::ExtraDataForTesting().

This is needed by https://chromium-review.googlesource.com/c/chromium/src/+/1956968
which changes the order of viewport scrollbar layers causing a lot of
failure in web_layer_test.cc which found layer by index.

Also move renderer/core/exported/web_layer_test.cc to
renderer/core/paint/compositing/compositing_test.cc because we no longer
have WebLayer. The place will be the home of end-to-end compositing tests
for both CAP and pre-CAP.

Change-Id: I558d291efd49ad9c52780a59bc53f2b5d2757022
Bug: 1028079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956972Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723251}

In case of main frame being aborted, if there is damage (from Impl)
it will be PresentedFrame or DidNotPresentFrame, and if there is no
damage at all will be DidNotProduceFrame. So the state of
kMainFrameAborted is not needed.

Bug: none
Change-Id: Ia62c98056e0edc7b70e727d29e90f3679a7c6846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953196Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723250}

For Web apps, close all tabs to close the opened window, which is
similar to the current Close function in context menu:
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/shelf_context_menu.cc?q=controller_-%3EClose&l=125&dr=C
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc?q=AppShortcutLauncherItemController::Close&l=251&dr=CSs

Otherwise, show pause information in browsers.

BUG=1011235

Change-Id: I2f2e6d761cb2861ae4540d64def25fc0b70ea6e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956967
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723249}

Adding for the PaintHolding Field Trial as required.

Bug: 1012732
Change-Id: I68bbc438f39d3859f9752d6f87798e5d56507517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959686
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723248}

SkiaOutputDeviceGL wasn't using a buffer format that could support HDR
content when using an HDR color space. Check if color space is HDR and
then use GL_RGBA16F in that case.

Bug: 985500
Change-Id: I9db010f990d0e57b7406e0eb2bd51d80337b968b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954282Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723247}

R=dmazzoni,akihiroota

Change-Id: Ie0a291c71c9698f3e7b17f29a9ddad196b71b032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949811
Commit-Queue: Chris Hall <chrishall@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723246}

Bug: b/141518780
Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and
validate all function of CCA on HALv1/v3 device works correctly.

Change-Id: Id5ca3db1bbd5f1af4cd728566266c596d2c1bfd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957607
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723245}

Bug: b/141518780
Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and
validate all function of CCA on HALv1/v3 device works correctly.

Change-Id: Ifd4e601cd6f8ba25d32edcae7a1e68d4d4082163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954994
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723244}

This CL converts MediaRouter mojom interface clients for
extensions in chrome to use BrowserInterfaceBroker.

Bug: 936482
Change-Id: I963dd3faa2fb4af8634d8f57c3e93cd68344e639
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952553
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#723243}

monochrome_apk_checker requires proguard, which will shortly be turned off for
android-kitkat.

Bug: 1029936
Change-Id: I8de9705cc7fcd93b5e819a1897d62afdd2f27ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946178
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723242}

crrev.com/c/1939845 renamed some instances of webgl2_conformance_tests
to webgl2_conformance_validating_tests, but it didn't update the
corresponding exceptions. mac_optional_gpu_tests_rel is running those
tests on the retina fleet as a result, even though that fleet is far too
small to support running the suite.

Bug: 1028850
No-try: true
Change-Id: I1fbc61b92de187bd83a3c1c5febec2502d32a441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959332
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723241}

This will make the code a lot simpler.

We will follow up with a CL that removes the 'caching' code within
ime_controller since the interface is no longer async.

Bug: 1023574
Change-Id: I995ae92d9f8ba9c4de557744443fc44f93ba7de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923871
Auto-Submit: Darren Shen <shend@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723240}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12269abbc75b..8f3d5744f68c


Created with:
  gclient setdep -r src-internal@8f3d5744f68c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: If2da1b373d5b58d401bc134910efe1320213270e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959565Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723239}

Make it more obvious "rm -rf" is happening.

Bug: 1009837
Tbr: juncai@chromium.org
Change-Id: I1f8e9e285a41f9ce6be1d324083e9d4330a6ace2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951707Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723238}

Test: Unit tests + manual comparing UI against mocks.
Bug: chromium:930901
Change-Id: Ie1203ca528f66c8348ab27f47a851f1e8b0a76d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947868Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: David Munro <davidmunro@google.com>
Auto-Submit: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#723237}

https://dawn.googlesource.com/dawn.git/+log/792ff476ce66..ff8b3f439723

git log 792ff476ce66..ff8b3f439723 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 enga@chromium.org Inline CommandAllocator/Iterator
2019-12-09 yunchao.he@intel.com Implement readonly storage buffer on OpenGL backend
2019-12-09 yunchao.he@intel.com Implement readonly storage buffer on Metal backend
2019-12-09 yunchao.he@intel.com Implement readonly storage buffer on D3D12 backend
2019-12-09 yunchao.he@intel.com Use GetBindGroupLayout in GpuMemorySynchronizationTests

Created with:
  gclient setdep -r src/third_party/dawn@ff8b3f439723

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I6e9ff997d0f7d2edd3ae11b53c3d37c402ef279b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959429Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723236}

This reverts commit df8539c0.

Reason for revert: More complete fix in CQ
https://chromium-review.googlesource.com/c/chromium/src/+/1959332

Original change's description:
> Remove webgl2_conformance_validating_tests from Optional Mac NVIDIA bot
> 
> Not enough capacity, was added by mistake in
> https://chromium-review.googlesource.com/c/chromium/src/+/1939845
> 
> TBR=kbr
> 
> Bug: 1032417
> Change-Id: Ic911dfd9937b19c00288e4220420d1ae94b0fccc
> No-try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959531
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#723229}

TBR=ynovikov@chromium.org,kbr@chromium.org

Change-Id: I11765e924bb2a664ccca2cb05e89352a1f4e830b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1032417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959769Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723235}

Bug: 1030411
Change-Id: I0696686982f1a089dc554013847ab4a2dafce83b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956529Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723234}

When "Create Shortcut" is selected on a page that has a manifest, we
currently use all manifest values but keep the scope empty to
ensure the shortcut app is treated differently to a PWA. This CL
removes the special casing and different treatment.

Also moves the default displayMode setting to web_application_info
instead of setting it in UpdateWebAppInfoFromManifest even when it
was not set in the manifest.

Bug: 910016
Change-Id: I61c29793d4dfec2db8342eb4e568fb422e531aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950367
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723233}

The dialog can be opened and closed and displays dummy background
colors. Selecting background colors does not work.

Bug: 1030459
Change-Id: I2ec6e75bdd8fc9b9d7464cf67e4f88e7a5c0068e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956273
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723232}

Bug: 268984
Change-Id: I36fc3bff7b2805ac6d950b2b6a56179169c05d06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954533
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723231}

- Detangle the plugin and non-plugin portion of a function in
  browser_root_view.cc.
- Remove unneeded plugin headers in content_setting_bubble_contents.cc.
- Fix lint errors.

Bug: 1027360
Change-Id: I23780549c0985853fd1a9f3ef37aec1e396be80a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951127Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723230}

Not enough capacity, was added by mistake in
https://chromium-review.googlesource.com/c/chromium/src/+/1939845

TBR=kbr

Bug: 1032417
Change-Id: Ic911dfd9937b19c00288e4220420d1ae94b0fccc
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959531Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723229}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: Ie57081a7dee3eebde311a3bd9747bcb7d446da05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959846Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723228}

This is the same implementation as the current HandlePlayStoreLaunch:
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc?q=ArcAppWindowLauncherController::HandlePlayStoreLaunch&l=527&dr=CSs

This CL also fixes the unit test:
ChromeLauncherControllerArcDefaultAppsTest.PlayStoreLaunchMetric

BUG=1011235

Change-Id: I2d7ae9e9dad18fc42eb72e1d087ef7315a1edcd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954816
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723227}

WebBundleURLLoaderFactory::EntryLoader() gets a list of accept languages
from prefs, and WebBundleReader uses it to compute best matching variant.

Bug: 1029406
Change-Id: If42d89c5b1474788599743b8d3221ffcce9344db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952567Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723226}

Bug: 1019296
Change-Id: I9baadffa0b75a8f9bb03bb88bb98a804ffefa0b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946933Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Archana Simha <archanasimha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723225}