- 02 Jan, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b87374f9130f..191e64b6c6c2 git log b87374f9130f..191e64b6c6c2 --date=short --no-merges --format='%ad %ae %s' 2019-01-02 reed@google.com pass a font to GlyphRunBuilder 2019-01-02 kjlubick@google.com [canvaskit] Move to using SkFont instead of SkPaint.measure* 2019-01-02 benjaminwagner@google.com [infra] Uninstall ASAN when cleaning up Android device. 2019-01-02 egdaniel@google.com Add initial support for creating a vulkan secondary command buffer drawing context. 2019-01-02 reed@google.com Revert "undefine SK_SUPPORT_LEGACY_PAINT_TEXTMEASURE" 2019-01-02 brianosman@google.com Remove special case for DCI P3 when making ICC profiles 2019-01-02 ianloic@google.com Update SkFontMgr_fuchsia.cpp for new FIDL API 2019-01-02 herb@google.com Return SkGlyphCache and GrTextStrike together. 2019-01-02 fmalita@chromium.org [skottie] Initial 3D layer transform support Created with: gclient setdep -r src/third_party/skia@191e64b6c6c2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Icac1bcfd5a51c1805220f37b09a0471235fb7d17 Reviewed-on: https://chromium-review.googlesource.com/c/1393354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619519}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a3b1ce7ab6d..bbd8fc1f9fa4 Created with: gclient setdep -r src-internal@bbd8fc1f9fa4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1ae7da720290d16f081ea108c25ec6ea619190c5 Reviewed-on: https://chromium-review.googlesource.com/c/1393414Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619518}
-
Michael Ludwig authored
Bug: 915735 Change-Id: Ie574420c2c6bda5da5cc3ba531e2ca3cdcae6b56 Reviewed-on: https://chromium-review.googlesource.com/c/1391305 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619517}
-
Leonard Grey authored
Bug: 918194 Change-Id: I4ffe380241ebaf46adac236535e8138729bfd227 Reviewed-on: https://chromium-review.googlesource.com/c/1393523Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619516}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8a0bd0021b2ab23c0154a3a668bf018cc8df5322 Reviewed-on: https://chromium-review.googlesource.com/c/1393413Reviewed-by:
-
Maxim Kolosovskiy authored
New heuristics look for <a>, <div> and <span> tags that contain button features (e.g. "button", "submit") in id/name/class attributes. Button titles are crowdsourced and used for better password generation classification. Bug: 910546 Change-Id: I162353a480065e80403a1eebafccceb428c80e43 Reviewed-on: https://chromium-review.googlesource.com/c/1367659 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#619514}
-
CJ DiMeglio authored
This is a reland of 543a2def Original change's description: > Reland "Reland: [Accessibility] Volume slider reads out level in percentages." > > This is a reland of d018c076 > > Original change's description: > > Reland: [Accessibility] Volume slider reads out level in percentages. > > > > This is a reland of change I0ee5a91215669f39c7394d3c8f113ae83a74cf00 > > > > This CL makes it such that the volume level is read out as a percentage > > in aria. This CL also amplifies how the accessibility information is > > given to aria, by setting attributes instead of explicitly creating > > accessibility nodes. > > > > TBR=thakis@chromium.org > > > > Bug: 905024 > > Change-Id: I831d9ed1f1790556d1a58431f3aaf9562c2c9043 > > Reviewed-on: https://chromium-review.googlesource.com/c/1373032 > > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#617338} > > TBR=thakis@chromium.org,dmazzoni@chromium.org,mlamouri@chromium.org > > Bug: 905024 > Change-Id: Ie308a4b30032491333072681fcf214a9fab58d5c > Reviewed-on: https://chromium-review.googlesource.com/c/1383307 > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618940} TBR=thakis@chromium.org,dmazzoni@chromium.org,mlamouri@chromium.org Bug: 905024 Change-Id: I8e4737b5ddea923f9ccef9ea5ec65485f5f63f66 Reviewed-on: https://chromium-review.googlesource.com/c/1391296Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#619513}
-
Prashant Malani authored
Add a new constructor for RenderViewHostTestHarness (and its derived class ChromeRenderViewHostTestHarness) to include ScopedTaskEnvironment parameters. This will allow the test harness classes to use the ScopedTaskEnvironment's task runner for mock time task runners, instead of instantiating a separate TestMockTimeTaskRunner. This CL also modifies the UserActivityManagerTest unit tests to leverage this in-built ScopedTaskEnvironment and remove the mock time task runner, and also makes the FakeSmartDimModel implementation utilize the task runner for posting tasks, to better mimick real-world behaviour. Bug: 893425, 914640, 917580 Test: - Builds and boots, inference calls checked via logs on nocturne - All related unit tests still pass. Change-Id: I552ae98f6b2bce88845d17648303001a3c644788 Reviewed-on: https://chromium-review.googlesource.com/c/1389963 Commit-Queue: Prashant Malani <pmalani@chromium.org> Reviewed-by:Jia Meng <jiameng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#619512}
-
kdillon authored
Disallow sync XHR during page dismissal when the page is being navigated away or closed by the user. Sync XHR is already on the deprecation path and its usage hurts end user experience. Rolling this out behind a base::Feature to help mitigate risk. This feature is disabled by default. Bug: 827324 Change-Id: I32cb71c3896281c1311ee32de3e7e434ba80322b Reviewed-on: https://chromium-review.googlesource.com/c/1336914 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#619511}
-
kdillon authored
Currently the limit on end-of-life handlers when the user navigates or closes a tab is 1s. This change restricts that to 500ms which accomodates at the 99.9th percentile. Bug: 832234 Change-Id: I09c9038dbe184910e44664e6d33b1b530c2645ae Reviewed-on: https://chromium-review.googlesource.com/c/1384790Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#619510}
-
Aga Wronska authored
New button is only visible for child user account. It allows parent to authorize unlocking child's device. Parent access button is displayed on lock screen shelf when the device is locked because of time limits. It might be extended to login screen shelf in the future to authorize additional actions on child's device. Parent access button is a part of Parent Access Code feature developed behind kParentAccess flag. Bug: 911326 Test: LoginShelfViewTest Change-Id: I9b513fb6f00ba7882686094761e5528ab3d475fd Reviewed-on: https://chromium-review.googlesource.com/c/1389166Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#619509}
-
James Cook authored
Turns on the window service (code in //services/ws) and uses it to back aura and views (code in //ui/aura/mus and //ui/views/mus). Runs the window service in-process. A label "SingleProcessMash enabled" will appear on the desktop wallpaper to let developers and QA know the feature is enabled. The label will be removed in a separate CL before this feature goes to dev channel. Otherwise there are no visible changes. Flips the former "single_process_mash_*" bot configs to "non_single_process_mash_*" and runs them with the feature disabled. This should keep the old code paths working until we're sure this feature will stick. TBR=sky@chromium.org BUG=918537 TEST=single_process_mash_* bots Change-Id: I58a30fd81ea12645b1aabc049c7e697ef1d9e72a Reviewed-on: https://chromium-review.googlesource.com/c/1393467Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#619508}
-
Brandon Wylie authored
Adding method to native to get image/favicon urls so they can be fetched in native. Bug: 831629 Change-Id: I4ec1be9f1de41471940ec63ce1830eabd11bb356 Reviewed-on: https://chromium-review.googlesource.com/c/1374958 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#619507}
-
John Chen authored
W3C spec allows the app to specify pauses within Perform Actions command (https://w3c.github.io/webdriver/#dfn-dispatch-actions). Updating ChromeDriver to handle these pauses. Bug: chromedriver:1897 Change-Id: I533179f4a9f2216bfacf0f4fdb539c8f898bed07 Reviewed-on: https://chromium-review.googlesource.com/c/1392281 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#619506}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f7c835487e0..bba675db3eb4 git log 5f7c835487e0..bba675db3eb4 --date=short --no-merges --format='%ad %ae %s' 2019-01-02 steveanton@webrtc.org Clean up api/ DEPS 2019-01-02 crodbro@webrtc.org Renamed a variable in overuse_detector. Created with: gclient setdep -r src/third_party/webrtc@bba675db3eb4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie250d08861ab825fae5dba359b5b7a80018e500f Reviewed-on: https://chromium-review.googlesource.com/c/1393412Reviewed-by:
-
Raul Tambre authored
Bug: 167187 Change-Id: I4b8dfc38ab8b818f0b8af7dbaa7688797ddb40d7 Reviewed-on: https://chromium-review.googlesource.com/c/1393336Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619504}
-
Peter Wen authored
Easier copy/pasting when ensuring updates or additions are no-ops. Bug: 913062 Change-Id: I5b5952403e2912e6f97bff086cfebf021b2954dd Reviewed-on: https://chromium-review.googlesource.com/c/1393437Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619503}
-
Toni Barzic authored
BUG=916669 Change-Id: I53239fc461494bb7af6a35edeecdc2083bde27c3 Reviewed-on: https://chromium-review.googlesource.com/c/1383492 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619502}
-
Torne (Richard Coles) authored
Make the Trichrome library package name and certificate digest into GN args so that anyone building Trichrome can easily override them. Change the default certificate digest to be the one for the upstream dev certificate (the one used by default if you check out and build chromium with no further configuration) so that upstream builds actually function out of the box, but make the default a GN variable so that downstream can override it back to the downstream dev certificate (the old value here). Bug: 887078 Change-Id: I988e304e7166313ca196793c595db5f00a41cce2 Reviewed-on: https://chromium-review.googlesource.com/c/1393524Reviewed-by:
-
Nate Fischer authored
No change to production logic. No expected change to test behavior. This swaps out our custom logic for deleting a directory with a FileUtils method. R=changwan@chromium.org Test: run_webview_instrumentation_test_apk -f=HttpCacheTest#* Change-Id: Ieaf269f4c0124e7d680ef0ba941f9c2ca730549f Reviewed-on: https://chromium-review.googlesource.com/c/1391295Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619500}
-
rbpotter authored
WebUIListenerTracker was originally added because Print Preview was not implemented using Polymer, and therefore could not use WebUIListenerBehavior like other Web UIs. Since Print Preview has now been converted to Polymer and there are no other users of this class, remove it and update Print Preview to use WebUIListenerBehavior. Bug: None Change-Id: I52c222916bc2acb5c1398dd177b50e28dcc63eaf Reviewed-on: https://chromium-review.googlesource.com/c/1392279Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#619499}
-
Peter Wen authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1384945 Fixes: - Use the new r8 flags - Use java_runtime_classpath when javac_full_interface_classpath is not available. Bug: 906803, 913679, 916733 Change-Id: Iedf88ac5b0b9a9277a97d3cbcad24ee44eb61607 Reviewed-on: https://chromium-review.googlesource.com/c/1393466Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619498}
-
Theresa authored
Set a popupMenuTheme and contextPopupMenuTheme on the base activity styles, updating their backgrounds to the material 9 patch. contextPopupMenuTheme will apply on N+. BUG=858003 Change-Id: Iea1b5ac524f687bde73c1b4b1722c132a568ffb6 Reviewed-on: https://chromium-review.googlesource.com/c/1387843Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619497}
-
Robert Ogden authored
This test was flaky because the reported data savings was sometimes zero. I was unable to repro locally, but adding another navigation afterwards should help a lot and I'll keep tabs on it with FindIt. Bug: 915775 Change-Id: Ib55370ed3ccdd4e047acfe30ca342d9693a560bc Reviewed-on: https://chromium-review.googlesource.com/c/1392598Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#619496}
-
Raul Tambre authored
Bug: 167187 Change-Id: Ied2e32a24a87f366c47ef6d10f136126dea040ef Reviewed-on: https://chromium-review.googlesource.com/c/1393329Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#619495}
-
Tomasz Wiszkowski authored
Bug: 871798 Change-Id: Iea3c57b101fca98a76e53c14bbb322c8ecb7ee49 Reviewed-on: https://chromium-review.googlesource.com/c/1391996 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619494}
-
Xida Chen authored
Forked from this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1350332 The name "LayerTreePainter" is very generic. The intention of this class is specifically targeting off-thread paint worklet. It is used to paint the layer specifically for paint worklet. This CL does the naming change. It should not introduce any behavior change. Bug: None Change-Id: Ia9fb8829cfc1f7d1b3dd7e7802f2ceb2c4c1b367 Reviewed-on: https://chromium-review.googlesource.com/c/1393423Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619493}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/04ea03e4e1e1..bbdeee914aeb git log 04ea03e4e1e1..bbdeee914aeb --date=short --no-merges --format='%ad %ae %s' 2019-01-02 jmadill@chromium.org Suppress FL 9_3 failing test. Created with: gclient setdep -r src/third_party/angle@bbdeee914aeb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I7786b7906739f8720acb9a570243d0b378cfe5a9 Reviewed-on: https://chromium-review.googlesource.com/c/1393255Reviewed-by:
-
Shakti Sahu authored
Added AutoResumptionHandler to handle downloads auto-resumption in native. This class will observe all download items and also listen to network changes. Based on the current network conditions and download network requirements, it will use a task scheduler to schedule a resumption task with the OS. It is expected to handle download completions/interruptions etc correctly and based on the state of downloads, either notify about task completion with cleaning up any already scheduled tasks or scheduling a new task for resumption when network conditions are met. Bug: 910878 Change-Id: Ia4aabc21e85afee523e78f10956df99e7e02c9dc Reviewed-on: https://chromium-review.googlesource.com/c/1356311 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#619491}
-
Vladimir Levin authored
This reverts commit a36e6e1d, which reverted the initial patch. The original patch description is: """ This patch ensures that we reject update/commit when it happens on a disconnected element. """ The changes in this CL include: - Ensuring that we can commit a disconnected element, since it just unlocks the lock - Ensuring that a timeout triggered on a disconnected element does not DCHECK (this was the cause of the revert to begin with) - Updates the test to have an explicit infinite timeout if timeout is not being tested, since bots can be slow and timeout the lock thus making tests flaky. - Adds a test for timeout on disconnected element. R=chrishtr@chromium.org Bug: 917584, 882663 Change-Id: I6a417fde2c6bd113959128c8bb33a865c97cac8b Reviewed-on: https://chromium-review.googlesource.com/c/1393346 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619490}
-
liberato@chromium.org authored
This CL introduces the ExtraTrees model, as a replacement for RandomForest. This allows us to skip bagging during training, and perform simpler feature splits when constructing the trees. This also renames the RandomForest model to VotingEnsemble, since it is used by ExtraTrees as well as RandomForest, and isn't really specific to RF at all. Change-Id: I91647ef374a7889fabcbf57d902651e8373438cc Reviewed-on: https://chromium-review.googlesource.com/c/1389016Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#619489}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dae815456c77..7a3b1ce7ab6d Created with: gclient setdep -r src-internal@7a3b1ce7ab6d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I18f14b2a55be6ae101a319cc1fd06cb0502b6045 Reviewed-on: https://chromium-review.googlesource.com/c/1393350Reviewed-by:
-
Natalie Chouinard authored
Initial empty Feed internals page at chrome://snippets-internals when the Interest Feed Content Suggestions flag is enabled. Bug: 913122 Change-Id: I7d5cd50c4758e1dcfaa10f2d23c666a3698e3ae0 Reviewed-on: https://chromium-review.googlesource.com/c/1370465 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619487}
-
Theresa authored
Use a minHeight instead of a layout_height for the accessibility text scaling prefence so that text doesn't get cut off. BUG=907366 Change-Id: Ieb25e34ef0104a50f94901aebbc5b232600d49c2 Reviewed-on: https://chromium-review.googlesource.com/c/1387692Reviewed-by:
-
Xianzhu Wang authored
The bug describes how the old code worked and how it caused bugs. The new code paints normal scrollbars in the background paint phase, and overlay scrollbars in the foreground paint phase, eliminating the second paint pass. This changes z-ordering of overlay scrollbars in some cases, but the new behavior is consistent with composited and non-composited layers, and in CompositeAfterPaint. The new behavior is that the overlay scrollbars appear on top of the scrolling contents, but below the outline phase of the current stacking context and other stacked contents with higher z-ordering. The new behavior is the same as the previous behavior when the scrolling block is composited. Bug: 918155 Change-Id: I3144af2a2e00e03cb370f4245353c13afe6b5ede Reviewed-on: https://chromium-review.googlesource.com/c/1391676Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/279b65ddb5a3..b87374f9130f git log 279b65ddb5a3..b87374f9130f --date=short --no-merges --format='%ad %ae %s' 2019-01-02 reed@google.com undefine SK_SUPPORT_LEGACY_PAINT_TEXTMEASURE 2019-01-02 reed@google.com don't use paint to perform char-to-glyph 2019-01-02 reed@google.com make bookmaker happier 2019-01-02 mtklein@google.com flip on one-big-switch SkRasterPipeline 2019-01-02 mtklein@google.com allocate a little bit of space 2019-01-02 reed@google.com use font instead of paint for text 2019-01-02 mtklein@google.com fix fallthrough when deciding lowp/highp Created with: gclient setdep -r src/third_party/skia@b87374f9130f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ibf0f477745520d8feee4b03acf7aad438a1a702b Reviewed-on: https://chromium-review.googlesource.com/c/1393411Reviewed-by:
-
Peter Kasting authored
These pass on Windows. This requires (mostly) reverting https://chromium-review.googlesource.com/c/chromium/src/+/1005103 . The revert is not perfect since many things changed since that CL initially landed (e.g. various tests got disabled). Bug: 658005, 678472, 817408, 828031, 843599, 849146, 863945 Change-Id: I23a3010be1faf962e0a2dfbaaa4a57a3e2cc89d3 Reviewed-on: https://chromium-review.googlesource.com/c/1351874Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Raul Tambre authored
Bug: 167187 Change-Id: Ib430ff6875cc5e9fe00bf791ac3b9029fdd87afd Reviewed-on: https://chromium-review.googlesource.com/c/1393335Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/46d76765..be1288c9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ice76ed16b240f1d23cd26324275909cb6d8112ac Reviewed-on: https://chromium-review.googlesource.com/c/1393464Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619481}
-
John Chen authored
Fixing various issues in the implementation of keyboard actions, including: * Proper handling of modifier keys. * Use W3C spec compliant codes and names for keys. * Setting key location property. * Keeping track of key presses between multiple actions. Most of the logic is in ConvertKeyActionToKeyEvent function, which was based on ConvertKeysToKeyEvents function for legacy (non action based) keyboard support. ChromeDriver now passes most WPT test cases for keyboard actions (webdriver/tests/perform_actions/key*.py), except: * 4 failures in key_special_keys.py, because Unicode characters above U+FFFF and grapheme clusters are not yet supported. * 7 failures in key_events.py, due to inconsistency in "code for key" table in W3C spec (https://github.com/w3c/webdriver/pull/1384). * 4 failures in key_events.py, because Chrome refers to the Meta keys as MetaLeft and MetaRight, while WPT names them OSLeft and OSRight. Bug: chromedriver:1897 Change-Id: Icaf9fff81c7e8127a849699f90871d8d24af4dfa Reviewed-on: https://chromium-review.googlesource.com/c/1392056Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
-
