- 05 Nov, 2019 40 commits
-
-
Tommy Steimel authored
This CL adds horizontal alignment to the title and artist labels to ensure that they stay properly aligned to the left. This fixes a bug where overflowing text would shift slightly to the right. Bug: 1021589 Change-Id: I7c007f4d7af4abe1556941b901a57569dcc41f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899089 Auto-Submit: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712663}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aaa64b76c0b4..b0a1f0a96806 git log aaa64b76c0b4..b0a1f0a96806 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 capn@google.com Update Vulkan CTS testlist Created with: gclient setdep -r src/third_party/swiftshader@b0a1f0a96806 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140172528 Change-Id: I2c83a7bcefd1083393d30dab942b6c35c88282d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899588Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712662}
-
Sergey Ulanov authored
FuchsiaVideoDecoder was crashing with a DCHECK in SendInputPacket() while being destroyed because in_flight_input_packets_ were cleared while there is pending data in the queue, which was causing new input packets to be produced. Added ReleaseInputBuffers() call in ~FuchsiaVideoDecoder() to avoid this issue. Bug: 1013919 Change-Id: Id455e97ad8dad70d6aaa7dfc1bbee0426df7ae48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898777 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712661}
-
Jazz Xu authored
ScrollNodeIntoView is causing the clickNode failure. Set it to false to fix the issue. Bug: 1000183 Change-Id: Ic80afd852e57a9a54e55cb1d7406bf3f0f701b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896344Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712660}
-
Mikhail Khokhlov authored
As discussed on the doc [1], adding a test_path_format option for correct parsing of test paths. The testPath attribute is now mandatory, so adding it to the test. [1] https://docs.google.com/document/d/18PstJFR6kmEeDiQZjVzJaqXWm4SocuZXrFVu57xDm-4 Change-Id: Id988cd620da0927fab9fb42b81fd52855198f75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899625 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#712659}
-
Collin Baker authored
Fixes: 1015132 Change-Id: I8b99f9fdd044b249f44c681bafe10bb2037046a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898305Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#712658}
-
Ken Rockot authored
The service (in //services/image_annotation) has been hanging off of ProfileImpl since it was moved off of Service Manager APIs. That breaks image annotation for OTR profiles. This CL migrates the client code to the AccessibilityLabelsService that hangs off of all Profiles. This also opportunistically moves Data Decoder consumption off of Service Manager APIs in favor of the new DataDecoder client API. Fixed: 1020657 Change-Id: I62f77f2f1bcfc84225efb8b62a75d74f2d0c655c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895963Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#712657}
-
Yuki Shiino authored
Implements two type conversion functions in blink_v8_bridge.py. Bug: 839389 Change-Id: I31dfbf882e8abd3a71719b54d8226313dd4bba92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899632Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#712656}
-
Jay Civelli authored
Removing myself as an OWNER as I am not actively contributing to the project. Change-Id: I29ed3d24114bfd36c6c618de62de169ed2bc3a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897951Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#712655}
-
Mirko Bonadei authored
In order to avoid regressions on the WebRTC component build in Chromium, WebRTC will add 2 trybots to build Chromium in WebRTC's CQ with is_debug=true and is_component_build=true. Bug: webrtc:9419 Change-Id: Ib68d5c1a170069bd032b4e8141b24765afb7c2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862680Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#712654}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cfa4f60270cf..e9b546970ec2 git log cfa4f60270cf..e9b546970ec2 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 bsalomon@google.com Add valgrind suppressions for GrClearImage 2019-11-05 robertphillips@google.com Revert "Fully embrace skcms types in SkColorSpace API" Created with: gclient setdep -r src/third_party/skia@e9b546970ec2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I3353721916bffe80cf52c308d99d27f8faf8ece9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899967Reviewed-by:
-
Alex Chau authored
Bug: 1021141, 1021143 Change-Id: I4c38246c2dd80b4090e084261b0853f37d0650d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897930Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#712652}
-
liberato@chromium.org authored
Previously, we would use one weak pointer for the media WebContentsObserver for all power experiment callbacks. However, since the experiment manager posts callbacks, it's possible that a callback will run after its RenderFrameHost is deleted. Since we use the RenderFrameHost to notify the renderer, this would be a problem in that case. This CL adds per-frame weak pointers that are invalidated after the frame is destroyed, so that any pending callbacks don't run. Change-Id: I02835ebfd620816e385fd215472dd78ecbeae4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897701Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#712651}
-
Toni Barzic authored
Adds logic to notify the home screen delegate of transition to home screen from app (when home button is tapped) for homerview transition. This reflects what's done by HomeLauncherGestureHandler when kHomerviewGesture feature is not enabled. Some perf tests rely on this notification being sent (for example LauncherDragTest.Close/1). BUG=1005366 Change-Id: I0a12ddb1289c8e5d1d093f438bdaa9a354deba29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897011Reviewed-by:
-
Pavel Shmakov authored
BrowserControllerImpl::DidFinishNavigation can be called while destroying WebContents: https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.cc?rcl=81163fe37074bf1ea2bb5a76fe88b2f49e86f23a&l=694 https://cs.chromium.org/chromium/src/content/browser/frame_host/navigation_request.cc?rcl=81163fe37074bf1ea2bb5a76fe88b2f49e86f23a&l=1062 This led to a nullptr dereference. Bug: 1021041 Change-Id: I1894912ed77e377dd0e1ffa2b746921f13f392b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897833 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712649}
-
Pavel Shmakov authored
Both WebView's and Chrome's cache clearing APIs do the following: 1) Clear the GL shader cache, which corresponds to DATA_TYPE_CACHE in the language of browser_data_remover.h. 2) Clear the Blink cache of the renderers. This CL implements the second part. Change-Id: I2c85de5ca6d286c22954c56a838e4b02cd57b5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893251Reviewed-by:
-
Owen Min authored
Extension requests are cached in the profile pref. Append the pending list into the report. Bug: 1006899 Change-Id: I62bee93204bb68a790f6ac6176046f17e1860172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894034Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b48a39e6e2c8..e600381cfd17 Created with: gclient setdep -r src-internal@e600381cfd17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ib5faec20da1a7279bda6421d7e490839596ee63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899966Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712646}
-
zhaoyangli authored
The constants.h import was introduced in crrev/c/1888601 to ensure the egtest in internal code base can continue accessing the constants. Now tha egtest in internal code base has been changed to directly import the constants header in crrev/i/2066050. So the header can be removed as it's not used in the file. Bug: 1015907 Change-Id: I6f4be06fd6327ea704012d2bac1e80a59a49bf68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893546Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#712645}
-
Hans Wennborg authored
and use that to download auxiliary packages, removing the custom scripts previously used to do that. Bug: 884608 Change-Id: Iefcd2145898588a6dbdc14c21841201f9d17f8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605911 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712644}
-
Henrique Nakashima authored
Use SharedPreferencesManager instead. Bug: 1017800 Change-Id: I3f0dafadf32f618f7baa05e5fb6f1114473658e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894399Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#712643}
-
Sammie Quon authored
This cl makes WindowCycleItemVIew inherit WindowMiniview. Also moved OverviewCloseButton to OverviewItemView. Makes WindowMiniView no longer a button. This required some accessibility changes - OverviewItems are now considered windows, which I think is more suitable than Button. TBR=aboxhall@chromium.org Test: manual, ash_unittests Bug: 1017912 Change-Id: Ia2b50e5b874b8db8ff4b335f38ab7a03710e3756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880956 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#712642}
-
Mitsuru Oshima authored
* It observes widget's destruction instead of observing compositor's in CompositorChecker. This allow CAR to continue running even if the widget's compositor changes. * Re-enable on chromeos Bug: 1019536 Test: Covered by unittests. Change-Id: Ia3a3201408b93d70b98339e79b7e9ffd6db22e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890493Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#712641}
-
Bailey Berro authored
crrev.com/c/1893511 fixes the regression in this test caused by crrev.com/c/1774637. Test: Verified locally Bug: 1006101 Change-Id: I2fd04f03a2a11af65a0a8cbeaca17b3d322fc21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898332 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Martin Kreichgauer authored
Changes the fingeprint enrollment dialog on the security keys settings subpage to iron-announce upon successful completion of a fingerprint enrollment. Bug: 974046 Change-Id: I61e4fc17d55bd16d2de299084586ec078829acc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898433Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#712639}
-
Peter K. Lee authored
Some EG tests use TestChromeBrowserState and they need blocking IO in some scopes. Bug: 1020027 Change-Id: I7766071a724967860cffe4139f00bd3f5bb2dcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898539 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#712638}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0da64443b6c7..51a6086ce618 git log 0da64443b6c7..51a6086ce618 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 rsavitski@google.com Merge "Bump googletest version to match external/googletest in aosp" Created with: gclient setdep -r src/third_party/perfetto@51a6086ce618 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I9a3a27fa64b7e22e2cad989c9a4e821acfe0f323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899482Reviewed-by:
-
Martin Kreichgauer authored
Also reorder the fingerprint enrollment and reset items on the security keys settings subpage. Bug: 974046 Change-Id: Ia2b3deb6ceb5ab57f06e555216d007f52b130571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894483Reviewed-by:
-
Marc Treib authored
It seems that signin::MakeAccountAvailableWithCookies, previously used by these tests, doesn't reliably make an unconsented primary account available. This CL changes the ProfileMenuClickTests to use helpers from secondary_account_helper:: instead, since several other browser tests use these and seem to be fine. If this resolves the flakiness, a followup item is to investigate what the relevant difference is between these helpers. Bug: 1015429 Change-Id: I2be36f30e08827911e7492fd69a6d531563eed34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899871Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#712635}
-
Connie Wan authored
We've gotten enough feedback on this that PM and UX have suggested that we remove this behavior. This change removes the groups that are magically created when the user opens a new tab via a link. Tabs opened from an already-grouped tab will still be opened within that group. Bug: 997344 Change-Id: Iad1ede15edc06356db9728bbcf5e4f59a4eae207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898620Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#712634}
-
Antonio Gomes authored
... left over of https://crrev.com/c/1884931. BUG=787254, 919392 R=haraken@chromium.org Change-Id: I5742b6938342e25583108b6bc70964b4bbd07a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899787 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712633}
-
Philipp Hancke authored
The code for generating the DTLS 1.0 deprecation warning is in the wrong method which is not called when the transport gets connected. Moves the code to the internal state change event and fixes punctuation in the warning. This can be tested with a peer that creates the OpenSSL context with the DTLS_method() and then does SSL_CTX_set_options(ctx, SSL_OP_NO_TLSv1_2) to disabled DTLS 1.2. Bug: webrtc:10261 Change-Id: Ib11851b7a104e4d3b6ba77eeb78bed3f1c4d0588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894006Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#712632}
-
Denis Kuznetsov authored
Bug: 893934,955194 Change-Id: Ie97de2f2034f2169c5c473a55c7a88388e6ae725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872056Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712631}
-
Takumi Fujimoto authored
Add CastMediaNotificationProvider, which is responsible for providing MediaToolbarButtonController with notification items for Cast, which are represented by the CastMediaNotificationItem class. MediaToolbarButtonController::MediaRoutesObserver has been merged into CastMediaNotificationProvider. Bug: 987479 Change-Id: I258674c6d5541a581e79f4d91d2568c239931be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888533Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#712630}
-
Tim van der Lippe authored
Bug: 1011466 Change-Id: I1187389e33f3bf97a51ed27f09d0e5a57b0f7831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899504 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712629}
-
Michael Lippautz authored
This patch unifies weak and strong handling of ephemerons and adds support for "reverse" ephemerons (strong key w/ weak value) to the heap snapshot. It also removes dependencies on Trait::kWeakHandlingFlag in ephemeron tracing. Bug: 1019191 Change-Id: Ic3429a6fb45663ab7fe3c59790a72384066a1892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897834 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Slav Ishutin authored
This CL allows using protoc_convert with cross-compilation. Change-Id: I20dd15a3ac56bed6deee2c66d0f09c2b9982c156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898070Reviewed-by:
-
Leszek Swirski authored
Use the StreamedSource constructor taking a unique_ptr<SourceStream> rather than the raw pointer version, which is less clear about ownership and so is deprecated. Change-Id: I8d95d8049b60925ea11f16249ba18ba5044908d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899848 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712626}
-
Joshua Pawlicki authored
TBR=rbpotter@chromium.org Bug: 1021545 Change-Id: I50c82dbae1ba6ebc08fcbbfa478b2d15bbe126bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899308Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712625}
-
Livvie Lin authored
Follow-up to crrev.com/c/1793260. Bug: 1017406 Change-Id: Ic7823f6a630d0cd4cbd7e64d0999b81d964b9129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894043Reviewed-by:
-
