- 23 Jan, 2019 40 commits
-
-
Steve Kobes authored
These were generating spurious janks on scroll, because the visual rect moves. (The old / new rects are mapped into the viewport's coordinate space, but both of these mappings use the updated scroll offset.) This is a temporary fix until we figure out a better way to detect real layout janks in fixed or sticky elements. Bug: 581518 Change-Id: I405c0933eb3cd52c135e97db55cb72c32dedc1a6 Reviewed-on: https://chromium-review.googlesource.com/c/1430589 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#625370}
-
Anne Lim authored
Intruduced LocalCardMigrationStrikeDatabase and added an AddStrikes and RemoveStrikes functions, which allows multiple strikes to be added at once. Bug: 920385 Change-Id: Ifbfad49c9d67570098b0e71d7a3fda1800563413 Reviewed-on: https://chromium-review.googlesource.com/c/1422701Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#625369}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/08b0b7fd5bd5..114b5af0e8cc git log 08b0b7fd5bd5..114b5af0e8cc --date=short --no-merges --format='%ad %ae %s' 2019-01-23 herb@google.com Fix bookmaker 2019-01-23 michaelludwig@google.com Increase tolerance in rectilinear quad detection 2019-01-23 herb@google.com Add getTypefaceOrDefault and refTypefaceOrDefault Created with: gclient setdep -r src/third_party/skia@114b5af0e8cc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:923946 TBR=djsollen@chromium.org Change-Id: Ie46dc2488dbfaf8cfd2546987c0a1cce374d712d Reviewed-on: https://chromium-review.googlesource.com/c/1431453Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625368}
-
Kristi Park authored
Screenshots: https://screenshot.googleplex.com/FqstoCzbOE2.png https://screenshot.googleplex.com/X0oy2QqeDt9.png https://screenshot.googleplex.com/tH0us5zzBJM.png Bug: 919961, 923988 Change-Id: I00bcf543284fb83a2565e9ff73701a07ac279dca Reviewed-on: https://chromium-review.googlesource.com/c/1428740 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625367}
-
Mitsuru Oshima authored
Bug: 924390 Test: None Change-Id: I2aa1f8dc832bfbc1a7ce8ff1154adedac55a2af1 Reviewed-on: https://chromium-review.googlesource.com/c/1429059Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#625366}
-
Salvador Guerrero authored
Modified the SharedProtoDatabaseClientList::ShouldUseSharedDB function to let us migrate each client to SharedProtoDatabase with a finch experiment Bug: 870813 Change-Id: Ife62d81a719387ec8fc0866191b0db5645707728 Reviewed-on: https://chromium-review.googlesource.com/c/1406296 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#625365}
-
Ben Pastene authored
Bug: 907899 Change-Id: Ic300c8d4120a581e2ea756a88b2498e5f861064c Reviewed-on: https://chromium-review.googlesource.com/c/1428819 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#625364}
-
Jacob Dufault authored
Bug: 908498 Change-Id: I763088c5a8f6eb065c563ae269e6ec24955aa1fc Reviewed-on: https://chromium-review.googlesource.com/c/1351688 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#625363}
-
Lei Zhang authored
Initialize printing on Android the same way as other platforms, instead of in TabAndroid::Print(). By calling printing::InitializePrinting() like other platforms, the PDF compositor will be created as needs. Also implement PrintCrossProcessSubframe() in TabWebContentsDelegateAndroid to redirect the subframe print request, since the Browser class does not exist on Android. BUG=890417 Change-Id: I7195cf2afe2560dd56a56b5a769acf9e51bbb41b Reviewed-on: https://chromium-review.googlesource.com/c/1420302 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#625362}
-
Jordan Demeulenaere authored
Change-Id: I3e9579e7e0fdf3bb90e1a6d806045a6a1207a230 Reviewed-on: https://chromium-review.googlesource.com/c/1430009 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#625361}
-
Kurt Horimoto authored
This CL updates UpdateDisabledCounterForContentHeight()'s implementation in two ways: - Accounts for the case when the FullscreenProvider is disabled and the scroll view may have been resized to a shorter height despite the content being fully visible on screen. - Updates to a <= check so that fullscreen is disabled when the content fits the scroll view exactly. Bug: 914347 Change-Id: I5d2c6e3ce09d25552de0f1071785d29078162377 Reviewed-on: https://chromium-review.googlesource.com/c/1423092 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625360}
-
Owen Min authored
1) Use raw string to avoid multiple escapes. 2) Add tests for plugins and signed in user data. 3) Add slash and quote in the test data to make sure they can be escaped properly by the report helper. Bug: 924645 Change-Id: I00d6166d967d8ebae82ac8bba5cc698b3eb2e418 Reviewed-on: https://chromium-review.googlesource.com/c/1431335Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625359}
-
Tommy C. Li authored
Currently, when Steady State Elisions is on, and the user unelides the URL, we put the full URL into the user text. This was convenient, but has some unintended consequences. Namely: 1) user_input_in_progress() as a boolean state becomes confusing, as sometimes it means the user has edited the URL, and sometimes it means the the user has merely unelided the URL. 2) Consequently, in many places in the code, we check if user input in progress AND if the user has meaningfully edited the URL away from the full URL text. 3) That's not obvious to non-omnibox owners, so it creates bugs like the one linked below. This CL changes how unelision works so it only updates the View's text and leaves the model's user-text alone. It no longer sets user_input_in_progress to true for mere unelision. This allows us to clean up fair number of callsites and puts the nail in the coffin for the below linked bug too. Bug: 921777 Change-Id: I9d113649f50c0bfafa1d112002add577e05928f7 Reviewed-on: https://chromium-review.googlesource.com/c/1427244Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#625358}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/56250c3ee3c0..3dfb55b889fd git log 56250c3ee3c0..3dfb55b889fd --date=short --no-merges --format='%ad %ae %s' 2019-01-23 vmiklos@collabora.co.uk core: use the libjpeg boolean type in the jpeg codec Created with: gclient setdep -r src/third_party/pdfium@3dfb55b889fd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4ab6bd306e1f15d231dffcc8c6e354ad347f9cd6 Reviewed-on: https://chromium-review.googlesource.com/c/1431492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625357}
-
Ken Rockot authored
This wipes out the last remaining usage of runtime JSON manifest parsing in favor of using build-time generated C++ manifests. All support code for parsing JSON manifests at runtime is removed as well. Bug: 895616 Change-Id: I35fdc82b719de4fbedb54ba433dda4293fb0f893 Reviewed-on: https://chromium-review.googlesource.com/c/1423354Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#625356}
-
chuanl authored
Bug: 882404 Change-Id: Iaa93ed3b96a70ba78fff6bc711eb0404b52f179f Reviewed-on: https://chromium-review.googlesource.com/c/1412397Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: John Lin <chuanl@google.com> Cr-Commit-Position: refs/heads/master@{#625355}
-
Paul Meyer authored
TBR: iclelland@chromium.org Change-Id: I70b78d5d9191ad554363ce26c76ba62469900de6 Reviewed-on: https://chromium-review.googlesource.com/c/1431013Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#625354}
-
Brian White authored
Bug: 923083 Change-Id: I25136857b84832ac896e76f32c182af8eb190e15 Reviewed-on: https://chromium-review.googlesource.com/c/1418517Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#625353}
-
Jered Gray authored
This reverts commit de34f0bd. Reason for revert: Fixed additional flakiness Original change's description: > Revert "Fix flakiness in previews browsertests" > > This reverts commit ddd4f721. > > Reason for revert: Looks like some tests become flaky (or even flakier?) > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10417 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10418 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10419 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31176 > > Original change's description: > > Fix flakiness in previews browsertests > > > > The previous logic relied upon the hints requested by the store upon a > > navigation to a url being loaded prior to the commit. This was not > > guaranteed to happen when cores were not available on a machine for > > background threads. > > > > The HintCache has been modified so that it now runs the hint loaded > > callback even in the case where no hints are available for the host. > > > > Additionally, a histogram has been added that tracks the loading of > > hints from the hint cache store has in PreviewsOptimizationGuide. The > > tests now run a priming navigation that waits for the hints to be > > loaded. This ensures that the hints are guaranteed to be available > > during the tests. > > > > Bug: 923161 > > Change-Id: I8b09dfc9391164f0a6d424ec0a8ea871334c4c8c > > Reviewed-on: https://chromium-review.googlesource.com/c/1423617 > > Commit-Queue: Jered Gray <jegray@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#625056} Change-Id: I675f7a0b3eb79d468100af8775310bb64531b069 Reviewed-on: https://chromium-review.googlesource.com/c/1431019Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#625352}
-
Xiaohui Chen authored
Bug: 120666177 Test: locally build and see voice model retraining works. Change-Id: Ieaff9f11cb1e879a65064001d5455b6f2d325f22 Reviewed-on: https://chromium-review.googlesource.com/c/1423659Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#625351}
-
Caleb Raitto authored
Change-Id: Ia56988f41bf11d74be67f0e7876b22c48a6c34d0 Reviewed-on: https://chromium-review.googlesource.com/c/1423619Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625350}
-
Luke Sorenson authored
Bug: 924649 Change-Id: I5cf3bc128b5aeafa4dbb2c2ae3df690086a19c26 Reviewed-on: https://chromium-review.googlesource.com/c/1431672Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#625349}
-
Khushal authored
SurfaceControl requires AImageReader to support video overlays. Disable it if AImageReader is disabled. R=piman@chromium.org Bug: 889328 Change-Id: I624f88b3759ce79eff296f75d82ac5a71616837d Reviewed-on: https://chromium-review.googlesource.com/c/1431232 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#625348}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1737fb0576a..6aa6bc44417e Created with: gclient setdep -r src-internal@6aa6bc44417e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:885350 TBR=mmoss@chromium.org Change-Id: If97db92ce6bd622089d2c08a0ac845d9f7fa5515 Reviewed-on: https://chromium-review.googlesource.com/c/1431253Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625347}
-
Jimmy Gong authored
- The "premount" mode lets preconfigured shares to be preemtively mounted upon start up of SMB file sharing. Bug: chromium=878502 Test: compiles + PolicyPrefTest unittest Change-Id: I3d53b33bb4687217b537b45d1562c4e4ed1b31b6 Reviewed-on: https://chromium-review.googlesource.com/c/1407655Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#625346}
-
Jonathan Backer authored
We should use GrShaderCache with SkiaRenderer, even if not using OOP-R. Change-Id: I096cbde69328efb1608232d3685a871c762d13ac Reviewed-on: https://chromium-review.googlesource.com/c/1431020 Auto-Submit: Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625345}
-
Joshua Bell authored
I can never remember what role the CannedBrowsingDataXYZHelper classes serve when someone asks, so documenting it for posterity. TBR=dullweber@chromium.org,mxcai@chromium.org NOTRY=true Change-Id: Id5853e0baccc2dd1b3649a6398cb3e86e1c1f5a1 Reviewed-on: https://chromium-review.googlesource.com/c/1431234 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625344}
-
Jacob Dufault authored
Bug: 908498 Change-Id: I5c3e0376e94f18808041db0371411ae6ec168eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1352355 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#625343}
-
Robert Ogden authored
Data Saver is being rebranded to Lite mode. However, we'd like to programatically roll this out via Finch in M73. We expect that this will require some merges. I'm landing this CL now so that the strings that will be used can be translated and will be available at branch. This CL is based off of https://chromium-review.googlesource.com/c/1354346 In a few places where only the description of the string was changed in that CL, the change was omitted here so that we don't need a whole other string. When Lite mode is launched, I'll come back and clean those up. All new strings are suffixed with _lite_mode, based on their Data Saver counterparts. Bug: 909915 Binary-Size: Increase is due to translations and so cannot be avoided. Change-Id: Ie3511d952c301290de8c404f4677d610767f9355 Reviewed-on: https://chromium-review.googlesource.com/c/1429499 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#625342}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3d7102424810..b1be6763f6f3 git log 3d7102424810..b1be6763f6f3 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 zoddicus@users.noreply.github.com Add helper for 'is Vulkan or WebGPU' (#2324) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b1be6763f6f3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic9ddcadfcb345088ea44a8dea26264635dc3788d Reviewed-on: https://chromium-review.googlesource.com/c/1431255Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625341}
-
Jamie Madill authored
This will allow ANGLE to use Chromium repos for third_party deps. Bug: angleproject:3088 Change-Id: I0d8d4c53df780d59fdc97813fb468d0960b18def Reviewed-on: https://chromium-review.googlesource.com/c/1424397Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#625340}
-
Parastoo Geranmayeh authored
Profiles are sorted in the DB and not in the Personal Data Manager, therefore, we need to reload them when the changes are done. => Call Refresh() each times there is no more change in the waiting in the scheduling queue. Bug: 920529 Change-Id: I7bc4337b881bac67185ed9ec279857fa6b207da4 Reviewed-on: https://chromium-review.googlesource.com/c/1406178 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#625339}
-
Mounir Lamouri authored
Bug: none Change-Id: I52f415f00624a3d160be1212d9317dffac113869 TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1431535 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#625338}
-
Eric Orth authored
Bug: 922161 Change-Id: I33ba427d5449a0e93d36bdd9078d8a9b59b90422 Reviewed-on: https://chromium-review.googlesource.com/c/1413057 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#625337}
-
Becca Hughes authored
Enable hardware key handling on CrOS for launch in M73. Also fixes a type for kInternalMediaSession flag. BUG=891401 Change-Id: Ic79a2cb889b5f633ef971f62d67aaaf52b54d715 Reviewed-on: https://chromium-review.googlesource.com/c/1423131Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#625336}
-
Xianda Sun authored
Ui::Layers call SetHideLayerAndSubtree when they become visible or hidden. But a cc::Layer with hide_layer_and_subtree = true still draws its content and is considered hit-testable, though not displayed on the screen. This patch makes cc hit testing respect hide_layer_and_subtree and do not hit test a layer if it's drawn but not displayed on screen. Bug: 901882 Change-Id: I18c9511c18628067dbcb471cd8dfe43a1e3c6426 Reviewed-on: https://chromium-review.googlesource.com/c/1413393Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#625335}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/db9cda8acc38..a824c339c217 git log db9cda8acc38..a824c339c217 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 lalitm@google.com trace_processor: add mm_event ingestion in trace processor 2019-01-23 lalitm@google.com trace_processor: don't parse sched_switch into raw or ingest args 2019-01-23 fmayer@google.com Merge "Do not require root for heap profiling script." Created with: gclient setdep -r src/third_party/perfetto@a824c339c217 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:118897434,chromium:123252504 TBR=perfetto-bugs@google.com Change-Id: I9b853ce07a6e7ba2165e7ed8eaaec46ac7838fd1 Reviewed-on: https://chromium-review.googlesource.com/c/1431092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625334}
-
Peter Beverloo authored
Also provide a series of new tests to cover the implementation, particularly this requirement. Bug: 860467 Change-Id: I274e433fadba5228ac5dc0853b5a30354904d43e Reviewed-on: https://chromium-review.googlesource.com/c/1430014 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#625333}
-
Wez authored
Bug: 854721 Change-Id: I0bbad92f6698db479518f268d0ae797a0a3d2d81 Reviewed-on: https://chromium-review.googlesource.com/c/1424598Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625332}
-
Robert Liao authored
The Dark/Light mode toggle in System Settings appears to be intended for UWP apps, so this change needs to be slightly more creative about checking this state. This change checks and monitors AppsUseLightTheme in HKCU's theme area, which is not an API guarantee. Future versions of Windows could change the way this is persisted and subsequently break this change. BUG=838670 Change-Id: Ic84341ae69e2bb9cd988f9bea027052033c66360 Reviewed-on: https://chromium-review.googlesource.com/c/1429963Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625331}
-