- 30 Oct, 2018 40 commits
- 
- 
Yuzu Saijo authoredAdd a new group config name for experiments. Change-Id: I4d522dd54be964958b9e32916523a11322543693 Reviewed-on: https://chromium-review.googlesource.com/c/1303318Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#603777} 
- 
Zhuoyu Qian authoredhttps://www.chromium.org/blink/public-c-api#TOC-Naming > All public Blink API types and classes are in the namespace blink and have the prefix Web. Namespace name should be lower-case but we can't make 'namespace WebOriginTrials' lower-case because of this naming rule. So we convert WebOriginTrials to a static-only class. Bug: 889726 Change-Id: Ia2fe9888da297b965d891287f05fb99d45d802f5 Reviewed-on: https://chromium-review.googlesource.com/c/1304185 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#603776} 
- 
Hiroki Nakagawa authoredBug: n/a Change-Id: Iddfa7b6912a753878bef0a85510f9b5f4dcc6e4c Reviewed-on: https://chromium-review.googlesource.com/c/1306956Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#603775} 
- 
chromium-autoroll authoredhttps://pdfium.googlesource.com/pdfium.git/+log/06305f5d71c7..05e43638cd37 git log 06305f5d71c7..05e43638cd37 --date=short --no-merges --format='%ad %ae %s' 2018-10-29 tsepez@chromium.org Rename two more CJS_PublicMethods methods. Created with: gclient setdep -r src/third_party/pdfium@05e43638cd37 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2eb7c27b45d8ca89236d0fba97228666eb54160c Reviewed-on: https://chromium-review.googlesource.com/c/1307114Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603774} 
- 
Tetsui Ohkubo authoredThis CL removes NotificationTray because now it's replaced by UnifiedSystemTray. This is the part 3 of removing old System Tray (+Notification Tray) code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray I'll try to keep the number of CLs as small as possible to make the history clean, but there can be multiple CLs for both part 2 and part 3 because some of them requires nontrivial refactoring to remove the dependency to the old code. TEST=trybot pass BUG=898419 Change-Id: I90f2904161aa453a0048947bf22bf31158d9442f Reviewed-on: https://chromium-review.googlesource.com/c/1304184 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#603773} 
- 
chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/06a4ef497ff1..14768f64fba3 git log 06a4ef497ff1..14768f64fba3 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 caryclark@skia.org update docs for new/changed textblob apis 2018-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4a22f4b04619..3420dcb0cff1 (7 commits) 2018-10-29 brianosman@google.com Keep paint color range/precision into ops and GPs (using GrColor4h) Created with: gclient setdep -r src/third_party/skia@14768f64fba3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I0f05efd8a4977f500acccf8fb18277af6e6775e5 Reviewed-on: https://chromium-review.googlesource.com/c/1306756Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603772} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6cf33fa7deb4..32abeea1737e Created with: gclient setdep -r src-internal@32abeea1737e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic257f570a844ecfb2afebd13eff76efc7a5eb72d Reviewed-on: https://chromium-review.googlesource.com/c/1307115Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603771} 
- 
Toni Barzic authoredThis was intended to enable auto-filling network credentials during Chromecast setup, but never actually caught on (i.e. it has not been actually used). BUG=846971 Change-Id: I66e5e316ec91eac0c286f82aa4aad1573ed931f8 Reviewed-on: https://chromium-review.googlesource.com/c/1297407 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#603770} 
- 
Tsuyoshi Horo authoredThis reverts commit 7b97163e. Reason for revert: Failed ios-device build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device/103715 Original change's description: > [ios] Drop iOS10 support, move deployment target to iOS11. > > Bug: 894099 > Change-Id: I638bd439a96e105cd33aa858cfd1209ed2ceabc9 > Reviewed-on: https://chromium-review.googlesource.com/c/1297250 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603758} TBR=dpranke@chromium.org,marq@chromium.org,justincohen@chromium.org,pkl@chromium.org,scottmg@chromium.org,jbudorick@chromium.org Change-Id: Id78ea18cc5a77fa7a967867a890dd81a6af5eea6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894099 Reviewed-on: https://chromium-review.googlesource.com/c/1306936Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#603769} 
- 
Oystein Eftevaag authoredThe broad strokes behind this CL is that TracedValue now can be supplied with a factory function, which is used to override its backing implementation. When Perfetto is enabled, this is used to let TracedValue write directly to a proto which can then be memcpy'd into the Perfetto shared buffer, rather than being written into a base::Pickle which is then serialized as a JSON strong. Dependent on these CLs landing and rolled into //third_party/perfetto: https://android-review.googlesource.com/c/platform/external/perfetto/+/792813 https://android-review.googlesource.com/c/platform/external/perfetto/+/792814 TBR=csharrison@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2bfa0cd7398a0ac4788c56d5be13fe951dc56770 Reviewed-on: https://chromium-review.googlesource.com/c/1263354Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Primiano Tucci <primiano@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#603768} 
- 
Scott Chen authoredBug: 874122 Change-Id: Ic25e7cf5b0c2d37af4d9ba2af311f9ce0c12e08b Reviewed-on: https://chromium-review.googlesource.com/c/1298616 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#603767} 
- 
Scott Chen authoredThis CL adds the boilerplate codes for browser-testing the onboarding welcome UI, and one simple test to verify it works. There will be follow-up CLs to add more browser tests to all onboarding welcome elements. Bug: 881937 Change-Id: I1c1d33411ad55eff5fd4ab43bd3cc1b93a257d3e Reviewed-on: https://chromium-review.googlesource.com/c/1300673 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#603766} 
- 
chrome-release-bot authored# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ied5535100c5612069aeae967095b2c732f68c159 Reviewed-on: https://chromium-review.googlesource.com/c/1306642Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#603765} 
- 
Tetsui Ohkubo authoredAccording to UX spec, check icon shown on the right side of a11y detailed view is 28994F. This change is important in terms of color contrast. TEST=manual BUG=899162 Change-Id: Idd32cbf94d974355a6229ef7bb88e9ae714ab97c Reviewed-on: https://chromium-review.googlesource.com/c/1304284Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#603764} 
- 
Bailey Berro authoredThis is the first in a series of changes to create a freeform dialog for adding an SMB share in addition to the dialog existing in settings. - Moves add_smb_share dialog to cr_components - Switches $i18n{} to i18n() - Updates BUILD files Bug: chromium:887135 Test: verified on test device Change-Id: I1133d9e45ee7ac63e338e22e4e69e3e000a3ee02 Reviewed-on: https://chromium-review.googlesource.com/c/1281868 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#603763} 
- 
Yuri Wiitala authoredAdds the implementation that determines which shader programs to use, and in what order, to execute scaling and format conversion. Also, adds pixel tests to check all the various features provided by GLScaler (via its Parameters). Bug: 870036 Change-Id: I7cb1d64d6df79a3a6221c2ab6cdf4b504b26c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1298737 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603762} 
- 
Hector Carmona authoredBoth the email and google app modules will show the bookmark bar. This change makes it so that the state of the bookmark bar is returned to the way it was before it was shown if no bookmarks are added. R=scottchen@chromium.org Bug: 881937 Change-Id: I64d0a03f6747589d594720dad406e14ee4483ca8 Reviewed-on: https://chromium-review.googlesource.com/c/1302316 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603761} 
- 
Regan Hsu authoredAdd metrics that break down the percentage of users who either accepted or declined MultiDevice OOBE setup. Bug: 870141 Change-Id: I1cf85910a3e445ca3b0b16e35028b5a816b6ec9b Reviewed-on: https://chromium-review.googlesource.com/c/1298495 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#603760} 
- 
Zhuoyu Qian authoredhttps://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I625fa68bf159d2ff66b5314149217823c2f7fb75 Reviewed-on: https://chromium-review.googlesource.com/c/1303326 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#603759} 
- 
Justin Cohen authoredBug: 894099 Change-Id: I638bd439a96e105cd33aa858cfd1209ed2ceabc9 Reviewed-on: https://chromium-review.googlesource.com/c/1297250Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603758} 
- 
Robert Sesek authoredThere are no more users of this implementation, and the new shared memory APIs do not support FD-backed shared memory on Mac. Bug: 776564 Change-Id: I9307a6e46daa4329f0d04e6951b6e432a79c2c47 Reviewed-on: https://chromium-review.googlesource.com/c/1303873Reviewed-by: Alexandr Ilin <alexilin@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#603757} 
- 
Eliot Courtney authoredBug: 883114 Bug: 841886 Bug: b/115291749 Test: ash_unittests Change-Id: I2e6cd712e9550d7d4ce4f971f5800dec18316078 Reviewed-on: https://chromium-review.googlesource.com/c/1298530Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#603756} 
- 
Hiroki Nakagawa authoredThis is a cleanup CL. Before this CL, AccessControlStatus for classic worker scripts are passed from each worker implementation to WorkerGlobalScope. Actually, however, AccessControlStatus::kSharableCrossOrigin is always specified because cross-origin workers are disallowed. For cleanup, this CL stops passing AccessControlStatus and instead hard-codes it in WorkerGlobalScope. Bug: 835717 Change-Id: I9af910c113f1d5f032e77f48f54e1bc74153808b Reviewed-on: https://chromium-review.googlesource.com/c/1304279 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#603755} 
- 
chromium-autoroll authoredThe AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I2e137b5c3f43c7c5f8811b0e481d7dc31f70c735 Reviewed-on: https://chromium-review.googlesource.com/c/1307113Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603754} 
- 
Darwin Huang authoredAdded comments to explain what KURL and GURL stand for. Mostly just trying to make clear things that I was confused about when first parsing the code Bug: 896479 Change-Id: Ic6857750884a2954ed32f5d4af3c32ff3356377b Reviewed-on: https://chromium-review.googlesource.com/c/1300681Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603753} 
- 
Jay Harris authoredDependencies on the LocationBarView have been abstracted into a delegate, so as to make the LocationIconView reusable. This is in preparation for introducing a CustomTabBarView for Desktop PWAs, which will have its own LocationIconView. Bug: 853593 Change-Id: I5817041e532cd8db6065f2a818e6b203a91fb012 Reviewed-on: https://chromium-review.googlesource.com/c/1248067 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#603752} 
- 
Eric Aleshire authoredThe WPR tests are now running on ios-wpr-simulator, but failing due to the proxy certificates not getting installed on each sim. I hypothesize this is happening due to an oversight where I do not explicitly create the simulator before installing certificates - therefore, I create the sim as done in SimulatorTestRunner, install certificates, then tear it down at the end of testing. Bug: 892381 Change-Id: I5a77ee609a462be18f22507fb6e73d9229126102 Reviewed-on: https://chromium-review.googlesource.com/c/1306844Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#603751} 
- 
dpapad authoredBug: 898763 Change-Id: Iff586501573beaea6ddf8e6ea9d9e5675f480bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1303403Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603750} 
- 
Chase Phillips authoredThis reverts commit d42a4b6f. Reason for revert: The "content/renderer/indexed_db move to Blink" change originally landed as commit d42a4b6f. We received a confirmed report in https://crbug.com/899446 that in one instance an IndexedDB database had its values replaced with incorrect values which bisect showed was caused by that change. We also found a possibly-related issue due to persistence when using Gmail with offline-enabled. This change reverts commit d42a4b6f so the pre-move functionality is restored while we investigate the cause and come up with a fix. This also reverts commit a5b50bfe that removed a using declaration. Original change's description: > IndexedDB: Move content/renderer/indexed_db/ to Blink > > Also in this CL: > - Add a :mojom_modules target to allow mojom files in this group > to link against symbols that only exist in the modules layer. > - Rename indexed*db_struct_traits* to _mojom_traits*. > > Bug: 717812 > Change-Id: I85fa493b345bb6ab955316fe1725e4794ed4c99b > Reviewed-on: https://chromium-review.googlesource.com/c/1265900 > Commit-Queue: Chase Phillips <cmp@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602911} TBR=cmp@chromium.org,dcheng@chromium.org,jsbell@chromium.org,kinuko@chromium.org,dmurph@chromium.org,mek@chromium.org,reillyg@chromium.org,clamy@chromium.org,haraken@chromium.org,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717812 Bug: 899446 Change-Id: I89ba3b64e3b14158d520ed513355b2ac07a09ad4 Reviewed-on: https://chromium-review.googlesource.com/c/1305243Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#603749} 
- 
Josh Pratt authoredAdds feature for Mounting Usbs into Crostini. Bug: 891381, 899568 Change-Id: I36f5cdf88d2901b24c9ef83671418fae64f275ad Reviewed-on: https://chromium-review.googlesource.com/c/1301095 Commit-Queue: Josh Pratt <jopra@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#603748} 
- 
Kent Tamura authoredhttps://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I7a99eaccc08cb2763bfc631f1a725022d59c79f8 Reviewed-on: https://chromium-review.googlesource.com/c/1307013Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#603747} 
- 
Chase Phillips authoredThis reverts commit 3856a7a9. Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/35823 failed in compile: FAILED: obj/ash/app_list/app_list/app_list_view.o ... -c ../../ash/app_list/views/app_list_view.cc -o obj/ash/app_list/app_list/app_list_view.o ../../ash/app_list/views/app_list_view.cc:513:43: error: no member named 'SetBackdropFilterQuality' in 'ui::Layer' app_list_background_shield_->layer()->SetBackdropFilterQuality( ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated. Original change's description: > ui: Lower applist and shelf blur quality > > crrev.com/c/1300235 introduced the option to lower the quality of backdrop > filters. > > This CL lowers the quality of the backdrop blur one the shelf and the > applist shield. > > In this way the texture allocations needed to apply the filter by cc will > be significantly smaller/faster and applying the filter itself will also > be faster on the GPU. > > Bug: 897369 > Change-Id: I57be9434c02b77b38315e0f998d23eda5d277e43 > Reviewed-on: https://chromium-review.googlesource.com/c/1306234 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603660} TBR=oshima@chromium.org,dcastagna@chromium.org Change-Id: Ie3fb29b6d37cd8b409ab5ac910b39a1c52531c6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897369 Reviewed-on: https://chromium-review.googlesource.com/c/1307058Reviewed-by: Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#603746} 
- 
Ben Pastene authoredCapacity's been refreshed. Let's see if we got enough. Bug: 877280, 731759 Change-Id: Iadf72d1220133710c618bbb5468d4a30facf6955 Reviewed-on: https://chromium-review.googlesource.com/c/1306843Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#603745} 
- 
Jun Mukai authoredAs is reported in the bug, the window service receives too many mojo messages for CancelActiveTouches, and that's because it always sends the messages every time CancelActiveTouches is requested. But it doesn't have to send it if nothing has to be canceled. BUG=899429 TEST=manually, and the new test case covers Change-Id: I26b0234ef9e541b5dc31623d27162a0ea374bb54 Reviewed-on: https://chromium-review.googlesource.com/c/1305235 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#603744} 
- 
Sebastien Marchand authoredBug: 895309 Change-Id: Ib777900ba581c77e4e94d998cd36b3ca2ada9ba6 Reviewed-on: https://chromium-review.googlesource.com/c/1282393Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#603743} 
- 
v8-ci-autoroll-builder authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3ca4c14..4a7631f5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I17e8c9f7b9f447bdd5621d04ac28faa05a682918 Reviewed-on: https://chromium-review.googlesource.com/c/1306783Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603742} 
- 
Sidney San Martín authoredThis change is similar to the original (below) with the following additions: - Skip requesting suggestions (and clear the candidate list) if the selection range is invalid. This caused crashes in the field: https://crbug.com/893038. - Skip requesting suggestions if the candidate list is collapsed. - Request suggestions immediately when the candidate list is shown. This relands commit d7c191591846d2138feeaa27d29db322a4cd0fe. Original change's description: > Fix bugs and improve perf in Touch Bar text suggestions. > > - The old implementation recreated the Touch Bar on each keystroke (including > when hidden, I believe), which burns a significant amount of power while > typing. This new implementation updates the existing candidate list, if it > exists and isn't collapsed. > > - Removes a bunch of support code for a behavior that was disabled in r590669. > It moves the remaining code into RWHV itself instead of a dedicated > controller class, which I have mixed feelings about, but ultimately picked > because after the support code was removed, most of what was left was > plumbing between RWHV and TextSuggestionsTouchBarController. > > - [Bigish change] Moves text suggestions out of the window and into the RWHV, > so that hiding and showing as focus and web contents change is left to AppKit > and the responder chain. > > - Fixes small lifecyle-ish bugs around when use this kind of Touch Bar — now > it's tied to the RWHV's input type instead of using a special > WebContentsTextObserver. > > Bug: 717553, 881545 > Change-Id: I8e1eff6da7918f92cfdb47465196d5841a88a7e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1212004 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597371} Bug: 717553, 881545, 893222, 893038 Change-Id: I2f8405f9784514462c2bfe8a754d3ca174f47d27 Reviewed-on: https://chromium-review.googlesource.com/c/1299664 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603741} 
- 
Michael Giuffrida authoredCreates a TimeLimitNotifier class to handle notification details for bedtime and screen time limits, and adds tests. Later, this can be used to hide the notification when it no longer applies, probably by listening to some event. Bug: 898000 Change-Id: Ie7844d6d0639815eac967062ae83b308346485d8 Reviewed-on: https://chromium-review.googlesource.com/c/1295182 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#603740} 
- 
Kristi Park authoredRemove HEAD request logic from custom link URL validation. Combined into one CL in order to avoid re-introducing a Windows crash. Bug: 874194 Change-Id: I89ffe7a0587ea9130b8da4a6fc20a890a31ba412 Reviewed-on: https://chromium-review.googlesource.com/c/1298510 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#603739} 
- 
Takashi Sakamoto authoredThis reverts commit 60b6acc1. Reason for revert: Suspect WebKit Linux Trusty MSAN falure. animations/responsive/filter-responsive-neutral-keyframe.html animations/svg/animated-filter-svg-element.html compositing/child-layer-3d-sorting.html compositing/child-transform-layer-with-foreground-layer.html compositing/clip-path-with-composited-descendants.html compositing/composited-descendant-grandparent-border-radius-mask.html compositing/composited-descendant-requiring-border-radius-mask.html compositing/composited-scaled-child-with-border-radius-parent-clip.html compositing/composited-translated-child-with-border-radius-parent-clip.html compositing/direct-image-compositing.html compositing/flat-with-transformed-child.html ... are crashed. Example: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/10739 Log: STDERR: Uninitialized value was stored to memory at STDERR: #0 0xfee509c in SetAll ./../../components/viz/common/quads/render_pass_draw_quad.cc:69:33 STDERR: #1 0xfee509c in viz::RenderPassDrawQuad::SetNew(viz::SharedQuadState const*, gfx::Rect const&, gfx::Rect const&, unsigned long, unsigned int, gfx::RectF const&, gfx::Size const&, gfx::Vector2dF const&, gfx::PointF const&, gfx::RectF const&, bool, float) ./../../components/viz/common/quads/render_pass_draw_quad.cc:37:0 STDERR: #2 0x101b9bd4 in cc::RenderSurfaceImpl::AppendQuads(cc::DrawMode, viz::RenderPass*, cc::AppendQuadsData*) ./../../cc/layers/render_surface_impl.cc:464:9 STDERR: #3 0x102419cf in cc::LayerTreeHostImpl::CalculateRenderPasses(cc::LayerTreeHostImpl::FrameData*) ./../../cc/trees/layer_tree_host_impl.cc:1095:25 STDERR: #4 0x1024cb03 in cc::LayerTreeHostImpl::PrepareToDraw(cc::LayerTreeHostImpl::FrameData*) ./../../cc/trees/layer_tree_host_impl.cc:1389:28 STDERR: #5 0x1058547e in cc::SingleThreadProxy::DoComposite(cc::LayerTreeHostImpl::FrameData*) ./../../cc/trees/single_thread_proxy.cc:623:31 STDERR: #6 0x10584813 in cc::SingleThreadProxy::CompositeImmediately(base::TimeTicks, bool) ./../../cc/trees/single_thread_proxy.cc:566:7 Original change's description: > ui/cc: Add Layer::SetBackdropFilterQuality > > Computing background blur at full resolution as a backdrop > filter turned out not to be cheap. > > This patch adds a backdrop_filter_quality float to cc::Layer > that can be used to reduce the size of the offscreen canvas > used to compute the blur. > > Currently this float is not exposed on the web and can be used > only from Chrome UI. > > Bug: 897369 > > Change-Id: Ia070772ba576b37a8ee399c3c70b3e2308397e41 > Reviewed-on: https://chromium-review.googlesource.com/c/1300235 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603649} TBR=oshima@chromium.org,ccameron@chromium.org,enne@chromium.org,senorblanco@chromium.org,dcastagna@chromium.org,rsesek@chromium.org Change-Id: I3f83c5aec525ba4199ef9cdb1c21e1fbe62b2fe0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897369 Reviewed-on: https://chromium-review.googlesource.com/c/1306934Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#603738} 
 
-