- 30 Oct, 2019 40 commits
-
-
zhaoyangli authored
This is a reland of cf629e19 Added import of constants.h file in unified_consent_view_controller.h so that internal egtests can continue access the constants. After this CL lands, will change the egtest header in internal code base and remove the constants.h header import here. Original change's description: > Extract unified consent constants target. > > Preparing for SigninEarlGreyUI and SigninEarlGreyUtils EG2 migrations. > > Bug: 922813, 1015907 > Change-Id: I47e4678e40f1820b22938463c5a791c04a662f3c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884286 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710479} Bug: 922813, 1015907 Change-Id: I4584bfdda1a4854e17aac174ba1906b9e80adf09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888601 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#710614}
-
Ionel Popescu authored
https://chromium-review.googlesource.com/c/chromium/src/+/1838997 caused an issue where using up/down keys to highlight autofill suggestions were not read out using VoiceOver and NVDA. The issue was caused by only checking for menu and menuitem roles when the events are fixed. The fix is to extend the checks to include the new roles: listbox and listboxoption. Bug: 1017527 Change-Id: I67f346b7a8a024d1d84d250d8afc63edc125bda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884763 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#710613}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca687f6e0c70..11a79e755c5e git log ca687f6e0c70..11a79e755c5e --date=short --no-merges --format='%ad %ae %s' 2019-10-29 primiano@google.com Trace Processor: Add RestoreInitialTables() method Created with: gclient setdep -r src/third_party/perfetto@11a79e755c5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:143074239 Change-Id: I8db9a9ff724bb2b9fa18557363a73e95a5d92c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710612}
-
Karan Bhatia authored
This is a purely refactoring CL. We are adding support for regex rules to DNR. Currently RulesetMatcher is tasked with evaluating a single ruleset source (An extension can have upto two ruleset sources: static and dynamic). RulesetMatcher implements matching of filter list style rules supported by url_pattern_index. This CL does the following: - Introduce an interface called RulesetMatcherInterface. - Introduce ExtensionUrlPatternIndexMatcher: this will handle all filter list style rules within a ruleset. - Move most of the implementation from RulesetMatcher to ExtensionUrlPatternIndexMatcher. After this CL RulesetMatcher is just a wrapper over ExtensionUrlPatternIndexMatcher. - A subsequent CL will - Introduce RegexRulesMatcher which will handle all regex rules within a ruleset. It will also implement the RulesetMatcherInterface. - RulesetMatcher owns a ExtensionUrlPatternIndexMatcher currently. Subsequently it will also own a RegexRulesMatcher and combine the results from the two. BUG=974391 Doc=https://docs.google.com/document/d/1mRErUMII_gSSPaHmxyn31UOYWUaZLj0xOaezekxD2-Y/edit?usp=sharing (Internal) Change-Id: I580be59c8b19840622c2c673338c0f54087f5186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879565Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710611}
-
Jinsuk Kim authored
The public API returns the underlying application context of |mThemedApplicationContext| which you can also get with |ContextUtils.getApplicationContext| directly. This CL deletes the API and has the call sites use ContextUtils instead. Bug: 925242, 995903 Change-Id: Ie323a815225f67a3876a9a1559eaee8b3dd01687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884402Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#710610}
-
Rob Schonberger authored
This is a major change that adds an implementation of NeuralStylusPalmDetectionFilter, along with a unittest for it. The changes outside of that new file are to support the new class added. Note that no actual implementation of a model is included, and this class is not instantiated or used in this change. Bug: 1009290 Change-Id: Icac32a1a113b0ff83e307bccb3a3d0fc948bcc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880414Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#710609}
-
Alex Cooper authored
If the only features requested for an XRSession can be fully supported by a sensorless session, then just create the sensorless session rather than trying to get a fully device backed session. There were cases where the only requested features were "viewer", but the session was still being backed by the orientation_sensors device. This change introduces an enum that indicates whether sensor data, and therefore a runtime, is needed, optional, or not required. If sensor data is not required, then a sensorless session is created rather than querying for device support. This also refactors "CanRequestSensorlessInlineSession" to an enum, to better consolidate and support this expanded logic. Fixed: 1018794 Change-Id: I0b930a733ccab85275fcc965969a17313cb3cf9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884827 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#710608}
-
Yuly Novikov authored
Pixel_Video_MP4_FourColors_Aspect_4x3 Pixel_Video_MP4_FourColors_Rot_180 Pixel_Video_MP4_FourColors_Rot_270 Pixel_Video_MP4_FourColors_Rot_90 Pixel_Video_MP4_Rounded_Corner TBR=kbr Bug: 1019462 Change-Id: I106e55d37671f92e256f10065b5f7fa081176b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888098Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#710607}
-
Hiroki Sato authored
Previously, a role of the root ARC++ accessibility nodes was changed from rootWebArea to genericContainer. (http://crrev/c/1469064) There was a remaining logic that checks role==rootWebArea. This CL fixes it. This CL also adds an unit test to check string properties, and moved a tooltip related test into here as it was previously in name computation test. Bug: None Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Change-Id: Id945f7fdd3e48455593986b975a339a73c83c1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886554Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#710606}
-
Sadrul Habib Chowdhury authored
Instead of running the webgl/canvas animations for 5 seconds, run them a little longer: 10 seconds. The web-animation tests are also currently run for 10 seconds. So this change aligns these animations. There are ~35 canvas stories, and ~15 webgl stories. So overall, this would increase the runtime, if all tests were to run on the same bot, by ~4 minutes (= 50 * 5seconds). If the stories are sharded, then the increased runtime should not be very noticeable. BUG=894287 Change-Id: I62e341cfd3b605ab4090af2fc185fa1648324459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882760Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#710605}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b07147b04082..e1cda3916cee git log b07147b04082..e1cda3916cee --date=short --no-merges --format='%ad %ae %s' 2019-10-29 sugoi@google.com vkGetPhysicalDeviceFeatures2 fix Created with: gclient setdep -r src/third_party/swiftshader@e1cda3916cee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I195d0d598b2adfd99cf4d0c9b61aaee486225a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888815Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c165bf48..87fb5cb2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib8b2347a9b9844323bdcf3a2bb8982d205c4fa60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888553Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710603}
-
Eugene But authored
The tests will run on ios-simulator-noncq bot. Bug: 987646 Change-Id: I49897122b3088a781c04a56dabb12cb58ef773f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879691 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#710602}
-
Yun Liu authored
Suites in test_suite_exceptions.pyl will cause linker issues when native coverage is on. Also browsertests will generate corrupt data on M, but not on higher Android apis. So that plan to separate Java and native coverage on CI right now. Bug: 985574 Change-Id: I02133b11a3c85beb5388790f009a4c2c7f0d09f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885217 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#710601}
-
Ken Rockot authored
This is a reland of 75651994 Original change's description: > Introduce DataDecoder API > > This provides a new DataDecoder API in the data_decoder client library, > allowing for clients to use the service for isolated and batched > operations without any dependency on the Service Manager or the > cumbersome usage of batch IDs. > > Only JSON parsing facilities are added to DataDecoder in this CL. > > The JsonSanitizer API is cleaned up a bit too, as is some test code. > > Bug: 977637 > Change-Id: I5798982a500a403ddb345ab40db35d466dc6b7fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879792 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710438} Bug: 977637 Change-Id: I2d5146230e40db0bc3bc74b1b08c0409054d9917 Tbr: avi@chromium.org Tbr: blundell@chromium.org Tbr: rsesek@chromium.org Tbr: sorin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888783Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#710600}
-
Mike Klein authored
This will fold away color filters before SW backend blitters see them. Change-Id: Ic7c6e6b9aa5a9a863e8092d28b9577b043f3e520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883620 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#710599}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b69001f36f76..e662695654ff git log b69001f36f76..e662695654ff --date=short --no-merges --format='%ad %ae %s' 2019-10-29 senorblanco@chromium.org Roll to ToT Dawn. 2019-10-29 mtklein@google.com hold a ref on Key effects 2019-10-29 mtklein@google.com rough sketch of shaders in SkVMBlitter 2019-10-29 mtklein@google.com support 3D masks in SkVMBlitter 2019-10-29 mtklein@google.com add a paint-color string to gm/emboss 2019-10-29 csmartdalton@google.com Reland "Revert "Revert "Rename gl_SampleMask to sk_SampleMask""" 2019-10-29 senorblanco@chromium.org Dawn: workaround X11 #defines for Always, Success, None. 2019-10-29 nigeltao@google.com Test Codec::getFrameCount updates with more data 2019-10-29 jvanverth@google.com If drawing an image as tiled fails, fallback to other methods. 2019-10-29 brianosman@google.com Use GPU special images in two GPU image filter tests 2019-10-29 egdaniel@google.com Remove outputSwizzle from GrRenderTargetProxy. 2019-10-29 brianosman@google.com SkMorphologyImageFilter: Avoid integer overflow with large radii Created with: gclient setdep -r src/third_party/skia@e662695654ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:1018190 Change-Id: I6d97455585f477e6a7ac976d36ab223f35b4a159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888812Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/882b743a85b7..2677bf6cf3de git log 882b743a85b7..2677bf6cf3de --date=short --no-merges --format='%ad %ae %s' 2019-10-29 mmortensen@google.com BuildAPI: Finish Package Mock responses. 2019-10-29 wbbradley@chromium.org build api metrics: use proper delimiters between cpv components 2019-10-29 dburger@chromium.org Remove scheduling of master-chromium-pfq and children. Created with: gclient setdep -r src/third_party/chromite@2677bf6cf3de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iece7604672a683308e138ce7e1dc04ac0a915f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888813Reviewed-by:
-
Darwin Huang authored
Small/Simple refactoring change. No functional changes. Change-Id: Idd64a7cf2fb76a34b8518246087f6becc11f1c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885976 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#710596}
-
Miriam Zimmerman authored
Previously, the background of the header was too light for the text that it contained. With this change, the ratio is now 4.5. BUG=chromium:1005543 TEST=Verified contrast of a screenshot with color contrast checker. Change-Id: Ia3b67419ee4b69181afb6e0084c593d13b00ec05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887727Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#710595}
-
Javier Fernandez authored
As part of the preferred width computation of LayoutText objects, we have an specific function to implement the min-word-fragment of a text. We are handling the case of break-all and break-word differently, and that's right. However, we are using the BreakIterator only in case of break-all. This caused that we consider valid to break grapheme clusters when computing the min-content size, which leads to wrong values in some cases, like the one described in the bug. This CL changes the mentioned logic to rely always into the BreakIterator, which knows better when is valid to break the text. Bug: 1013775 Change-Id: Ia152d346a61b6b54eaac185a399b0d572e3aba4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857319 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710594}
-
Jay Harris authored
This lets web apps that can handle files show up in the open-with menu on Linux. Note: This is still experimental and hidden behind the NativeFileSystemAPI and FileHandlingAPI flags. In addition, some work needs to be done to register custom mimetypes with the operating system as in: https://specifications.freedesktop.org/shared-mime-info-spec/latest/ar01s02.html Bug: 829689 Change-Id: I92bcc07cb5dffaa715c409bc6cf07c8410db34ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833027 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#710593}
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::P2PTrustedSocketManager using Remote. Bug: 955171 Change-Id: I6db67452dd0cfaa3caafe33f31edcef9b8c7c717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883348Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#710592}
-
Alan Cutter authored
This CL updates CustomTabBarView to report its class name to native UI devtools. Bug: 853593 Change-Id: I9b56a2138ef08d54a604f67fa5dd7eaf8e9b19b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888851 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#710591}
-
Xianzhu Wang authored
Most of these rebaselines are for the mock scrollbar change which missed rebaselining for CAP. The other rebaselines are for new tests added for virtual/controls-refresh. TBR=schenney@chromium.org Change-Id: Ia710bd0bf371eae8367c1ee3739691985f314840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888572Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710590}
-
Junyi Xiao authored
Temporarily disable the test for landing this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1874670 Bug: 842488 Change-Id: If5bfe378e5b9d656c645c64ff0a187fa41b81ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888378 Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710589}
-
Tina Lu authored
Bug: 1018380 Change-Id: I8dbfc8b1d181c39935e3d877675d3fd696c80af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888514Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Tina Lu <ltina@google.com> Cr-Commit-Position: refs/heads/master@{#710588}
-
Yi Xu authored
StrokeRect can get inflated, which may go to infinity. Generalize the validation functions for double and float and validate rect during strokeRect. Bug: 1010586 Change-Id: Id2e057bf1f5789b334a8ad3155a1da0a1a91b8f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869034 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710587}
-
kdillon authored
Previously, these experiments would not change the compositor priority if it was set to highest or higher in one of the use cases. This precluded the compositor gesture use case in which the priority would be set to low as a proxy for prioritizing loading. We suspect this caused regressions in jankiness metrics during the experiment as the low priority could be changed to very high or normal. This cl changes it so that we will only overwrite compositor priority if it has not been set because of a use case. Bug: 966177 Change-Id: If3ecfa898249f3f9ce52b1afbcfc7320dbbd96b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877814 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710586}
-
Ahmed Mehfooz authored
Initializing the system tray and message center with chrome vox enabled causes a crash when the tray event filter references the message center bubble before it's constructor is fully executed. This fix ensures this doesn't happen by separating the constructor from the part of the code which shows the bubble. Change-Id: I297bf5212fb82a3372081dc418c25473f22d5cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881689 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#710585}
-
Austin Tankiang authored
With the removal of the legacy drive client, DriveFsTestVolume can be used instead. Bug: 1003238 Change-Id: I57e99412c4a22c6bfa2d831f3506dc48309fa489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885865 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#710584}
-
Timothy Loh authored
Change-Id: Ie57165228901ff1c85907ea7c1e20829b3a04e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884403Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710583}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9a8fdbed. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Idf4fb87083981a1b900aaf42b42f929309fdef28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888575Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710582}
-
Mitsuru Oshima authored
Bug: 1019485 Change-Id: I016c2529ad046180be57e8904a16fff9ff0b6c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887874Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710581}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 79 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-04-26. Change-Id: I606fe320a735c8914ca01400ccc3b8bb3abc553b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886631 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#710580}
-
Yusuf Sengul authored
?sz={n} query parameter to specify the Google profile image size doesn't work. It may not be supported anymore. This change fixes it as well as adds logging in a couple of places. Bug: 1019032 Change-Id: I4fe794ac5e8f04b3624de2d021dd2a526e565294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885346Reviewed-by:Tien Mai <tienmai@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#710579}
-
Wei Li authored
The manual layout just put one child view at the start and one in the middle vertically. This CL removes the manual layout by introducing two container views to be placed in equal size vertically. BUG=1005568 Change-Id: Iae552da751d71175d3967deaf788a323221d0a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884999 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#710578}
-
Regan Hsu authored
Currently, the confirm button is not disabled while the password is being checked,serving a confusing experience as users can repeatedly hit the confirm button without a visual ack that the password is being checked. This CL disables the confirm button while the password is being checked. Bug: 999475 Change-Id: I907017dd1f7bfdf4cff318b0621d730b113200bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888150 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710577}
-
Jesse Schettler authored
Replace PrintMsg_PrintingDone, PrintMsg_PrintPages, and PrintMsg_SetPrintingEnabled IPC messages with new Mojo methods. Update AwPrintManager and HeadlessPrintManager to also use these new methods. Bug: 1008939 Test: Print a webpage and PDF Change-Id: I3a403dd47ffc9c4debe819d26b00eccbd24b1180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876473 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
Avery Musbach authored
The present CL modifies GetGridBoundsInScreenForSplitview so that it uses the correct split view controller when on an external display. SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.Dragging Test: ash_unittests Bug: 1019221 Change-Id: Ibba4867a342d6a4057e7bb724fbd24b0dae85d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887837 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#710575}
-
