GitLab

This reverts commit 8bd3e513.

Reason for revert: identified as likely cause for flakyness of PreviewsLitePageServerBrowserTest.LitePagePreviewsNavigation by FindIt

Original change's description:
> Integrate Lite Page Server Previews with the Previews Stack
> 
> Adds Lite Page Server Previews to DetermineAllowedPreviews and
> DetermineCommitted. For now, the preview is always allowed if the
> feature is enabled and is committed if the URL matches.
> 
> This intentionally leaves an open question about whether more logic
> in the NavigationThrottle can/should be moved into the DeciderImpl.
> 
> The biggest part of this change is moving the URL checking logic to
> the previews component and adding additional helper functions there.
> 
> Bug: 898557
> Change-Id: Iccc0b672eeedbe23942f4d17f6afd214426372a9
> Reviewed-on: https://chromium-review.googlesource.com/c/1323800
> Commit-Queue: Robert Ogden <robertogden@chromium.org>
> Reviewed-by: Doug Arnett <dougarnett@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607427}

TBR=dougarnett@chromium.org,robertogden@chromium.org

Change-Id: Iaa200e39f10086d95654bc7fb7485c66d3f53ed0
No-Presubmit: true
No-Tree-Checks: true
Bug: 898557,904830
Reviewed-on: https://chromium-review.googlesource.com/c/1333814Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607613}

It assumes a specific ordering between immediate and delayed tasks that is
not guaranteed by the SequencedTaskRunner API which only states that :

//   - Given two tasks T2 and T1, T2 will start after T1 starts if:
//
//       * T2 is posted after T1; and
//       * T2 has equal or higher delay than T1; and
//       * T2 is non-nestable or T1 is nestable.

This property is already verified by
MessageLoopTypedTest.PostDelayedTask_InPostOrder_3 and recursive post task
ordering is verified by MessageLoopTypedTest.RecursiveDenial1.

R=gab@chromium.org
BUG=891670

Change-Id: Ic340df17dcd3529565564dff3c18c64f48bd1d2d
Reviewed-on: https://chromium-review.googlesource.com/c/1333772Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607612}

as it is flaky

BUG=904841
TEST=test only change
TBR=antrim@chromium.org

Change-Id: If14a89ef3e6488867860601b9191e55381245547
Reviewed-on: https://chromium-review.googlesource.com/c/1333757Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607611}

This reverts commit 2687587b.

Reason for revert: This triggers a use of initialized value on the msan bots. I believe you forgot to initialize is_removing_imm_entry_

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8929963931985091872/+/steps/unit_tests/0/logs/ArcInputMethodManagerServiceTest.EnableIme/0

==14387==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x5638655272d9 in arc::ArcInputMethodManagerService::ImeMenuListChanged() ./../../chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc:394:7
    #1 0x56385b307d20 in arc::ArcInputMethodManagerServiceTest_EnableIme_Test::TestBody() ./../../chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc:313:14
    #2 0x56385dbb3cb2 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #3 0x56385dbb3cb2 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2522:0
    #4 0x56385dbb7a6b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2698:11
    #5 0x56385dbb9559 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2816:28
    #6 0x56385dbf2614 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5182:43
    #7 0x56385dbf0ee7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #8 0x56385dbf0ee7 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4791:0
    #9 0x56386b81af20 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2333:46
    #10 0x56386b81af20 in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0
    #11 0x56386b822e8a in Run ./../../base/callback.h:99:12
    #12 0x56386b822e8a in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0
    #13 0x56386b822607 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:575:10
    #14 0x56386b7e9154 in main ./../../chrome/test/base/run_all_unittests.cc:30:10
    #15 0x7fd6f88f4f44 in __libc_start_main ??:0:0
    #16 0x5638521e2b09 in _start ??:0:0

Original change's description:
> Disable Android IMEs according to given ImeInfo.
> 
> Android IMEs can be disabled in Android side by using 'ime' command.
> This CL ensures that disabled IMEs are also disabled in Chrome OS's
> InputMethodManager.
> 
> Bug: b/119274469
> Change-Id: I46c2996a41327221470d69b778da2b7270c73cd2
> Reviewed-on: https://chromium-review.googlesource.com/c/1331294
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607473}

TBR=yusukes@chromium.org,yhanada@chromium.org

Change-Id: I5fd93607e711cd90edc4eb0ccf656b4c82ad5555
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/119274469
Reviewed-on: https://chromium-review.googlesource.com/c/1333892Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607610}

WebAuthN UI modal should only show Bluetooth security keys in device
selection modal if the security key is in pairing mode and not already
paired. As so, plumb FidoAuthenticator::IsPaired() to WebAuthN Chrome
embedder layer.

Bug: 877344
Change-Id: I214ef45b833cbf3c9258be10b4a83b43f4b51167
Reviewed-on: https://chromium-review.googlesource.com/c/1319631
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607609}

IconLabelBubbleView is a Button and should use Button::GetAccessibleNodeData,
not Label::GetAccessibleNodeData. Setting its button text causes the right
behavior here.

Before: "This site is using your location."
After: "This site is using your location. Button."

Maybe ideally: "This site is using your location. Manage location access.
               Button."

... but that requires new strings.

Bug: 879014
Change-Id: I7b4840e17ea70eede41ee0b3095a8a2de288c6ea
Reviewed-on: https://chromium-review.googlesource.com/c/1331668
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607608}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d6eeae28d72..a20b35ec2dc1


Created with:
  gclient setdep -r src-internal@a20b35ec2dc1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I99fb2333987a8240bb457e8ff95037878b43502d
Reviewed-on: https://chromium-review.googlesource.com/c/1333851Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607607}

There is a kSymbolKey in the public API and due to the new
enum shadow warnings, jumbo builds might combine the code in
such an order that the public blink::WebInputEvent::kSymbolKey
shadows the blink::{anonymous namespace}::kSymbolKey.

Note, there is no bug, just an unfortunate false warning and one
that only appears in rare jumbo builds.

Change-Id: Id575b2aef3b3f1be46d3722ed79454212bcf650e
Reviewed-on: https://chromium-review.googlesource.com/c/1333649
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607606}

https://skia.googlesource.com/skia.git/+log/9e3109c99ea5..60b6bc3c2950


git log 9e3109c99ea5..60b6bc3c2950 --date=short --no-merges --format='%ad %ae %s'
2018-11-13 brianosman@google.com Use WriteVertexData in GrTessellator, remove all DefaultGeoProc structs


Created with:
  gclient setdep -r src/third_party/skia@60b6bc3c2950

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@chromium.org

Change-Id: I664b7d784a81890fb6b086bfaf56519d79f3fdc6
Reviewed-on: https://chromium-review.googlesource.com/c/1333852Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607605}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2fc18984..0e317c5c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I9b0c537a35e63f24742ebbb5b0c7fe351d432b83
Reviewed-on: https://chromium-review.googlesource.com/c/1333729Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607604}

Bug: 860311
Change-Id: I64a96abec0161200fb55f78c5492e20970fa9c3b
Reviewed-on: https://chromium-review.googlesource.com/c/1333369Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607603}

https://android.googlesource.com/platform/external/perfetto.git/+log/4afdd6426477..0b46de2db691


git log 4afdd6426477..0b46de2db691 --date=short --no-merges --format='%ad %ae %s'
2018-11-13 primiano@google.com Merge "Deflake TracingServiceImplTest.WriteIntoFileAndStopOnMaxSize."


Created with:
  gclient setdep -r src/third_party/perfetto@0b46de2db691

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I90135bd3fee0e58dc88cf6100472381a732d0786
Reviewed-on: https://chromium-review.googlesource.com/c/1333847Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607602}

In jumbo build experiments, two cc files both defined
interface_name<PPB_InputEvent_1_0>() which clashed since in
jumbo builds many cc files are compiled in the same translation unit.

This moves the shared code to a shared file.

Bug: 898475
Change-Id: I9ce58e837d663cb5c15ba2596c22812a41def4c0
Reviewed-on: https://chromium-review.googlesource.com/c/1297148Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sam Clegg <sbc@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#607601}

Previously, downgrades were only possible via master_preferences (for
use by the enterprise wrapper). This change makes downgrades possible
via the command line.

BUG=607592
R=zmin@chromium.org

Change-Id: I5885fe9eb1b2f2ba477958a9d06797da6e9d4acc
Reviewed-on: https://chromium-review.googlesource.com/c/1333811Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607600}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f1ff631c9f6c..c59d48ec1594


git log f1ff631c9f6c..c59d48ec1594 --date=short --no-merges --format='%ad %ae %s'
2018-11-13 dgarrett@google.com manifest_version: Add resolution helpers for buildspecs.


Created with:
  gclient setdep -r src/third_party/chromite@c59d48ec1594

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ibc7c3cccd04799b23d4a10ec7b89153778e6b5f9
Reviewed-on: https://chromium-review.googlesource.com/c/1333850Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607599}

Change-Id: Ic6f6d7b29443395105c8a3619b74bac9f464666e
Reviewed-on: https://chromium-review.googlesource.com/c/1330062Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607598}

Currently there is a call to rAF inside step_func_done which means the
test will actually complete before the rAF fires and so the assert_true
will never run.

Bug: 887659
Change-Id: Ic3d017cb106994507cba995ccf41133902c0d101
Reviewed-on: https://chromium-review.googlesource.com/c/1333887
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607597}

https://gn-review.googlesource.com/c/gn/+/3200 removed the --no-sysroot
option from gen.py and moved to only use a sysroot in the GN bots, so the
options here no longer have any effect.

Bug: 904350
Change-Id: Ieddc71a4f8f802c2d050de1c69ca3a9ec788ee88
Reviewed-on: https://chromium-review.googlesource.com/c/1333391Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#607596}

Using wpt-import in Chromium 4c6f6e21.
With Chromium commits locally applied on WPT:
9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I89e3faebc7872e892ad5ec43b0b3bcd8fd514021
Reviewed-on: https://chromium-review.googlesource.com/c/1333728
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607595}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f343a1576406..2b1f6b373ca9


git log f343a1576406..2b1f6b373ca9 --date=short --no-merges --format='%ad %ae %s'
2018-11-13 sheredom@gmail.com Validate that VertexId and InstanceId are not allowed in Vulkan. (#2036)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@2b1f6b373ca9

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ibf1eb4d5be24102a7c77f0ecf9e92f735ee0cb16
Reviewed-on: https://chromium-review.googlesource.com/c/1333848Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607594}

Because of expecting '.' in every orderfile entry the current
compare_orderiles.py observes zero symbols in recent orderfiles.

Add a separate (simpler) path to parse the new orderfiles (with symbols
only). Also add an option to keep the downloaded orderfiles in /tmp for
further inspection.

Tested with orderfile commits:
new: 03cc43767b83b9b3460461dc5636be1ce1e74e51
old: a4b93acc41d5e19e4cbfb86d802f442dce10e38f

One new worry is that for newer orderfiles the 'average fractional
distance' is usually about 4.50% while for the old orderfiles it used
to be less than 0.5%. There are 1.4x more symbols now than there were
back then.

Bug: 893981
Change-Id: I1c812d4d67f68e0ee0fc31273104a2145fbebaa9
Reviewed-on: https://chromium-review.googlesource.com/c/1333648Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607593}

The new story is named cct:no_warmup:bbc

Bug: 760498

Change-Id: I11a1d2e0b9b4a9dbfb4c4f31f039c4ca3bbe75c6
Reviewed-on: https://chromium-review.googlesource.com/c/1301914
Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607592}

https://codereview.chromium.org/2860663006/ forgot to update the
kTypeLast.

Change-Id: Ieae9b0711c841a00357dfd3190c6ed9e1c5c86a6
Reviewed-on: https://chromium-review.googlesource.com/c/1331045Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607591}

Changed finch study name to account for changes in the recently reviewed and submitted revised Autofill Aisstant finch experiment (http://cr/221236914).

Previously, the overlay experiment was designed as a standalone finch experiment. Now, overlay_color is a parameter of the existing AutofillAssistant finch experiment.

Bug: 806868
Change-Id: I0ed398900f30480112c81a892655e0a08a81a034
Reviewed-on: https://chromium-review.googlesource.com/c/1333448
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607590}

Bug: 806868
Change-Id: Idba43630fae018d6791e4f089e7b05e35f628693
Reviewed-on: https://chromium-review.googlesource.com/c/1332627Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607589}

Change-Id: I81941775176835e2dd93f31965183dc4f3e43ab3
Reviewed-on: https://chromium-review.googlesource.com/c/1333747Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607588}

This uses a PostMessageHandler internally to communicate with the web contents.
The PostMessageHandler is initialised once the dynamic module has been loaded
and is reset each time the web contents change.

A new class, ActivityDelegatePostMessageBackend, replaces the service backend
usually used by PostMessageHandler and forwards all events along to the
dynamic module if it's present.

Bug: 898840
Change-Id: Ia308c84cd771d2fdb96fc076472488fc48946162
Reviewed-on: https://chromium-review.googlesource.com/c/1323669
Commit-Queue: David Barker <barkerd@google.com>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607587}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29ce020e1568..7d6eeae28d72


Created with:
  gclient setdep -r src-internal@7d6eeae28d72

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6ac8cc23fe08ef903dcc49ea4077c0b928cada6c
Reviewed-on: https://chromium-review.googlesource.com/c/1333529Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607586}

As requested on the bug.

R=fdoray@chromium.org

Bug: 736531
Change-Id: I8f1fda7cc7e5973c72b2c9ff970c8a88620e0ca5
Reviewed-on: https://chromium-review.googlesource.com/c/1332768
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607585}

The relevant header is renamed to not imply that it's part of the
generator only, and added as a source of both the generator and of
the platform component.

Some mild renaming included, but optional.

This resolves a gn check failure in //third_party/blink/renderer/platform.

Change-Id: Ic7b3f7c7e70307cea99fa7cbdd9787484f9a0122
Reviewed-on: https://chromium-review.googlesource.com/c/1329841Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607584}

Includes translator from autofill::CreditCard. Will be used in manual_fill in a follow up cl.

Bug: 845472
Change-Id: I1f70757e5de4ace6f12a3dfebbcf263c960a7d57
Reviewed-on: https://chromium-review.googlesource.com/c/1331391Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607583}

- Fixes a bug when there are fewer most visited tiles than 4.
- Properly updates the most visited tiles and suppresses updates when
the tiles are visible.

Change-Id: Ide1a6307b643cce3a1bf73a4a98082e06b1e8a9c
Reviewed-on: https://chromium-review.googlesource.com/c/1296590
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607582}

With this CL, perf FYI builders sharding data can be generated by running:
$ ./tools/perf/generate_perf_sharding update -w perf-fyi -r

This CL also remove 'One Buildbot Step Test Builder' in
perf.fyi.json since the corresponding builder has been removed.

BUG:chromium:898832

Change-Id: I7caf239d55259b95418750bdecf3ccb4d6e94398
Reviewed-on: https://chromium-review.googlesource.com/c/1318682Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#607581}

https://android.googlesource.com/platform/external/perfetto.git/+log/01a7fc207e58..4afdd6426477


git log 01a7fc207e58..4afdd6426477 --date=short --no-merges --format='%ad %ae %s'
2018-11-13 fmayer@google.com profiling: Write bookkeeping to trace


Created with:
  gclient setdep -r src/third_party/perfetto@4afdd6426477

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I33f5ddb70d5baa60642b5889effac5355af95c4f
Reviewed-on: https://chromium-review.googlesource.com/c/1333528Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607580}

NGInlineItemsBuilder::ToString() removes trailing spaces at
the end of the block. This is unintuitive from the function
name, and caused CL:1322184 to be reverted.

This patch moves this to ExitBlock(), and make ToString()
clean, without side effects.

Ran webkit_unit_tests locally with DCHECK disabled.

Bug: 636993
Change-Id: I03f814afc272b9be0c274391cde076aecb6dbc91
Reviewed-on: https://chromium-review.googlesource.com/c/1329804
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607579}

This is mainly to take
https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1314232

Bug: 894045
Change-Id: I1d44c36232d2771ea881c8fd1ca04fdfbf596ef4
Reviewed-on: https://chromium-review.googlesource.com/c/1333093Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607578}

SyncUserSettings is a new class that encapsulates all the
user-configurable knobs for Sync. It replaces a bunch of setters
and getters directly on the SyncService.

Bug: 884159
Change-Id: I219dc4d37ecd4a9eac1a7fb40f50b6b0bc2cb88d
Reviewed-on: https://chromium-review.googlesource.com/c/1331402Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607577}

It was disabled, because it used to fail. Now it passes. Don't remember
the details.

Bug: 889449
Change-Id: I0cd4b0f6fa5bb37494e814818740b3e35afc6fbe
Reviewed-on: https://chromium-review.googlesource.com/c/1333374Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607576}

The previous message contained the duration, which was confusing because the message was static and did not change while the timer was running. However, implementing a changing countdown message is somewhat tricky and not directly supported by snackbars. This change is a UI workaround to avoid this confusion.

Bug: 806868
Change-Id: I6d7a0c98545741341df2f8200acc49c4ebf776dd
Reviewed-on: https://chromium-review.googlesource.com/c/1331393Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#607575}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9e77655d..2fc18984

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I366c17cb100d429d34383d5f7e837ce862c11129
Reviewed-on: https://chromium-review.googlesource.com/c/1333467Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607574}