- 09 Mar, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Idd99d738b9a53dbc0201695ff1fc088121990e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748151}
-
Hans Wennborg authored
This shaves a few minutes off the clang packaging time, simplifies our build script, and brings the build config for lld closer to that for clang so that we can potentially build them in one go in the future. Building lld without thinlto does not appear to affect its performance. Bug: 884608 Change-Id: I4c3c39aa935fdb0a0977b1dd46400eee02d76dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089835 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#748150}
-
David Jean authored
Bug: 1049638 Change-Id: I623e7655777a023df89299ef4211e891d0b69cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091528Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#748149}
-
Kuo Jen Wei authored
The switch resolution race is caused by logic of enabling switching options right after STREAMING ready and before camera configuration finishing. This CL fix the race by introducing new CAMERA_CONFIGURING state will be flagged during the camera stream reconfiguration process. Bug: b/147567355 Test: Manually test clicking on the resolution options when it's clickable and won't jump back to previous option after clicked. Change-Id: I32153ff78bc1bc6a3478225479e289e5617851a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082665Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#748148}
-
Noel Gordon authored
The tab hover color was visually too dark G Grey 200 (should be 100). Bug: 992819 Change-Id: I96c02a72fc4d23ec0a3bb7981ed4429de4ef0210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094580Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748147}
-
Ewann authored
This CL Renames page_info_legacy_coordinator. and page_info_config. files, preparing for the implementation of the page info site security. Bug: 1038919 Change-Id: I91a62fd92589f1f6b406b4680c7f7bc1636b24de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089849 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Kei Nakashima authored
|MoveTo| moves the target node before the node with the given iterator in a linked list. This operation is executed by just updating indices of related nodes. Change-Id: I49fef39956717d878a505a0431d5d25b32c90bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094837Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kei Nakashima <keinakashima@google.com> Cr-Commit-Position: refs/heads/master@{#748145}
-
Takashi Sakamoto authored
- RendererScheduler.TasksWithSafepoints.TaskTime - RendererScheduler.TasksWithSafepoints.TaskSliceTime - RendererScheduler.TasksWithSafepoints.SafepointCount - RendererScheduler.TaskCountPerFrameType.HasSafePoint - RendererScheduler.TaskCountPerFrameType.HasSafePoint.LongerThan50ms - RendererScheduler.TaskCountPerFrameType.HasSafePoint.LongerThan150ms - RendererScheduler.TaskCountPerFrameType.HasSafePoint.LongerThan1s - RendererScheduler.TaskCountPerFrameType.HasSafePoint.LongerThan16ms - RendererScheduler.TaskCountPerFrameType.HasSafePoint.LongerThan100ms Change-Id: I398f21352485f49fda5e99ba6e2b2e62a7e0e000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063619Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#748144}
-
Rohit Agarwal authored
We currently don't have extensive tests on java side which checks any leakage of data across activities. This CL adds browser tests to check cookies leaks involving both Tabbed and CCT activities for both regular and incognito mode. Bug: 1035770 Change-Id: Iba3481d51923c0a30ec38646b25614db36549bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054109 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#748143}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: I75d6d7c3c5a6e62e4fcdcb8dafb3bea44d766f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093963 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#748142}
-
Anastasiia Nikolaienko authored
Add 'Education account' labels for secondary accounts for Child users (Child users will be able to add only EDU accounts). Bug: 1043108 Change-Id: I4fad5c5a3da32538cacdb7e7557f2756ceef4a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007823 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#748141}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0268f16c7e98..5e9dd1d5e265 git log 0268f16c7e98..5e9dd1d5e265 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 szuend@chromium.org [utilities] Use Set instead of Array in ServiceWorkerCacheTreeElement Created with: gclient setdep -r src/third_party/devtools-frontend/src@5e9dd1d5e265 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47b0c3e02f96dcbbaec8649c1291de71c8be33ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094686Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/aa95c80e1a89..6861ea4e10a1 git log aa95c80e1a89..6861ea4e10a1 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 johnkslang@users.noreply.github.com Merge pull request #2101 from travisfoo/master Created with: gclient setdep -r src/third_party/glslang/src@6861ea4e10a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I13047c26c6031693bc7a6dc62fdb45641768296a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094689Reviewed-by:
-
Gauthier Ambard authored
The first run animation is done with the BVC being shown and the FirstRunViewController being presented on the same runloop. On official, this calls the completion handler of the BVC animation with finished at NO even if it actually completes. For now this CL fixes it by ignoring the finished value as it is not taken into account anywhere else (so it is not working). The long term solution will be to have a better way to present the first run. Fixed: 1056697 Change-Id: Iaf30240f4da98cf9d5856d34b6be174b371f1ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089767Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#748138}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3f3ca3d9d2ba..b0a8b6693f9b git log 3f3ca3d9d2ba..b0a8b6693f9b --date=short --first-parent --format='%ad %ae %s' 2020-03-09 eseckler@google.com Merge "Remove single dangling _COMPONENT suffix" Created with: gclient setdep -r src/third_party/perfetto@b0a8b6693f9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I93b9e64cb364daf7ff870b0ef84a56cf5d7cddfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094685Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1987b8f36714..0154105fc14c git log 1987b8f36714..0154105fc14c --date=short --first-parent --format='%ad %ae %s' 2020-03-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src da581c3b..5c8f724b (551 commits) 2020-03-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9acaf6626042..0c9b6abde90c (11 commits) Created with: gclient setdep -r src/third_party/skia@0154105fc14c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I8b867c2ef83138c2e7b5c36c7ad0054aa891b7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094682Reviewed-by:
-
Luciano Pacheco authored
Fix the selector to be able to reach to <button> or <cr-button> in the toolbar. Bug: 1035691 Change-Id: I75ddda33c00914c049d048209e1d21cf761b4758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094063 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748135}
-
Yuichiro Hanada authored
Clients of exo expects to handle the key repeat in the client side according to crrev.com/c/1079768. Therefore, exo::Keyboard silently ignores the key repeat events. However, it doesn't mark the key repeat events as handled and they are used to invoke the accelerators. This CL changes exo::Keyboard to mark the key repeat events as handled, then they are not used to invoke the accelerators anymore. Bug: b/149477038 Test: Hold Ctrl and W on an ARC++ app which eats Ctrl-W key event, and check that the app doesn't close. Change-Id: Iab480b94b98ea8d3e12ce67b810162f1f671e3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091328Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#748134}
-
Makoto Shimazu authored
New service worker needs to update loader factories after the main script is loaded because COEP header in the response header for the main script needs to take effect. This CL is to update the loader factories for loading imported scripts. Bug: 1039613 Change-Id: I5a4f74c8037c47c4b14daf0608f8477f34569666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087209 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#748133}
-
Xianzhu Wang authored
If a box paint no background display items, let the paint chunk (which is created if necessary) contain the empty backgrounds, to ensure the containing composited layer to contain the bounds of the background for correct composited hit test. Bug: 937573 Change-Id: I8c3ecd1ade6ee13eac0df41140eeb5021ace9e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070688 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#748132}
-
Kent Tamura authored
This CL renames HTMLSelectElement::OptionToBeShown() to OptionToBeShownForTesting() because it is used only by testing code. This CL has no behavior changes. Bug: 1052232 Change-Id: I8522a59be99958be526fd59f4494860755666254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094520Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a77d0ef73e6b..43f79a1d77b2 Created with: gclient setdep -r src-internal@43f79a1d77b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I102ada0f3cbb2c20e4acb64c414418620230d742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094680Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748130}
-
Kenichi Ishibashi authored
The bug was fixed and we don't observe flakiness any longer. Remove the instrumentations. Tbr: kinuko@chromium.org Bug: 946719 Change-Id: I7f31002516f2507a7205ab5c2680ebcf3f748e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094375 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#748129}
-
S. Ganesh authored
The display name changes from the format "Google Chrome Elevation Service" to "Google Chrome Elevation Service (GoogleChromeElevationService)". Bug: 1059459 Change-Id: I3505a1c2fea6deee66e7d2395a7e9594e76dc95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092671 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#748128}
-
Hiroki Nakagawa authored
This CL makes DedicatedWorkerHostFactoryImpl use its |parent_execution_origin_| (renamed to |creator_origin| by this CL) for starting a dedicated worker instead of an origin passed from a renderer process. This was not feasible before because |parent_execution_origin_| is provided from parent's |RenderFrameHostImpl::last_committed_origin_| that is set during navigation commit. Worker creation IPC from the renderer to browser could race with navigation commit, and could see the wrong last committed origin. Now this is feasible. This is because worker creation IPC is now tied with RenderFrameHostImpl's BrowserInterfaceBroker that is re-bound during navigation commit[*]. This ensures that worker creation requests issued before the navigation commit are discarded by the previous BrowserInterfaceBroker, and new requests via the new BrowserInterfaceBroker are scoped to the new last committed origin. [*] The call path between binding BrowserInterfaceBroker and updating the last committed origin is as follows. These are synchronously done. - RenderFrameHostImpl::DidCommitNavigation() re-binds the interface broker https://source.chromium.org/chromium/chromium/src/+/master:content/browser/frame_host/render_frame_host_impl.cc;l=7489;drc=d54ee0c3d25dfc644282b50c5f57e23b7ab4dda4?originalUrl=https:%2F%2Fcs.chromium.org%2F -> RenderFrameHostImpl::DidCommitNavigationInternal() -> NavigatorImpl::DidNavigate() -> RenderFrameHostImpl::DidNavigate() -> RenderFrameHostImpl::SetLastCommittedOrigin() Change-Id: Id69c3d66e50aa8cbb7fee520a1479b28970de1c6 Bug: 906991, 1030909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971660Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#748127}
-
Alan Cutter authored
This is part of an experimental implementation of tabbed web app windows hidden behind the DesktopPWAsTabStrip flag. This CL adds a UI option for Chrome OS that lets users assign individual web apps to be opened in the experimental tabbed window. Because this option is experimental and users may turn the flag off at any time we do not store this setting in the same place as the launch container setting. Instead we store it in a per web app "experimental_tabbed_window_mode" pref. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=436695&signed_aid=pNFo1z1fXrwGgoTkDSgTXA==&inline=1 Bug: 897314 Change-Id: Ie0a9417e38fd0cfc593d93b5b97224742b37d841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086465 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#748126}
-
Kei Nakashima authored
LinkedListInVector maintains a linked list in a vector. It uses prev/next indices instead of pointers. Implemented iterators and insert functions. Change-Id: I7e15734b5c209618c4760efe65b7e68f1f827b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089543Reviewed-by:
-
Noel Gordon authored
Some styles need to be avoided if Files app <html> is in a .col-resize CL:1851789 to avoid scrollbars. Detect with simpler class selector. Bug: 992819 Change-Id: Ic38a719ea5d6d8fd485d81f398630e0fad3ef1b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094464 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Raul Tambre authored
__hash__() isn't defined by default in Python 3 if __eq__() is user-defined. This fixes NameStyleConverter being unhashable in Python 3. The default __hash__() in Python 2 is defined in terms of id(self), i.e. identity-based hashing. However, since the custom __eq__() is defined in terms of value equality, this is probably unintended and a bug. Thus this CL also changes behaviour by defining __hash__() in terms of hash(self.original), i.e. value-based hashing. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 80, in <module> json5_generator.Maker(FeaturePolicyFeatureWriter).main() File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 337, in main writer = self._writer_class(args.files, args.output_dir) File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 44, in __init__ fp_origin_trial_dependency_map[feature['name']].append( TypeError: unhashable type: 'NameStyleConverter' Bug: 941669 Change-Id: Ie7811c7a5e0620376bf01c0d91a2c14043c85293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093491 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:Kent Tamura <tkent@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#748123}
-
Findit authored
This reverts commit 63c4f9f5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 748116 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYzYzRmOWY1NDU1NDEyOGEwOGM3ZWU1YTU3N2I1YjBhZmRlMjZjZjMM Sample Failed Build: https://ci.chromium.org/b/8886328647561495520 Sample Failed Step: compile Original change's description: > Adds slotAssignmentMode to the shadow root bindings. > > Prior to this CL, the previous implementation of imperative slot API uses > 'slotting' as an optional parameter for Element.attachShadow(). However, > based on the feedback by JanMiksovsky@ in > https://github.com/w3c/webcomponents/pull/866, the parameter should be > changed to 'slotAssignment' to make it align with other members, > assignNodes(), assignElements(). I agree with this feedback. > > This CL updates the following: > 1. update bindings where the previous 'slotting' was used to > 'slotAssignment'. > 2. Updated the enum type of slotAssignment. It should be, > SlotAssignmentMode [auto | manual]. > 3. Added attribute 'slotAssignment' to Shadow_Root.idl and updated > global-interface-listing-expected.txt. > 4. Modify existing tests from using slotting to slotAssignment. > 5. Removed test that'll be covered by > external/wpt/shadow-dom/slots-imperative-slot-api.tentative.html. > https://chromium-review.googlesource.com/c/chromium/src/+/2083742 > I'll update this CL with the correct > slots-imperative-slot-api.tentative-expected.txt once that CL lands. > > Bug: 869308 > Change-Id: I0fb1a9e11c88d52fc0b0570f3f3e1f5bf834f858 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084376 > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748116} Change-Id: I180387fec3b6ad9d9306d20f57783e16657b39de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094815 Cr-Commit-Position: refs/heads/master@{#748122}
-
Rachel Wong authored
Bug: 1014839 Change-Id: Id8d23da26d5d5fa796f3f53e921ac1d7adccb34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093958Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#748121}
-
Jiewei Qian authored
This CL adds support for system web apps to enable origin trials. It uses WebAppTabHelper to enable origin trials on ReadyToCommitNavigation. Works when launching SWA from shelf or when being navigated to in a tab. Under the hood, it adds a new ForceEnableOriginTrials method to NavigationHandle, which sets the origin trials for this navigation. Internally, the trials are saved to commit_params. When RenderFrame commits this navigation, it passes the origin trial information to blink via WebNavigationParams. The DocumentLoader then enables the provided trials. Fixed: 1024655,1043842 Change-Id: I4030575c21454c0addb4953992149cdd4ee6ffe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038511Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#748120}
-
Abhijeet Kandalkar authored
This CL has two goals to use new downcast helper for blink::LayoutTextControl & blink::LayoutTextControlSingleLine. Bug: 891908 Change-Id: I721ae55a1252a79b03575d5f2cd1c2a7ad3a0727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016697 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c56950442dd1..1987b8f36714 git log c56950442dd1..1987b8f36714 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 51b2800bb317..b44162fdbb25 (2 commits) Created with: gclient setdep -r src/third_party/skia@1987b8f36714 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Id18407bd88522b3e1fd3b85d0e97232d6c940913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094679Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/04f7bfc4192f..39be828c846a git log 04f7bfc4192f..39be828c846a --date=short --first-parent --format='%ad %ae %s' 2020-03-09 deadbeef@webrtc.org Add commas between codec parameters in VideoReceiveStream logging. 2020-03-06 zetilovn@google.com Remove old FakeVP8Encoder alias. Created with: gclient setdep -r src/third_party/webrtc@39be828c846a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic2af139fde4855d8507d2f79f98b55883c493c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094678Reviewed-by:
-
Yu Han authored
Prior to this CL, the previous implementation of imperative slot API uses 'slotting' as an optional parameter for Element.attachShadow(). However, based on the feedback by JanMiksovsky@ in https://github.com/w3c/webcomponents/pull/866, the parameter should be changed to 'slotAssignment' to make it align with other members, assignNodes(), assignElements(). I agree with this feedback. This CL updates the following: 1. update bindings where the previous 'slotting' was used to 'slotAssignment'. 2. Updated the enum type of slotAssignment. It should be, SlotAssignmentMode [auto | manual]. 3. Added attribute 'slotAssignment' to Shadow_Root.idl and updated global-interface-listing-expected.txt. 4. Modify existing tests from using slotting to slotAssignment. 5. Removed test that'll be covered by external/wpt/shadow-dom/slots-imperative-slot-api.tentative.html. https://chromium-review.googlesource.com/c/chromium/src/+/2083742 I'll update this CL with the correct slots-imperative-slot-api.tentative-expected.txt once that CL lands. Bug: 869308 Change-Id: I0fb1a9e11c88d52fc0b0570f3f3e1f5bf834f858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084376 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#748116}
-
Mitsuru Oshima authored
3000x2000 panel uses the scale factor that procuess 1332x888 dp size. This scale causes 1px larger vertical size when ceiled due to very small error (2000.00012207..) Bug: 1050105, b/149022007 Test: covered by unittets. Change-Id: I745ca422dc5f35474dc64d489631a20f34f65b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071177Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#748115}
-
Maggie Cai authored
This test is flaky on https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/2309. BUG=1059645 TBR=tkent@chromium.org Change-Id: I3e96afa16ec0f7781aac489dffe744b3066fdf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094418Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748114}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/213a50aaa32d..0268f16c7e98 git log 213a50aaa32d..0268f16c7e98 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@0268f16c7e98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75a251bf318d489edc0c9545e0664efd1db6b0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094677Reviewed-by:
-
Makoto Shimazu authored
Currently Cross-Origin-Embedder-Policy header is parsed in ServiceWorkerNewScriptLoader when launching a new service worker. However, the COEP in the response header for the main script isn't applied for the network loader created on launching a service worker because the network loader is created before starting to load the main script. This CL is to pause the service worker's script evaluation until the main script is loaded. Once the main script loaded, new subresource loaders are created by using the COEP value, and they are sent to the service worker. Imported scripts also need to refer to the new value, but the loaders are in different place (ServiceWorkerScriptLoaderFactory), so it'll be addressed in a later patch. Bug: 1039613 Change-Id: Ice82eef86beec2f2f5c5e91f3aa136229f14c3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029403 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
