- 06 Mar, 2019 40 commits
-
-
Owen Min authored
Disable the test on Android, Linux and Fuchsia due to flaky. Tbr: petewil@chromium.org Bug: 938812 Change-Id: I96504518c8556d5e8cdfb60a9e74c5dc8e1040ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506380Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638226}
-
Christopher Cameron authored
The root cause of this bug is that the call to LSCopyApplicationURLsForBundleIdentifier that is made in WebAppShortcutCreator::GetAppBundlesByIdUnsorted will not necessarily find app shims that were created just moments ago (likely there is an asynchronous indexing that is going on). To fix this, make WebAppShortcutCreator::GetAppBundlesByIdUnsorted read through all of the app shims in the path under ~/Applications where app shims are created, and see if it finds an application that matches the one we are looking for, based on its Info.plist. Rather than add another place where Info.plists are manually parsed, merge all code that reads Info.plists from app bundles, and put all of the accessors for this data in a single BundleInfoPlist class. Note that some of the moved code is not well understood by this author (in particular, IsForCurrentUserDataDir and GetFullProfilePath). This BundleInfoPlist will be used more extensively in the updated code to delete zombie bundles and to provide more robust renaming. Bug: 937703 Change-Id: Ia292840debd9c74024d707f784dceab78443a536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500851 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#638225}
-
Owen Min authored
Disable the test due to Timeout Bug: 938883 Change-Id: Id2b1f3bed6f8044bd8426dc42ac021ac2ec440ab Bug: 938883 Tbr: petewil@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506117Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0563888d3868..a2179093ac06 Created with: gclient setdep -r src-internal@a2179093ac06 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I047a9b75faa3ba9f27b2e542ccd59f13f40aecd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505982Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638223}
-
Austin Eng authored
WebGPUDecoderImpl will later need to link against symbols in libdawn_native. This patch directly copies the contents to separate files which later can be conditionally compiled when building with use_dawn. Bug: 877147 Change-Id: Iab7abfa2dd636bb4d5d3f3b0a416f2c1f69de990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504495Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#638222}
-
Gayane Petrosyan authored
This relands crrev.com/c/1472450 which was reverted because of a crash crbug.com/936830. The cause of the crash was fixed separately at crrev.com/c/1501493. Bug: 931806 Change-Id: Id659440b7798fe6f0a3c233c3b29a584565cdba3 TBR=ramyan@chromium.org, engedy@chromium.org Change-Id: Id659440b7798fe6f0a3c233c3b29a584565cdba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506107Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#638221}
-
Alex Newcomer authored
HomeLauncherGestureHandler used to send the work area's y position as the max y position of the AppListView in an attempt to modify the work area. AppListView already accounts for work area changes. This bug went unnoticed until HomeLauncherGestureHandler had to deal with the workspace being shrunk from the top via the DockedMagnifier. Now, send 0 instead of the work area y position to AppListView and let AppListView handle the work area change. Also translate based on the keyboard being shown/hidden to prevent search results from being pushed off screen with docked magnifier enabled. TEST=manually tested with multiple display configurations Bug: 936381 Change-Id: I4de62a0f239a72ba69256f5561c7bfb10035a870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504434 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#638220}
-
Arthur Hemery authored
This function is unused since the NavigationHandle and NavigationRequest are kept together now. Change-Id: I0ca24dc4dd37712c298084f7c2d2088df9a24e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495547Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#638219}
-
Jonathan Backer authored
Bug: 938076 Change-Id: I39087f0882c9296975c4a02742898e76175e17a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503342 Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638218}
-
Owen Min authored
Disable the test on ChromeOS due to flaky. Tbr: petewil@chromium.org Bug: 938755 Change-Id: I99eb58c46f53ae6cac8c2925171b7c3e838e15b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506119Reviewed-by:
-
Peng Huang authored
Bug: None Change-Id: I9675e5f6515131e24fab8d4e39b9b3420387bf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506096Reviewed-by:
-
Wez authored
Previously CastRunner would look for Agent-provided services (e.g. CastChannel) in the service namespace supplied on component launch. If a ComponentContext is found in the service namespace passed to StartComponent() then the CastRunner will now use that to connect to the CastAgent to find Cast-specific services. This requires temporary work-arounds e.g. to fall-back to looking at the "additional services" provided in the component's StartupInfo, until we migrate to the new component-manager APIs. Bug: 920920, 893229 Change-Id: I43aec5c47bc24a0d2a537de621b20fad3342a5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472333 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#638215}
-
Jarryd authored
This change adds two new histograms that will be used in monitoring the quota expansion experiment. The experiment is ready to be launched on beta for M74, but if the data from that channel/milestone is insufficient, we will have these metrics in for M75. The first metric added is Quota.UsageByOrigin which records the usage by each origin (absolute value, in MB). Right now, we only have the value as a percentage of the quota granted to each origin, so this could be a little more useful for this particular experiment given that we've increased the quota granted for each origin. The second metric added is Quota.PercentUsedByTemporaryStorage2, which is the same as the first of it's name (global usage in MB of the temporary pool / total disk space), except this will be logged regularly. The first of it's name is logged during eviction, and since our experimental groups have less evictions, we have significantly less data for the experimental groups than the control; thus the original histogram is unreliable for this experiment. This metric will be logged regularly using QuotaManager's histogram timer. Change-Id: I4339f7d4f512cd31405dadd24a515719baa75c9f Bug: 897276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501218 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#638214}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e68767e2fe2..0668403dfdd6 git log 7e68767e2fe2..0668403dfdd6 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 sergiyb@chromium.org Also redirect stderr from the browser since Chrome recently started using it too Created with: gclient setdep -r src/third_party/depot_tools@0668403dfdd6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If6a08283417a5f61fbe48987c0ebe5e417b6c53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638213}
-
Tien Mai authored
- Linked agains gdi+ to use their image converting tools. - Now when downloading the profile picture, the largest downloaded picture will also be converted into .bmp and saved into the same directory. - Override the GetBitmapValue of the credential to read this bmp file and return it. Bug: 936847 Change-Id: Ie36b99e167c828ed7b46b88c400465f5fca44fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497192 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#638212}
-
Jarryd authored
The purpose of this change is to make it easy to reason about the thread safety of QuotaTemporaryStorageEvictor. Change-Id: I6dc9c684f9e1d0c70a8f8703ed2e7ac5ec8bd15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503901Reviewed-by:
-
Sami Kyostila authored
Some of the tasks are posted before native is initialized. In order to read the flag value before native is initialized we make use of FeatureUtilities. This patch just adds the flag, there will be many follow ups making actual use of it. Original patch by Carlos Caballero <carlscab@google.com>. Bug: 863341 Change-Id: If95542568c9074b9031250fb7c702aaf033114c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503416Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#638210}
-
chrome://autofill-internalsAnne Lim authored
Created a page which is empty for now, but will be used to help diagnose tricky Autofill bugs. Bug: 928595 Change-Id: I841a568eaeb24d312c26965d52265b948be7a1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497283Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#638209}
-
Karolina Soltys authored
I created a new class, BrowserThreadUtils, in content_public/browser. It has all of the functionalities of base/ThreadUtils that we want to retain, but uses PostTask. Running blocking tasks has been moved to a new class TestThreadUtils, because it is not supposed to be used by production code. This is part of an ongoing effort to unify Java and C++ scheduling: http://go/migrating-threadutils-to-posttask Bug: 863341 Change-Id: Id7da815b63dd2f5c57b01a093401e1c73a5d57db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489243 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638208}
-
Stephen Martinis authored
Most of these merge scripts lived in tools/build. These are moving source side so that: * Devs can find it easily * Tryjobs can test changes to it * Different trigger scripts can share and re-use code Bug: 928577 Change-Id: I6a78164a3b5dfe142983ec111756bd60f838b2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479171Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
-
Martin Robinson authored
When using WORD_BOUNDARY, the boundaries are defined by the start of the word and then the start of the next one (including whitespace in between them). Have SENTENCE_BOUNDARY work similarly including inside a sentence all punctuation and whitespace before the start of the next one. This is what ATK expects. Bug: 866337 Change-Id: I4abcda7f70756bf34dcb9dc91941a6bd64f8f8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476992 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#638206}
-
Adam Langley authored
Change-Id: Iad0ce2343f2ce115a0f8539f9cce5dfc8f9ffc8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496235 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam (slow; perfing) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#638205}
-
Varun Khaneja authored
Change-Id: Icb99781d30ec3561f9e2fbde67d9abf8c6aa663b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505842 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#638204}
-
Elly Fong-Jones authored
Bug: 780980 Change-Id: Icc5248b5f37b6c8bb2605a88016a523a5e8fb756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1457096Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638203}
-
Antonio Gomes authored
R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I52b5eba4ca69746597318b84f5499bb0fdb93ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506152 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638202}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c854c371c89b..5abc126b0795 git log c854c371c89b..5abc126b0795 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 fmayer@google.com Use emplace_back over push_back to support unique_ptr. Created with: gclient setdep -r src/third_party/perfetto@5abc126b0795 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I710f940a12279f7e953c9ec0344b734d29b19dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505856Reviewed-by:
-
Stepan Khapugin authored
This is useful when you only have the shortcuts, but no results, and you can't see them all (in landscape). Bug: 931210, 906054 Test: 1. Enable Shortcuts flag. Navigate to any URL. Scroll the popup area. Keyboard should be dismissed. 2. Same steps, but clear the text field (see issue 906054) before scrolling. The omnibox should be empty, the Cancel button should be visible, the keyboard should be dismissed. Change-Id: Ibd1637d17536e13352ec0a3b1f872b6df8aed714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491272 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#638200}
-
Ethan Jimenez authored
1. Implementing `ShowContextMenu`, which is the only method that should be provided for the `IRawElementProviderSimple2` interface. 2. Adding cross-platform browser test for the `kShowContextMenu` action. Unit tests for `IRawElementProviderSimple2::ShowContextMenu` and its error handling are introduced in `AXPlatformNodeWinTest`. 3. Replacing `long` type definitions with `LONG` for consistency with the rest of the code in `AXPlatformNodeWinTest`. 4. Refactoring `AXPlatformNodeWinTest::InitListBox` to match other similar helper methods in `AXPlatformNodeTest::BuildListBox`. Bug: 847971 Change-Id: I3d42421c119c41c6fae68eebc813a3e6a67558ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493815Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#638199}
-
Long Ly authored
The issue is that session->capabilities is not available W3C mode since it was moved to 'body' object when session is initiated. Therefore, when GET /sessions is called, session->capabilities will trigger errors. Bug: chromedriver:2798 Change-Id: Ifc7dbc69d00485a53a150a96a7b6c94b9578bdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504760Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Long Ly <loly@microsoft.com> Cr-Commit-Position: refs/heads/master@{#638198}
-
Nicolas authored
Bug: 934992 Change-Id: I1a16b600e4ccbe5d690d0e8a433da97c427e6351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504263 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#638197}
-
Ovidio Henriquez authored
This change adds the ability for device_unittests to run with resource strings in order to test the BluetoothDevice::GetAddressWithLocalizedDeviceTypeName() method. Bug: 506415 Change-Id: I598181822d5b7101b6f2a3dc04d7e39a605c87f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497323Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#638196}
-
Colin Blundell authored
This CL takes a step toward the elimination of FakeAccountFetcherService by eliminating the need for it to override AccountFetcherService network fetches with a do-nothing implementation. In a testing context, AccountFetcherService does not do network fetches by default. One somewhat-surprising consequence of this policy is that refresh token revocation does not result in AccountTrackerService firing the corresponding expected notification that the account was removed. Some tests *require* that flow to work as expected in order to be able to test their clients' production flow. In order to facilitate such tests, AccountFetcherService has a testing method that enables network fetches. This method is typically used by tests in conjunction with a FakeAccountFetcherService instance, which subclasses AccountFetcherService and overrides the methods that do the actual network fetches to do nothing. As detailed in crbug.com/935998, we are looking to eliminate FakeAccountFetcherService. This CL changes the way that the above flow works: instead of these tests enabling network fetches and then using FakeAccountFetcherService to short-circuit out of the actual network fetches, AccountFetcherService now provides the facility to simply enable processing of account removal for tests. That is in fact all that these tests need. We can then eliminate the overrides of the above-mentioned methods in FakeAccountFetcherService, moving one step closer to FakeAccountFetcherService not being necessary. The one necessary usage of AccountFetcherService::EnableNetworkFetchesForTests() is in the AccountTrackerService unittest. Here this usage is deliberate as the test in fact tests the actual interaction with the network, supplying a TestURLLoaderFactory to the production AccountFetcherService instance that it uses. This CL adds comments to the two testing methods to clarify when to use one vs. the other. TBR=sdefresne@chromium.org Bug: 935998 Change-Id: I5106a85cf20874b48aa38bc3935df9a08018ea72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489241Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638195}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b085fa9c8c19..cb4eb612f02f git log b085fa9c8c19..cb4eb612f02f --date=short --no-merges --format='%ad %ae %s' 2019-03-06 kjlubick@google.com [canvaskit] Remove additional copies of CanvasKit when testing 2019-03-06 borenet@google.com [infra] Remove bookmaker bots 2019-03-06 reed@google.com change gm to use srgb (not linear) so srgb and legacy draw the same 2019-03-06 jvanverth@google.com Fix stencil setup in Metal 2019-03-06 kjlubick@google.com [canvaskit] Add particles integration Created with: gclient setdep -r src/third_party/skia@cb4eb612f02f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Iaa0424baaa2fd46ee4f7dd448a58bef96c290f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505980Reviewed-by:
-
Lorne Mitchell authored
There are severals places in the DevTools frontend UI where we need to update existing strings to ensure that they are localizable. 1. Updated strings that are conditionaly plural into their singular and plural forms. 2. Updated strings that use concatenation to instead use variable substitution. 3. Fixed a couple other minor issues. Regarding the use of variable substitution instead of concatenation. Consider: Common.UIString(palette.colors[i] + '. Long-click to show alternate shades.'); Here, the location of the color isn't captured, instead the actual hex value is. What we really need is a string with a marker for the variable substitution. Instead, we should do the following: Common.UIString('%s. Long-click to show alternate shades.', palette.colors[i]); Or, ls`${palette.colors[i]}. Long-click to show alternate shades.`; Change-Id: Ica7253f7c69e9a2478452d0a944147680b4ca8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504254 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#638193}
-
Henrik Boström authored
Based on https://github.com/w3c/webrtc-pc/pull/2112. Bug: 937844 Change-Id: I7ad149f47fb394f15055cc8fd77e79b4e5e0f317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499613 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#638192}
-
Daniel Bratell authored
Code generated by grit depends on //base (base/stl_util.h) so the build target will need to depend on //base as well. Found when gn check was taught to look at generated files and not just at files in the source tree. Bug: 938933 Change-Id: I566d8c1f0c6b8d16ec21eb7cc864f86b4ed08370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505943 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#638191}
-
Lucas Tenório authored
This feature is already mostly renamed but unfortunately the tests lagged behind in the migration. Bug: 933530 Change-Id: Iae6114bb33f9ae8372f729bbb1777565795f00cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496216 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#638190}
-
Tomasz Wiszkowski authored
This change will allow us to share feature flags currently defined explicitly for CrOS omnibox (kEnableZeroStateSuggest in particular). Change done to avoid cluttering ash with unnecessary code, and to prevent pollution of flag namespace with duplicates that aim at achieving same goal. Reasoning behind the change: 1. create a shared space for flags used by the omnibox and the CrOS launcher. 2. Move the kEnableZeroStateSuggest flag into components/omnibox/common/omnibox_features. 3. Reference kEnableZeroStateSuggest in Android code. Bug: 934922 Change-Id: Ib920f3a0616cf1b1e54399a27af656da6ba74a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484856 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638189}
-
sczs authored
- InfobarCommands will be used by the LocationBar badge button to communicate with the InfobarContainer and display the InfobarModal whenever the button is tapped. Bug: 911864 Change-Id: Ib0126ce8d8de9378d91606f9a76855ff882cbc9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500605 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638188}
-
Peter E Conn authored
Bug: 938836 Change-Id: I389403bd798e1712441acdba149d1941f4881da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506079Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#638187}
-
