GitLab

…and remove the duplicate divider drawing in DownloadShelfView.

BUG=589943

Review-Url: https://codereview.chromium.org/2336463002
Cr-Commit-Position: refs/heads/master@{#418641}

Reason for revert:
The original fix is opt-in, which causes unit test binaries to miss symbols. I will
reimplement an opt-out for binaries that we do not want to whole-archive libs.

Original issue description:
>> All chromecast executable include all libstdc++/libgcc symbols by default
>> due to b/25566835. Added a config for --whole-archive for only ones that
>> depend on shared libs. ~700kb saving per executable.

BUG=internal b/31417380

This reverts commit 92947f23.

Review-Url: https://codereview.chromium.org/2334163004
Cr-Commit-Position: refs/heads/master@{#418640}

This reverts commit a7ce77dd. Monitoring tells
us severely regressed isolate performance.

TBR=jam@chromium.org
BUG=644410

Review-Url: https://codereview.chromium.org/2344563003
Cr-Commit-Position: refs/heads/master@{#418639}

This is to make EnsurePtrConvertibleArgDecl(T, const T) to fail
for https://codereview.chromium.org/2220543002.

This CL also adds unit tests for EnsurePtrConvertibleArgDecl.

BUG=

Review-Url: https://codereview.chromium.org/2220443004
Cr-Commit-Position: refs/heads/master@{#418638}

With this patch, the passthrough command buffer is capable of rendering chrome
and basic WebGL content.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2317363005
Cr-Commit-Position: refs/heads/master@{#418637}

BUG= internal b/31488922

Review-Url: https://codereview.chromium.org/2340013002
Cr-Commit-Position: refs/heads/master@{#418636}

Can be enabled in about://flags

BUG=638198

Review-Url: https://codereview.chromium.org/2323563002
Cr-Commit-Position: refs/heads/master@{#418635}

This CL removes all calls to XSelectInput, or XCreateWindow using
CWEventMask, from the browser process that uses the main X
display (ie, the one returned by gfx::GetXDisplay()).  Window event
selection will instead by managed by XWindowEventManager.

BUG=634084

Review-Url: https://codereview.chromium.org/2319933002
Cr-Commit-Position: refs/heads/master@{#418634}

- Add a full integration test that spawns both an engine and client in
  the same process and validates that the rendering pipeline produces
  the correct thing.
- Also add Linux support for BlimpContents and exposed a
  BlimpContentsView, which is required to gain access to the right
  classes to validate the rendering path.

Marking this as NOPRESUBMIT because there are some ScopedAllowIO calls during test setup and client tear down.  Please feel free to revert or ping me on any landing issues.

BUG=644262
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2320923002
Cr-Commit-Position: refs/heads/master@{#418633}

TBR=nednguyen@chromium.org
BUG=646925

Review-Url: https://codereview.chromium.org/2340033002
Cr-Commit-Position: refs/heads/master@{#418632}

This patch enables caching of spellcheck results to improve performance
and address issues mentioned below.

In its current state i.e. without caching spellcheck on Android and Mac
has a number of issues e.g.:
- selection (click) of words or movement of the caret can result
in unnecessary calls to the platform spellchecker.
- typing of non-word characters in the end results in unnecessary
calls to the platform spellchecker.
- modifying text does not always result in invocation of spellchecker,
hence not showing the misspelled words.

BUG=583616, 629609

Review-Url: https://codereview.chromium.org/2317113004
Cr-Commit-Position: refs/heads/master@{#418631}

BUG=

Review-Url: https://codereview.chromium.org/2344583002
Cr-Commit-Position: refs/heads/master@{#418630}

As the mouse cursor moves across OOPIF boundaries, elements in
other processes that have certain mouse event handlers might require
notification in order to fire those handlers. An example is MouseLeave,
which is not currently fired when the MouseMove is directed to a
parent frame.

This CL tracks the last RenderWidgetHostView to receive a mouse
event and sends appropriate events to other renderers when that changes.

BUG=632035

Review-Url: https://codereview.chromium.org/2229463004
Cr-Commit-Position: refs/heads/master@{#418629}

so that the function takes content::WebContents* instead of
content::NavigationHandle*. That allows us to use the bubble
view class outside the throttle.

BUG=b:29079617, b:31406784
TEST=try

Review-Url: https://codereview.chromium.org/2335313003
Cr-Commit-Position: refs/heads/master@{#418628}

BUG=644268
TEST=none

Review-Url: https://codereview.chromium.org/2339813004
Cr-Commit-Position: refs/heads/master@{#418627}

https://pdfium.googlesource.com/pdfium.git/+log/8b1ed1614492..1f2489023f2b

$ git log 8b1ed1614..1f2489023 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 dsinclair Remove FFI_ from CPDFSDK_Environment method names

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2343673002
Cr-Commit-Position: refs/heads/master@{#418626}

Nothing outside of MostVisitedSites needs to use it.

Review-Url: https://codereview.chromium.org/2337893003
Cr-Commit-Position: refs/heads/master@{#418625}

BUG=619055
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2336803005
Cr-Commit-Position: refs/heads/master@{#418624}

Cronet API classes must be in org.chromium.net package and
Cronet implementation classes must not be in org.chromium.net package.

BUG=629299

Review-Url: https://codereview.chromium.org/2320413002
Cr-Commit-Position: refs/heads/master@{#418623}

[Offline Pages] Gates immediate triggering (non scheduled) of background loading by whether low end device.
Makes unit tests conditional on this check - ran unit tests on both svelte and regular devices locally.

BUG=646888

Review-Url: https://codereview.chromium.org/2338313002
Cr-Commit-Position: refs/heads/master@{#418622}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/61504ac2..798d1e3c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2340573003
Cr-Commit-Position: refs/heads/master@{#418621}

When a Javascript: url is dropped on a tab, it executes in the
security context of the selected tab, representing a script
injection attack ("Dropjacking"). We will match other browsers
and disallow such drops.

BUG=639750

Review-Url: https://codereview.chromium.org/2323273003
Cr-Commit-Position: refs/heads/master@{#418620}

This is temporary measure to get the NaCl SDK bots
building again.

BUG=646666
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk

Review-Url: https://codereview.chromium.org/2334303003
Cr-Commit-Position: refs/heads/master@{#418619}

There was potential that a stream events could enter rAF while it was being
processed. This was an initial design consideration but after talking with
an external partner it appears that probably we should just process what
is queued. This gives the benefit that only one type of a given event
will be processed during the callback.

BUG=625693

Review-Url: https://codereview.chromium.org/2342603003
Cr-Commit-Position: refs/heads/master@{#418618}

Unit tests for both the PreviewsInfoBarDelegate and
PreviewsInfoBarTabHelper. Verfies that the infobar shows
with the correct strings and only shows once for a page.

BUG=615566
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2266653002
Cr-Commit-Position: refs/heads/master@{#418617}

BUG=644626

Review-Url: https://codereview.chromium.org/2330543002
Cr-Commit-Position: refs/heads/master@{#418616}

BUG=645295

Review-Url: https://codereview.chromium.org/2338013006
Cr-Commit-Position: refs/heads/master@{#418615}

Revert of Enforce capability spec renderer <--> browser (patchset #14 id:260001 of https://codereview.chromium.org/2259903002/ )

Reason for revert:
Numerous failures; some examples:
https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/builds/10021
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/45903
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/36939
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/70401

Potentially related:
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/28370

Original issue's description:
> Enforce capability spec renderer <--> browser.
>
> This implements:
>
> - allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer.
> - adds such an overlay to chrome/browser
>
> So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review.
>
> R=rockot@chromium.org,tsepez@chromium.org
>
> Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
> Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
> Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
> Cr-Original-Original-Commit-Position: refs/heads/master@{#418282}
> Cr-Original-Commit-Position: refs/heads/master@{#418398}
> Cr-Commit-Position: refs/heads/master@{#418582}

TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2342523003
Cr-Commit-Position: refs/heads/master@{#418614}

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- feedback_private
- file_manager/private_api_drive
- file_manager/private_api_misc
- file_manager/private_api_strings
- file_manager/private_api_tasks
- file_system
- file_system_provider

BUG=634140

Review-Url: https://codereview.chromium.org/2335213004
Cr-Commit-Position: refs/heads/master@{#418613}

Revert of Fix webkit_tests by adding two more interfaces they expect. (patchset #1 id:1 of https://codereview.chromium.org/2339703003/ )

Reason for revert:
Reverting this and https://codereview.chromium.org/2259903002
I'll post more details on the other CL

Original issue's description:
> Fix webkit_tests by adding two more interfaces they expect.
>
> TBR=rockot@chromium.org,tsepez@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/5a3bcc8be6b98f0084ad3cbf45045cfa4f848e3c
> Cr-Commit-Position: refs/heads/master@{#418600}

TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2338163003
Cr-Commit-Position: refs/heads/master@{#418612}

This change adds a confirmation dialog for the It2Me Linux host.  This
dialog will be displayed when an incoming It2Me connection and will wait
up to 60 seconds for the user to accept/reject it.  If the user accepts
the connection then we will complete the conneciton process, otherwise
the incoming request will be rejected.

BUG=645540

Review-Url: https://codereview.chromium.org/2343443002
Cr-Commit-Position: refs/heads/master@{#418611}

This is caused in WebApkInstaller::OnSucess() which uses a local variable after
deleting the "this" pointer. Therefore, a wrong package name is given to the
infobar and the infobar believes the WebAPK hasn't been installed yet.

BUG=646844

Review-Url: https://codereview.chromium.org/2338253002
Cr-Commit-Position: refs/heads/master@{#418610}

Use TimeDelta instead of an int representing milliseconds in Media
Router mojo interfaces.

BUG=629375

Review-Url: https://codereview.chromium.org/2324133003
Cr-Commit-Position: refs/heads/master@{#418609}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/32dd31095913..8c5c37517378

$ git log 32dd31095..8c5c37517 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 benjhayden Stop serializing HistogramBin ranges.
2016-09-14 petrcermak [tracing] Add support for delta sparklines to <tr-v-ui-scalar-span>

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2338803005
Cr-Commit-Position: refs/heads/master@{#418608}

Most of the TranslateLayer test can pass even on AURA machines; only
one clause needs to be #ifdef'd out on MACOS *and* AURA.

Also documents the surpising DstATop xfermode use in MakeOpaque,
and changes that function from OS_WIN-only to running on every platform,
where it should be a cheap noop.

Followup: other parts of the Chrome codebase have their own
MakeOpaque implementations; we can probably share this through
skia_utils.

R=fmalita@chromium.org
BUG=154358

Review-Url: https://codereview.chromium.org/2340823002
Cr-Commit-Position: refs/heads/master@{#418607}

sed -i 's/ ASSERT(/ DCHECK(/g'
sed -i 's/ RELEASE_ASSERT(/ CHECK(/g'
sed -i 's/ ASSERT_NOT_REACHED(/ NOTREACHED(/g'
sed -i 's/ ASSERT_WITH_SECURITY_IMPLICATION(/ SECURITY_DCHECK(/g'
perl -npe '$_ =~ s/ASSERT_UNUSED\((.*?), (.*)\);$/DCHECK($2);/g'

for `find third_party/WebKit/Source/core/{fetch,loader}/ -name '*.*'`.

This CL replaces
- DCHECK(a == b) with DCHECK_EQ(a, b)
- DCHECK(a && b) with DCHECK(a) and DCHECK(b)
etc. manually.

BUG=645395, 596760

Review-Url: https://codereview.chromium.org/2327643003
Cr-Commit-Position: refs/heads/master@{#418606}

https://pdfium.googlesource.com/pdfium.git/+log/79db609948b0..8b1ed1614492

$ git log 79db60994..8b1ed1614 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 npm Map glyph bitmap in LookUpGlyphBitmap even when unsuccessful

BUG=638856

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2332333004
Cr-Commit-Position: refs/heads/master@{#418605}

Unlike web::shell_test_util::LoadUrl this new method waits until the
load is completed.

BUG=646544

Review-Url: https://codereview.chromium.org/2340533004
Cr-Commit-Position: refs/heads/master@{#418604}

The added API will be fired when the virtual keyboard window has been closed, for example, this can happen when turning off on-screen keyboard or exiting tablet mode.

IME extensions rely on input view's visibility changing event to do some work such as hide candidate window. While, when exiting tablet mode, OS will close input view window immediately but doesn't fire 'unload' event, so the IME extensions won't receive the visibility changed event.

Thus, we add this API to notify the extensions the keyboard closed event.

BUG=619763
TEST=KeyboardControllerTest.CloseKeyboard

Review-Url: https://codereview.chromium.org/2122873002
Cr-Commit-Position: refs/heads/master@{#418603}

https://chromium.googlesource.com/skia.git/+log/eed356d281ad..95573e4865c9

$ git log eed356d28..95573e486 --date=short --no-merges --format='%ad %ae %s'
2016-09-14 fmalita Fix SVG flag iOS linking
2016-09-14 fmalita Nanobench SVG support

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2341613003
Cr-Commit-Position: refs/heads/master@{#418602}