- 01 Aug, 2018 40 commits
-
-
Gauthier Ambard authored
This CL adds a delay for the voice over announcement of the InProduct Help tips. This delay is added to prevent the announcement to be cancelled by the element being focused, when the tab is presented. It also adds an accessibility label to the empty space where the omnibox should be if the toolbar was visible. Bug: 866936 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia75dd56772203e39b8d0bf1e94bef9cfacd87fdd Reviewed-on: https://chromium-review.googlesource.com/1158236 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579886}
-
Yue Cen authored
Bug: 835029 Change-Id: Ia50091e2e1669f180f4d9eb5860a59a141bc0c4c Reviewed-on: https://chromium-review.googlesource.com/1150636Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#579885}
-
Peng Huang authored
And we only use features "disable_timestamp_queries" to disable glQuereyCounter. Bug: 811661 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I81eaf2001d17b31d56dbaadadb1b34f6741e0af0 Reviewed-on: https://chromium-review.googlesource.com/1159098Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#579884}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like these callsites can use the THREAD_POOL_EXECUTOR instead, since these uses don't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: I0a2c9021be07447d9437c7e33606307ea3685fc5 Reviewed-on: https://chromium-review.googlesource.com/1159105Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579883}
-
Mathieu Perreault authored
Bug: 863174 Change-Id: I4d694bc9d8faedb7d74a5aedb0d6bf7caffc8d0a Reviewed-on: https://chromium-review.googlesource.com/1157662Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579882}
-
Avi Drissman authored
BUG=859779 Change-Id: I053e26086599ffb68f6379844bb20bf894e613e1 Reviewed-on: https://chromium-review.googlesource.com/1155663 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#579881}
-
kristipark authored
Bug: 851293 Change-Id: Icd8963e26cb1bea4e4109080b3b06d42beb26e1d Reviewed-on: https://chromium-review.googlesource.com/1157285 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579880}
-
Tom Anderson authored
Also: * Add no_default_deps to mini_installer. * Updates an incorrect comment and removes an unnecessary dependency on libc++ in mini_installer/BUILD.gn which became broken in [1]. [1] https://chromium-review.googlesource.com/1073613 BUG=None Change-Id: I44f8f09e36f2764b3077af5d0cd7605a575b347e Reviewed-on: https://chromium-review.googlesource.com/1157509 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579879}
-
Vladimir Levin authored
Compositing update may change the state of the throttling, causing the lifecycle state to not update for the local root frame. This patch ensures that the DCHECK doesn't fail due to throttling. R=chrishtr@chromium.org Bug: 869807 Change-Id: Iae4de9420f566b5901be1a0bbbb92dd47eafcacb Reviewed-on: https://chromium-review.googlesource.com/1158991Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579878}
-
Xiaoqian Dai authored
If overview mode is opened behind the current dragged window, we should not do the animation when entering overview. Bug: 823769 Test: None Change-Id: I1d89bcdc27ea784449698183e026aa63f1c2cf2c Reviewed-on: https://chromium-review.googlesource.com/1157289 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#579877}
-
David Black authored
As we develop the motion spec in pieces, the UI may regress until the choreography is fully implemented. To prevent this, I added a constant that we can use to gate changes that should not be enabled until additional motion specs are also implemented. This change is gated by that flag, so this change will not be visible by default. See bug for spec/demo. Bug: b:111890130 Change-Id: I88ab63e4ba83e8210eacdd3dd8b3c45b305d0373 Reviewed-on: https://chromium-review.googlesource.com/1152208Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#579876}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ebafd75a0c5d..6af2bfe03baf git log ebafd75a0c5d..6af2bfe03baf --date=short --no-merges --format='%ad %ae %s' 2018-08-01 treehugger-gerrit@google.com Merge "Allow to send multiple fds over UnixSocket." Created with: gclient setdep -r src/third_party/perfetto@6af2bfe03baf The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I316f3d9861190e8417f8691201a197a344571f51 Reviewed-on: https://chromium-review.googlesource.com/1158785 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579875}
-
gogerald authored
Bug: 806868 Change-Id: I2877c4cfa3241dc6a783311b69f46c27c3b347c5 Reviewed-on: https://chromium-review.googlesource.com/1158855 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#579874}
-
tzik authored
GetOriginsTask is ref counted, and its first reference is implicitly retained by base::Bind() in GetOriginsTask::Run(). Though this case is safe, an upcoming base::Bind change rejects this pattern of the first reference retention. After this CL, the caller of GetOriginsTask::Run() keeps the first reference to the GetOriginsTask instance to avoid the check failure. Bug: 866456 Change-Id: Ia011ccc3b815a626200403b22c63b8133c83fbb0 Reviewed-on: https://chromium-review.googlesource.com/1158664 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#579873}
-
Sergey Ulanov authored
1. /pkg, /svc and /config/ssl are now cloned to Context processes. https://crrev.com/1149262 removed FDIO_SPAWN_CLONE_NAMESPACE. As result the context process was failing to open /pkg/icudtl.dat. 2. Added FDIO_SPAWN_CLONE_JOB flag - job needs to be cloned so the context process can start its own children. 3. Updated SandboxPolicyFuchsia not to clone /tmp - it doesn't appear to be necessary for any sandboxed processes. 4. Removed FDIO_SPAWN_CLONE_STDIO for Context and sandboxed processes. Instead stderr is added fds_to_map. Bug: 852145, 869216, 868556 Change-Id: I89c429231cd0e295247c80f12e587e1c7335456b Reviewed-on: https://chromium-review.googlesource.com/1155967 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#579872}
-
Weilun Shi authored
Attribution section should be removed after clicking restore default background. Adding clearAttribution function when the restoreDefaultInteraction is called. Screenshot: https://screenshot.googleplex.com/AQT8eBddJ7A.png Bug: 869693 Change-Id: I18526c72c74fbff84320faf5f8a756c545138fcf Reviewed-on: https://chromium-review.googlesource.com/1157650Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d97057a..b538ae75 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65b789ae482ea58277b26e78d4cfb82aa563ab12 Reviewed-on: https://chromium-review.googlesource.com/1158397Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579870}
-
Manu Cornet authored
* Make it a little easier to understand * Remove some panel-related code (a lot more of that in a separate CL) No change in behavior. Bug: 805612 Bug: 788033 Change-Id: I70225cc90cba940a8e2cb148be4aa887ebaa01ce Reviewed-on: https://chromium-review.googlesource.com/1150776 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#579869}
-
David Tseng authored
This change: - writes to settings each time ChromeVox changes a tts property - updates from prefs on startup - observes pref changes and announces when rate, pitch, and volume changes - adds a new key binding (Search+o, s) which opens the tts settings - adds a new menu item in the ChromeVox menus opening tts settings There should be no functional change for ChromeVox commands (e.g. keyboard shortcut to change pitch). Changes to global tts settings should be reflected in ChromeVox immediately once changed. Change-Id: Ic701c6f7b4422194ac8a957fbaf4fe0fd60e00af Reviewed-on: https://chromium-review.googlesource.com/1157173 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#579868}
-
Peter Wen authored
Allows each target to then append and customize the license file based on their third-party sub-licenses. Bug: 869935 Change-Id: I732c132abaf386f7ce763fb7452384717c1264ed Reviewed-on: https://chromium-review.googlesource.com/1158964 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#579867}
-
yoshiki iguchi authored
This CL supports showing toasts on lock screen. If the device is locked and the toast can be in the lock screen, ToastOverlay appears in kShellWindowId_LockSystemModalContainer instead of kShellWindowId_SystemModalContainer. kShellWindowId_LockSystemModalContainer can be used only during the lock screen is visible, so we switched the container when the lock status is changed. Bug: b/79951342 Test: ash_unittests --gtest_filter="ToastManagerTest.*" passes Change-Id: I40d62e21b437686fcfc4b119a0c9954207f3533d Reviewed-on: https://chromium-review.googlesource.com/1154783 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Peter Beverloo authored
Change-Id: I9a2287102428a6c386fde09d9d237c6a9419e824 Reviewed-on: https://chromium-review.googlesource.com/1156589Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#579865}
-
Miguel Casas authored
This CL fixes the Size we SetAll() in the viz::TextureDrawQuad from an empty one to the appropriate CanvasResource Size -- this is needed to indicate to e.g. Ozone the |resource_size_in_pixels| of the overlay candidate, but it's also more correct in general. Also removes an unused variable and adds {} in a few needed places. Bug: 869161 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ice28fb8c9d7f9a4eee29a22f8634b08c9dfb2e36 Reviewed-on: https://chromium-review.googlesource.com/1157232 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579864}
-
Sharon Yang authored
This CL implements the Read and Write functionality for the new data store. It has not yet replaced the existing notification database. Bug: 856603 Change-Id: Ie218078f1a17ef0948279fef4632c24cdc437ff0 Reviewed-on: https://chromium-review.googlesource.com/1140163 Commit-Queue: Sharon Yang <yangsharon@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579863}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like this callsite can use the THREAD_POOL_EXECUTOR instead, since this use doesn't appear to rely on the concurrency guarantees that SERIAL_EXECUTOR provides. Bug: 869907 Change-Id: I7dce5b4f28520a3d2a81491756f5aec5f6806fa9 Reviewed-on: https://chromium-review.googlesource.com/1158962Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#579862}
-
Peter Boström authored
Adds a Views::GetAnchorBoundsInScreen() method. This defaults to GetBoundsInScreen() but can be overridden for views whose visual bounds differ from their actual bounds. This is the case for toolbar buttons on Touch (that provide larger hit targets than their visual size). This method is then used for the menus spawned by AppMenuButton and ToolbarButton as well as BubbleDialogDelegate which allows these specific menus and BubbleDialogDelegates in general to be better aligned visually to their anchors. Bug: chromium:800372, chromium:869928 Change-Id: I9c516d8a7ecb6c922e347d4db61ce1db72c71be7 Reviewed-on: https://chromium-review.googlesource.com/1152525 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#579861}
-
Wez authored
Change-Id: Ia3190dd63539ef85e33d13642ad9005910bffa70 Reviewed-on: https://chromium-review.googlesource.com/1157528Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#579860}
-
David Black authored
Previously, Assistant response text/cards/suggestions were streamed in and rendered immediately. We actually want to cache them until all renderable elements for an interaction are received, and then show them all at once. This is a prerequisite for motion specs which require animating the response in as a whole and resizing the container smoothly. To accomplish this, this CL adds: - AssistantResponse object to hold the renderable elements. - A cached AssistantResponse in AssistantInteractionController that is not added to the model until it is finalized. - Notification of TTS started event to AssistantInteractionController. This is used as an early indication that we have received all renderable elements for an interaction. Bug: b:111932420 Change-Id: I0cc84079183fc30b8c949491e5e2bc4d0b4365b1 Reviewed-on: https://chromium-review.googlesource.com/1153626Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#579859}
-
Moe Ahmadi authored
This reverts commit e93874be. Reason for revert: http://crbug.com/863954#c3 Original change's description: > [AF] Do not discard form data after dynamic form submission > > Prior to this change form data were being discarded after a dynamic form > submission. This was because the dynamically changed form was being added > to the cache with its user entered/autofilled values. At the time of > submission, form data were being discarded as they were thought to be the > initial values of the fields at page load. This CL changes > AutofillHandler::OnFormsSeen (which is called on dynamic form changes) to > attempt to find a previously cached version of the form first. Prior to > addition to the cache, form values are overridden by the cached values. > This prevents those values from getting confused with the initial form > values at the time of submission. > > Bug: 863954 > > Change-Id: Iba4771ee87b9777e66a6b10b6b369379dc123a46 > Reviewed-on: https://chromium-review.googlesource.com/1137021 > Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577033} TBR=sebsg@chromium.org,mahmadi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863954 Change-Id: I71d0970d10fe1d4857e98ba558b9253b13ad053d Reviewed-on: https://chromium-review.googlesource.com/1151911Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#579858}
-
Yusuf Ozuysal authored
This reverts commit 734d2825. Reason for revert: The CL this CL was fixing was already revertedand looks like this is causing other regressions. Original change's description: > Fix animation jankiness after selecting the current NTP in Android tab switcher > > If you open an NTP on Android, open the tab switcher, and then focus the NTP, > there is often some jankiness at the end of the animation where the page very > quickly appears to jump back-and-forth by a few pixels. > > It turns out that this happens when we switch from TabListSceneLayer (what we > use to display the tab switcher) to StaticTabSceneLayer (what we use to show > the tab during normal browsing): for the NTP, we never use the live layer in > the tab switcher, so we have to use the static layer. When we switch to > StaticTabSceneLayer, it (sometimes?) still uses the static layer very briefly, > but displays it at not quite the right size, which causes the jumpiness before > we switch back to the live layer. > > The fix is to make ContentLayer clip the static layer to the value of > ComputedSize() in the case where should_clip == false. > > Bug: 748648 > Change-Id: I2999ee1be91681d692e381a9aff230567ace20fc > Reviewed-on: https://chromium-review.googlesource.com/1114349 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Ryan Landay <rlanday@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570974} TBR=dtrainor@chromium.org,rlanday@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 748648, 867868, 865395 Change-Id: I9f092f7906a3b2d96480e3a797292d96dda22074 Reviewed-on: https://chromium-review.googlesource.com/1151568Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#579857}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7a1c7f782a14..78026754a734 git log 7a1c7f782a14..78026754a734 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 peah@webrtc.org AEC3: Utilize shadow filter output to respond to audio path changes 2018-08-01 oprypin@webrtc.org Explicitly add -mfpu=neon to all targets that use NEON Created with: gclient setdep -r src/third_party/webrtc@78026754a734 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:869821 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I50a4664af22308ac41d58db2390bf766493e546b Reviewed-on: https://chromium-review.googlesource.com/1158786Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579856}
-
Peter Beverloo authored
New subscriptions are currently considered as having been server- invalidated, which is incorrect. This change should significantly drive the number down to expected values. Change-Id: I56a5de9e6f9388ee60674c9f3de3af5727291392 Reviewed-on: https://chromium-review.googlesource.com/1158829 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Max Moroz authored
This change removes 6+ MB of binaries from the build tools bundle: 3.7M lib/linux/libclang_rt.asan-i686-android.so 2.5M lib/linux/libclang_rt.ubsan_standalone-i686-android.so 80K lib/linux/libclang_rt.profile-i686-android.a It also can break some workflows, but as discussed in person, there is a good chance that no one is using those libraries on i686 arch. Bug: 866225 Change-Id: Ifbc85e542359681f60f19f52e5bd7a8a7e1655f3 Reviewed-on: https://chromium-review.googlesource.com/1158708Reviewed-by:
-
Tom Anderson authored
Also: * Remove an out-of-date comment. * Add binutils to install-build-deps.sh for readelf and grep. We already use binutils in many places, and it's likely already installed everywhere, but it's good to list out direct dependencies. BUG=850682 R=thakis Change-Id: I80830ad42fe37f1b93f393f5a6ca5af68ef92998 Reviewed-on: https://chromium-review.googlesource.com/1157436Reviewed-by:
-
Anita Woodruff authored
- Some of these tests were consistently failing but went unnoticed because they only run on Android O+ and there are no cq-blocking O bots yet. - Tested by running all tests with *Channels* in the name on an Android O device. Change-Id: I29d92984eb9f9d74062ec36dc391412be8b0fa51 Reviewed-on: https://chromium-review.googlesource.com/1158834Reviewed-by:
-
Tessa Nijssen authored
Previously, each tab had its own SuggestedTextTouchBarController. Now, because of http://crrev/c/1151613, there is only one SuggestedTextTouchBarController per window. Because the controller does not maintain the state of each tab, as a user switches tabs, the controller needs to update its state to match the tab. When the controller's WebContents change, new suggestions should be generated for the selected text in the current tab. The methods -webContentsTextSelectionChanged:range: and -webContentsFinishedLoading were combined into a singular method, -updateTextSelection:range:, because they had very similar functionality. The parameters for -requestSuggestionsForText:inRange: were removed because they were always |text_| and |selectionRange_|. A new method was created, -webContentsChanged, to get a tab's current text and selected range and then call -updateTextSelection:range: with the proper parameters. When the controller gets a new pointer to a WebContents, the pointer may be null. To avoid calling WebContents::IsFocusedElementEditable() on a null pointer, a method -isTextfieldFocused was created to check that |webContents_| is not a null pointer and that an editable element is focused. A new SuggestedTextTouchBarControllerBrowserTest was written, SetWebContentsTest, to test that the SuggestedTextTouchBarController properly updates its current text selection based on the new WebContents. Bug: 717553 Change-Id: I356a548bbdf33b51484fd7c55a1aa5ea37be4bae Reviewed-on: https://chromium-review.googlesource.com/1153728Reviewed-by:
Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#579851}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ad63728be30d..038e725af257 git log ad63728be30d..038e725af257 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 jmadill@chromium.org D3D11: Use angle::Result error pattern. 2/3 Created with: gclient setdep -r src/third_party/angle@038e725af257 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ic94f4f359c637874db543cd7efa9bbcf95baa3e7 Reviewed-on: https://chromium-review.googlesource.com/1158784Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579850}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3a40bed9d6e5..56094c50c0da git log 3a40bed9d6e5..56094c50c0da --date=short --no-merges --format='%ad %ae %s' 2018-08-01 tsepez@chromium.org Rename PageSetContainerLayoutItem to TraverseStrategy_PageSet. Created with: gclient setdep -r src/third_party/pdfium@56094c50c0da The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib9431028d74bce02b171e0b884d677e78510c5fa Reviewed-on: https://chromium-review.googlesource.com/1158727Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579849}
-
khmel@google.com authored
This is follow up to fix after crrev.com/c/1142687 Test: Manually + unit test Bug: 868231 Change-Id: I176da80dbde497e8bf47730045bfa770c23dec36 Reviewed-on: https://chromium-review.googlesource.com/1157703 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
-
jdoerrie authored
This change moves MergeDictionary() from base::DictionaryValue to the parent class base::Value and relaxes its interface to accept base::Value pointers as well. Appropriate CHECKs are added. Bug: 646133 Change-Id: Ib6dab60ea2ff4f56b320e4a54f0782905aa3c4ae Reviewed-on: https://chromium-review.googlesource.com/1158233Reviewed-by:
-
