- 30 Nov, 2020 40 commits
-
-
Mattias Nissler authored
This new device setting will supersede the existing "startup flags" setting. The latter was storing chrome://flags feature flags as raw command line switches, which turned out to be problematic since Chrome can't easily map the switches back to feature flags to validate them. Subsequent changes will add support for the new way of doing things as well as migration logic in session_manager and Chrome. BUG=chromium:1073940 TEST=None Change-Id: Id816469ab29e0458a36085655a5922a3dcb3e5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565637Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#832033}
-
David Roger authored
The avatar images in profile UIs did not have any accessibility options, and the voice over was spelling out the whole image URL, which is a broken experience. The voice over label for the avatars is not strictly required, and thus this CL disables the voice over by passing an empty 'alt' attribute to the images. Fixed: 1151916 Change-Id: Ifd098e78842a3b01e1bd28d19baf8e2aac86c4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565432 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#832032}
-
Kenneth Russell authored
It's failing on that configuration as well. Bug: 1152259 Change-Id: Iacba1849f88cb5bb6f02315eb26d1b684ca3de95 Tbr: shrekshao@google.com Tbr: penghuang@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566330Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#832031}
-
Eric Lawrence [MSFT] authored
Clarify a comment by fixing a spelling error. Change-Id: I8ab42f402bae9b5706ad4915be2a7808f79490eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565395 Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#832030}
-
Joe Downing authored
Change-Id: I4673b4bec0b3f2c0a75ec690124c5f2c02470de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565770Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#832029}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2fe7335d34bc..6a7095d8c753 2020-11-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from aa212ee81f71 to eac3c5bf5197 (1 revision) 2020-11-30 enga@chromium.org Update ScissorTests to use WGSL 2020-11-30 enga@chromium.org Update DepthStencilCopyTests to use WGSL 2020-11-30 enga@chromium.org Update ObjectCachingTests to use WGSL 2020-11-30 jiawei.shao@intel.com Use FilterMode::Nearest in TextureFormatSamplingTests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I9a3198ae179cd1b9e5841620762380bd477b25fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832028}
-
David Bertoni authored
This test is flaky for Service Worker-based extensions due to reloading to remove file access. This CL adds the kEnableFileAccess flag as a workaround. Bug: 1127564 Change-Id: I9fe5728639169bdcb8ea8d05f3cb0081675cdd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560608 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#832027}
-
Roman Arora authored
Modified `Verify ShowUI()` test to avoid timing issues that can cause the test to flake and re-enabled it. Move the listenOnce/showUI logic to the ready() function of the component. Bug: 1148061 Change-Id: I1a583dcc1ba531b39e8f92a5f9b9faf4fcfc18e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538150Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#832026}
-
Ben Pastene authored
crrev.com/i/3438440 allocates the machines for this. Bug: 1140727 Change-Id: I0a4fee5f1d267ec698f20b740cbbc4e0619685c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564391Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#832025}
-
Aaron Leventhal authored
This logic doesn't make a difference in any tests. Notably: continuation.html in web tests passes. This CL progresses towards removal of ShouldUseLayoutBuilderTraversal(), simplifying AddChildren() and removing conditions that lead to lack of symmetry in child-parent relationships. Bug: None Change-Id: Ic436c4dd51ba7d12cd6adec0f7d35cdbab7dc487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563863Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832024}
-
Tommy Li authored
This CL simplifies ProcessSyncChanges() to no longer attempt to uniquify keywords for engines. We can do that now because the preceding CL made Add() and Update() tolerant of engines with keyword conflicts: https://chromium-review.googlesource.com/c/chromium/src/+/2548160 The long explanation is here: go/chrome-search-engines-2020-improvements Bug: 1022775 Change-Id: If99d4d12510625b9474e4abfcb235c202f4911cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558911 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#832023}
-
Andrew Xu authored
In this CL, the code of MainButton and DeleteButton is moved to independent files instead of living in clipboard_history_item_view.cc. It improves the code readability. This CL should not introduce any visual differences. Bug: 1151493, 1152815 Change-Id: I16200f26ca1d5321a1407b6703e297f0b7d7fe89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556898Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832022}
-
Dan Harrington authored
Bug: b/173610894 Change-Id: I20bb9ebb59a04b6d13b8cc4a1a3fabfbf4c7d6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558977 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#832021}
-
Xi Han authored
The bug was caused by cleaning up suppression tokens by the StartSurfaceStateObserver after leaving the start surface. In this CL, the following changes are made: 1) Two observers, StateObserver and the HintlessActivityTabObserver, share the same token to handle the suppression/unsuppression of the bottom sheet for tab switcher. 2) The suppression is done by the first observer who notices the tab switcher is shown. The token is reset after suppression to guarantee it can be used again to suppress the sheet. 3) Clearing up requests when transit from a tab to Start surface. This prevents the preview page (a kind of bottom sheet) from being shown on the Start surface. Bug: 1151804 Change-Id: I42a9405e46f863971dd439f03d31fed8eda46524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553286 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#832020}
-
Patrick Noland authored
transitionToRegularScriptWithoutOnboarding Bug: 1149965 Change-Id: If40484762339925fb333ee78db634902c8ddbb06 TBR: arbesser@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565070Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#832019}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4314.0-1605523684-benchmark-88.0.4324.12-r1 to 89-4324.9-1606128713-benchmark-89.0.4335.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4c5f3d84d767e06be1655c861ee305059c2b32a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565398Reviewed-by:
-
Moe Ahmadi authored
Settings the line-height CSS property can result in unappealing outcomes such as characters appearing chopped off. By default, line-height is calculated based on the font size, font family and other factors such as presence of italic text etc. This CL eliminates uses of line-height in the realbox in order to better support larger minimum font sizes. The following are screenshots of the realbox with "tiny" (default) and "huge" (maximum) minimum font sizes. before (tiny): screenshot/6GZeMfLZEejVEG7 before (huge): screenshot/A8nt8ynzpG4yeKF after (tiny): screenshot/BNyDMfRYbuum8AK after (huge): screenshot/9TdmkQoswconjv4 Fixed: 1145840, 1051865 Change-Id: Ia24c8f44cf9f97ed6345c7f0064178dde525b3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561580Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832017}
-
Robert Kroeger authored
Mac Nvidia Retina is failing consistently on s3tc-and-rgtc.html. Suppress the test failure. Bug: 1153689 Change-Id: Idd1e491643ccdf37980655dc62a9e53acf44059f TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565731Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#832016}
-
Piotr Bialecki authored
Removes plane detection state, world tracking state and world information since the general approach of the APIs that we are adding seems to just add additional entries to XRFrame / XRSession directly, w/o the layer of indirection. The spec also contains a mechanism of detecting whether a feature has been enabled through integration with permissions API - this makes the tracking states unnecessary, since they were only needed to communicate exactly that. Change-Id: I36298b05019f87f0de47c992fc29fef987e6e192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540575 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#832015}
-
Aaron Krajeski authored
I lost a few hours to this when changing a signature and having no idea what was going on: https://chromium-review.googlesource.com/c/chromium/src/+/2564189 I guess they're against the style guide for a reason! Bug: 1140535 Change-Id: I79b534db6b1752b73689cb032aaa24a0e326ac38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564817Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#832014}
-
Jason D. Clinton authored
These were reviewed by senior engineers across the project on https://docs.google.com/document/d/1EZNCv9szJzY6ADyj_WojT9iRB6JJUY9aGc6cNiGnvCo/edit Change-Id: I8a839ec93403b3b7fe7bad7ed17bb440e7cb980a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556450Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jason Clinton <jclinton@chromium.org> Cr-Commit-Position: refs/heads/master@{#832013}
-
Tom Sepez authored
Bug: chromium:1129358 Change-Id: Iee01b1df931cd5dcf63cf378ac504d68ea4cbf75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565736Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#832012}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4492956adde..25c0c4f6128c 2020-11-30 szuend@chromium.org [cleanup] Remove casts that are no longer needed 2020-11-30 michael.liao@microsoft.com [Sources- Accessibility]: Fix keyboard navigation for breakpoint sidebar If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1147743 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1a810cf86fb5cb1fa6468f8aa837becda6cf32f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565403Reviewed-by:
-
Ken Rockot authored
Fixed: 902135 Change-Id: I9aeb13d6606ed2cf89185bd7380e621b1dc22caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565656 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#832010}
-
Yuly Novikov authored
instead of 20.04. TBR=bsheedy Bug: 1153160 Change-Id: I2e1370afb24bb2069fdb87368a4bfc232f6c16fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565622Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#832009}
-
Charlie Hu authored
This CL fixes the missing Permissions Policy issue for XSLT document. Previously, the XSLT navigation will commit a new document without necessary header information in |DocumentLoader::response_|, resulting permissions policy header not effective for XSLT documents. This CL lets document loader copy the state of Permissions Policy (Feature Policy) from previous document to solve this problem. Bug: 1151954 Change-Id: I4e1591af65d9e93ad49850fb23f69426bf116dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561144Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#832008}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ie1f840d34e5c0b471177aad68cbb77aff9fc8394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565112Reviewed-by:
-
Benjamin Beaudry authored
In NGSimplifiedOOFLayoutAlgorithm, the order in which fragments are added to the builder is important and apparently more complex than I initially thought. The way it was implemented, it caused problem when we were trying to find the matching break token since the order was different. For more info on the new implementation, see my comments in ng_simplified_oof_layout_algorithm.cc. Fixing the order fixed all disabled tests in NGOutOfFlowLayoutPartTest, but one related to nested fragmentation that is unrelated. Bug: 1143301, 1117625, 1148875 Change-Id: I0e2c559930da3f0042ada106c334d35521163d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552076 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#832006}
-
Tom Anderson authored
R=dpranke Bug: None Change-Id: Id6af2f6fe655131415ccb24cf6d0150d12600688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555591 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#832005}
-
Thomas Guilbert authored
This CL updates the test expectations that were missed as part of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2556497 Bug: 963141 Change-Id: Ia858b484779160089d1803f3b0753dd8e56a018e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561780 Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#832004}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9be11f7d2b44..c6465ca683e6 2020-11-30 miu@chromium.org Remote virtual connections [1/3]: Refactor VCRouter to extend VCManager. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I69f2a02082251c2a0831e992648761acdcf4b460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564477Reviewed-by:
-
David Van Cleve authored
battre@ pointed out that a number of the data reduction prefs corresponding to obsolete metrics removed in crrev.com/c/1762336 were never cleared, so they continue to take up space in profile directories where they were set. This change adds back the prefs deleted in that CL temporarily, clearing them on startup. I've filed crbug.com/1153394 to remind us to remove the prefs once M90 branches (so that the clearing logic will have been live for two releases). Test: Added a unit test verifying all of the obsolete prefs get cleared Bug: 1132866,934982,1153394 Change-Id: Ife2dab8634205812119db36d50e95d0173884a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563788Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#832002}
-
Kyle Milka authored
Make the divider take up the full width of the bottom sheet. Bug: 1152646 Change-Id: I5aae6100e6e9fe3b66d9a49a9451dd8e1c28b972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563434 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
-
Christopher Cameron authored
CanvasColorParams is a poor match for ImageData. It has the same CanvasColorSpace names, but different pixel format support, and unused an unused opacity parameter. Remove the accessor ImageData::GetCanvasColorParams because of this mismatch. Clean up serialization of CanvasColorParams to not use these accessors. Remove ImageData::Create that takes a StaticBitmapImage, since this is not used and is the last place where CanvasColorParams are used. Remove the now-unused helper functions from ImageData ImageDataInCanvasColorSettings and ConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat. Bug: 1150969 Change-Id: Icf8697685ed4d0bfbcee07a47196a2fe4772a2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548773Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#832000}
-
Abigail Klein authored
Do not enable extra mac nodes on the AXTree because it caused a crash. Bug: 1136813 Change-Id: I46ce64b3af5ec5d4bf3abb82e30bbb96b71637e5 AX-Relnotes: Fix a browser crash on Mac. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555559 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#831999}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606737208-c1622dbc8154d000833156e031e2fb92fdbe0368.profdata to chrome-linux-master-1606759191-6cd311392c4a2d76b8ec4391ac1874206c9889b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibbe128fb84ccc1e97f186f665afc7e84729bf6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565114Reviewed-by:
-
Lucas Radaelli authored
This change implements support in the AccessibilityBridge to deal with multiple semantic trees, each one representing an iframe. The trees are combined before they are sent to Fuchsia into a single semantic tree. Test: AccessibilityBridgeTest.* Bug: fuchsia:63612,fuchsia:63610,fuchsia64329 Change-Id: I174ec9db254647edb33ada5b31eb24595debe031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556462Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/master@{#831997}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606737208-e8262bf3e6eb680125b6c552d8461f977d1e98a6.profdata to chrome-mac-master-1606759191-e36e6bb9e34aaec2b6f2fa507df72b0ae1dbb4d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8d0ca2c0cf6c2ea4e36b254cb2b6759d97742d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565111Reviewed-by:
-
Thomas Guilbert authored
This CL uses video.requestVideoFrameCallback to guarantee a video frame was displayed before ending the test. Bug: 1083605, 1083609e Change-Id: I6a6b3a4a3349ba35c301fe1c7998857c9f94d9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561746 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL configures //third_party:dagger_java //third_party:dagger_processor so that they can point to the internal implementation of Dagger2 for internal Chrome builds BUG=1141111 Change-Id: Ibe7bc24341afcaad4835bf7a60093f563d65de5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565192Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831994}
-
![Eric Lawrence [MSFT]'s avatar](https://secure.gravatar.com/avatar/16e6d745c0e05bade0525857d18118ce?s=80&d=identicon "Eric Lawrence [MSFT]")
