GitLab

BUG=101244


Review URL: https://chromiumcodereview.appspot.com/10762006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146269 0039d316-1c4b-4281-b951-d872f2087c98

This change updates the suppression rule for Bug 111186 <http://crbug.com/111186> to catch up with r140100 <http://crrev.com/140100>.

TBR=dhollowa
BUG=111186
TEST=make the "Linux Tests (valgrind)(5)" bot and the "Chromium OS Tests (valgrind)(5)" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10704177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146267 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135258
TEST=Manual, made sure that the tab background was fully tinted with several themes

Review URL: https://chromiumcodereview.appspot.com/10690115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10692141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146265 0039d316-1c4b-4281-b951-d872f2087c98

We saw a Chrome crash on changing the device volume in Guest mode if Accessibility has been turned on. This automation test will catch this type of crash.

TEST=None
BUG=129218
Review URL: https://chromiumcodereview.appspot.com/10696169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146263 0039d316-1c4b-4281-b951-d872f2087c98

Relanding with improved tests and support for cleaning up partial nigori.

The original patch was reverted due to users who needed to download a new nigori
node, but who had since been migrated. We do not handle migration before the
backend is initialized, so we now go ahead and detect+delete partial nigori
nodes before redownloading them. By blowing away the old progress marker,
we're no longer at risk of receiving the migration done response.

In order to test this the SyncBackendHost unit tests have been substantially upgraded.

original review at: https://chromiumcodereview.appspot.com/10483015

BUG=129665,133061,133219
TEST=unit/integration tests

Review URL: https://chromiumcodereview.appspot.com/10701085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146262 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses a leak in base::PlatformThread::SetName() shown in the heapchecker bots. (Even though this std::string is created by tracked_object and it may be a duplicate of Bug 102327 <http://crbug.com/102327>, I do not have any ideas why this stack does not include tracked_objects.)

TBR=dhollowa
BUG=136936
TEST=make the "Linux Heapcheck" bot and the "Chromium OS Heapcheck" bot green.
Review URL: https://chromiumcodereview.appspot.com/10694149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146259 0039d316-1c4b-4281-b951-d872f2087c98

R=erg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146258 0039d316-1c4b-4281-b951-d872f2087c98

Display separate dialog if there are neither installed nor suggested services.

BUG=129005
TEST=bring up intent picker without any intents installed, and none in CWS. (Easier in Chromium, since CWS suggestions are disabled there)

R=pkasting@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10703121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146257 0039d316-1c4b-4281-b951-d872f2087c98

in SendBody instead of SendBodyComplete.

SpdyHttpStream inherits from ChunkCallback (SpdyStream doesn't inherit
from ChunkCallback). OnChunkAvailable is handled by SpdyHttpStream.

In unit tests, added new tests (similar to http_stream_parser_unittest
for chunked uploads), to delay sending of chunked data.

Also added sending of window_update during chunk uploads. Verified
that these tests fail with the old code and run ok with the new changes.

This change also fixed chunked uploads hanging (or stalling) for
speech recgonition.

Many many thanks to sleevi for suggesting the way to clean up
the SpdyHttpStream's SendBody and SendBodyComplete code.

R=rch@chromium.org, rsleevi@chromium.org
TEST=network unit tests
BUG=113107, 136044

Review URL: https://chromiumcodereview.appspot.com/10689034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146255 0039d316-1c4b-4281-b951-d872f2087c98

Wraps the SincResampler for multichannel use.  Can't land until after
https://chromiumcodereview.appspot.com/10702050/ lands.

Since the SincResampler unit tests focus on accuracy, the multi channel
resampling tests just ensure the wrapper functions as expected with a
single resampling frequency and a constant fill value.

BUG=133637
TEST=MultiChannelResampler Unittests.


Review URL: https://chromiumcodereview.appspot.com/10701049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146254 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146253 0039d316-1c4b-4281-b951-d872f2087c98

Though it's not documented in the function comment, UpdateCache()
had ability to remove an existing cache entry. This is more like a
surprising behavior. This patch removes the behavior.

Along the way, rename the function to be more descriptive.
Also rename RemoveFromCache() to RemoveCacheEntry().

BUG=136921
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10690154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146251 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10736040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146250 0039d316-1c4b-4281-b951-d872f2087c98

This is part of the unit_tests linking effort.


Review URL: https://chromiumcodereview.appspot.com/10698095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146249 0039d316-1c4b-4281-b951-d872f2087c98

If a browser is running, and the service process is running the connector, the
connector will occasionally start up a chromium process to check the connector
enablement policy. The flag to do so would get passed to a running browser, if
present, and there is a path through the policy check code that could cause the
browser to quit.

This patch prevents the policy check flag from being passed on; the started
process will be very short lived and does a silent launch.

BUG=134252
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10666010

TBR=scottbyer@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10703157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136803
TEST=none, unittests

Review URL: https://chromiumcodereview.appspot.com/10693153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146246 0039d316-1c4b-4281-b951-d872f2087c98

Duplicating ~100 lines of code for the ~5 lines of code that are different isn't worth it.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10735016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146242 0039d316-1c4b-4281-b951-d872f2087c98

It depends on ManagaedMode (which is excluded on android).

BUG=117407

TEST=


Review URL: https://chromiumcodereview.appspot.com/10735043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146240 0039d316-1c4b-4281-b951-d872f2087c98

Clicking in the Omnibox (without prior focus or selection) should select-all in reverse to show the leading text.

Note: OmniboxViewViews selection differs from OmniboxViewWin in other tangentially related ways (retention and display of unfocused selection, tracked in crbug.com/134701).

BUG=134762,134701
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10694140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146239 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10704166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146238 0039d316-1c4b-4281-b951-d872f2087c98

Remove browser::FindTabbedBrowser from old_panel_browsertest.cc by deleting the tests now that use it. These tests are going to be deleted soon anyways. This matches a subset of r145215.

BUG=129187
Review URL: https://chromiumcodereview.appspot.com/10694145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146237 0039d316-1c4b-4281-b951-d872f2087c98

Along the way, rename it to GDataCacheEntry to be consistent
with other classes, and put it in a separate header file.

FWIW, nested classes are usually avoided.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Nested_Classes

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10690149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146236 0039d316-1c4b-4281-b951-d872f2087c98

R=nirmimesh@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/10704170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146235 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/10756018/


BUG=133570
TBR=cmp@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10704171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146231 0039d316-1c4b-4281-b951-d872f2087c98

The policy setting crash has been fixed. Re-enable the tests.

TBR=mnissler@chromium.org
BUG=134560
TEST=

Review URL: https://chromiumcodereview.appspot.com/10692175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135482
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10700150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146229 0039d316-1c4b-4281-b951-d872f2087c98

CacheEntry is now complex enough to be a class, rather than a struct.

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10698157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146227 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs:

ui_resources.pak  ==>  duplicated in each scaled-resource pak
ui_resources_standard.h  ==>  merged into ui_resources.h
ui_resources_standard_map.h  ==>  renamed to ui_resources_map.h
ui_resources_standard_map.cc  ==>  renamed to ui_resources_map.cc

theme_resources.rc  ==>  merged into theme_resources_standard.rc
theme_resources.pak  ==>  duplicated in each scaled-resource pak
theme_resources_standard.h  ==>  merged into theme_resources.h
theme_resources_standard_map.h  ==>  merged into theme_resources_map.h
theme_resources_standard_map.cc  ==>  merged into theme_resources_map.cc

The image duplication is intentional; we may revisit this later.

Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL.


TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org
BUG=133570
TEST=Trybots, local build

Review URL: https://chromiumcodereview.appspot.com/10756018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123739
TEST=try


Review URL: https://chromiumcodereview.appspot.com/10695150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10752006

TBR=shishir@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10704169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146221 0039d316-1c4b-4281-b951-d872f2087c98

Some of the tests, such as layout tests, need to run on a seperate thread.
Adding an extra to the intent to achieve this.
When invoking the test, users can use 'adb shell am start -e RunInSubThread -n testName'

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10696172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146220 0039d316-1c4b-4281-b951-d872f2087c98

This is a partial port of WebAudio's SincResampler from WebKit formatted and
culled for use by Chrome Media.

We can't directly use the one in WebKit as it's layed under a ton of abstraction
and is tightly coupled with WebKit objects.

Test generates a swept sine wave and calculates the RMS error for common sample
rates (via UMA stats).

MultiChannelResampler and AudioRenderMixer changes to support resampling will
come in later CLs.

The 1000 ft view is that MultiChannelResampler will implement SincResampler::
AudioSourceProvider and AudioRendererMixer will implement a new
MultiChannelResampler::MultiChannelAudioSourceProvider interface.

When resampling is necessary AudioRenderMixer will feed itself into a
MultiChannelResampler instance which will poll data as necessary and feed it
channel by channel into a set of SincResamplers (one for each channel).

We want to resample post-mixing since resampling is a much more expensive
operation.

Original for reference:
http://git.chromium.org/gitweb/?p=external/Webkit.git&a=blob&f=Source/WebCore/platform/audio/SincResampler.cpp

Visual plot of 44100 to 48000 for reference; red line is the resampled signal
and the green line is the reference signal. Ideally only the pure signal (green)
should be seen.  Any bit of the resampled signal showing (red) is where the
resampling algorithm is incorrect: http://i.imgur.com/1vsaI.png

BUG=133637
TEST=New unittests.

Review URL: https://chromiumcodereview.appspot.com/10702050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146219 0039d316-1c4b-4281-b951-d872f2087c98

This preference appears to be unused and the code for Hixie76 has been removed
from WebKit.

Review URL: https://chromiumcodereview.appspot.com/10689165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146218 0039d316-1c4b-4281-b951-d872f2087c98

(otherwise only half (the common half...:( ) of the sid string would get encoded...)

this change is super trivial and only fixes the resulting suffix

R=grt@chromium.org
BUG=133810
TEST=Make sure Chrome gets the proper suffix


Review URL: https://chromiumcodereview.appspot.com/10703147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146217 0039d316-1c4b-4281-b951-d872f2087c98

to base\win\metro.

BUG=133560
R=cpu
Review URL: https://chromiumcodereview.appspot.com/10693133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136629
TEST=no
TBR=aa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10690144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146213 0039d316-1c4b-4281-b951-d872f2087c98

Rename/re-comment tests and added new death tests for WeakPtr.

Review URL: https://chromiumcodereview.appspot.com/10690080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146212 0039d316-1c4b-4281-b951-d872f2087c98

R=jar@chromium.org
BUG=108171


Review URL: https://chromiumcodereview.appspot.com/10694131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146211 0039d316-1c4b-4281-b951-d872f2087c98

These tests are failing since the MS 2008 - 2010 switch.  Turning them off to make the tree green until someone takes the bug and figures out how to fix it.

BUG=132133
TEST=gpu win release bots
TBR=nduca
Review URL: https://chromiumcodereview.appspot.com/10540111

TBR=zmo@google.com
Review URL: https://chromiumcodereview.appspot.com/10704161

TBR=jbates@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10695160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146210 0039d316-1c4b-4281-b951-d872f2087c98