- 06 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/76488e6d8e63..dc68e3248ed9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id1c1625a67d253145e2d6dfde0dd2ff5949ea643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795633}
-
Nasko Oskov authored
The navigation_handle_id_ is initialized when the navigation starts. The goal of this CL is to initialize it during the construction of the NavigationRequest object, so it can be used as unique identifier for emitting tracing events for the lifetime of the NavigationRequest. Bug: None Change-Id: Iee966826d4275a1b6659348d89f7f3dd3855c871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274596 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#795632}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70df33d24eb1..19c3850508fd 2020-08-06 westont@google.com [infra] iPad 13.6 2020-08-06 westont@google.com [infra] Add new provisioning profile including 4 new ipad UIDs. 2020-08-06 adlai@google.com Revert "Migrate SkImage::MakeFromTexture to GrRecordingContext" 2020-08-06 adlai@google.com Revert "Migrate MakeCrossContextFromPixmap to GrDirectContext" 2020-08-06 brianosman@google.com Disallow runtime effect color filters that depend on position If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: Ica8f2a96b19ca8dfbddddf44a5a4aafe5c03b4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340313Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795631}
-
Rahul Arakeri authored
This CL implements the bounce forwards animation for when user performs a fling. When the scroller reaches the bounds, the residual velocity determines the extent of the overscroll. This then gets applied to the scroller followed by the usual bounce back animation. Bug: 1058071 Change-Id: Id14cfff5e99843bd9849d7122058dc16d929e74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337940 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795630}
-
Yue Ru Sun authored
This additional logging will allow us to have a simple way to visualize a breakdown of entry counts by entry type, similar to what we already have for dropped entries. Change-Id: Ic86230cd43541492b171d3572224db02900788da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340706Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#795629}
-
Bruce Dawson authored
This reverts commit f4832bba. Reason for revert: Chrome branded builds are breaking. First breakage was https://ci.chromium.org/p/chrome/builders/ci/win64-trunk/51134 Error is: FAILED: obj/chrome/test/unit_tests/metrics_reporting_handler_unittest.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc(108,10): error: no matching member function for call to 'Set' map()->Set(policy::key::kMetricsReportingEnabled, This file is only compiled for official builds so that's why it was missed. Original change's description: > Reland "Remove the old version of PolicyMap::Set" > > This is a reland of 9b84489c > after fixing google_update_policy_fetcher_win.cc > > Original change's description: > > Remove the old version of PolicyMap::Set > > > > 1. Removed the old version of PolicyMap::Set, > > which passes value as unique_ptr. > > 2. Changed all the remaining refs use the new > > version which passes value parameter as base::Value > > instead of unique_ptr. > > > > Bug: 1092469 > > Change-Id: Ie45bb05b603cedcad8119a65134c4f5f008964dc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332191 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#795078} > > Bug: 1092469 > Change-Id: I4dfdf57753377ca49a6965b416e2a88c306f2ec7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339958 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795338} TBR=avi@chromium.org,eugenebut@chromium.org,emaxx@chromium.org,ayaelattar@chromium.org Change-Id: I66eeda5d032bcbf1d8e3628690e38911dbc5dd13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341817Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#795628}
-
Jeremy Chinsen authored
This reverts commit db70952d. Reason for revert: Caused a regression in preview (bug: 1112747) Original change's description: > cros: Replace custom header for wallpaper picker with default. > > Currently the wallpaper picker uses a customer header that lacks a > maximize button. However, the wallpaper picker is resizeable and can be > maximized. To make the wallpaper picker consistent with similar apps, > replaced custom header with the default. > > Test: manual > Bug: 1096274 > Change-Id: If7d31b2ef53c782b05d361b8147554736742726f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316152 > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791553} TBR=xdai@chromium.org,chinsenj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1096274 Change-Id: I06a800ead6cd20a22e4a1f222b90ff681b1d0491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341750Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795627}
-
Yves Arrouye authored
Bug: None Test: None Change-Id: I9bed2a106220ab51aa6aa2e7324833e8dd9b5826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341389Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#795626}
-
David Van Cleve authored
The browser's views of certain same-origin subframes' feature policies can disagree from the values available to a well-behaved renderer, erroneously triggering this renderer kill. This is because not all same-origin subframes commit navigations, but the Feature Policy code in RenderFrameHostImpl depends on a call to DidNavigate to update RFHI's |feature_policy_| member after learning a new frame's origin. For frames that don't see DidNavigate calls, RFHI::feature_policy_ ends up in a state that can disagree with the renderer-side feature policy state for the same frame, stored in blink::SecurityContext. This change adds a fix by adding a call to ResetFeaturePolicy to RFHI::SetOriginAndIsolationInfoOfNewFrame, which is the first time that the browser's representation of a new frame learns the frame's origin. This allows computing a correct feature policy for features whose values depend on the frame origin. (Currently, we compute the policy before knowing the origin, which leads to the problematic inconsistent state.) Bug: 1112959, 1111735 Test: Add a browser test that crashes before the fix and passes after Change-Id: Ic3c42fbf10a468d230d85981eba10b4be4533307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335910Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#795625}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/d39fe6cd6f..f66bc74928 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/d39fe6cd6f..f66bc74928 Bug: None Change-Id: I70da4b407f6cd29566285e8f7a87a0a3a7ea44b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340044Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#795624}
-
Dominique Fauteux-Chapleau authored
Bug: 1113259 Change-Id: If8fb61be399b871baa34c0bace03dceebe60b928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339695Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#795623}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/76488e6d8e63..dc68e3248ed9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3a3d9844ad42bdf9df1a4f51d3e066539bce5e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341036Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795622}
-
Changwan Ryu authored
This allows keyboard apps to avoid querying text around the selection, which is required for predictive suggestions on keyboard. The synchronous text querying process in InputConnection is known to be very slow on low-end devices, and supporting the new API will reduce the time taken in showing the keyboard. This CL also ensures that the last text data in ImeAdapterImpl is correct. Bug: b/162992484 Change-Id: I8137782536afcbfcd95200b77e3d1127b2b67031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340295Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795621}
-
Fabio Tirelo authored
Test is flaky on CrOS MSan TBR=reillyg@chromiu.org Bug: 1113853 Change-Id: I5d722be7d57048431af4f42abe07ba9834782c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341156Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795620}
-
Esmael El-Moslimany authored
Bug: 1112994 Change-Id: I6b1ebaa751a8a403cb921777ea22c44ab9fb8a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337502 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795619}
-
Nick Burris authored
This patch adds the strings for the secure payment confirmation UI. The reference image is https://storage.cloud.google.com/chromium-translation-screenshots/d6454af2fab327588d43904eeb11fadc01551faa Bug: 1110322 Change-Id: Ib60153e26a593007d635db38c03d46088495ba2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330081 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795618}
-
Mila Green authored
Bug: 1109231 Change-Id: I48ed51576cf1a8a00a01fcdae0731076e42b176c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340284Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795617}
-
Fabio Tirelo authored
TBR=reillyg@chromium.org Bug: 879885 Change-Id: I9e301cca22f501bf0b0e25f6544a3cf53b35ea04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339349Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795616}
-
Aaron Colwell authored
Removing GetSiteForExtensionId() and updated the sole caller since it doesn't actually need to use a site URL to accomplish what it was trying to do. - Removed extensions::util::GetSiteForExtensionId() to discourage new usage of site URLs. - Updated file system logic to compute the origin it needs directly from the extension URL instead of calling GetSiteForExtensionId() to indirectly generate the same URL. Bug: 1085275 Change-Id: I501e6ab3596597e4cdd8ee28df2c91f1104bed1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339608 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795615}
-
Chris Lu authored
Util method LogSignificantUserEvent() will log timestamps of user actions deemed indicative of users that would want Chrome as their default browser. The user actions in this CL are Extension Actions, searches from copied clipboard content, and GrowthKit opens. Bug: 1107489 Change-Id: If5f24100352a60362c35044feabf9fdc7b29f2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330931 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795614}
-
My Nguyen authored
Bug: 1106033 Change-Id: I2fe04f513f3ae2be866be0c24e3a524775418f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306500 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#795613}
-
Fabio Tirelo authored
TBR=reillyg@chromium.org Bug: 1113695 Change-Id: Ib404365d13b802bb45fff8b083f0c71e68a13546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339003Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795612}
-
Chris Cunningham authored
"Broker" acts as a simple decoder, but under the hood manages creation and selection of of underlying media::AudioDecoders, and thread-hopping. This also enables WebCodecs to use MojoAudioDecoder (android) when not in a Worker context. For Workers, we still need to expose the relevant Mojo interfaces (currently tied to the RenderFrame). Bug: 1094091 Change-Id: I3743de18aa6701428fc3655a2e917c3b447c4a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333379 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#795611}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsDateTimePage* Change-Id: If26368a1d86a29979c822e98597665774e404473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340724Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#795610}
-
John Z Wu authored
Also updated test to use OCMock for SharedPasswordControllerDelegate. Bug: 1097353 Change-Id: I8463b9790139b87c5ba7276328f46111d175b719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330749Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#795609}
-
John Lee authored
Bug: 973674 Change-Id: I124c385f33ebbe265392a2bfb4812475e3387c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336014 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#795608}
-
chrome://flagsThomas Lukaszewicz authored
This addition is necessary to allow users to disable the feature once the experiment is enabled. Reland comment: Original CL was missing metadata. Bug: 1099917 Change-Id: I89b92c0c0b2ec2065fff4598976c9536b0b19a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341382Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#795607}
-
Gavin Williams authored
This changes consolidates the CupsPrinterStatus kConnectingToDevice enum value into kPrinterUnreachable enum value. Having both enum values is redundant as they both would convey the same meaning to the user. The enums modified in this CL are relatively new and not persisted anywhere so they are safe to update. Bug: 1059607 Change-Id: If890c95f5c4650d25125cb4c40291aae616f4d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340292Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#795606}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b2d9bf02a88..2399aa25d56e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC reillyg@google.com,ftirelo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033067,chromium:1064151,chromium:1085419 Tbr: reillyg@google.com,ftirelo@google.com Change-Id: Ia1108d748a14e175f228a1e6704d719c5f076f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341365Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795605}
-
Morten Stenshorne authored
If there's a forced break, and it's at a valid class A breakpoint, we may break there. There's nothing in the spec suggesting otherwise. This is working correctly in the LayoutNG fragmentation engine, but not in the legacy engine (where we require some non-zero block-size content to allow forced breaks). Remove invalid tests, and add a couple of valid ones. Bug: 1100849 Change-Id: I1829a00a4e9761906ebe4536ded9c994f4737e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339663Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#795604}
-
Scott Little authored
This CL cleans up std::string usage in translate_language_list.cc and translate_browser_metrics.cc, expanding to callers in a few places. This CL also includes some miscellaneous cleanup to these files, such as removing the test-only method translate::TranslateBrowserMetrics::GetMetricsName() and instead inlines the string literals in the tests themselves. This CL changes no functionality, and is clean up only. Bug: 1109032 Change-Id: Icc18b29b7f79ec9e57b491548d1f05e032923ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332363Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#795603}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113845 Change-Id: Ib730ef14cc83593bc09b82640a469569612e2e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341153Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795602}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113835 Change-Id: Id7079fe52a1b35c8c5293db42bf9dccf0c4bd156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341151Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795601}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113821 Change-Id: I5174fce7966dd6e390a8c50bd427dc461a5b7874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341150Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795600}
-
Yu Han authored
Prior to this CL, the popup border, control's border and background color for color picker popup don't match spec. In addition, the suggested color picker popup wasn't styled. Updated the colors for color picker. And added a test for suggested color picker. The suggested color picker swatch control uses outline to indicate both hover (mouse) and focus (keyboard), [1]. Thus, I kept the existing behavior of using outline. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/forms/resources/colorSuggestionPicker.js;l=202 Bug: 1111926 Change-Id: Ib0608a85e6e2f276cff45446a7bac11e9726040a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336290 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#795599}
-
Fabio Tirelo authored
Test is flaky on CrOS TBR=reillyg@chromium.org Bug: 1113839 Change-Id: I31ee8f7c4954f363a2f7b462091ff9fd5cf7c794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341152Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795598}
-
Natalie Chouinard authored
This test is flakily crashing on test-n-phone: https://ci.chromium.org/p/chrome/builders/ci/test-n-phone Example failure: https://ci.chromium.org/p/chrome/builders/ci/test-n-phone/10873 TBR=dominickn@chromium.org Bug: 1062843 Change-Id: Icd4539aa98dc09e90ef45cfc7599c36647b5894e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341405Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795597}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc68e3248ed9..e69d5b2de943 2020-08-06 treehugger-gerrit@google.com Merge "Tests: Add client library + service stress test" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I66ef754640d991285df6ea0aea38b08346bef78e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795596}
-
Rainhard Findling authored
* Logs the Chrome cleaner result shown to users in an UMA histogram. Bug: 1087263 Change-Id: I25cdd664300632f3d893f59a01c3803ce3db6f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332802 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#795595}
-
Evan Stade authored
- stop explicitly disabling for WebLayer - add a play services java dependency to WebLayer Shell so the play services version metadata is added to the manifest - add some error logging to SmsUserConsentReceiver to make the case where apps lack that tag more apparent Bug: 1035836 Change-Id: I15a1a946479c1b5126e1458f548fa13d08e526d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337387 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795594}
-