- 16 May, 2018 40 commits
-
-
Aldo Culquicondor authored
This is the first step necessary prior to introduce a LinearGradientQuadRenderer. Bug: 843239 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I1be5e6265b99a153c3b7dba6e385f965952bac15 Reviewed-on: https://chromium-review.googlesource.com/1060120 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#559135}
-
Colin Blundell authored
When we first built out the IdentityManager C++ class and backed it via //components/signin classes, we wanted its interaction with those classes to mimic eventual interaction with the Identity Service as much as possible. As part of this design goal, we implemented it to handle callbacks from SigninManager by posting tasks to set its internal state and notify observers; this mimics the fact of receiving these notifications asynchronously from the Identity Service. This mimicking has proven useful, as it has ferreted out issues with tests assuming that signin state can be changed and have those changes observed synchronously. However, it has also proven problematic: 1. By delaying the change to IdentityManager's internal state, we could end up with clients getting inconsistent views of the user's signin state from SigninManager and IdentityManager (cf. crbug.com/804410). 2. We then changed IdentityManager to change its internal state before SigninManager sends its callbacks, but still delay notifying its (IdentityManager's) observers by posting a task. However, we have gotten feedback from developers of clients of IdentityManager that this behavior is problematic semantically: these developers want to be able to make changes to internal state in response to IdentityManager callbacks and have the invariant that those changes to internal state are made atomically with the change in IdentityManager's internal state. By decoupling the change in IdentityManager's internal state from the notification of its observers, these developers are forced to handle additional intermediate states in their code (e.g., "IdentityManager has changed to have the user be signed in but hasn't yet notified its observers"). In consequence of (1) and (2), we are abandoning the asynchronous notification at this time. However, once the codebase is converted away from direct usage of SigninManager entirely to IdentityManager, it could be a good idea to reintroduce the implementation described in the top paragraph above; reintroducing that implementation would be a good intermediate move to switching in the Identity Service-backed implementation. This change should not introduce any behavioral changes, as nothing in the codebase relies on these callbacks being fired asynchronously (or is even aware that they're fired asynchronously). Bug: 843510 Change-Id: Id1bc40fccbe1c4481d0c4968f90d7c15d1af154a Reviewed-on: https://chromium-review.googlesource.com/1061494 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#559134}
-
Jiaquan He authored
Regression of crrev.com/c/1056447. Bug: 733662 Bug: 843451 Change-Id: Ia123a20a0c6fff9ddb20697e10e8423b3f04b949 Reviewed-on: https://chromium-review.googlesource.com/1061835Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#559133}
-
Qiang Xu authored
Bug: None Test: compiles Change-Id: I53a62885d30d8ba8bc5695277fc73fdf857628ba Reviewed-on: https://chromium-review.googlesource.com/1060636Reviewed-by:
-
Jialiu Lin authored
1. Skip checking for enterprise whitelisted downloads If enterprise admin has configured "SafeBrowsingWhitelistDomains" policy, and the any URL in this download's |GetUrlChain()| matches any of these whitelisted domains, download protection will not check the URL(s) and content of this download. 2. When user opens a dangerous download, trigger |OnDangerousDownloadOpened| private extension API calls. (This private extension API call is only used by enterprise reporting extension.) Bug: 811467, 811454 Change-Id: I7e716a6a10900bc894ad721368edb9c82802efd4 TBR: benjhayden@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1054832 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#559131}
-
Stephen McGruer authored
This is a (very) partial reland of https://chromium-review.googlesource.com/c/chromium/src/+/738395, restoring only the changes to LayoutTests. This should be safe since '%23' always has been a correct encoding of '#' and so should work with the data URI code as it is today. It will also make any future re-land of the core original CL easier. Bug: 123004 Change-Id: I87126ea0e3fd39756e571a8e6cf966107e7f7209 Reviewed-on: https://chromium-review.googlesource.com/1048287Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#559130}
-
Corentin Wallez authored
BUG=chromium:809093 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9b061df95987130aeaacc46fa3feca943c781a9d Reviewed-on: https://chromium-review.googlesource.com/1060277Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#559129}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c2a34e4804e..510e9e399b3d $ git log 4c2a34e48..510e9e399 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 caryclark Reland "Reland "remove obsolete color defines"" 2018-05-15 jcgregorio [docker] Move to testing-slim as the base image. 2018-05-15 borenet [recipes] Move 'gclient runhooks' from flutter build to core 2018-05-15 kjlubick Fix UBSAN warnings in SkPerlinNoiseShaderImpl 2018-05-16 angle-skia-autoroll Roll third_party/externals/angle2/ 10e7e5013..80c32ccbb (1 commit) 2018-05-16 caryclark Documentation refresh Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: If7d14726e3202b2c3c5d582b7e1350e5af10f0db Reviewed-on: https://chromium-review.googlesource.com/1061580Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559128}
-
Benoit Lize authored
This is a follow-up to https://chromium-review.googlesource.com/975562, testing subresources as well. Bug: 824209 Change-Id: Ie8ebe5d105bfd266f7f99e5851bdabc8f0323540 Reviewed-on: https://chromium-review.googlesource.com/1060033 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559127}
-
Hans Wennborg authored
These are old leaks, so suppressing seems appropriate. Bug: 831667 Change-Id: Ic5efd1d06bb220d99edad1f9d44db5e7371f6ed5 Reviewed-on: https://chromium-review.googlesource.com/1061501Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#559126}
-
Emil A Eklund authored
Tbr: kojii@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I987a89c3401656712f0ccee78b6ef12b9b16e997 Reviewed-on: https://chromium-review.googlesource.com/1060080Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#559125}
-
Andrew Grieve authored
Bug: 810890 Change-Id: I5230aaf33ea5d90e61a4a20e77a08b46d457a275 Reviewed-on: https://chromium-review.googlesource.com/1059950Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#559124}
-
Felicia Lim authored
Cherry-picked from https://github.com/xiph/opus/pull/87 Change-Id: I328f08be0396597d83ef09b13624f2a236fe0263 Reviewed-on: https://chromium-review.googlesource.com/1060739Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559123}
-
khmel@google.com authored
This fixes one more race condition for OEM folder creation where it is created on demand on ash side first. This also fixes issue when OEM folder may appear in ash as normal folder. Plus does refactoring by discarding passing redundant oem_folder_id. Test: Manually Bug: 839024 Change-Id: I3844e8fbf24fc12c806f25f7c87973eebe167d02 Reviewed-on: https://chromium-review.googlesource.com/1060166Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Alexander Timin authored
Register WorkerSchedulers with NonMainThreadScheduler similar to how PageSchedulers are registered with MainThreadScheduler. R=alexclarke@chromium.org BUG=776416 Change-Id: I824cccfaafb4cea701807f60e3f0b70014e1b423 Reviewed-on: https://chromium-review.googlesource.com/1061461Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559121}
-
Fernando Serboncini authored
- Canvas2D.addPath - CanvasPattern - PaintRenderingContext - removes currentTransform Bug: 651798 Change-Id: If4c94253d6b060964c1575eb7f189979b42486e5 Reviewed-on: https://chromium-review.googlesource.com/677643 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#559120}
-
Mustafa Çamurcu authored
This cl is a workaround for handling events on windows/ozone. A PlatformEvent is a ui::Event when ozone is enabled while windows specific code assumes that an Event is an MSG. This cl introduces utility functions that help windows code convert MSGs into ui:Events and vice versa. Change-Id: Ic811bc12fdcd0d6ff0cebd174ad4c87aa689b930 Reviewed-on: https://chromium-review.googlesource.com/1011109Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Cr-Commit-Position: refs/heads/master@{#559119}
-
gogerald authored
Bug: 840803 Change-Id: I73adf2f8279ba491200cd027e29a493b45d6590d Reviewed-on: https://chromium-review.googlesource.com/1060602 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559118}
-
Yuki Shiino authored
Annotates RegisteredEventListener class as final. Change-Id: Ie2ec4d9686e27ca74a6535440259e7088ef20697 Reviewed-on: https://chromium-review.googlesource.com/1061714Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#559117}
-
Greg Thompson authored
This change suppresses error logging when the Policies key does not exist, as this is an acceptable (and expected) condition. This CL also: - Changes from requesting KEY_READ to KEY_QUERY_VALUE rights when opening the Policies key (principle of least privilege). - Removes some misleading wording in the emitted error messages (the call to Open() does not result in the creation of a key, and the call to ReadValue() does not write anything). - Switches to a combination of SetLastError and PLOG so that the log messages contain a human-readable error code. - Shortens the error messages -- the reader can inspect the code given the emitted file+line info if needed. - Removes an early-exit path, as RegKey::ReadValue is documented as not modifying its out param in case of error. BUG=812641,840369 R=rogerta@chromium.org Change-Id: I8990f85a4595b5356196e24167738222653846d2 Reviewed-on: https://chromium-review.googlesource.com/1060058Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#559116}
-
Nico Weber authored
This reverts commit 55d941b0. Reason for revert: Looks like this broke compile on Windows without goma. E.g. https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/603 error: error reading '../../third_party/blink/renderer/build/win/precompile.h' I'm guessing the precompile step needs a "-I." flag that it currently lacks. Original change's description: > Reland "Remove unnecessary include_dirs settings from BUILD.gn in Blink" > > This is a reland of 7f4f1890 > This CL has no differences from it. http://crrev.com/559003 should > fix a build issue. > > Original change's description: > > Remove unnecessary include_dirs settings from BUILD.gn in Blink > > > > Now we have no Blink-relative #includes. > > > > Bug: 836071 > > Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b > > Reviewed-on: https://chromium-review.googlesource.com/1058876 > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > > Commit-Queue: Kent Tamura <tkent@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#558629} > > TBR=peria@chromium.org > > Bug: 836071 > Change-Id: I452a61199a31b6a6a617e2985331ab6a034c6c7c > Reviewed-on: https://chromium-review.googlesource.com/1059636 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559018} TBR=peria@chromium.org,tkent@chromium.org Change-Id: Idc752c3912c4e4e5a1f941990883693b112aed7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836071 Reviewed-on: https://chromium-review.googlesource.com/1061598Reviewed-by:
-
Andrew Grieve authored
Bug: b/78588631 Change-Id: Id8ca31426b0a8536dc8d690cc57ff9cd89ee14b7 Reviewed-on: https://chromium-review.googlesource.com/1055610Reviewed-by:
Anthony Berent <aberent@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#559114}
-
Lindsay Pasricha authored
Bug: 830810 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iee9ccfb5684f67dd1e266fb5b99eed5c2b0688ed Reviewed-on: https://chromium-review.googlesource.com/1060271Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559113}
-
Eric Karl authored
Android OS may deschedule Chrome more aggressively when the app is backgrounded. This leads to longer task execution times and likely causes spurious watchdog timeouts. This change forwards visibility messages from the Browser process to the GPU process, disabling the GPU watchdog when we are backgrounded. Bug: 836986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic209d463c6433e6ffcc8bff06c811272513e66c8 Reviewed-on: https://chromium-review.googlesource.com/1042531Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#559112}
-
Mark Pilgrim authored
Bug: 773295 Change-Id: Icf521005f62dd0d48d160d9ff6c9fb2f9c7108b0 Reviewed-on: https://chromium-review.googlesource.com/1047825 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#559111}
-
Sigurdur Asgeirsson authored
This also makes the GetPlatformIndependentCPUUsage function generic, except for a couple of unsupported platforms that seem to retrieve fractional CPU utilization directly from kernel. Bug: 755840 Change-Id: I8254a1f1371d7d35d0eeec27f6f4efda03b0dbf9 Reviewed-on: https://chromium-review.googlesource.com/1058079Reviewed-by:
-
Fan Yang authored
Turn on some quic flags to see whether they are related with cronet perf regression: FLAGS_quic_reloadable_flag_quic_simplify_pacing_sender, FLAGS_quic_reloadable_flag_quic_incremental_loss_detection, FLAGS_quic_reloadable_flag_quic_early_retransmit_detects_in_flight_packet_lost. R=rch@chromium.org Bug: 842677 Change-Id: Ib31af2a2da05400bddbe1f852f5ca967dcfad8bf Reviewed-on: https://chromium-review.googlesource.com/1061595Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#559109}
-
Kim Paulhamus authored
This is a reland of 203117d9 that adds back U2fApiHandler to java_sources. Original change's description: > Rename U2f* to Fido2* > > In GmsCore v19, the Fido2 APIs will provide the unified functionality > of the U2F and Fido2 APIs so it will no longer be necessary to call > both of them. > > Since the rename spans upstream and downstream, will initially add > all Fido2* classes and then later remove the U2f* classes once > downstream changes have landed. > > Bug: 842006 > Change-Id: I4775682b428c0ffdc4aa6f699136a2c7d15ee40c > Reviewed-on: https://chromium-review.googlesource.com/1054778 > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558479} Bug: 842006 Change-Id: Ib6e5337a25c8ca57c7abe5736a6531975baeda19 Reviewed-on: https://chromium-review.googlesource.com/1059737Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#559108}
-
Tsuyoshi Horo authored
This reverts commit 4b00991e. Reason for revert: It is easy to fix the test failure. Original change's description: > Revert "Revive WorkerThreadableLoader for sync XHR again" > > This reverts commit 14b1861d. > > Reason for revert: This CL introduced a layout test that seems to be consistently failing on Win10 starting in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35033 in http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html: > > FAIL Synchronous CORS XHR after redirect on worker assert_equals: expected "PASS: Cross-domain access allowed.\n" but got "PASS: Cross-domain access allowed.\r\n" > > Original change's description: > > Revive WorkerThreadableLoader for sync XHR again > > > > The cl "5e1b52dd" which made ThreadableLoader > > use DocumentThreadableLoader for sync loading from worker thread had broken > > existing site. https://crbug.com/840348 > > > > This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't > > support CORS after redirect. > > > > It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously() > > support it. So This CL revives WorkerThreadableLoader for sync XHR. > > > > Bug: 840348, 706331 > > Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537 > > Reviewed-on: https://chromium-review.googlesource.com/1060793 > > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#559023} > > TBR=horo@chromium.org,kinuko@chromium.org > > Change-Id: I1605a0b591d59737fa09951e6f8d5f3d907d52b4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 840348, 706331 > Reviewed-on: https://chromium-review.googlesource.com/1061894 > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559101} TBR=horo@chromium.org,kinuko@chromium.org,lukasza@chromium.org Change-Id: I6d078b4124defec2f9d7514b95eed00ff6f685f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840348, 706331 Reviewed-on: https://chromium-review.googlesource.com/1061435 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#559107}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9795ca36af56..72b67fe2e3ac $ git log 9795ca36a..72b67fe2e --date=short --no-merges --format='%ad %ae %s' 2018-05-16 nednguyen Remove duplicate error handling of finding browser in shared_page_state Created with: roll-dep src/third_party/catapult BUG=chromium:843516 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iceaea818c4ae5222a7279d615489483ef0ce857e Reviewed-on: https://chromium-review.googlesource.com/1061578Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559106}
-
https://pdfium.googlesource.com/pdfium.git/+log/c3aa483e1325..a68ee04cfdeb $ git log c3aa483e1..a68ee04cf --date=short --no-merges --format='%ad %ae %s' 2018-05-16 dsinclair Verify bidi pos is within range before accessing Created with: roll-dep src/third_party/pdfium BUG=chromium:843100 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I538af2faea53bef08fc016efdb5eb33f10759520 Reviewed-on: https://chromium-review.googlesource.com/1061577 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559105}
-
Christopher Thompson authored
This implements the first phase of https://crbug.com/542484, to start having the omnibox suggest HTTPS URLs directly if there is a redirect from HTTP to HTTPS. This handles initial setup and db migration. A follow up CL will make the user-visible changes about scoring. A second follow up CL will change the terminology of "typed_count" to "omnibox_typed_score" throughout the rest of the codebase. This CL does the following: (1) Move the logic that determines the typed_increment based on transition type from HistoryBackend::AddPageVisit() to a helper. (2) Adds a migration for the visits database to add a new |incremented_omnibox_typed_score| boolean column, using that helper function. (3) Updates the history expiration logic to use the new column to decide when/how to decrement typed counts. Bug: 542484 Change-Id: I8b42c5b0e234703ad73537aa63373f240e66cc13 Reviewed-on: https://chromium-review.googlesource.com/1002890Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
kylechar authored
Empty once callbacks can't be run, so pass DoNothing callback instead. Bug: 843458 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I657e750efba2d12fea9f89d3617cfeebbaed78e3 Reviewed-on: https://chromium-review.googlesource.com/1061576Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#559103}
-
Lucas Gadani authored
This reverts commit 7a5a390d. Reason for revert: Windows bots aren't happy. Original change's description: > Remove CacheStorage mojom typemaps. > > This CL removes the typemaps for CacheStorage and converts the browser usage of > CacheStorage types to mojo types. > > Bug: 612287 > Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1 > Reviewed-on: https://chromium-review.googlesource.com/1058334 > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559058} TBR=jsbell@chromium.org,kinuko@chromium.org,lfg@chromium.org Change-Id: I3fc714c0984587beaed5cd4d21a7786e2288c662 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 612287 Reviewed-on: https://chromium-review.googlesource.com/1061965Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#559102}
-
Łukasz Anforowicz authored
This reverts commit 14b1861d. Reason for revert: This CL introduced a layout test that seems to be consistently failing on Win10 starting in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/35033 in http/tests/xmlhttprequest/workers/sync-cors-after-redirect-on-worker.html: FAIL Synchronous CORS XHR after redirect on worker assert_equals: expected "PASS: Cross-domain access allowed.\n" but got "PASS: Cross-domain access allowed.\r\n" Original change's description: > Revive WorkerThreadableLoader for sync XHR again > > The cl "5e1b52dd" which made ThreadableLoader > use DocumentThreadableLoader for sync loading from worker thread had broken > existing site. https://crbug.com/840348 > > This is because DocumentThreadableLoader::LoadResourceSynchronously() doesn't > support CORS after redirect. > > It is difficult to make DocumentThreadableLoader::LoadResourceSynchronously() > support it. So This CL revives WorkerThreadableLoader for sync XHR. > > Bug: 840348, 706331 > Change-Id: Ib41fc442ddca508011431609cad1b6b6f9bda537 > Reviewed-on: https://chromium-review.googlesource.com/1060793 > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559023} TBR=horo@chromium.org,kinuko@chromium.org Change-Id: I1605a0b591d59737fa09951e6f8d5f3d907d52b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840348, 706331 Reviewed-on: https://chromium-review.googlesource.com/1061894Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#559101}
-
Yuki Shiino authored
Annotates EventListenerMap class as final. Change-Id: Ifa70b4ac0ada0f73533817035e1abca5a5233299 Reviewed-on: https://chromium-review.googlesource.com/1061633Reviewed-by:
-
Gabriel Charette authored
We recently found a major handle leak. Adding the handle count as a field will help identify spurious crashes that were caused by this and avoid 100 owners looking into the same thing and cursing Windows + crash. R=siggi@chromium.org Bug: 841565 Change-Id: Ife9126450397df0bb736860141a28888143062f2 Reviewed-on: https://chromium-review.googlesource.com/1053806Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#559099}
-
Alexandr Ilin authored
Change-Id: I4c7aed23d680d70283f68124a7b7883b246cd0d9 Reviewed-on: https://chromium-review.googlesource.com/1061465Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559098}
-
Ben Wagner authored
This adds the SK_IGNORE_SKIMAGE_ONREFENCODED_CHANGE flag to hold off a Skia API change to use smart pointers for SkData returned from SkImage. After the Skia change rolls into Chromium, Chromium implementations of this API will be updated and the flag removed. Change-Id: I66649e7eb6ce25b51b8467337a8216e8acfd2e17 Reviewed-on: https://chromium-review.googlesource.com/1059731Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#559097}
-
Hayato Ito authored
This is a tentative fix for several crashes cluster fuzzer reported. It looks HTMLSlotElement::DetachLayoutTree is touching dirty assigned_nodes. It's still hard to have a minimized test case, so I'll work on that later to investigate further. I've added TODO comment there. Bug: 776656,843069,843261 Change-Id: I9093e170e3c851b89612f40e764bfdbdc1532d4f Reviewed-on: https://chromium-review.googlesource.com/1061274 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559096}
-
