- 20 Feb, 2019 40 commits
-
-
Brandon Jones authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1343065 Incorporates fixes made by jacde@chromium.org (Thanks!) Deactivates XRFrame objects once the relevant callback returns, which causes future calls to the object methods to throw an exception. Bug: 906842 Change-Id: Ib635f56ed28b728434a08347b9d9fb98d1ecd694 Reviewed-on: https://chromium-review.googlesource.com/c/1363836 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#633845}
-
Nico Weber authored
Bug: 926235 Change-Id: If8aad69145d67db353b17364d4e7c28ef38a7f51 Reviewed-on: https://chromium-review.googlesource.com/c/1477827 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#633844}
-
Bruce Dawson authored
On ARM64 builds of mini_installer the compiler generates calls to memcpy. Since we don't link mini_installer with the CRT (to guarantee that it is kept small) we have to implement this function. Bug: 931856 Change-Id: I3e1909b6ebf6255e0da981f20282562c33547a9b Reviewed-on: https://chromium-review.googlesource.com/c/1476527 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#633843}
-
Liquan(Max) Gu authored
The current implementation has a memory leak issue. TextPaintTimingDetector has two heaps which only allows adding but not removing. This leads to a memory leak issue. In a test case (see bug 922925) where new nodes keep generated and deleted, the memory leak is detected. To fix this issue, we use a cap as a stopping condition for tracking new nodes. The cap has already been in place but only used by recorded_text_node_ids_. We will extend it to the heaps. The stopping condition was triggered by the size of recorded_text_node_ids_, which was not in sync with the two heaps. In our change, we will make the three in sync so that the two heaps' deactivation will also be subjected to the same condition. More impl details: * We add a detached-node-set to record the detached nodes. Initially, when a node was detached, we completely forgot the record of it. Now, we keep it in detached-node-set until the node is reattached. * We replace the heaps with ordered set, which instruments the adding of detached-node-set. We used to use heap, which only allowed visiting the top of the heap each time. If the top had been erased, we discard the value. In this change, we need to support visiting the non-top as we no longer employ the discarding approach, so we need to replace the heap with the ordered set. Bug: 922925 Change-Id: Ie7d988bf077aa99ee776c7280c63ce39d51fa447 Reviewed-on: https://chromium-review.googlesource.com/c/1475907 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#633842}
-
Justin Cohen authored
Now that the NTP can load asynchronously, don't show the network indicator, or the progress bar, when loading an NTP. Bug: 920669 Change-Id: I6e49e10716da50c529b609f0972b74bb67135daf Reviewed-on: https://chromium-review.googlesource.com/c/1471236 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#633841}
-
Collin Baker authored
This function gets called whenever a tab is reopened from the main menu, even if IPH isn't showing. As a result, DCHECKing which promo step we are on fails. To remove the DCHECK, a separate flag is used to track whether IPH is showing. This flag is queried to check whether to update the current step. Bug: 933329 Change-Id: I1cad6305cc95a3170ec784015e85c0a067d6522c Reviewed-on: https://chromium-review.googlesource.com/c/1478188Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#633840}
-
Ian Kilpatrick authored
This patch reuses a lot of the logic we currently have to skip layout in LayoutNGMixin::CachedLayoutResult. It also moves this logic from ng_length_utils.cc to ng_layout_utils.cc We also make sure that if the constraint spaces don't match we force a layout of the child. Previously we were only performing a LayoutIfNeeded in this case, and as a result children not respecting the available size, etc. Bug: 635619, 928672 Change-Id: I36e248f1a7413f5becd2b39bdd2db25ca2843559 Reviewed-on: https://chromium-review.googlesource.com/c/1476263 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#633839}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1834d8c6d38..b946458b8e6f Created with: gclient setdep -r src-internal@b946458b8e6f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie915472850c977ab69a0b79185d01160dd0e08ce Reviewed-on: https://chromium-review.googlesource.com/c/1477885Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633838}
-
Piotr Bialecki authored
Bug: 930797 Change-Id: I85048ef330fce15ed098876ad9aff8d7b4cdd367 Reviewed-on: https://chromium-review.googlesource.com/c/1476179Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#633837}
-
Caitlin Fischer authored
The parameters in the comment no longer existed in the function declaration. The return type had changed, too. Change-Id: I3118bf0d30ec9fd5df4373db6a9c6197770ba29d Reviewed-on: https://chromium-review.googlesource.com/c/1478499 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#633836}
-
Aaron Krajeski authored
Because HTMLCanvasElement::ShouldAccelerate always returned true if the AlwaysAccelerate finch trial was running, it would never hit the path where it creates a ContextProviderWrapper and checks that it is even POSSIBLE to create an accelerated canvas. This CL changes the logic of that function so that features::kAlwaysAccelerateCanvas simply bypasses all of the other heuristics, but still performs the check on the context provider. Bug: 930559 Change-Id: If4d52b6696424488c468fcaa779793dbec9e689b Reviewed-on: https://chromium-review.googlesource.com/c/1478484Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#633835}
-
Tien Mai authored
The function FindUserBySID was not returning a successful result when it is passed no username or domain to fill even though the user was found. Bug: 933850 Change-Id: I97c9e208ea85695b94651029aac4c58b551beaa6 Reviewed-on: https://chromium-review.googlesource.com/c/1479091 Auto-Submit: Tien Mai <tienmai@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#633834}
-
Eric Orth authored
These all seem to extend from a copy/paste of code to set the mock resolver to synchronous mode, but there's no need to make a resolve afterwards. Bug: 922699 Change-Id: I439c7ba4bc37fa63314c48171c2a36a89c714135 Reviewed-on: https://chromium-review.googlesource.com/c/1477302 Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#633833}
-
Edwin Joe authored
Added if guard before using submission_trace_id() and embed_trace_id() method of LocalSurfaceId in trace events to ensure that the LocalSurfaceId is valid when they are called. Bug: 931792 Change-Id: I6cd64feb7b94d84dcd2b4df2d558cf5c8fc904a1 Reviewed-on: https://chromium-review.googlesource.com/c/1478931Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Edwin Joe <ejoe@google.com> Cr-Commit-Position: refs/heads/master@{#633832}
-
Manu Cornet authored
These are very useful for debugging, but also for some runtime checks that before this CL really didn't check anything, see |ShelfView|'s |GetAppListButton| and |GetBackButton| methods (those used to just resolve to "Button"). The runtime checks in |ShelfView| are also why some of these string class names are made publicly accessible (back button and app list button) while the others are returned inline in the overridden method. Change-Id: Ia775f961fd6b9f1107659105d94020b13de8e9c5 Reviewed-on: https://chromium-review.googlesource.com/c/1477613Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#633831}
-
Evan Stade authored
mash_fyi_interactive_ui_tests: - LocationIconViewTest.HideOnSecondClick - MouseEventsTest.MouseOver Bug: none Change-Id: Iea021f7e500848bf25d9afd0f061c2a58dc20ee0 Reviewed-on: https://chromium-review.googlesource.com/c/1479190 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#633830}
-
David Bokan authored
The crash is a SegFault at 0x1c which is consistent with ScrollNode::user_scrollable_horizontal's position in ScrollNode. This is a stop-gap to prevent crashing in stable. Once it's confirmed and merged I'll investigate the underlying cause and real fix. Bug: 924068 Change-Id: I7a613b945176d54116c15feaf7f5fdc91833735a Reviewed-on: https://chromium-review.googlesource.com/c/1478373Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#633829}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f20f5b94939e..938811eef933 git log f20f5b94939e..938811eef933 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 yunchao.he@intel.com Use const*const* to annotate color state descriptors Created with: gclient setdep -r src/third_party/dawn@938811eef933 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ic306db9b20de6093e1db31fa1e0e1ab5dc248a95 Reviewed-on: https://chromium-review.googlesource.com/c/1479050Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633828}
-
Dmitry Gozman authored
This patch removes public AppendRedirect function and handles redirect chain entirely in DocumentLoader. WebFrameTest.AppendRedirects test was actually testing that Vector::push_back() works, so it is changed to only test for initial redirect value. Bug: 855189 Change-Id: Ide2c411a328e69e70dd88369fe598fa7781ca746 Reviewed-on: https://chromium-review.googlesource.com/c/1455621Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#633827}
-
Ryan Sturm authored
This fix forces the unittest to not use the browser process network quality tracker, but instead use a passed in test tracker. Without this, messages can be queued while the testbrowserthreadbundle is tearing down causing a DCHECK in that class. Bug: 933533 Change-Id: I370a2048ef5f764b5e335c5ca63431a4f48aa1c7 Reviewed-on: https://chromium-review.googlesource.com/c/1479094 Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#633826}
-
Matt Menke authored
They were never really needed. Bug: none Change-Id: Icec8bb3dbff4a8181e5416035e4e60c90a0cb3b8 Reviewed-on: https://chromium-review.googlesource.com/c/1479170 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#633825}
-
kyle Ju authored
Bug: 881513 Change-Id: I7545077ccf34528b9053561749f65bd1553e8ca2 Reviewed-on: https://chromium-review.googlesource.com/c/1474600Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#633824}
-
Thiemo Nagel authored
Suggested by jonann@. Bug: none Change-Id: I6ce09c78087964ccb9b768dfaf750c03cadc3185 Reviewed-on: https://chromium-review.googlesource.com/c/1475489Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#633823}
-
Ian Kilpatrick authored
This is probably a more interesting change. Whenever we perform layout from NG->Legacy this enables us to reuse an old layout result stored on the object (even if that object is a LayoutBox). This decreases the size of LayoutBlock by a pointer, but increases the size of LayoutBox. Bug: 635619 Change-Id: I5be1bbf72f0a45623e90cb4f2767e5bd47bd4001 Reviewed-on: https://chromium-review.googlesource.com/c/1476567 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#633822}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=creis@chromium.org Bug: 714018 Change-Id: I45ef06c750df8d491227b7b7a8d9fdf233f06f04 Reviewed-on: https://chromium-review.googlesource.com/c/1475642 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#633821}
-
Yutaka Hirano authored
This is a preliminary change followed by https://crrev.com/c/1474887. Document::CheckCompleted should be immune to excessive calls, so this should not be a problem. Bug: 914739 Change-Id: I3b33b01fc434d04f328865777166e30c9abddf55 Reviewed-on: https://chromium-review.googlesource.com/c/1478318 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#633820}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is migrating PassphraseType into @IntDef using rules similar to other @IntDef inside Chromium project: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Notes: 1. PassphraseType.java is moved into Passphrase.java 2. functions inside Passphrase are using ordered List instead of Set 3. we remove Parcelable interface for PassphraseType BUG=919666 Change-Id: I2b8854d0638780eb817e42fbfc2bfc15df8e4a2a Reviewed-on: https://chromium-review.googlesource.com/c/1461877Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#633819}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5994ae2a0450..76730a46a1d8 git log 5994ae2a0450..76730a46a1d8 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 9856269+sarahM0@users.noreply.github.com In Vulkan, disallow BufferBlock on StorageBuffer variables (#2380) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@76730a46a1d8 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id3c2e8281fc720a4f2762509371e058c41900d5c Reviewed-on: https://chromium-review.googlesource.com/c/1478444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633818}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d544fffe7ff..902ceed39986 git log 3d544fffe7ff..902ceed39986 --date=short --no-merges --format='%ad %ae %s' 2019-02-20 timvp@google.com Revert "Create Container ANGLE APK" Created with: gclient setdep -r src/third_party/angle@902ceed39986 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I9e38f319b1ec3be4dd4bb3fb4771858239db85a4 Reviewed-on: https://chromium-review.googlesource.com/c/1477883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633817}
-
Hiroshige Hayashizaki authored
The newly added test and its expected.txt are mostly the same as its classic version of same-origin-test.js, except for: - notStreamedReason (it's always "module script"), - tracing event name (v8.compileModule), and - Set type=module. Bug: 841466 Change-Id: Id64fdbb91ffd406a002c3e907065720e475d157b Reviewed-on: https://chromium-review.googlesource.com/c/1475071 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#633816}
-
Xida Chen authored
This CL implements the rasterization part for a paint image that is generated by PaintWorklet, which is the DrawImageOp::RasterWithFlags. Bug: 907897 Change-Id: I993d29035f1ad09e7cbe3caecc5445876078ac01 Reviewed-on: https://chromium-review.googlesource.com/c/1426015Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#633815}
-
Hiroshige Hayashizaki authored
To remove ExecutionContext::Url() call from WorkerFetchContext. Bug: 878274, 931532 Change-Id: I40eaa79c72cc0c9b6ff9c7a7ecc2b206ee39bc28 Reviewed-on: https://chromium-review.googlesource.com/c/1394382Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#633814}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/177cd13347a9..4534fdbeafdc git log 177cd13347a9..4534fdbeafdc --date=short --no-merges --format='%ad %ae %s' 2019-02-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4534fdbeafdc The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0aa1610973d804e8377ba625f5737165475ea999 Reviewed-on: https://chromium-review.googlesource.com/c/1477882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#633813}
-
Elly Fong-Jones authored
Bug: None Change-Id: I1bf4f33b8bb92b7932981b9373994ecf6f71e680 Reviewed-on: https://chromium-review.googlesource.com/c/1478496 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#633812}
-
Eric Orth authored
Bug: 922699 Change-Id: Icb3454e12b0dcecae9aaa1773b39c206e9dd78b4 Reviewed-on: https://chromium-review.googlesource.com/c/1479151 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#633811}
-
Jeff Fisher authored
This fixes a couple presubmit issues when running on Windows: * check_gn didn't properly normalize paths * eslint didn't execute in node successfully since the bin style for the npm install was unix specific (it's a CMD file on Windows) Bug: 929919 Change-Id: Iec7e1057254047bd0a6539e16df964dc8a58d528 Reviewed-on: https://chromium-review.googlesource.com/c/1459576Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#633810}
-
Robbie McElrath authored
This test occasionally crashes with the network service enabled because a request hits the Interceptor after its been deleted. Change-Id: Ib09e8c6cdf1208ced3297af37e2261c880bae0f1 Reviewed-on: https://chromium-review.googlesource.com/c/1478307Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#633809}
-
Wez authored
Work-around some issues with the component launcher implementation by falling-back to using LaunchInfo-provided services if the ApplicationConfigManager cannot be found in the CastRunner's incoming service directory. Bug: 893229 Change-Id: I500920cb21186fdbd60f59783f359fdaf65aecaf Reviewed-on: https://chromium-review.googlesource.com/c/1476594Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#633808}
-
Tom Anderson authored
BUG=801780 R=thakis Change-Id: I60588de2dd5de1fe92f9731592d7ebd4468764c2 Reviewed-on: https://chromium-review.googlesource.com/c/1479410 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#633807}
-
Manu Cornet authored
Change-Id: I212670f81a9e4f01f06ba70cb312585fdaceab1c Reviewed-on: https://chromium-review.googlesource.com/c/1478658Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#633806}
-