- 30 Jul, 2019 40 commits
-
-
David Jean authored
A simple change for opening discussion about UMA for Startup time goal: appLaunchTime is used (in metrics_mediator.mm) to fill the following existing metrics: "Startup.ColdStartWithExternalURLTime" "Startup.ColdStartWithoutExternalURLTime" appLaunchTime is set in main_controller, which in the simulator, runs about 0.09 seconds later than IOSChromeMain::InitStartTime(), the first call in main(). I couldn't find any use of IOSChromeMain::StartTime() so I retyped it to a base::TimeTicks and used it as a replacement value in main_controller. If there is something/someone currently tracking the two metrics above, then they will get slightly bigger from now on. If it is not acceptable, then we can look at creating parallel Startup metrics. Bug: 988395 Change-Id: Ie3e7d4d1c0f9931a5f760c6fcd5a06ceaa4a0ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722538 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#682205}
-
Christos Froussios authored
This reverts commit 103900b9. Reason for reland: The preceding CL was also relanded. Original change's description: > Revert "[Password Manager] Restore UMA metric for how many linux users don't have encryption" > > This reverts commit 7dd2ac40. > > Reason for revert: landed on top of a change that needs to be reverted for https://bugs.chromium.org/p/chromium/issues/detail?id=988010 > > Original change's description: > > [Password Manager] Restore UMA metric for how many linux users don't have encryption > > > > The existing UMA uploads don't separate new profiles from existing > > profiles which couldn't be migrated. > > > > Bug: 950267 > > Change-Id: I0f8f823e843bd2127a71438c347031f6a7b23346 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720630 > > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > > Auto-Submit: Christos Froussios <cfroussios@chromium.org> > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#681348} > > TBR=vasilii@chromium.org,cfroussios@chromium.org > > Change-Id: Ib6d74e8400e81f0a62160326273abf76dd74dc6d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 950267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721291 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681351} TBR=vasilii@chromium.org,cfroussios@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 950267 Change-Id: I3c4470089468507b92104e0108f6078b1cef2938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724759Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#682204}
-
Jérôme Lebel authored
In ChromeSigninViewController, when a swipe to dismiss is done by the user, the secondary button (Cancel) action is triggered. The swipe to dismiss does the exact same behavior than the Cancel button. Swipe to dismiss is only enabled for UnityConsent flag enabled. Bug: 987232 Change-Id: I3dc6f41a49652e3a2c4482628f26e1de5621ab47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715292 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#682203}
-
Christos Froussios authored
This reverts commit 341d33c3. Reason for reland: The preceding CL was also relanded. Original change's description: > Revert "[Password Manager] Cleanup feature: Migrate Linux to LoginDB" > > This reverts commit 3a84c395. > > Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 didn't stick, see https://bugs.chromium.org/p/chromium/issues/detail?id=988010 > > Original change's description: > > [Password Manager] Cleanup feature: Migrate Linux to LoginDB > > > > The migration has been completed and the feature is no longer used. > > > > Bug: 950269 > > Change-Id: I91f79f33ccda95e75d2b6156ade5d44f2e27c0ae > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719008 > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#681244} > > TBR=vasilii@chromium.org,cfroussios@chromium.org > > Change-Id: Ic0733620d3ebca563f5fa0be9f60742770eacd45 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 950269 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721290 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681347} TBR=vasilii@chromium.org,cfroussios@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 950269 Change-Id: Ifb49e8c9a6feeeaaa6e097296dda46540df66f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724527Reviewed-by:
-
Omer Katz authored
Added a worklist used by MarkingVisitor to record callbacks for backing stores. HeapCompact then reads that worklist to propagate it's inner Fixups() object (used to update references during compaction). Bug: 986235 Change-Id: Idebb79918ab855e768889f3bd4e45476d0ce5c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720643 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#682201}
-
Lowell Manners authored
This adds a NavigationsAreFullyCommitted test which checks that the BFCache code is actually committing navigations, and isn't just swapping in the frame without committing. This CL also defines a separate PageWithDedicatedWorkerNotCached test which focuses on a single disallowed feature. We expect to have many more tests like this, (one per disallowed feature). Change-Id: I5a4c17cd19698cc21dfcaa8dcd7c1d31eecf135d Bug: 976697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702021 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#682200}
-
Shao-Chuan Lee authored
This reverts commit 56c0a53e. Reason for revert: breaks betty-arcnext-chrome-pfq Original change's description: > viz: Create Separate Type for OutputSurface as Overlay > > When using a BufferQueue, the OutputSurface is treated as an Overlay, > and is made into an OverlayCandidate. That overlay candidate is then > pushed in as the front of the candidate list. This CL changes it into > its own type instead of checking for a bool on OverlayCandidate. > > R=rjkroege > > Bug: 963597 > Change-Id: I05588ba4d3b1ac03ed01ac0fff25d9ae03fc28c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696168 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680431} TBR=rjkroege@chromium.org,weiliangc@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963597, 988114 Change-Id: I614aa2c943ea8fdbfca1da40ae622d79070eeda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725033 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#682199}
-
Carlos Caballero authored
Use ScopedTaskEnvironment instead of MessageLoopForUI in /base/memory/memory_pressure_monitor_win_unittest.cc MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=brucedawson@chromium.org Change-Id: I212a7534542ecb94ed6414190e285f7eeaff2288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715363 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#682198}
-
Matt Falkenhagen authored
This is a reland of eb6b4eb4 Original change's description: > Disable flaky test WebRtcMediaStreamTrackAdapterTest.LocalVideoTrack. > > Bug: 982200 > Change-Id: I68547d2d5b097ab0fd816e44ca548a0024acec70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692223 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675841} Bug: 982200 Change-Id: Idd6a45b5fc6d6062aca35f6ee15bfe51c44e9eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722948Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#682197}
-
Stepan Khapugin authored
This reverts the improvements introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1183495 on iOS 13 due to a UIKit bug. This way, swiping on the system keyboard does not hang the app and the keyboard. However, bugs 875918,873544 are regressing. Bug: 988431, 875918, 873544 Change-Id: I91f358d80531d17104ffc6db96d4a488864325a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722545Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682196}
-
Md. Hasanur Rashid authored
As the "overflow" shorthand is divided into two longhands: "overflow-x" and "overflow-y", we add two different counters for both longhands to be counted while parsing the shorthand. Bug: 984177 Change-Id: I5eef66b9cc6bc72a023cfeb8b80ac584e71b433e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724640Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682195}
-
Miyoung Shin authored
|pause_| can be set on the main thread and read on the io thread at the same time. Declaring |pause_| as an atomic variable solves the data race problem. Fuzzer report: https://clusterfuzz.com/testcase?key=5766664522432512 Bug: 988327 Change-Id: Idd43e9d932dc96900b46a09c8b46ba4337505880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722952 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Marc Treib authored
It was decided not to launch this for now, so let's reflect that in the client-side default value. Bug: 983940 Change-Id: If6531b697212586e3832d30fea666481c774131d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724749Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#682193}
-
Lutz Justen authored
Marks org.chromium.chrome.browser.contextmenu.ContextMenuTest #testContextMenuRetrievesImageOptions_NoDefaultSearchEngine as flaky on Android Nexus 5. TBR=tedchoc@chromium.org BUG=chromium:988891 TEST=None Change-Id: Iee2e866aafb57024641a88ac58750aff8a86137d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724524Reviewed-by:Lutz Justen <ljusten@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#682192}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a79c2440f653..9addf0cb8cee git log a79c2440f653..9addf0cb8cee --date=short --no-merges --format='%ad %ae %s' 2019-07-30 timvp@google.com Vulkan: Enable Line Rasterization Emulation Created with: gclient setdep -r src/third_party/angle@9addf0cb8cee The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I493251b1d8831c71855ae7c26a58db220ccf12d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682191}
-
Eugene But authored
child_window_open_by_dom_egtest.mm file is already EG2 compatible. This CL simply adds a file to an existing EG2 target. Bug: 987646 Change-Id: I763129056ae5ca3f898a3a887eca8c59a0317747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724821 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682190}
-
Makoto Shimazu authored
Previously 404 was just treated as a identical scripts, but it's wrong because if a new worker tries to import the script during the initial script evaluation for a update, it should fail due to the network error. This CL adds code to capture the network failure in ServiceWorkerSingleScriptUpdateChecker and replay the network failure in ServiceWorkerNewScriptLoader. The failure in update-import-scripts.https.html will be fixed once ServiceWorkerImprotedScriptUpdateCheck is enabled. Bug: 648295 Change-Id: Ibcd879cc4c46b9878b1f6df1a6983c110f606fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715414 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682189}
-
Yutaka Hirano authored
Reject invalid use found in https://crrev.com/c/chromium/src/+/1695341/. Bug: 862184 Change-Id: I174d90bec44b8f077168a446b671a76ad38f0317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699587 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#682188}
-
rajendrant authored
Bug: 988188, 988186 Change-Id: Ie1a3638d156070ee82a39dd7669d00d64d0e0401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725244Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#682187}
-
Eric Willigers authored
The Launch Service can now be used to open a new application window. The numerous call sites of ::OpenApplication are being migrated to use the Launch Service in subsequent CL https://chromium-review.googlesource.com/c/chromium/src/+/1723794 Still to be implemented: When the BMO flag DesktopPWAsWithoutExtensions is enabled, we currently do not notify SiteEngagementService or AppBannerSettingsHelper about web application launches. Bug: 966288, 966290 Change-Id: Ia122eaa67561e3fa9b6373d4ad9e8692eb2e4f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722953 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#682186}
-
Alexey Baskakov authored
Let WebAppTest be a pure alias for ChromeRenderViewHostTestHarness. Bug: 973324 Change-Id: Ia957fbba1fe04c6f6472357c58e5109559d3b8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724838Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#682185}
-
Sergey Ulanov authored
viz_unittests now pass on Fuchsia (with headless ozone platform), so they can be enabled on the bots. Also added --child-arg argument in the test runner, which makes it easier to pass custom arguments to the test binary. Bug: 961455 Change-Id: I923af4978658b57d4da00a68fab8fdb3449ff47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725157 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682184}
-
Rakina Zata Amni authored
No-Presubmit: true No-Tree-Checks: true No-Try: true TBR: kojii@chromium.org, eae@chromium.org Bug: 626703 Change-Id: I8bab0bfb367f047f5b76bca7cea9a6bbcbd738ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724523Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#682183}
-
Ramin Halavati authored
Annotations.xml was outdated due to some changes that are not affected in it. This spammed the commit queue. Change-Id: Id0c8edbe20614044d19023c48e7581326387a71c TBR: nicolaso@chromium.org Change-Id: Id0c8edbe20614044d19023c48e7581326387a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724519Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#682182}
-
Shao-Chuan Lee authored
This reverts commit b8dd353f. Reason for revert: parent CL crrev.com/c/1725033 breaks betty-arcnext-chrome-pfq Original change's description: > viz: Use Build Flags to Maintain Single Overlay Candidate Type > > For each platform, we only use one overlay candidate type. Use build > flags to manage that. This also helps unify different platform's > ProcessForOverlay API. > > R=rjkroege > > Bug: 963597 > Change-Id: Icf0de8b30928cb4e7c23a3573eb46591191fb804 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664476 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680522} TBR=rjkroege@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963597, 988114 Change-Id: I0a97ba8e96bdd5abe4f6250ad2f681a23327e282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725434 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
-
Koji Ishii authored
With this patch, |CaseMap::ToLower, ToUpper| can use existing fast code path algorithms whenever possible, with or without |TextOffsetMap|. Redundant code is unified, all full Unicode case-mapping goes to |icu::CaseMap| API. The dromaeo benchmark looks neutral, noisy from positive 5.4% to negative 5.2%. https://pinpoint-dot-chromeperf.appspot.com/job/123853bf5c0000 https://pinpoint-dot-chromeperf.appspot.com/job/15cfedf0dc0000 The new |TextOffsetMap| is not used in the actual code path yet. Following patch will start using it to fix issue 926003. Bug: 926003, 985201 Change-Id: I7ff0c2335e8dc61b64b629364978ceba6c8fac96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722830 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#682180}
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //skia/public. *_struct_traits.* => *_mojom_traits.* skia/public/interfaces => skia/public/mojom Bug: 806965 Change-Id: I9b322799a7726149a1d685608b2e417e58107e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722837 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#682179}
-
Ting Shao authored
This fixes a failing browser test: WorkerNetworkIsolationKeyBrowserTest.ServiceWorkerMainScriptRequest when ServiceWorkerImportedScriptUpdateCheck is enabled. It's caused by missing the network isolation key for requests generated during update check. Network isolation key is used to separate requests from different contexts when accessing shared network resources like http cache. It's necessary for service worker update check. Bug: 648295 Change-Id: Id97e1e60ea2ceb7f59211dfcb6b2e32776455487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716391Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Ting Shao <ting.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#682178}
-
Adam Rice authored
In blink::WebSocketChannelImpl, send ArrayBuffer and String WebSocket messages synchronously if they are small enough to fit in the available quota. This avoids async behaviour in the common path, in preparation for running a callback when async message send completes. This is part of the implementation of WebSocketStream. See design doc: https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit#heading=h.7nki9mck5t64 BUG=983030 Change-Id: Iaa92783f2c06826da5341d73c29b968830bb83fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711334 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#682177}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bff2939b6249..105c9d507045 git log bff2939b6249..105c9d507045 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a96b79f90940..cbabea734cbd (6 commits) Created with: gclient setdep -r src/third_party/skia@105c9d507045 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Iefc2edee086a3099b5d05a1a26e7d7601a75835e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725262Reviewed-by:
-
Lutz Justen authored
This reverts commit 98c28cee. Reason for revert: Disabled the wrong test (Disables vs Enables). Original change's description: > [Sheriff] Disable testPaymentsIntegration... test > > Disables > org.chromium.chrome.browser.sync.ManageSyncPreferencesTest > #testPaymentsIntegrationCheckboxEnablesPaymentsIntegration > on Android. It's flaky on Nexus 5 devices. > > TBR=triploblastic@chromium.org,sahel@chromium.org > > BUG=chromium:987827 > TEST=None > > Change-Id: If5bc156d28dc19f34d6bf2cf13e10ddb2d4ff4a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722961 > Commit-Queue: Lutz Justen <ljusten@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681773} TBR=ljusten@chromium.org,sahel@chromium.org,triploblastic@chromium.org Change-Id: I14e5669f2bedfdea6d27eefc2da7c53ba8051da7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:987827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724756Reviewed-by:
-
Koji Ishii authored
W3C importer added platform conditions to some failures, but they are actually failing on other platfroms too; e.g., crbug.com/988932. These tests failing only on some platforms doesn't make sense, this patch removes all conditions. TBR: eae@chromium.org, futhark@chroium.org, rakina@chromium.org Bug: 988585, 988932 Change-Id: I487e7a0bcb60933d7196d972aab163137534b5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725103Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Christos Froussios authored
Bug: 893553 Change-Id: Ia935b7b07ad16d6b801a809d06d0a518576dc871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700222Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Auto-Submit: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#682173}
-
Alexey Baskakov authored
Move all extension-based tests into web_applications/extensions/. TBR=bsep@chromium.org Bug: 973324 Change-Id: I3a2238ad37f9d540e2970e2d3a5bb4341f3e1ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724520 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#682172}
-
Kenichi Ishibashi authored
Service workers and some worklets don't depend on WorkerClients anymore. Don't create WorkerClients for these workers/worklets. Bug: 988335 Change-Id: Ie556b1ced23c06500d86b55b062b7c4ca26375a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722944 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Noel Gordon authored
CL:1535465 did not really disable this test in DEBUG, it still runs on CQ bots in DEBUG where it hits the bot time-out limit often. Disabling a test in DEBUG is a little tricky: use !defined(NDEBUG) !! Tbr: adanilo@ Bug: 944697, 936429 Change-Id: I5e6311e91d630d0ec999b624b282dcaf16ff5bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724293Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#682170}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7dec2d1c5689..34f8bd8c4850 git log 7dec2d1c5689..34f8bd8c4850 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 shaobo.yan@intel.com Dynamic Buffer Offset : OpenGL Backend Created with: gclient setdep -r src/third_party/dawn@34f8bd8c4850 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ic96b764411162e7917d99ea1fa82efac7e97a1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725424Reviewed-by:
-
Takashi Toyoshima authored
This final patch does following cleanup. - Use uint64_t rather than int64_t in DataSource interface - Be careful for integer overflow - Remove IsValid, and just make consequent Read fail on wrong data sources - Add SetRange to FileDataSource rather than implicitly relying on seek position - FileURLLoaderFactory cleanup to utilize design changes above Bug: 983023 Change-Id: Ic58ca4445555103866187e20aed69f631e866231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712562 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#682168}
-
Ankit Kumar 🌪️ authored
This CL adds a test for validating the paragraph and heading support in PDF accessibility pipeline. A single PDF has been added which has a heading and multiple paragraphs. Bug: 981448 Change-Id: I40fe2b958e29fba2c8e0d98de254c438ad6ea248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723851Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#682167} -
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Also adds snippets_interals:closure_compile to the closure_compile target so that type checks are run. Bug: 968369 Change-Id: I1af11449962172036b3f24f16e7fe9570d37ee2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717731Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#682166}
-
