- 19 Oct, 2020 40 commits
-
-
Sean Topping authored
Bug: local 169779668 Test: tryjobs Change-Id: I7978e19241c1041c9a91533e6098684f7a4c9f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486075Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Sandeep Vijayasekar <sandv@google.com> Cr-Commit-Position: refs/heads/master@{#818696}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f4f1d8a352ca..5b99b448b3db 2020-10-19 bclayton@google.com Fix uninitialized use of TIntermediate::resource (#2424) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: If679aafe95c402ae4df59d5c44055413b3b7be69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818695}
-
Rouslan Solomakhin authored
Before this patch, Chromium developers could call RenderFrameHost::IsCurrent() to check whether the frame is about to be deleted without understanding that IsCurrent() can return false temporarily, e.g., when in bfcache. This patch adds comments to RenderFrameHost::IsCurrent() and WebContents::FromRenderFrameHost() that explain how IsCurrent() should be called before FromRenderFrameHost(). After this patch, it should be more clear to Chromium developers that IsCurrent() should be used to check whether FromRenderFrameHost() can be called. Change-Id: I7bba60ca7e73e3ff5c4320ffe8f3ee1be00393be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461590 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818694}
-
Ahmed Mehfooz authored
The animation_metrics_reporter_ in UnifiedSystemTrayController was being destroyed before the animation_. This could cause a crash when the tray is destroyed during an animation. Bug: 1137498 Change-Id: I1248e362947941f739a6d73fc67645d372e8af0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485141Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818693}
-
Etienne Bergeron authored
This CL is fixing a shutdown hangs caused by a condition variable wait(...). The code is scheduling a background task that will never be executed which is causing a deadlock. see: https://bugs.chromium.org/p/chromium/issues/detail?id=1086185#c24 Bug: 1086185 Change-Id: Ie401cd284d6af29f6c8c5da8ed085c72a81a0487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485635Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#818692}
-
Donn Denman authored
Disables a set of tests that are failing on M87 on Android. We plan to land on Master, merge into M87, revert on Master (since it has been addressed on Master). BUG=1137967 Change-Id: I6f38149b21df33d1354394322b7bad9ff492dad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481629 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818691}
-
wutao authored
The about flag has limitation to set up params for features. Remove the ambient mode flag otherwise will be conflict with finch experiment. Bug: b/171088716 Test: Manual Change-Id: I7d5a3aeaf299011f808db85ee4a400c899963304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481787Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#818690}
-
Andrew Xu authored
ClipboardHistoryItemView::SelectionFlag indicates both children visibility and the view responding to user actions (such as clicking on the menu item or pressing ENTER key). It damages code readability. To solve this problem, this CL does the following things: (1) Remove SelectionFlags. Use PseudoFocus to infer children visibility. (2) An enum class called PseudoFocus is introduced to specify the view responding to user actions. This CL should not introduce any visual difference. Bug: 1134422 Change-Id: I57541d081575a5f66606961281b717f1b253f9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483586Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818689}
-
Ian Prest authored
This is a reland of 78b97c89 Also updated the tsan_suppressions.cc file with the updated names of the globals that were moved. Original change's description: > Move Skia SkFontLCDConfig globals to Chromium > > This change eliminates the usage of the deprecated SkFontLCDConfig, > which stores font-related monitor properties in some global variables. > Chromium is the only client of this deprecated API, and the Skia team > has wanted to remove it for some time. > > Unfortunately, the use is fairly widespread within Chromium: > 1. The globals are set directly in a handful of places via calls to > SkFontLCDConfig functions. > 2. The globals are used (indirectly) whenever an SkSurfaceProps is > initialized with the kLegacyFontHost_InitType flag, and also when > an SkCanvas or SkSurface are created without specifying the props. > > The correct long-term plan would be to retrieve the values from the > Display (ideally per-monitor values) and pass them along as needed. > But given the extensive usage, the only reasonable short-term approach > is to lift the globals out of Skia and bring them "in-house" into > Chromium. > > To that end: > -- Undefines SK_LEGACY_SURFACE_PROPS. > -- New globals and APIs in /skia/ext/legacy_display_globals.* > -- Replaced "SkSurfaceProps(kLegacyFontHost_InitType)" with calls to > new API: skia::LegacyDisplayGlobals::GetSkSurfaceProps() > -- Found places where SkCanvas and SkSurface were created and props > weren't already specified; passing the LegacyDisplayGlobals in most > cases, but `nullptr` (or empty SkSurfaceProps) if it was clear > without doing much analysis that no text was being drawn. > > This gets us closer to the end-goal by allowing Skia to fully remove > the deprecated APIs, and also surfacing a lot of places where the use > of the globals was hidden by indirect usage. > > Change-Id: I8fffaee4933c03ee828d2ffab858f53d92c59f4d > Bug: 1126992, skia:3934 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378763 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ben Wagner <bungeman@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Commit-Queue: Ian Prest <iapres@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#818197} TBR=sky@chromium.org Bug: 1126992, 328826, skia:3934 Change-Id: I8911a67cb8a9d4079b993feaff29ff8abd02dd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486073Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818688}
-
Lukasz Anforowicz authored
To consume win32-specific cmdline parameters (e.g. -imsvc, /FI or /Yu) clang needs to be invoked with `--driver-mode=cl`. This CL ensures that the driver-mode cmdline switch is appended not only when running a rewriter tool on Windows, but also when run_tool.py or generate_compdb.py are invoked with an explicit --target_os=win cmdline argument. Manual tests: 1. Manually run unit tests for tools/clang/pylib/clang/compile_db.py: $ pushd tools/clang/pylib/clang/ $ python compile_db_test.py 2. Manually tried running the rewriter on linux, when targeting win: $ cat out/rewrite-win/args.gn clang_use_chrome_plugins = false target_os = "win" $ tools/clang/scripts/run_tool.py --tool rewrite_raw_ptr_fields \ --generate-compdb --target_os=win -p out/rewrite-win \ content/browser/renderer_host/render_process_host_impl.cc \ >~/scratch/rewriter.out 3. Manually tried running generate_compdb.py: $ tools/clang/scripts/generate_compdb.py -p out/rewrite gn_all \ -o ~/scratch/compdb Bug: 1069567 Change-Id: I54fcee164d7bb05119c8267b43e0d872bc2f436b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481745 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#818687}
-
Esmael El-Moslimany authored
The recipe task module is mostly the same as the shopping task module. This CL is mostly a copy of the shopping task module. Removing the duplication will be addressed in a follow-up. Renamed the UI string IDs. No change to the strings. Screenshot: https://screenshot.googleplex.com/7pbxJMPP2QgAgkM Bug: 1138011 Change-Id: Ib709c1dd35a7f05058570ba4c1bf1bc7dddb7d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469401 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ib3e39d1f1ae411a63d1bb8f75c9a714ba5eb60b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486276Reviewed-by:
-
Fabio Rocha authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2462383 I needed to update Win7 tests to account for particularities of that OS, namely the fact that the extension is omitted for launcher filenames since those are also used as the app's display name. --- Reason for revert: The tests added here (WebAppHandlerRegistrationUtilsWinTest.*) are failing on multiple Win 7 bots, see https://bugs.chromium.org/p/chromium/issues/detail?id=1139503 Original change's description: > desktop-pwas: Introduce shared file/protocol handler registration logic > > This CL refactors Windows file handler registration in a way that > exposes shared logic useful for protocol handler registration. Protocol > handler registration that consumes the shared logic will be added in a > subsequent CL. This design is detailed in section 4.4 of [1] with a > summary given below. > > The refactor splits up registration by functional concerns, > with pieces that may be shared with protocol handler registration living > in web_app_handler_registration_utils_win.h/.cc. > web_app_file_handler_registration_win.h/.cc is now significantly smaller > and addresses file-handler-specific concerns in addition to consuming > the utils API. > > File handler registration consists of several pieces: > > 1) Create an app registry entry: HKCU\Software\Classes\<app_progid> > 2) Copy (or hardlink) chrome_pwa_launcher.exe from browser install > directory to <profile_dir>\web_applications\<app_id>\<app_name.exe> > 3) Reregister an app (steps 1 and 2) with a profile-specific name when > the same app is installed to a different profile > (e.g. "App" -> "App (Profile 1)") > 4) Create a file type association registry entry: > HKCU\Software\Classes\.<file_ext> > > In this approach, 1 & 4 are contained in the existing > ShellUtil::AddFileAssociations function. 2 & 3 are moved to utils > (CreateAppLauncherFile and CheckAndUpdateExternalInstallations). > > Important note about this design: > - Reregistration logic (3) is altered in this approach. Currently, > pieces 1, 2, 4 are all executed during reregistration. Because (4) is a > file-handler only concern, it wouldn't make sense to use existing logic > from the protocol registration flow. Reregistering (1) and (2) are > sufficient to rename a duplicate app - this is because file handler > registry entries (4) only reference the progid of an app which doesn't > change if its display name is updated (or if the update fails). > CheckAndUpdateExternalInstallations only updates necessary registration > pieces to reflect an updated name while leaving existing file/protocol > pieces in place. > > Alternative design: > crrev.com/c/2309759 previously attempted this refactor by splitting the > registration process into a shared app-level API instead of a Utils API. > As a result, ShellUtil functions that are currently atomic > (AddFileAssociations) were split into non-atomic app-level and file > handler pieces. The design was abandoned for this reason. > > [1] https://docs.google.com/document/d/1NHlWLjAPZ-dyxcz3AoTWibeerDeHW7Vqrx6FmhB0XmE/edit#heading=h.qsh70q > > Bug: 1019239 > Change-Id: I5f727a5ca1483efd21935c0201ee54474a94e598 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462383 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#818065} Bug: 1019239 Change-Id: I06cfeb90e2e3c7b438210250fc95917e4362e425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482185Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818684}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I8efd248752758c77cc37859bd138adadac09c28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486277Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I0bb2e5cabcb5814b8520277b8916b7a043c688bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486442Reviewed-by:
-
Vladimir Levin authored
During scroll anchoring, before layout, we determine an on-screen anchor and then process the layout and ensure that one of the top corners (left or right depending on writing mode) is positioned in the same spot as before. However, this causes problems if the size of the anchor also changes (with visibility) to be far off screen. Instead, only allow the anchor to move "just off screen", with one of its edges touching the viewport area. This is only applied to content-visibility: auto elements that have a pending layout. The effect is similar: the object is moved off screen, but it prevents unstable behavior with content-visibility: auto. Note that the intent of scroll anchoring is to keep the visible contents from shifting. However, in this case the contents are shifting anyway (since the anchor is off screen), so manipulating exactly how far off-screen should be ok. It is also limited to only content-visibility auto elements. R=chrishtr@chromium.org Bug: 1138801 Change-Id: I1fbc5f8b634563c770db29bf30ef6d409d810614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481348Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#818681}
-
Ken Rockot authored
There is a branch of Node::OnUserMessageReadAckRequest where the local `event_to_send` is never initialized from a null state. It is however unconditionally passed to `ForwardEvent` which assumes a non-null object. Bug: None Change-Id: I3615c02033f58412f2322c7a6df6bad20ab451a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485847Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#818680}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6d3d381e7251..61ab38196942 2020-10-19 ynovikov@chromium.org Expand ProgramBinaryTest.SRGBDecodeWithSamplerAndTexelFetchTest skip 2020-10-19 jmadill@chromium.org Rename "NonLinear" to "SRGB". 2020-10-19 jmadill@chromium.org Rename "texelFetchInvoked" to "texelFetchStaticUse". 2020-10-19 j.vigil@samsung.com EGL: Implement EGL_KHR_reusable_sync 2020-10-19 jmadill@ad.corp.google.com Add isSRGB flag to angle::Format. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: angle_deqp_egl_tests Change-Id: I46f416f37e3640aa6878c3fabe8a73da26a2617c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486273Reviewed-by:
-
Peter Kasting authored
This also reworks how the class is tested so only the public API is tested, and the actual construction/teardown are more like production. Bug: 772945 Change-Id: I8cd6970d314359296398104484afc7551441808f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469666 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#818678}
-
Peter Boström authored
Replaces CalculatePreferredSize() overrides. Change also replaces a few DialogDelegate overrides with corresponding setters. Bug: 1128500 Change-Id: If6a1048d0c3b560fa8bbfffed146ea982a75c502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485619Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#818677}
-
Kelvin Jiang authored
Split GetStaticRuleLimit to GetStaticRuleLimit and GetMaximumRulesPerRuleset for code without/with global rules. Bug: 1132178 Change-Id: Id073bb5ffc0a5ed4373431b63a130571a6d1234d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478222 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#818676}
-
Yue Li authored
Bug: b/171175172 Test: Run existing tests Change-Id: Id4985b806f939ea90a62f9f5b7e337bd3d7151f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484332Reviewed-by:
-
Lei Zhang authored
Update callers and remove deprecated base::Value API usage along the way. Bug: 1012811 Change-Id: Ic2094c106538cf547cb69bfecdab976e6a095674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478683Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#818674}
-
Xianzhu Wang authored
With unified PaintController, to support SetNeedsDisplay() we would need to add PaintController mechanism to invalidate all display items in a range for a GraphicsLayer. Removing SetNeedsDisplay() can avoid that. We instead use the normal paint invalidation code path. For needed invalidation, now invalidate the display items of and in the GraphicsLayer. Some invalidations are not needed because we have already invalidated the DisplayItemClients. Also rename SetContentsNeedsDisplay() to InvalidateContents(), and SetNeedsDisplayInrect() to InvaldiateRaster() which is only called by RasterInvalidator. Bug: 1132717 Change-Id: I535cdcc7ee1d07e23a490fdf2aa267573a54d0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478026 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#818673}
-
Mark Schillaci authored
This CL is the second part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. We have also hidden the entire feature behind a feature flag, so this CL is not visible to an average user. ---------- This CL adds the following: - Settings sub page for image descriptions - Preference options for image descriptions - Associated strings etc for above ---------- AX-Relnotes: Adds feature to enable generating alt image descriptions Bug: 1057169 Change-Id: Ie968e8e831b20df7bfbfe27f0ffad1282fd835c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268299 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
mlcui authored
We should now have translations for these two languages. The pak files were already being built and shipped with Chrome OS, but couldn't be used as they were explicitly disabled. Test: CL author switched device language and saw translated strings Bug: 1093583 Change-Id: I401baabe4af8f04d9918332a7f26badf720038ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459135Reviewed-by:
-
Robert Ogden authored
Also transitions the origin prober over to using the new probe result enum so that it can be passed to the metrics collector. ScopedRefPtr: The metrics collector uses a scoped ref ptr to manage its lifetime. For mainframe prefetching, the TabHelper has the only refptr to the collector. But during NSP, the refptr is shared to every subresource manager that is created. If the next navigation does not go to a prefetched page, all subresource managers are destroyed, as well as the TabHelper's CurrentPageLoad class which destroys the metrics collector. Since there would not be any cache reuse to record in the metrics, it can be safely destroyed then. If the next navigation goes to a prefetched page, then all refptrs to the metrics collector will be destroyed, except for the one in the subresource manager associated with that page. This allows the subresource manager to record cache reuse directly, without relying on the TabHelper to make some lifetime guarantee about the metrics collector. Furthermore, this pattern keeps the cache reuse logic out of the TabHelper when it is already isolated to the subresource manager. Bug: 1136174 Change-Id: I4e0e52acb8f99a1490f67d98b44329f997e40720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463544 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#818670}
-
Curt Clemens authored
- Add radiogroup role to share target list. - Label share target list with page subtitle so that it's clear what the list is for. - Make share target list an aria-live region so that new share targets are announced as they arrive. - Add aria-modal="true" to page template. Bug: b/163036847 Change-Id: I4ff89d4ad635c7299198d95249f6b5accbe3e6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485875 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#818669}
-
Roberto Moura authored
This change fixes a bug where closing the last incognito tab would create a transition from the incognito grid to the regular browser, which existed before but gained more visibility after crbug.com/1134718 was fixed. Add an active tab grid page argument to the method of the protocol GridTransitionAnimationLayoutProviding that provides the transition layout. Add active tab grid page as argument to both TabGridTransitionHandler methods. Bug: 1136882 Change-Id: Ide742143bdefcd5aac4a7d02ea9225d385fe7fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471496 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#818668}
-
Robert Sesek authored
- Protobuf is similarly trusted for deserializing messages at high privilege (though it should be avoided if possible). - Many Android system APIs are Java facades around C++ and are not considered memory safe. Change-Id: Ia70520fc8b319a639b03cb78f1a664b478902528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486113 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#818667}
-
Maks Orlovich authored
We would like to see how much entropy is leaked via it. The approach taken here is to instrument at CSS layer, which means things that would be defined in CSS and checked via getComputedStyle or the like get caught, and not just things explicitly Window.matchMedia; but has the downside of counting purely declarative use that's not actually actively observed by the page. Bug: 973801 Change-Id: If762d74c1b6b17ca96533b9040cd31e44fdb06cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449913 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#818666}
-
Rafael Cintron authored
gfx::GpuFenceHandle and gl::GLFence previously only supported POSIX operating systems. This change adds support for Windows for both classes. Bug: 1131616 Change-Id: Iea3bf9ae52c6c7d22527cdb2f48711dd6981dee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466515Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818665}
-
Donn Denman authored
Speculate fix for testLivePrefetchFailoverRequestMadeAfterOpen which was failing with out-of-process network service error. BUG=1071721 Change-Id: I95cc3bba5ffd17e38b58fc88a3ff227045fe9feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486072 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#818664}
-
Prakhar authored
It is the tester for windows coverage cq builder https://source.chromium.org/chromium/chromium/tools/build/+/master:recipes/recipe_modules/chromium_tests/trybots.py;l=1368 Also removes the same from GPU tester bot as we are not interested in coverage data in GPU tests Bug: 1139007 Change-Id: Ie9b9bb2238d868e5d8c19c85ed1564425b79ecc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477693 Commit-Queue: Prakhar Asthana <pasthana@google.com> Auto-Submit: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#818663}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I89f1904efad1073763f0e213f1cf1747a3038b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485680Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#818662}
-
Lan Wei authored
This reverts commit 4e484a8f. Reason for revert: AutofillInteractiveTest.PrefillFormAndFill fails on Mac10.11 Tests, https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests. Original change's description: > Give test hooks to allow autofill test to keep popup open > > On some test bots, mac dock or external values cause the browser to > make minor resizings of the frame. These are extraneous to our tests > so we would like to ignore those during tests. > > This CL provides a test hook by adding test access methods to > ChromeAutofillClient to make the autofill popup more > resistant to hiding from frame resizes, and then has AutofillUiTest > access that hook when running Interactive UI tests. > > This re-enables autofill interactive tests on mac bots. > > > Bug: 967588 > Change-Id: Id9e25988f0cf64f0aa0631a48d48eb982b116c34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473802 > Commit-Queue: Ian Struiksma <ianstruiksma@google.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818550} TBR=battre@chromium.org,vasilii@chromium.org,ianstruiksma@google.com Change-Id: I82610a8d1f4a1161a13f0ce62771fac6a12b091f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485539Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#818661}
-
Lan Wei authored
virtual/threaded/external/wpt/web-animations/timing-model/animations/ updating-the-finished-state.html is flaky on Mac10.15, https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests, disable it for now until it is fixed. TBR=xidachen@chromium.org NOTRY=True Bug: 1140228 Change-Id: Id7b53abfee1bae911c5076738dce41ca61330f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486256Reviewed-by:
-
Xianzhu Wang authored
The global display item indices (in the whole DisplayItemList) are more meaningful than the previous local indices (in DisplayItemRanges, which are in PaintChunks in the output of ShowDebugData) because we use the former in PaintController logic. Change-Id: I40c6d12bbf99d0f9fbfbbfa19050e75bd6cf2a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483584 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Ionel Popescu authored
This CL adds a check to ensure that a new eye dropper is not opened while an eye dropper is already opened. Bug: 1137328 Change-Id: I14a134a5cb6ec8d3923956d6f3a1bbf8b5604c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481072Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818658}
-
Elly Fong-Jones authored
This change: 1) Introduces ScopedPageAllocation, to avoid tests needing to remember to free everything they allocate manually; 2) Merges the two bodies of this test into one; 3) Fixes this test on Mac-Arm64 via (2) Bug: 1128436 Change-Id: I158fe54ffb6286168fb2995508bfc06db53aa0ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482342Reviewed-by:
-
