GitLab

This test should now be working after the fixes to the screenshotting code
that initialy had made it fail.

Also adding an OWNERS file for the Feedback API directory.

R=kalman@chromium.org
BUG=369886

Review URL: https://codereview.chromium.org/516083002

Cr-Commit-Position: refs/heads/master@{#292547}

Instead of explicitly depending on specific browser threads the USB
service can assume that it is instantiated on BrowserThread::FILE (or
equivalent) and save a TaskRunner reference from this instantiation for
later use when called from other threads.

To reach BrowserThread::UI (required for DBus on Chrome OS) a reference
to the appropriate TaskRunner must be provided when calling
UsbService::GetInstance().

BUG=

Review URL: https://codereview.chromium.org/507503002

Cr-Commit-Position: refs/heads/master@{#292546}

The current warning is the generic "Read your browsing history"
warning. The new warning for topSites will be suppressed by
read only and read/write history warnings, and all hosts warning.

BUG=404334

Review URL: https://codereview.chromium.org/482953003

Cr-Commit-Position: refs/heads/master@{#292545}

In preparation for changing how we compute media time, add some tests to
verify the current behaviour.

BUG=370634

Review URL: https://codereview.chromium.org/517843003

Cr-Commit-Position: refs/heads/master@{#292544}

This is in preparation for implementing the Trepn profiler.

BUG=

Review URL: https://codereview.chromium.org/510943002

Cr-Commit-Position: refs/heads/master@{#292543}

Now we pass Demuxer and Renderer directly into Pipeline, and create TextRenderer
directly in Pipeline. As a result, we don't need FilterCollection anymore.

BUG=408602
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/511323003

Cr-Commit-Position: refs/heads/master@{#292542}

These CLs implement a simple frame recording and fetch "extension" for the Chromoting protocol, to allow sample sessions to be captured for performance testing.

The three main classes introduced are:
- HostExtensionSessionManager
  This pulls logic for handling Chromoting extensions out of
  ClientSession instances into a dedicated manager class.
  It also introduces hooks through which extensions can
  wrap or replace the Chromoting video encoder or capturer.
- VideoFrameRecorder
  This allows a VideoEncoder to be wrapped to return a new
  encoder that will optionally copy & deliver frames to the
  VideoFrameRecorder before supplying them to the real
  encoder.
- VideoFrameRecorderHostExtension
  This extension uses a VideoFrameRecorder to allow a
  connected client to start/stop recording, and to retrieve
  the resulting frame data.

Original CLs:
crrev.com/402233003
crrev.com/339073002
crrev.com/372943002
crrev.com/462503002

BUG=260879

Review URL: https://codereview.chromium.org/468613002

Cr-Commit-Position: refs/heads/master@{#292541}

Background color issue should already be fixed by
crbug.com/391462

BUG=384559

Review URL: https://codereview.chromium.org/517153002

Cr-Commit-Position: refs/heads/master@{#292540}

An analysis was performed for sources of flakiness in this test.  A
number of implementation problems have been resolved in recent changes,
with this change focusing on addressing problems with the test code
itself:

1. Do not require the color to match the tone at the same time.  A/V
   sync belongs in a perf test.
2. Do not require a color or tone to be held for a full half-second.
   Instead, any momentary observation that matches expectations is
   sufficient.
3. Only examine the content part of each video frame (i.e., exclude the
   surrounding black borders caused by letterboxing).
4. Generate the source content using a canvas and
   requestAnimationFrame().  The source content has a little "ball"
   animating within it to ensure changing video frames are being sent
   through end-to-end.

Also added AES keys to test end-to-end with encryption enabled.

This change re-enables the test for Release builds only.  Once the test
has proven to be stable again, it will be re-enabled for Debug builds as
well.  Baby steps...

BUG=396413

Review URL: https://codereview.chromium.org/515473004

Cr-Commit-Position: refs/heads/master@{#292539}

Don't show "Access Address Book" prompt if Autofill is disabled, the form has
the attribute autocomplete="off", or if Chrome doesn't think the form is
Autofillable.

BUG=398476

Review URL: https://codereview.chromium.org/512933004

Cr-Commit-Position: refs/heads/master@{#292538}

Adjust underline positions so the lines won't get clipped. I
think that the inaccuracy may be occurring due to our
conversion from PangoFontDescriptions (usually containing a
point-based size) to a rounded pixel-based size and then
back to a PangoFontDescription. Luckily, RenderTextPango
will be replaced by RenderTextHarfBuzz soon.

Also delete some dead code in PlatformFontPango for
computing underline metrics.

BUG=393117
TEST=manual: checked that the "Import bookmarks now..."
     underline is visible after setting my UI font to
     "Ubuntu 11"

Review URL: https://codereview.chromium.org/509093004

Cr-Commit-Position: refs/heads/master@{#292537}

BUG=408251
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/519523002

Cr-Commit-Position: refs/heads/master@{#292536}

In [[Install]] algo. of the latest spec, register() resolves a promise
with a registration object after the worker enters the installation
process. This means the registration needs to set its .installing field
before the register promise is resolved.

But, before this patch, the registration cannot do so before resolving
the register promise because its proxy is set when the registration is
passed to the blink.

This change makes the registration queue notifications of worker version
and 'updatefound'. Once the proxy becomes ready, the registration handles
them.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#installation-algorithm

BUG=399533,406240
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py http/tests/serviceworker

Review URL: https://codereview.chromium.org/516873002

Cr-Commit-Position: refs/heads/master@{#292535}

Any thoughts?

BUG=

Review URL: https://codereview.chromium.org/510203002

Cr-Commit-Position: refs/heads/master@{#292534}

BUG=110610

Review URL: https://codereview.chromium.org/511183002

Cr-Commit-Position: refs/heads/master@{#292533}

Revert of Fix the Copresence permission. (patchset #1 of https://codereview.chromium.org/523433002/)

Reason for revert:
This change causes a test failure:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/48008/steps/unit_tests/logs/stdio

Error:

[ RUN      ] PermissionsTest.PermissionMessages
../../chrome/common/extensions/permissions/permission_set_unittest.cc:781: Failure
Value of: permission_info->message_id()
Actual: 65
Expected: PermissionMessage::kNone
Which is: 1
unexpected message_id for copresence

Looks like this change is the cause.

Original issue's description:
> Fix the Copresence permission.
>
> The initializer for the Copresence permission is malformed. It specifies the
> message id instead of the flag.
>
> R=kalman@chromium.org
> BUG=408843
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/c2a41e8

TBR=kalman@chromium.org,rkc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408843

Review URL: https://codereview.chromium.org/520493002

Cr-Commit-Position: refs/heads/master@{#292532}

This value was added to the code in commit position 292033.

R=isherman@chromium.org
CC=robertshield@chromium.org
BUG=394352
NOTRY=true

Review URL: https://codereview.chromium.org/515313004

Cr-Commit-Position: refs/heads/master@{#292531}

This CL fixes two issues.
. It brings up a scroll bar if the text in the feedback window doesn't fit in
  the space available on screen (this happens when the user sets the page zoom
  too 120% or above)
. Sets the focus to the description field when the feedback app starts.

R=xiyuan@chromium.org
BUG=295999,330139

Review URL: https://codereview.chromium.org/511393002

Cr-Commit-Position: refs/heads/master@{#292530}

If we're running a test image or have the --disable-demo-mode flag specified
we should not be launching demo mode. The channel check doesn't exist for the
HID screen. This CL moves the check into the main demo mode detector so if it
is called from anywhere, the check is always performed.

R=xiyuan@chromium.org
BUG=398271

Review URL: https://codereview.chromium.org/514273003

Cr-Commit-Position: refs/heads/master@{#292529}

Test is flaky. See bug for details.

NOTRY=true
TBR=nkostylev@chromium.org
BUG=408867

Review URL: https://codereview.chromium.org/522453004

Cr-Commit-Position: refs/heads/master@{#292528}

Nest a QUIC SerializedPacket inside a QUIC QueuedPacket.

Merge internal change: 74239145
https://codereview.chromium.org/509203003/

Remove PacketType from QUIC because the QUEUED type is not used and the
other types can be reduced to a bool.

Merge internal change: 74148481
https://codereview.chromium.org/515003003/

Don't send a QUIC SCUP message until after handshake confirmed.

A server config update was occasionally being sent before the crypto
handshake was complete, causing the client to close the connection.

Merge internal change: 74132773
https://codereview.chromium.org/516713002/

Change TransmissionInfo's all_transmissions SequenceNumberSet* to
default to NULL, and only be present if there are multiple transmissions.

Estimated to save ~2% of CPU.

Merge internal change: 74076012
https://codereview.chromium.org/509073004/

Log the quic version for internal server tracing.
Not used in production.

Merge internal change: 74069715
https://codereview.chromium.org/514043002/

Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a
deque.

Estimated to save ~3% of CPU based on pprof profiling of 100 large gets
on tools/quic/end_to_end_test.cc.

Merge internal change: 74054196
https://codereview.chromium.org/514033002/

Unit test for empty packet closes QUIC connection bug.

Merge internal change: 74041239
https://codereview.chromium.org/495423011/

Log the QUIC transmission type in QUIC internal server trace visitor.
Not used in production.

Merge internal change: 73895739
https://codereview.chromium.org/514023002/

Not used in production. Log whether a QUIC packet sent was a crypto
packet or not for internal server side tracing.

Merge internal change: 73894063
https://codereview.chromium.org/515003002/

Fix a QUIC bug in which PING frames were not being ACK'd.

Merge internal change: 73837644
https://codereview.chromium.org/512933005/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/515303003

Cr-Commit-Position: refs/heads/master@{#292527}

https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..088f4b8eb31b2af26e66dcbaae062f40b3955059

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/516973003

Cr-Commit-Position: refs/heads/master@{#292526}

BUG=407994
TEST=as in bug

Review URL: https://codereview.chromium.org/518443003

Cr-Commit-Position: refs/heads/master@{#292525}

unittest produces a suite._ErrorHolder object in these cases. We can parse its description to figure out what class/module it is and what tests we have in that class/module.

BUG=405766
TEST=Make a TestCase fail setUpClass, run it with --retry-limit=3 and check for retries.
R=dpranke, tonyg

Review URL: https://codereview.chromium.org/515263003

Cr-Commit-Position: refs/heads/master@{#292524}

BUG=366603

Review URL: https://codereview.chromium.org/469523003

Cr-Commit-Position: refs/heads/master@{#292523}

Revert of Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update. (patchset #5 of https://codereview.chromium.org/471233003/)

Reason for revert:
Test is failing on a Blink bot on ChromeOS

Original issue's description:
> Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update.
>
> Add more checks to test to detect that the resource type of
> the URL request is indeed OBJECT.
> Would like to get this merged to the M38 branch.
>
> BUG=401755
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bfc3e122d6721ccc93f0f8b19dac4a3c2a0c947d

TBR=teravest@chromium.org,ncbray@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401755

Review URL: https://codereview.chromium.org/524483002

Cr-Commit-Position: refs/heads/master@{#292522}

Also switch harfbuzz to internal by default to minimize deps.

BUG=178543
TEST=run the tool
TBR=bashi1

Review URL: https://codereview.chromium.org/509323004

Cr-Commit-Position: refs/heads/master@{#292521}

The operations would get routed to the viewer process under the assumption that it was Windows 8
which would eventually crash while trying to open the metro dialogs which don't work on Windows 7.

Fix is to return false from the ShellDialogsDelegateWin::IsWindowInMetro function for anything below
Windows 8.

BUG=356475

Review URL: https://codereview.chromium.org/510223002

Cr-Commit-Position: refs/heads/master@{#292520}

NOTRY=true

Review URL: https://codereview.chromium.org/522483002

Cr-Commit-Position: refs/heads/master@{#292519}

This CL add a ChannelProxy equivalent of the Channel benchmark
to ipc_perftests.

To use it in the benchmark, TestIOThread is extracted from
mojo/system/ to base/test

TEST=IPChannelPerfTest.ChannelProxyPingPong
R=viettrungluu@chromium.org,brettw@chromium.org,darin@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/488003003

Cr-Commit-Position: refs/heads/master@{#292518}

BUG=308692

Review URL: https://codereview.chromium.org/513803005

Cr-Commit-Position: refs/heads/master@{#292517}

BUG=355227
TEST=visual

Review URL: https://codereview.chromium.org/515973003

Cr-Commit-Position: refs/heads/master@{#292516}

This initial version still returns ENOSYS.

Review URL: https://codereview.chromium.org/512603008

Cr-Commit-Position: refs/heads/master@{#292515}

BUG=110610

Review URL: https://codereview.chromium.org/511173002

Cr-Commit-Position: refs/heads/master@{#292514}

While debugging flaky browser_tests, it was revealed that a
WebContentsVideoCaptureMachine could actually outlive the tear-down of
the BrowserThreadImpl for the UI thread.  Not having been explicitly
stopped first, destructors in the object graph would execute clean up
code that would attempt operations that are invalid after the
BrowserThreadImpl for the UI thread has been torn down.

This change also includes a bunch of minor clean-ups.

BUG=396413

Review URL: https://codereview.chromium.org/514073002

Cr-Commit-Position: refs/heads/master@{#292513}

https://chromium.googlesource.com/chromium/blink/+log/5d3187faa8b0dc282ac6f16311c8ba96bfb91bd8..78d2b11092668ed42fc97d9a81290a3e226bed43
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/518573002

Cr-Commit-Position: refs/heads/master@{#292512}

Currently, if |compositor_needs_continuous_invalidate_| is unset before
PostFallbackTick or FallbackTickFired, then the fallback ticks are
cancelled, but we never unset |block_invalidates_|, which will block
invalidates indefinitely.

Fix is simply always unset |block_invalidates_| even if we skip
the fallback tick.

BUG=408779

Review URL: https://codereview.chromium.org/512403002

Cr-Commit-Position: refs/heads/master@{#292511}

BUG=None
TEST=athena_unittests run again

Review URL: https://codereview.chromium.org/517053002

Cr-Commit-Position: refs/heads/master@{#292510}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506773002

Cr-Commit-Position: refs/heads/master@{#292509}

BUG=402934

Review URL: https://codereview.chromium.org/515803002

Cr-Commit-Position: refs/heads/master@{#292508}