GitLab

During the wiki->docs/*.md conversion, someone added a bunch of TODO
comments and then never acted on them.  Since having TODOs in documentation
is pretty gross and since the TODOs don't make much sense, remove them.

BUG=none
R=hans@chromium.org

Review URL: https://codereview.chromium.org/1636073003 .

Cr-Commit-Position: refs/heads/master@{#371532}

BUG=none
R=japhet

Review URL: https://codereview.chromium.org/1627273002

Cr-Commit-Position: refs/heads/master@{#371531}

Provide an optional WebMediaSession to embedder when creating a
WebMediaPlayer. A null WebMediaSession means the player should belong
to the default media session.

BUG=497735

Review URL: https://codereview.chromium.org/1585163002

Cr-Commit-Position: refs/heads/master@{#371530}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f7563a0c32bf..4028a4f07d37

$ git log f7563a0c3..4028a4f07 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1633163002

Cr-Commit-Position: refs/heads/master@{#371529}

We conventionally use CamelCase attribute names.

BUG=581169
R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/1637903002

Cr-Commit-Position: refs/heads/master@{#371528}

TBR=sky,dbeam,kelvinp
BUG=503905, 579666

Review URL: https://codereview.chromium.org/1634163002

Cr-Commit-Position: refs/heads/master@{#371527}

https://chromium.googlesource.com/skia.git/+log/e9573317d35d..05332d9c8aef

$ git log e9573317d..05332d9c8 --date=short --no-merges --format='%ad %ae %s'
2016-01-26 lsalzman check for both __ARM_NEON__ and __ARM_NEON

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1630783004

Cr-Commit-Position: refs/heads/master@{#371526}

The regex experessions checks of IP, URL, Email, SSID in
SystemLogUploader are substituted with feedback::AnonymizerTool, that treats the same and more (+BSSID).
Removed UMA stats from SystemLogUploader.

BUG=579040

Review URL: https://codereview.chromium.org/1610123003

Cr-Commit-Position: refs/heads/master@{#371525}

I was going to rename set_default_check_params() to
set_default_check_params_for_testing(), but then realized we don't
need this at all.
Then asargent@ pointed out that we don't even need the member
default_params_ in ExtensionUpdater.

One use of this was to specify check_blacklist (http://crrev.com/11339047),
however, later this was removed (http://crrev.com/23591050), but the
code stayed around.

Cleaning this up to remove confusion.

BUG=None
Test=unit_tests and browser_tests compiles under ChromeOS.

Review URL: https://codereview.chromium.org/1630903003

Cr-Commit-Position: refs/heads/master@{#371524}

Build error:
input_handler_proxy.cc:610:1: error: control reaches end of non-void
function [-Werror=return-type]

BUG=

Review URL: https://codereview.chromium.org/1631563002

Cr-Commit-Position: refs/heads/master@{#371523}

This properly identify redirect chains. Before this CL, each link in the
redirect chain would seem to be initiated by the eventual request,
instead of the previous redirect.

Also logs the number of cases where the redirected request doesn't have
the same initiator as the initial request.

Review URL: https://codereview.chromium.org/1633813005

Cr-Commit-Position: refs/heads/master@{#371522}

In abstract preventing task blockimg if not expecting frames sounds like
a good idea.  In practice it caused a large perf regression since we
probably should be blocking tasks that take longer than 50ms even if we're
not expecting frames because touch starts can and will get delayed.

Removing this condition is safe because:
a. We are now using task blocking in more limited cases
b. For the usual compositor scrolling case we increased the blocking
threshold to 50ms

BUG=574343

Review URL: https://codereview.chromium.org/1636513003

Cr-Commit-Position: refs/heads/master@{#371521}

Also turn on chromium_code for these targets in gyp.  This makes warnings
for these targets consistent between gyp and gn.

BUG=550983, 581133, 82385
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/1637793003

Cr-Commit-Position: refs/heads/master@{#371520}

When a AutofillHostMsg_QueryFormFieldAutofill message is sent from
an out-of-process iframe, its screen coordinates are relative to the
subframe's rect and not the top-level frame's viewport.

This CL exposes a facility in the content API to perform the necessary
transformation, particularly:
- it promotes GetView() from RenderFrameHostImpl to RenderFrameHost, so the RenderWidgetHostView becomes available to the embedder, and
- it promotes TransformPointToRootCoordSpace from RenderWidgetHostViewBase to RenderWidgetHostView, so that chrome/ or components/ code that directly receives coordinates from a renderer process can ensure they properly transformed

Finally, it causes the ContentAutofillDriver to use the exposed methods to transform received autofill popup coordinates in order for them to display in the correct position.

BUG=554119
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1526263003

Cr-Commit-Position: refs/heads/master@{#371519}

As brought up in https://codereview.chromium.org/1622073002/

BUG=None

Review URL: https://codereview.chromium.org/1624373004

Cr-Commit-Position: refs/heads/master@{#371518}

This patch fixes a problem with throttled FrameViews sometimes appearing partially painted.
This was because we generally paint some distance beyond the viewport, i.e., covering the
entire interest rect. FrameViews which are inside the interest rect but outside the viewport
are skipped during painting, so the recorded display list won't include their contents. If
the FrameView is then scrolled on-screen without causing any other paint invalidations, the
display list won't get updated and the FrameView contents will not be shown.

This patch fixes the problem by forcing a repaint of FrameViews when they become
unthrottled, discarding any previous display lists and tile textures for the area they
cover.

BUG=562343

Review URL: https://codereview.chromium.org/1603983002

Cr-Commit-Position: refs/heads/master@{#371517}

These tests were causing compile warnings on platforms other than Linux.
Now that I'm trying to get the battor_agent tests on the waterfall, this
is problematic.

TBR=zhenw@chromium.org

Review URL: https://codereview.chromium.org/1634933005

Cr-Commit-Position: refs/heads/master@{#371516}

Follow up on cl/1611283002.
minidump_generator may be buit on by the breakpad_client target, which
needs to allow the deprecated call.

Will be removed after reland of https://codereview.chromium.org/1563223004/

BUG=579522, 569158

Review URL: https://codereview.chromium.org/1638723003

Cr-Commit-Position: refs/heads/master@{#371515}

See: https://notifications.spec.whatwg.org/#api

Review URL: https://codereview.chromium.org/1633123002

Cr-Commit-Position: refs/heads/master@{#371514}

The bubble may be closed by some navigation in the content area. However, if the user pressed a button before closing and released after then the button action is still sent. Moreover, all the objects like NSWindow, NSWindowController, NSViewController are still alive. The UI code should not ping ManagePasswordsBubbleModel which is actually destroyed.

BUG=579726

Review URL: https://codereview.chromium.org/1637043002

Cr-Commit-Position: refs/heads/master@{#371513}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/99af10a4..2801e08d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1631243002

Cr-Commit-Position: refs/heads/master@{#371512}

Overview of changes:
- Added InkDropHover class that manages animating a Layer to show
  visual feedback for mouse hover.
- Wired the InkDropHover class in to the InkDropAnimationControllerImpl.
- Wired some Views up to use the hover animation.

Overview of Hover behavior:
- Hover will fade in when mouse enters an enabled View
- Hover will fade out instantly if an ink drop animation is initiated.
- Hover will fade back in, after a delay, when an ink drop animation
  completes and the mouse is still hovering the View.

TEST=InkDropHoverTest.InitialStateAfterConstruction
TEST=InkDropHoverTest.IsHoveredStateTransitions
TEST=InkDropAnimationControllerFactoryTest.HoveredStateAfterAnimateToState
TEST=HoveredStateAfterHoverTimerFiresWhenHostIsHovered.SetHoveredIsHovered
TEST=HoveredStateAfterHoverTimerFiresWhenHostIsHovered.HoveredStateAfterHoverTimerFiresWhenHostIsHovered
TEST=HoveredStateAfterHoverTimerFiresWhenHostIsHovered.HoveredStateAfterHoverTimerFiresWhenHostIsNotHovered

BUG=537238, 518919

Review URL: https://codereview.chromium.org/1390113006

Cr-Commit-Position: refs/heads/master@{#371511}

This is implementing the IPC logic but also adds the base classes that
are required to use MediaMetadata in content/.

This CL is written on top of:
https://codereview.chromium.org/1441883003

BUG=497735

Review URL: https://codereview.chromium.org/1515623002

Cr-Commit-Position: refs/heads/master@{#371510}

After https://codereview.chromium.org/1593313011 the mappings between routes and MRPs are being cleaned up.
Which means that if casting is stopped from the browser UI while the page tried to send a message over, Chrome will crash.

BUG=None
TEST=Manual

Review URL: https://codereview.chromium.org/1632133006

Cr-Commit-Position: refs/heads/master@{#371509}

Currently we select best matches as credentials with highest store, independently of usernames. And so if there are credentials for different usernames stored on different forms (for example on Sign-In and Sign-Up forms) we propose to autofill only one credentials, since they have different score. This patch changed our selection algorithm by choosing the best credentials by each username separately.

Since these changes in logic, we might have mixed PSL-non PSL matches in |best_matches_| so both PSL and non PSL matches might be shown in a suggestion dropdown, but it was implemented not to show PSL matched credentials in manage bubble.

BUG=579485

Review URL: https://codereview.chromium.org/1620083003

Cr-Commit-Position: refs/heads/master@{#371508}

The associated bug got closed, the crash is no longer observed since version
43, so the checks are overdue to be removed.

BUG=486931,510952
R=vasilii@chromium.org

Review URL: https://codereview.chromium.org/1636813003

Cr-Commit-Position: refs/heads/master@{#371507}

This patch makes it possible to pass in command line arguments to the
run commmand, e.g.:

  $ cr run chrome https://www.youtube.com

The trade-off is that it is no longer possible to run multiple targets
using a single command.

Review URL: https://codereview.chromium.org/1638793002

Cr-Commit-Position: refs/heads/master@{#371506}

In case of an AuthException, start the recovery intent if it exists. This is a temporary fix to unblock devs while we work towards the real solution.

BUG=547048

Review URL: https://codereview.chromium.org/1630673002

Cr-Commit-Position: refs/heads/master@{#371505}

Adds a lens leveraging a rules file to tag whether a given request is
related to Ads and/or tracking/analytics. This CL also displays this in
the PNG output of the dependency graph.

Review URL: https://codereview.chromium.org/1626393002

Cr-Commit-Position: refs/heads/master@{#371504}

Adds a new experimental flag for Reading List on iOS. The flag is
toggled with Settings.bundle downstream.

BUG=581014

Review URL: https://codereview.chromium.org/1631813002

Cr-Commit-Position: refs/heads/master@{#371503}

Revert of Fix leaks in exensions_unittests after enabling Oilpan (patchset #1 id:1 of https://codereview.chromium.org/1632763003/ )

Reason for revert:
This CL didn't fix the leak. Also per the discussion in https://codereview.chromium.org/1632763003/, suppressing the leak looks like a reasonable solution at the moment. So revert this CL.

Original issue's description:
> Fix leaks in exensions_unittests after enabling Oilpan
>
> This CL adds an Oilpan's GC before tearing down the extensions_unittests.
>
> BUG=581092
>
> Committed: https://crrev.com/6ae6611de742bb291305a1df558e710213556fa4
> Cr-Commit-Position: refs/heads/master@{#371408}

TBR=rockot@chromium.org,oilpan-reviews@chromium.org,oshima@chromium.org,sigbjornf@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581092

Review URL: https://codereview.chromium.org/1637013002

Cr-Commit-Position: refs/heads/master@{#371502}

The flakiness was caused by waiting for a wrong number of JavaScript
test results, which resulted in inconsistency between events that were
expected to happen and the events that have actually happened. In a
detailed manner, the reportCertificates callback in file basic.js is
wrapped through chrome.test.callbackPass method, which itself calls
chrome.test.succeed method; meanwhile the C++ code in
certificate_provider_apitest.cc didn't expect this chrome.test.succeed
call, and it behaved as if the
chrome.certificateProvider.onSignDigestRequested event handler was
already executed - which is not always true and causes flakiness.

BUG=576364

Review URL: https://codereview.chromium.org/1632053002

Cr-Commit-Position: refs/heads/master@{#371501}

This CL replaces CSSParserToken::valueEqualsIgnoringCase and
CSSParserString::equalIgnoringCase with valueEqualsIgnoringASCIICase
and equalIgnoringASCIICase respectively - calling the similarly named
function in WTF.
Some cases where CSSParserToken::value() was coerced to a String is
changed to avoid the coercion - using the CSSParserToken method
directly.
Similarly some cases that use the CSSParserString overload for
equalIgnoringCase is changed to use the method on CSSParserToken.
The dead equalIgnoringCase(const CSSParserString&, ...) function in
LegacyCSSPropertyParser.cpp is removed.

BUG=581001

Review URL: https://codereview.chromium.org/1636453002

Cr-Commit-Position: refs/heads/master@{#371500}

BUG=525873

Review URL: https://codereview.chromium.org/1633063003

Cr-Commit-Position: refs/heads/master@{#371499}

BUG=581283
TBR=henrika@chromium.org

Review URL: https://codereview.chromium.org/1637853002

Cr-Commit-Position: refs/heads/master@{#371498}

+ Fix obstacle rendering issue
+ Fix resize clipping bug

BUG=524907,504251

Review URL: https://codereview.chromium.org/1486653003

Cr-Commit-Position: refs/heads/master@{#371497}

iostream contains a static initializer and generally should be frowned upon.
It also makes presubmit fire when touching this file.  (But after removing
this, they complain about streams, so it doesn't really solve that problem.)

BUG=none

Review URL: https://codereview.chromium.org/1626413002

Cr-Commit-Position: refs/heads/master@{#371496}

Reland of [tracing] Dump child processes' memory metrics in browser (patchset #1 id:1 of https://codereview.chromium.org/1617263002/ )

Reason for revert:
The crash was fixed in crrev.com/1620783002

Original issue's description:
> Revert of [tracing] Dump child processes' memory metrics in browser (patchset #1 id:1 of https://codereview.chromium.org/1591553002/ )
>
> Reason for revert:
> TracingBrowserTest.TestMemoryInfra is failing on DrMemory bot with the following
> error:
>
> UNADDRESSABLE ACCESS: reading 0x00000048-0x0000004c 4 byte(s)
> # 0 base.dll!base::Thread::task_runner
> [base\threading\thread.h:168]
> # 1 base.dll!base::trace_event::MemoryDumpManager::CreateProcessDump
> [base\trace_event\memory_dump_manager.cc:313]
> # 2 content.dll!content::TracingControllerImpl::RequestGlobalMemoryDump
> [content\browser\tracing\tracing_controller_impl.cc:1039]
> # 3 content.dll!base::internal::Invoker<>::Run
> [base\bind_internal.h:350]
>
> bug: crbug.com/580295
>
> Original issue's description:
> > Reland of [tracing] Dump child processes' memory metrics in browser (patchset #1 id:1 of https://codereview.chromium.org/1586893003/ )
> >
> > The failure was due to flakiness fixed by crrev.com/1606983002.
> > See crbug.com/578128.
> >
> > Original issue's description:
> > > Revert of [tracing] Dump child processes' memory metrics in browser (patchset #15 id:400001 of https://codereview.chromium.org/1417003003/ )
> > >
> > > Reason for revert:
> > > This is suspected by Findit to cause failure in TracingBrowserTest.TestMemoryInfra under Mac ASan 64 Tests (1).
> > >
> > > Original issue's description:
> > > > [tracing] Dump child processes' memory metrics in browser
> > > >
> > > > The sandbox in linux prevents the process from reading the process
> > > > metrics file. To work around this issue, the browser process will now
> > > > dump statistics of the child processes too. This requires the
> > > > composable dumps support in trace viewer and telemetry.
> > > >
> > > > This CL makes following changes.
> > > > 1. Move the process totals and memory maps dump provider into a single
> > > > header as process_metrics_dump_provider in components/tracing. This is
> > > > because it is not necessary to have this in base and now the provider
> > > > knows/manages for different processes. Also the dump method are made to
> > > > handle error better, since process can vanish while dumping.
> > > >
> > > > 2. Make the dump provider non-singleton and have a register / unregister
> > > > that manages the lifetime of the dump providers.
> > > >
> > > > 3. The dump providers unregister using the new
> > > > UnregisterAndDeleteDumpProviderAsync api added by crrev.com/1430073002.
> > > >
> > > > 4. On linux the browser process dumps metrics for all processes and on
> > > > android the child processes can dump since seccomp sandbox is not
> > > > enabled in android yet.
> > > >
> > > > 5. The proc/status file is human readable stats and is not guaranteed to
> > > > have a field that is asked for. So, the NOTREACHED is removed in
> > > > ReadProcStatusAndGetFieldAsSizeT.
> > > >
> > > > 6. Since we introduce other process dumps from browser process there
> > > > could be races while unregistering and dumping. To test this, the
> > > > browser test is updated.
> > > >
> > > > BUG=461788
> > > >
> > > > Committed: https://crrev.com/4d77d76a42425282b1a3c5b7309db9b98e777f60
> > > > Cr-Commit-Position: refs/heads/master@{#369482}
> > >
> > > TBR=primiano@chromium.org,thakis@chromium.org,simonhatch@chromium.org,sievers@chromium.org,ssid@chromium.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=461788
> > >
> > > Committed: https://crrev.com/93aa967cfcb3e933000f169b9a4f7ac84dbd96da
> > > Cr-Commit-Position: refs/heads/master@{#369535}
> >
> > TBR=primiano@chromium.org,thakis@chromium.org,simonhatch@chromium.org,sievers@chromium.org,huangs@chromium.org
> > BUG=461788
> > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> >
> > Committed: https://crrev.com/df4156349708e21844209290a2d3638b550e18b2
> > Cr-Commit-Position: refs/heads/master@{#370195}
>
> TBR=primiano@chromium.org,thakis@chromium.org,simonhatch@chromium.org,sievers@chromium.org,huangs@chromium.org,ssid@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=461788
>
> Committed: https://crrev.com/94bef8d8bf199e23102783a55a15c9f10bc88631
> Cr-Commit-Position: refs/heads/master@{#370836}

TBR=primiano@chromium.org,thakis@chromium.org,simonhatch@chromium.org,sievers@chromium.org,huangs@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=461788

Review URL: https://codereview.chromium.org/1629393003

Cr-Commit-Position: refs/heads/master@{#371495}

isMaxSizeNone() is nonsensical for min-width. Zero (but represented as
Auto) is initial Length value for min-width, not MaxSizeNone. This
stands out after the rename from isUndefined() to isMaxSizeNone(). But
in this case it seems |style()->logicalMinWidth().isMaxSizeNone()| was
a just long alias for |false| so remove it.

Review URL: https://codereview.chromium.org/1633683002

Cr-Commit-Position: refs/heads/master@{#371494}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e78b4e2e..99af10a4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1634133002

Cr-Commit-Position: refs/heads/master@{#371493}