- 17 Nov, 2020 40 commits
-
-
Marijn Kruisselbrink authored
This reverts commit ecd22f2f. Reason for revert: SubresourceFilterBrowserTest.DisallowedSubframeURLBlockedOnActivatedURL is flaky Example failures on https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863356200301577856/+/steps/weblayer_browsertests/0/logs/Deterministic_failure:_SubresourceFilterBrowserTest.DisallowedSubframeURLBlockedOnActivatedURL__status_FAILURE_/0 ../../weblayer/browser/subresource_filter_browsertest.cc(196): error: Value of: WasParsedScriptElementLoaded(web_contents->GetMainFrame()) Actual: true Expected: false Original change's description: > [WebLayer] Initial bringup of ad blocking > > This CL does the initial bringup of ad tagging and blocking > functionality in WebLayer. To do so, we do the following: > - Bring up an implementation of SubresourceFilterClient and attach it > to WebContents instances > - Instantiate subresource filter navigation throttles on navigation > - Instantiates and configures SubresourceFilterAgent instances in the > renderer > > The organization and code added is modeled after that in //chrome. We > have left TODOs for significant pieces of functionality to be added > in followups (e.g., showing of the infobar on Android). One thing to > note is that ad tagging/blocking only triggers on Android in WebLayer, > as it requires having a safe browsing database instance and WebLayer > does not have one on platforms other than Android. > > This CL also adds browsertests of this initial functionality: > - that the subresource filter activation state is computed on page loads > - that ads are blocked on activated pages if they are flagged by the > ruleset > > Bug: 1116095 > Change-Id: I1db0136709014004c221bb0251551eaeac3538e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526087 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827735} TBR=blundell@chromium.org,csharrison@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1116095 Change-Id: I4b8bbed57ed18666e2155dae7a25186803802267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545763Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828459}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser/ui. Bug: 1113033 Change-Id: I7b66fc969130543f13445bd86c7a443c0de6b7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544872 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#828458}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser/ui. Bug: 1113033 Change-Id: Id893e982a7002c21c46c95f0d4732e638c6e22db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545027 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Consider ConnectionDetails::connection_medium_ when comparing ConnectionMedium objects. This fixes an issue in which two ConnectionDetails objects with the same device ID but different mediums were compared incorrectly, causing an issue where connection attempts to the same device with different mediums ended up using the same underlying connection instead of two separate connections. Bug: 1150070 Change-Id: I9bb2802676aebf4a0df9a430cc33bff683dcd14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545664 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#828456}
-
Luciano Pacheco authored
All of them aren't working on Files app anymore so can be spared from the occasional code review for it. Thank you all for your time served with us! Change-Id: I58ddb08e6fc49a0ad49500912c67124793764740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536419 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Anand K Mistry <amistry@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#828455}
-
Becca Hughes authored
This will be used for watchtime tracking (in a sep. CL). Change-Id: I4d3c58b307e4f7e2bf76010a81660defca399f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544930 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#828454}
-
Bettina authored
The ResetShortcutsComponent will use the existing sandboxed shortcut parser to retrieve modified shortcuts and then overwrites the existing shortcuts with new ones. The component will be hooked up to the CCT in a future CL. Bug: 1116017,1148930 Change-Id: Ia6c8453af267b98884804eed3b18944afb0506ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520419Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#828453}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605581968-699188875fbc74b98026cce85d5b16d698948c9f.profdata to chrome-win64-master-1605625046-b998d997d9684c194050542ad9b812298a5a0da2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idbf2f136b9b3b3f0dadf98ad2006ce7728c1f2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828452}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/04515da400d5..f1223ce969c7 2020-11-17 capn@google.com Switch Android to LLVM ORCv2 JIT and remove ORCv1 support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4a768ec54ee3dea737278ada208b01f9d4cea492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545084Reviewed-by:
-
Lucas Radaelli authored
This change implements a class that maps between AXNode IDs to unique Fuchsia Node IDs. Bug: fuchsia:63607 Test: AXTreeConverterTest.* Change-Id: I75352da5b310112d07bd353ea4af7e23c52eac06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530981Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/master@{#828450}
-
Samuel Huang authored
The main analysis file for android-binary-size has been switched to Trichrome (from MonochromePublic) crrev.com/c/2545043, which updated constant.py by changing DEFAULT_SIZE_CONFIG_JSON. Although the file specifies DEFAULT_ANALYZE_TARGETS and DEFAULT_COMPILE_TARGETS that includes Trichrome targets, it turns out that android-binary-size's builder config overrides these values, but does not build Trichrome! This is causing android-binary-size bot to fail, since Trichrome is not built. This CL solves the problem by updating the builder config for android-binary-size. Bug: 1040645, 1150128 Change-Id: I5ba8205d44100288f8770345bfa64aadf785d2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545486Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#828449}
-
Liquan (Max) Gu authored
Before the CL: - CPRService#continueShow() calls CPRService#triggerPaymentAppUiSkipIfApplicable() After the CL: - PRService#continueShow() calls PRService#triggerPaymentAppUiSkipIfApplicable() Bug: 1147092 Change-Id: I11a5af8815759b04738ed2f423c8a5921b4efdc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543131 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828448}
-
Ilya Sherman authored
I have been reverse shadowing her reviews for a few weeks, and I think she is ready to become a full-fledged owner. R=asvitkine Bug: None Change-Id: I01b629b3e1312a85df11b193a7196c230f3452d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543831 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#828447}
-
Brandon Wylie authored
Bug: 1117271 Change-Id: I0cfa8867edb70df45f2ed382aa745cc29390d160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538533Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828446}
-
Clark DuVall authored
This reverts commit 66495856. Reason for revert: Probably breaking canary Play Store upload: crbug.com/1149919 Original change's description: > Reland "Enable isolated splits in canary and dev" > > This is a reland of c7a74ee0 > > Fix for manifest issue is in http://crrev.com/c/2538369, will reland > after that change is submitted. > > Original change's description: > > Enable isolated splits in canary and dev > > > > All major crashes have been fixed and numbers look good. M88 branch was > > just cut, so should be safe to enable now. > > > > Bug: 1126301 > > Change-Id: I351d565e68f14af2411c71fa80f34852bab5455a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529729 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827387} > > Bug: 1126301 > Change-Id: I6aa825bde70b184cdc412d37d5e5e8850f00bac0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539667 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827815} TBR=agrieve@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1126301, 1149919 Change-Id: Ic085efe1ada81385542cb14e6f92ba81719e34ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544876Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#828445}
-
My Nguyen authored
Bug: b/171924347 Change-Id: Ia4deca20e2d79fda81eb1a0fcadedf38b887b093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533057Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#828444}
-
Avi Drissman authored
Now that we're building against the macOS 11 SDK, do some cleanup. Bug: 1105187 Change-Id: I53fe103d8006f03dacdf2a9a2241bf743f39755f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545232 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828443}
-
Alan Cutter authored
This is a reland of 86556051 The original CL missed a dep requirement in the Chrome branded Windows build. This has been fixed: https://chromium-review.googlesource.com/c/chromium/src/+/2543873/2/chrome/browser/win/conflicts/BUILD.gn Original change's description: > Extract browser_process.h/cc into own gn target > > This CL pulls out browser_process.h and browser_process.cc into their > own gn target so that other gn targets can depend on it without creating > cyclic dependencies with //chrome/browser:browser. > > This is required for CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2528519 > > Bug: 1147410, 883570, 925153 > Change-Id: I17ef1f0b1683c4abb7588a6ef24ec89f15647545 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529309 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828077} Bug: 1147410 Bug: 883570 Bug: 925153 Change-Id: I18faaddc3850ceafb924bda6d8e197f886e79433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543873Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Mehran Mahmoudi authored
This attempts to fix this flaky/failing test by changing assertion from checking Paint Preview is currently is showing to whether it has ever been shown. Bug: 1145783 Change-Id: I7d15ff6c517979684b129102d71d5f4ebaa926e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545089Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828441}
-
Ken Rockot authored
This header is going to be removed. Most inclusions are unused. This CL prunes them and removes an effectively unused testing API. Bug: 977637 Change-Id: I032c1a538751ac6b610aeee8867429563bb8f187 Tbr: alexmos@chromium.org Tbr: hidehiko@chromium.org Tbr: spang@chromium.org Tbr: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544936Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#828440}
-
Muyao Xu authored
This CL uses the native logger to log WebRTC messages between the mirroring service and mirroring receiver. AES related data will be scrubbed before sent to the logger. Bug: b/170651376, 1117673 Change-Id: I4e72edc715d8f56b6ac7f3c3353dae1d119e8d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533118 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#828439}
-
Antonio Gomes authored
This is a preparation step to share BrowserNonClientFrameViewAsh with lacros/chrome. BUG=1113900 R=jamescook@chromium.org Change-Id: I60ded69e234b17d4012d35843f5ac646c1c80f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545231 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828438}
-
danielng authored
Changing some strings to better portray errors to users and advise them of what steps they can take next. Both of these are DLC related. One relates to an error that can occur when a user tries to install borealis, cancels and tries to install again (before the last installation has finalized its cancellation). The other relates to the DLC "Catch-all" error message, where sometimes if users just retry, the installation will succeed. Bug: b/171672034, b/172284265 Change-Id: I17ef2028cab27361ec42e0ab581e828d83c72f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544322Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#828437}
-
Gavin Williams authored
Using an observer + boolean attributes to reduce the number of unnecessary function calls from the HTML whenever AppState changes. Bug: 1059779 Change-Id: I20f92489adcc351dace224d0fc33f4c95478f472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544751 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#828436}
-
Natalie Chouinard authored
Last references to this target have been cleaned up in: https://crrev.com/i/3401020. Bug: 1047896 Change-Id: I95047d97ba548ef71c982c62d266fc9fdcc9033b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541563Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#828435}
-
Marijn Kruisselbrink authored
Bug: 1095379 Change-Id: Id2089d4dd8242da09bdeb0569bab180f08a73e6e Tbr: masonfreed@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545565Reviewed-by:
-
adoneria authored
For the builders and testers added in crrev.com/c/2542883. Bug: 1149557 Change-Id: I1ae766997c46561d128353a02063a00d7f860b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542809Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#828433}
-
Brandon Wylie authored
Bug: 1148747 Change-Id: Ie7d12ccd515f9a224ab025ed75a63bd70a9e4a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538261Reviewed-by:
-
Gavin Williams authored
Splitting this out to a new element for better compartmentalization for the Done section features. http://screen/6DrzkKGwwfkXcgr Bug: 1059779 Change-Id: Ia81015785081904d46320754977fff9fb5190a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542670Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 198 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-02-15. TBR=chromium-metrics-reviews@google.com Change-Id: Id584782bc1bdd5198c0e474aad5b95da4fd110cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543246Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#828430}
-
Marijn Kruisselbrink authored
Bug: 1095379 Change-Id: Icf60c0c72ed31abbb547a13af57f12e0bbe2d74e Tbr: masonfreed@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545762Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia4d38a04f0029bc9566043014546664c19a011e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545209Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828428}
-
Jared Saul authored
Change-Id: I7c055a216e7ce2f5aca3cda2a0fe943c20b72a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541748 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#828427}
-
Yann Dago authored
Bug: 1149989 Change-Id: If7daa7e9bb5f43b43860cc097f214755b3b75bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544370Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#828426}
-
Marijn Kruisselbrink authored
This reverts commit a4b670d5. Reason for revert: Test is flaky/failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/95514? ../../chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:2470: Failure Expected equality of these values: tab_strip_width + TabStyle::GetStandardWidth() Which is: 751 tab_strip->width() Which is: 761 Original change's description: > [Tab Scrolling] Add test for tabstrip resizing when dragging. > > When the browser window is large enough, the tabstrip should expand to > accommodate tabs dragging past the last tab. This is a test for > crrev.com/c/2472577 > > Bug: 1141674 > Change-Id: Icfb4b0d6b9ebfa243a0e352b0cef68a2a6f2c263 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537068 > Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827998} TBR=tbergquist@chromium.org,cyan@chromium.org Change-Id: Iaee8c99d3a53eb4f1031d969b01e39d86febe6a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1141674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545744Reviewed-by:
-
Xing Liu authored
This CL implements more details for bookmark bottom sheet. The contents includes: 1. Load bookmark top level data to bottom sheet. 2. Implement the click event. 3. Implement the view holder. Reuse BookmarkRow but plumb data through MVC view binder, might be good for future development. 4. A few integration tests are added to BookmarkBottomSheetTest. doc: go/chrome-bottomsheet-mvc Bug: 1133496 Change-Id: Id5ce9abb44351c3a6a350531e1622f08c725a1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537785 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828424}
-
Matt Menard authored
The `Polymer` and `html` are unused in css js files. Change-Id: Iee6a6d6df14562c769bd7723a4f35698cc8a7478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541702Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#828423}
-
Alex Gough authored
Tested on hardware as part of https://chromium-review.googlesource.com/c/chromium/src/+/2494509/2/build/config/compiler/BUILD.gn Bug: 1136664 Change-Id: I7c5cf2c54259c6aa29fd1ea39a66cf3e8ae7ac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541782Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#828422}
-
Marijn Kruisselbrink authored
These tests were timing out rather than (or in addition to?) failing, so add Timeout as one of the expected outcomes. Bug: 1149734 Change-Id: Ief7709340fe76350a210046d7cd75a0626d9c44d Tbr: tguilbert@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545249Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828421}
-
Mark Cogan authored
Adds a VoiceOver notification when the number of visible Chrome windows changes, if multiple windows are possible. This is complicated by some window manipulations causing transient changes in the number of foregrounded windows -- for example, replacing one window with another will briefly have three scenes with Foreground- Inactive states. To mitigate this, the app agent delays notifications, and coalesces multiple notifications in the delay period into a single notification. (No notification is posted if the window count doesn't change from the last notification). Bug: 1137818 Change-Id: I2a308072c92aceb3816397dae6fdf50d61d14398 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540670 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#828420}
-
