GitLab

Passes the context associated with the profile invoker's ScriptState
into v8::CpuProfilingOptions for filtration, providing isolation of
traces to the invoker's realm.

Bug: 956688
Change-Id: Iafb46d1990841656b216588a67ef63e3198b0a14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762249Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#689137}

This CHECK hasn't tripped in the recent Canary builds, it's safe to turn
it back into a DCHECK.

Bug: 966059
Change-Id: Ieeb23543146fb276d601790638b3d3fbd1880c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760279
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689136}

The version code is useful to identify java proguard mappings.
Also removes posting task for metadata generation in privacy
filtered mode.

Change-Id: Ifd26a4ee39010467a89a73c7159bada02e15490c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759293
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689135}

https://skia.googlesource.com/skia.git/+log/ad10df694213..aa3cbb81b706

git log ad10df694213..aa3cbb81b706 --date=short --no-merges --format='%ad %ae %s'
2019-08-21 csmartdalton@google.com Mark mipmaps dirty from makeClosed() rather than opList constructors
2019-08-21 robertphillips@google.com Remove GrPendingIOResource
2019-08-21 csmartdalton@google.com Convert GrManyDependentsMipMappedTest to a mock gpu test
2019-08-21 fmalita@chromium.org [svgcanvas] Don't emit default fill and stroke attributes
2019-08-21 bsalomon@google.com Fix sk_sp<> for incomplete type build issue
2019-08-21 bungeman@google.com Simplify gdi handle use with gdi fonts.

Created with:
  gclient setdep -r src/third_party/skia@aa3cbb81b706

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@google.com

Bug: None
Change-Id: Ibb54b3b7dd485b5a4a607bf9b5f32f4a00388964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764230Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689134}

- Display the icon only when that accessibility feature is visible in
the accessibility tray menu and its being controlled by a policy which
has a value of forced on.
- Display the additional settings separator ,which starts the
section of additional accessibility features, only if there exists
at least one visible in each of the additional and primary
accessibility features.
- Shows the additional settings label in tray menu only if there
exist at least one visible of the additional accessibility features.
- Record the user action only if the accessibility feature is visible
and its state isn't forced on by a policy.

Bug: 552439
Change-Id: I7621ba186e4cd407b5835a74ab378ad7b2bb76ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732107
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689133}

This CL will manage the visibility of all of the following accessiblity
features:
- Autoclick
- Caret highlight
- Focus highlight
- Full screen magnifier
- Docked magnifier
- Spoken feedback
- Select to speak
- Switch access
- Sticky keys
- Virtual keyboard
Show any of these accessibility features only if one of the following
conditions have meet :
-Its not being controlled by any policy
-Its being controlled by a policy and the value of the policy is force on

Bug: 552439
Change-Id: I0ea0e6165270f5de00c51ecbe4047e9243ca130f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738374
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689132}

This CL wires EDID's bits per channel indication to DisplaySnapshot,
ManagedDisplayInfo, and DisplayManager.  This is needed as a first
step to create 10 bit per component/30 bit depth framebuffers for
monitors that support it such as [1] or HP z32x.

[1] https://paste.googleplex.com/4515759143256064

Bug: 949260
Change-Id: Ic30c34099da68f9ec9a7e099e5136b945aab6879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733887
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689131}

https://quiche.googlesource.com/quiche.git/+log/fd3ee30e9b48..9a910e3deaec

$ git log fd3ee30e9..9a910e3de --date=short --no-merges --format='%ad %ae %s'
2019-08-19 dschinazi Generate stateless reset tokens by hashing instead of XOR.
2019-08-19 dschinazi Workaround for Android UDP network conformance test
2019-08-19 dschinazi Deprecate quic_use_allocated_connection_ids
2019-08-19 renjietang Rename ENCRYPTION_REESTABLISHED to ENCRYPTION_ESTABLISHED as ENCRRYPTION_FIRST_ESTABLISHED has been removed.
2019-08-19 wub gfe-relnote: (n/a) Ensure BandwidthSampler.max_ack_height_tracker_.aggregation_epoch_start_time_ is initialized before Update(). Protected by --gfe2_reloadable_flag_quic_track_ack_height_in_bandwidth_sampler2, which replaces the old v1 flag.
2019-08-19 dschinazi Deprecate quic_deterministic_replacement_connection_ids
2019-08-19 renjietang Do not send stream type twice in QPACK streams.
2019-08-19 renjietang Remove unused ENCRYPTION_FIRST_ESTABLISHED.
2019-08-19 dschinazi Use deterministic replacement connection IDs
2019-08-19 zhongyi gfe-relnote: rename OnConnectivityProbeReceived to OnPacketReceived. Not flag protected, this is a refactor and has no behavior change.
2019-08-19 fkastenholz Add default to function generating name of Transport Error Code
2019-08-16 bnc Rename QuicSpdyStreamBodyBuffer to QuicSpdyStreamBodyManager.
2019-08-16 wub gfe-relnote: Move QuicCryptoServerStream::Helper::GenerateConnectionIdForReject to QuicDispatcher::GenerateNewServerConnectionId. Refactor only.
2019-08-16 bnc Remove Http2String wrapper for std::string.
2019-08-16 dschinazi Flush queued frames when processing coalesced packets
2019-08-16 renjietang Add QpackStreams into QuicSpdySession.
2019-08-16 fkastenholz Add text outputter for IETF stream types

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I4f5e3f43094b4a84c31b3ce64b4aaf1d694a571a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761735Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689130}

Change-Id: Ibf169f00e7de6b38211e01907f879f185f578bc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763644
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689129}

Bug: 966388
Change-Id: I9c4537e1802ac08407c28db2139806ecefc9d149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763753
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689128}

This reverts commit a42eb196.

Reason for revert: Causing a crash.  See crbug.com/996179

Original change's description:
> Change Show in folder to single pulse + test
> 
> Bug: 994293
> Change-Id: I2446ed845f08b5173ac25fe836e50b114f58cf45
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756545
> Commit-Queue: Theresa  <twellington@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688295}

TBR=dtrainor@chromium.org,twellington@chromium.org,mdjones@chromium.org,jhimawan@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 994293
Change-Id: Ie448f7de1ef72dac1e3bd4f7c93466c903ab1b03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762473Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689127}

Chrome OS Account Manager has been enabled for 1% on Stable channel.
Enable it on ToT as preparation for 100% Stable ramp up.

TBR=droger@chromium.org

Bug: 816954
Change-Id: I6e0097237600e40c39a98e59af063deddd1da9a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761588Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689126}

The colors for the button and selected table cell are changed to the
right ones.

Bug: 995271
Change-Id: I988161221bbc46853672aace94132505beaab1b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762221
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#689125}

These get in the way of refactoring, and aren't used anyway.

TBR=raymes

Bug: 982024
Change-Id: Ifa87a5e7af30a8529bf531409b49307f499a64fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761714Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689124}

We had made response header names lowercase because they are case
insensitive. It turns out UrlResponseInfoImpl already uses a TreeMap
with a case insensitive order. Map keys will always be case insensitive
anyway, but it could be confusing to users if we change the case of the
headers.

Original Discussion: crrev.com/c/1703325/36/components/cronet/android/fake/java/org/chromium/net/test/FakeUrlRequest.java#203

Bug: 669707
Change-Id: If8af8faf9214fba51e2dceab28e8dcb82976b8ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762356
Commit-Queue: Benjamin Kirchman <kirchman@google.com>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689123}

This reverts commit 7472b906.

Reason for revert: sheriff suspects this caused a build break on win{,32}-archive-rel:

https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/4309

In file included from ../../chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc_unittest.cc:14:
In file included from ../..\base/test/scoped_task_environment.h:15:
In file included from ../..\base/task/lazy_task_runner.h:17:
../..\base/task/task_traits.h(263,5): error: static_assert failed due to requirement 'has_thread_pool ^ has_extension' "Traits must explicitly specify a destination (e.g. ThreadPool or a named thread like BrowserThread)"
    static_assert(
    ^
../..\chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc.h(108,39): note: in instantiation of function template specialization 'base::TaskTraits::TaskTraits<base::MayBlock, void>' requested here
      base::CreateSequencedTaskRunner({base::MayBlock()});
                                      ^
1 error generated.

Original change's description:
> [TaskEnvironment] Standardize paradigm for classes forwarding traits
> 
> As discussed @
> https://chromium-review.googlesource.com/c/chromium/src/+/1749538/6/ash/test/ash_test_base.h#84
> 
> Usage of explicit everywhere also avoids implicit copy construction
> and is the reason for changes to a few unit tests that previously
> used operator= to initialize their task environments.
> 
> TBR=dcheng@chromium.org
> (for widespread mechanical change)
> 
> Bug: 992483
> Change-Id: I321576674f3b387a6f5069e8e71eebf41c98e7ed
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758338
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689098}

TBR=dcheng@chromium.org,gab@chromium.org

Change-Id: I69b71b220ab583bc3a18e8fb07213fa1b6a75b50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 992483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762475Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689122}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I7c2ea12e5a011f27ba2a026beac9a2aa8b984004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763161Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689121}

This CL enables <input type=text/number/password/button/submit>
to render high contrast colors when high contrast mode is enabled.

test: web_tests\fast\forms\controls-new-ui-high-contrast\text_number_password_button_submit.html
Note the test is verifying if we are correctly using system colors
in high contrast mode and since we don't really change system setting
for HC in webtests, the results colors are still black/grey/white
(in higher contrast) instead of black/white/green.

Bug: 994219
Change-Id: I0a9653c3051eb9e7db01ef43ec024354518be950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763429
Commit-Queue: Alex Keng <shihken@microsoft.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#689120}

Bug: 966388
Change-Id: I19ff60ec305481b5de301a41a1807d154981afc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763673Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689119}

https://android.googlesource.com/platform/external/perfetto.git/+log/6a337fb9b12b..2891cbc02f12

git log 6a337fb9b12b..2891cbc02f12 --date=short --no-merges --format='%ad %ae %s'
2019-08-21 taylori@google.com perfetto-ui: Fix to split up FrontendLocalState

Created with:
  gclient setdep -r src/third_party/perfetto@2891cbc02f12

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I3750be80265c5f8052b4a01ca2dc383ba4dec61a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763639Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689118}

Bug: 862097
Change-Id: I961db6594f82812270fbd8d3114e9aa687abb43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762689
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689117}

Bug: 996273

Change-Id: Ib14172afd9ca3b4661f5708572d2d719a71379b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759059
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689116}

Using the previously added submatch support, this CL allows
tab switch suggestions to be separate suggestions below their
parent suggestion. Instead of clicking a button to activate
the tab switch, this change allows selecting a special
suggestion.

Bug: 995935
Change-Id: I039e879f1b330cf9b17755daf9134013451cd9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762827
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689115}

https://imgur.com/a/MfVqsey

Bug: 989131
Change-Id: If40b94d6ceecbdf46ee336e765f65df2efb19673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762835Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689114}

- Implement Coordinator which uses the same Presenting delegate as the QR Scanner.

Bug: 989951

Change-Id: I6a48b71313825b1139d0d0f237fd0c91125ed487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730906
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689113}

Bug: 967076

Change-Id: I099d7862e216ea656fccef800d38e3396b0a8668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761077
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689112}

This CL is adding UMA metrics to evaluate the amount of calls to each
fallback fonts mechanism.

  1) Compare the PlatformFontWin and PlatformFontSkia on fallbacks
  2) Determine whether or not the FontLink code on windows is not used
     (see crbug/995789).

ShapeRuns(...) is shaping the text by running these mechanisms:

  1) Skipping newline character
  2) Trying the primary font
  3) Trying the fallback font (e.g. GetFontFallback(...))
  4) Trying the fallbacks font (e.g. GetFontFallbacks(...))
  5) Failing to shape the text

R=robliao@chromium.org, asvitkine@chromium.org

Bug: 995789
Change-Id: I954c50ab8dfa8d0a6e552f175d58357685a3b95f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759058Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689111}

Move destruction of an adopted-but-not-inserted portal into HTMLPortalElement::ExpireAdoptionLifetime.

Change-Id: Id7323e014838ae9c06434369f4d7e1124062275a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761400Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689110}

This CL introduces a new method PDFiumPage::CalculateImage() which is
responsible for populating images vector in PDFiumPage.

Added a unit test TestCalculateImages() as well as pdf test file
containing three images to verify the image data.

Bug: 981448
Change-Id: Ifbc8426cb47a3a7a76b2bca309c7a68e1792b3fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738690Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Pratish Kumar <prkum@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#689109}

Change-Id: I096f86553aa1c173c03f2e103a8c199db94d7d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711101Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Lei Lei <leilei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689108}

This CL adds NetworkIsolationKey as an argument to the
ServerNetworkStats methods in HttpServerProperties, and makes
consumers pass in the correct key.

Bug: 969890
Change-Id: I0259dc37b0428a7a649e2391b6c23459caba4673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758297
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689107}

Change-Id: I170282a5298026be223d63259cebd527444fb05a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763159
Auto-Submit: Eric Karl <ericrk@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689106}

This CL rewrites the logic to schedule background task in
BackgroundTaskCoordinator. Now it's based on deliver time window.

The old unit tests are deleted, new unit tests will be added in
following CL.

Bug: 991010
Change-Id: I8a05e8178d94b1daadf87d8abc8f9e0bac783e37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756439
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689105}

No intended logic changes, but should be more readable.

Change-Id: Ife2389f5fbfa8e5448d584efdd612cbc1d67721d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762979
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689104}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3654f21952d9..ad86dfbd3219

git log 3654f21952d9..ad86dfbd3219 --date=short --no-merges --format='%ad %ae %s'
2019-08-21 cjmcdonald@chromium.org Move cros_check_patches to use depgraph lib

Created with:
  gclient setdep -r src/third_party/chromite@ad86dfbd3219

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I566d93f86fc30f285076df403d9edefb28bdc386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763173Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689103}

The outline was appearing even if the user used the mouse to click on
the button. Elsewhere in settings we only show outlines when the user
uses the keyboard. Update action-link CSS styles to check the global
focus-outline-visible style added by FocusOutlineManager.

I did this at the settings level, rather than for all action-links,
because I'm not sure that all consumers of action-link need or want
a dependency on FocusOutlineManager.

Bug: 995921
Test: no outline when button clicked with mouse, outline present when triggered with keyboard
Change-Id: Idb7d4e0f96bb70d1d24c63fbc760460198a08304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762695Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689102}

NullValue() is represented as a NaN in a double. We could better return
a base::Optional<double> and use the undefined base::Optional as null
value. Also there is no need for the IsNull() call as we could just use
the returned value as a boolean.

Bug: 994811
Change-Id: Ibb4a6b89102dd49450d68aae35b03e9eba46332f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760963Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#689101}

This CL adds metrics to track two level db we use in notification
scheduling system.

TBR=dtrainor@chromium.org

Bug: 963298
Change-Id: I6e0698827b0ef5450df1c23abca8f94168086e09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761651
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689100}

This reverts commit 75116336.

Reason for revert: crbug.com/996271

Original change's description:
> [Printing] Don't create unnecessary PrintSettings instances.
> 
> Make |PrintingContext::settings_| null before settings are created or
> after ownership is passed to PrinterQuery.
> 
> Bug: 964948
> Change-Id: I0cff0b5b460ecb3424ff0cb07e5849bed3ffe51e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678182
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688541}

TBR=thestig@chromium.org,vkuzkokov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 964948
Change-Id: If0dfec489dcbb8e38f2fbf3e8510904dc80893f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758237Reviewed-by: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689099}

As discussed @
https://chromium-review.googlesource.com/c/chromium/src/+/1749538/6/ash/test/ash_test_base.h#84

Usage of explicit everywhere also avoids implicit copy construction
and is the reason for changes to a few unit tests that previously
used operator= to initialize their task environments.

TBR=dcheng@chromium.org
(for widespread mechanical change)

Bug: 992483
Change-Id: I321576674f3b387a6f5069e8e71eebf41c98e7ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758338Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689098}