1. 15 Mar, 2011 31 commits
    • commit-queue@webkit.org's avatar
      2011-03-14 Alexis Menard <alexis.menard@openbossa.org> · 1f85178b
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Seeking videos using the timeline bar does not work properly and stop the video playback.
              https://bugs.webkit.org/show_bug.cgi?id=56145
      
              We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough.
              positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because
              of a bug in QtMultimedia.
      
              * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
              (WebCore::MediaPlayerPrivateQt::seek):
              (WebCore::MediaPlayerPrivateQt::stateChanged):
              (WebCore::MediaPlayerPrivateQt::positionChanged):
              * platform/graphics/qt/MediaPlayerPrivateQt.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81114 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1f85178b
    • commit-queue@webkit.org's avatar
      2011-03-14 Alexey Marinichev <amarinichev@chromium.org> · 276cbca9
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              Graphics Context is not properly recovered if the GPU process dies.
              https://bugs.webkit.org/show_bug.cgi?id=56148
      
              Split context recreation into two steps.
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::composite):
              (WebKit::WebViewImpl::doComposite):
              (WebKit::WebViewImpl::reallocateRenderer):
              * src/WebViewImpl.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81113 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      276cbca9
    • morrita@google.com's avatar
      2011-03-14 MORITA Hajime <morrita@google.com> · 0941835f
      morrita@google.com authored
              Unreviewed, skipped tests that uses an unsupported DRT API.
      
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81112 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0941835f
    • ap@apple.com's avatar
      2011-03-14 Alexey Proskuryakov <ap@apple.com> · f89921ac
      ap@apple.com authored
              Reviewed by Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=44138
              Crashes beneath SocketStreamHandle::readStreamCallback when running WebSocket tests.
      
              * platform/win/Skipped: Unskipped tests that should be fixed now. I couldn't verify that
              locally, becasue most WebSocket tests time out on my machine.
      2011-03-14  Alexey Proskuryakov  <ap@apple.com>
      
              Reviewed by Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=44138
              Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html
      
              https://bugs.webkit.org/show_bug.cgi?id=55375
              http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
      
              https://bugs.webkit.org/show_bug.cgi?id=56185
              http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
      
              * platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that
              a pointer can be passed across threads when wrapped in a RefPtr.
      
              * platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists
              when executing a method on main thread by using RefPtr.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81111 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f89921ac
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · ff6489d1
      rniwa@webkit.org authored
              Chromium rebaselines for r81095.
      
              * platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
              * platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
              * platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
              * platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt:
              * platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt:
              * platform/chromium-linux/editing/selection/fake-drag-expected.txt: Removed.
              * platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
              * platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
              * platform/chromium-win/editing/deleting/smart-delete-002-expected.txt:
              * platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt:
              * platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt:
              * platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt:
              * platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt:
              * platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
              * platform/chromium-win/editing/selection/after-line-break-expected.txt:
              * platform/chromium-win/editing/selection/expanding-selections-expected.txt:
              * platform/chromium-win/editing/selection/expanding-selections2-expected.txt:
              * platform/chromium-win/editing/selection/fake-drag-expected.txt:
              * platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
              * platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81110 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ff6489d1
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · 5f05f0ed
      rniwa@webkit.org authored
              GTK and Qt rebaselines for r81095.
      
              * platform/gtk/editing/deleting/smart-delete-001-expected.txt:
              * platform/gtk/editing/deleting/smart-delete-002-expected.txt:
              * platform/gtk/editing/pasteboard/smart-paste-001-expected.txt:
              * platform/gtk/editing/pasteboard/smart-paste-003-expected.txt:
              * platform/gtk/editing/pasteboard/smart-paste-004-expected.txt:
              * platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
              * platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
              * platform/gtk/editing/selection/expanding-selections-expected.txt:
              * platform/gtk/editing/selection/expanding-selections2-expected.txt:
              * platform/gtk/editing/selection/fake-drag-expected.txt:
              * platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
              * platform/gtk/editing/selection/triple-click-in-pre-expected.txt:
              * platform/qt/editing/deleting/smart-delete-001-expected.txt:
              * platform/qt/editing/pasteboard/smart-paste-001-expected.txt:
              * platform/qt/editing/pasteboard/smart-paste-003-expected.txt:
              * platform/qt/editing/pasteboard/smart-paste-004-expected.txt:
              * platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
              * platform/qt/editing/selection/expanding-selections-expected.txt:
              * platform/qt/editing/selection/expanding-selections2-expected.txt:
              * platform/qt/editing/selection/triple-click-in-pre-expected.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81109 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5f05f0ed
    • commit-queue@webkit.org's avatar
      2011-03-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com> · a43e7675
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
              https://bugs.webkit.org/show_bug.cgi?id=56006
      
              * QtTestBrowser/launcherwindow.cpp:
              (LauncherWindow::initializeView):
              * QtTestBrowser/main.cpp:
              (LauncherApplication::handleUserOptions):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81108 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a43e7675
    • weinig@apple.com's avatar
      Mac build fix. Part 1 of N. · 70f64dbe
      weinig@apple.com authored
      * WebCore.exp.in:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81107 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      70f64dbe
    • commit-queue@webkit.org's avatar
      2011-03-14 James Kozianski <koz@chromium.org> · 26435197
      commit-queue@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Add method to make BuildBot return test outputs
              https://bugs.webkit.org/show_bug.cgi?id=54374
      
              The Builder.latest_cached_build will be used by the new rebaseline
              script to determine the build to use baselines from.
      
              * Scripts/webkitpy/common/net/buildbot/buildbot.py:
              * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81106 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      26435197
    • aroben@apple.com's avatar
      Make WKBundlePageCanHandleRequest return true for empty document URLs · ec43bb1b
      aroben@apple.com authored
      Reviewed by Sam Weinig.
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::canHandleRequest): Return true for any URL schemes that are handled as
      empty documents, and defer to the platform for everything else.
      
      * WebProcess/WebPage/WebPage.h: Added platformCanHandleRequest.
      
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformCanHandleRequest):
      * WebProcess/WebPage/qt/WebPageQt.cpp:
      (WebKit::WebPage::platformCanHandleRequest):
      * WebProcess/WebPage/win/WebPageWin.cpp:
      (WebKit::WebPage::platformCanHandleRequest):
      Renamed from canHandleRequest.
      
      Tools:
      
      Test that WKBundlePageCanHandleRequest returns true for empty document URLs
      
      * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
      (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
      (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
      (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
      ensure the web process is initialized, then ask the bundle to run the test and assert that
      it succeeded.
      
      * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
      (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
      (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
      handle a given URL.
      (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
      URL type cannot be handled).
      (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
      result.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/win/TestWebKitAPI.vcproj:
      * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
      Added new files to the project.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81105 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ec43bb1b
    • joepeck@webkit.org's avatar
      2011-03-14 Joseph Pecoraro <joepeck@webkit.org> · e8dd2abe
      joepeck@webkit.org authored
              Reviewed by Eric Carlson.
      
              Stalled media elements don't stop delaying the load event
              https://bugs.webkit.org/show_bug.cgi?id=56316
      
              * http/tests/media/video-play-stall-before-meta-data-expected.txt: Added.
              * http/tests/media/video-play-stall-before-meta-data.html: Added.
      2011-03-14  Joseph Pecoraro  <joepeck@webkit.org>
      
              Reviewed by Eric Carlson.
      
              Stalled media elements don't stop delaying the load event
              https://bugs.webkit.org/show_bug.cgi?id=56316
      
              We should stop delaying the load event when the load has
              stalled naturally, or if we require a user gesture to
              continue the load.
      
              Test: http/tests/media/video-play-stall-before-meta-data.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying.
              (WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81104 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e8dd2abe
    • mrowe@apple.com's avatar
      Roll out r81097. It broke the 32-bit Mac build and caused assertion failures... · fa26eb24
      mrowe@apple.com authored
      Roll out r81097.  It broke the 32-bit Mac build and caused assertion failures on the Windows Debug bots.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81103 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fa26eb24
    • commit-queue@webkit.org's avatar
      2011-03-14 Ryuan Choi <ryuan.choi@samsung.com> · 752e756d
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Possible leaks after splitting TextCheckerClientEnchant.
              https://bugs.webkit.org/show_bug.cgi?id=55989
      
              Convert gchar* to GOwnPtr<gchar> and refactor the code.
      
              * WebCoreSupport/TextCheckerClientEnchant.cpp:
              (WebKit::TextCheckerClientEnchant::checkSpellingOfString):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81102 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      752e756d
    • morrita@google.com's avatar
      2011-03-13 MORITA Hajime <morrita@google.com> · 3b6bee0a
      morrita@google.com authored
              Reviewed by Tony Chang.
      
              Crash when dragging and dropping in a document with an invalid XHTML header
              https://bugs.webkit.org/show_bug.cgi?id=48799
      
              * editing/pasteboard/drop-file-svg.html: Added.
              * editing/pasteboard/resources/drop-file-svg.svg: Added.
      2011-03-13  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Tony Chang.
      
              Crash when dragging and dropping in a document with an invalid XHTML header
              https://bugs.webkit.org/show_bug.cgi?id=48799
      
              DragController tried to dispatch textInput event even when the
              drag destination is not the editable area.
              This change skips the event dispatching on that case.
      
              Test: editing/pasteboard/drop-file-svg.html
      
              * page/DragController.cpp:
              (WebCore::DragController::dispatchTextInputEventFor):
              (WebCore::DragController::concludeEditDrag):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81101 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3b6bee0a
    • ggaren@apple.com's avatar
      2011-03-14 Geoffrey Garen <ggaren@apple.com> · 726b632f
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Made the global object moving-GC-safe
              https://bugs.webkit.org/show_bug.cgi?id=56348
              
              SunSpider reports no change.
      
              * runtime/JSGlobalObject.cpp:
              (JSC::JSGlobalObject::markChildren): Removed a dubious comment that
              suggested we do not need to visit all our references during GC, since
              that is not true in a moving GC.
      
              Re-sorted data members by type, removed one duplicate, and added back
              the one missing mark I found.
      
              * runtime/JSGlobalObject.h: Re-sorted data members by type.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81100 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      726b632f
    • levin@chromium.org's avatar
      Unreviewed, rolling out r81094. · ce6e393f
      levin@chromium.org authored
      http://trac.webkit.org/changeset/81094
      https://bugs.webkit.org/show_bug.cgi?id=56355
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-03-14
      Broke the chromium DRT related build. (Requested by dave_levin
      on #webkit).
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * WebCore.order:
      * page/Frame.cpp:
      (WebCore::Frame::layerTreeAsText):
      * page/Frame.h:
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::layerTreeAsText):
      * rendering/RenderLayerCompositor.h:
      
      Source/WebKit/chromium:
      
      * public/WebFrame.h:
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::renderTreeAsText):
      (WebKit::WebFrameImpl::layerTreeAsText):
      * src/WebFrameImpl.h:
      
      Tools:
      
      * DumpRenderTree/chromium/DumpRenderTree.cpp:
      (main):
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (LayoutTestController::layerTreeAsText):
      * DumpRenderTree/chromium/LayoutTestController.h:
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::runFileTest):
      (TestShell::dump):
      * DumpRenderTree/chromium/TestShell.h:
      (TestParams::TestParams):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81099 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ce6e393f
    • abarth@webkit.org's avatar
      2011-03-14 Adam Barth <abarth@webkit.org> · c7edd69d
      abarth@webkit.org authored
              Apparently we need to exclude DefaultSharedWorkerRepository.cpp from
              the Chromium build, otherwise the objects visible in the global scope
              change.
      
              * WebCore.gyp/WebCore.gyp:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c7edd69d
    • commit-queue@webkit.org's avatar
      2011-03-14 Rik Cabanier <cabanier@gmail.com> · 9d345140
      commit-queue@webkit.org authored
              Reviewed by David Hyatt.
      
              bug 56052: percentages are incorrectly rounded in WebKit
              https://bugs.webkit.org/show_bug.cgi?id=56052
      
              * platform/mac/fast/css/percentage-non-integer-expected.txt:
      2011-03-14  Rik Cabanier  <cabanier@adobe.com>
      
              Reviewed by David Hyatt.
      
              bug 56052: percentages are incorrectly rounded in WebKit
              https://bugs.webkit.org/show_bug.cgi?id=56052
      
              test: fast/css/percentage-non-integer.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * page/PrintContext.cpp:
              (WebCore::PrintContext::pageProperty):
              * platform/Length.h:
              (WebCore::Length::Length):
              (WebCore::Length::operator*=):
              (WebCore::Length::value):
              (WebCore::Length::percent):
              (WebCore::Length::setValue):
              (WebCore::Length::calcValue):
              (WebCore::Length::calcMinValue):
              (WebCore::Length::isUndefined):
              (WebCore::Length::isZero):
              (WebCore::Length::isPositive):
              (WebCore::Length::isNegative):
              * rendering/AutoTableLayout.cpp:
              (WebCore::AutoTableLayout::recalcColumn):
              (WebCore::AutoTableLayout::computePreferredLogicalWidths):
              (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
              (WebCore::AutoTableLayout::layout):
              * rendering/FixedTableLayout.cpp:
              (WebCore::FixedTableLayout::calcWidthArray):
              (WebCore::FixedTableLayout::layout):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::addCell):
              (WebCore::RenderTableSection::layoutRows):
              * rendering/style/BorderData.h:
              (WebCore::BorderData::hasBorderRadius):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81097 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9d345140
    • abarth@webkit.org's avatar
      2011-03-14 Adam Barth <abarth@webkit.org> · 5703aa86
      abarth@webkit.org authored
              Attempted Chromium build fix.  Exclude AllInOne harder.
      
              * WebCore.gyp/WebCore.gyp:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81096 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5703aa86
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · bf71fc82
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              EventHandler calls shouldChangeSelection needlessly
              https://bugs.webkit.org/show_bug.cgi?id=56324
      
              Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
              avoided calling shouldChangeSelection and setSelection when the existing
              selection is identical to that of new selection.
      
              * page/EventHandler.cpp:
              (WebCore::setSelectionIfNeeded): Extracted.
              (WebCore::setNonDirectionalSelectionIfNeeded): Extracted.
              (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above.
              (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
              (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
              (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
              (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.
              (WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
      2011-03-14  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Adam Barth.
      
              [v8] Rework object group building.
              https://bugs.webkit.org/show_bug.cgi?id=55399
      
              Instead of going top-down (from owner to owned elements), go up---from objects
              to their group ids.  That fits better to v8's object grouping model and guarantees
              that each wrapper belongs to the single group.
      
              Alas, this cannot be implemented for one kind of objects---CSSProperties.
      
              Part of core GC algorithm and tested extensively by exisiting layout tests.
      
              * platform/chromium/test_expectations.txt: Temporary suppress text differences.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81095 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bf71fc82
    • commit-queue@webkit.org's avatar
      2011-03-14 Daniel Sievers <sievers@google.com> · 55a0ae11
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
              https://bugs.webkit.org/show_bug.cgi?id=56139
      
              * WebCore.exp.in:
              * WebCore.order:
              * page/Frame.cpp:
              (WebCore::Frame::layerTreeAsText):
              * page/Frame.h:
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::layerTreeAsText):
              * rendering/RenderLayerCompositor.h:
      2011-03-14  Daniel Sievers  <sievers@google.com>
      
              Reviewed by Simon Fraser.
      
              [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
              https://bugs.webkit.org/show_bug.cgi?id=56139
      
              * public/WebFrame.h:
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::renderTreeAsText):
              (WebKit::WebFrameImpl::layerTreeAsText):
              * src/WebFrameImpl.h:
      2011-03-14  Daniel Sievers  <sievers@google.com>
      
              Reviewed by Simon Fraser.
      
              [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
              https://bugs.webkit.org/show_bug.cgi?id=56139
      
              * DumpRenderTree/chromium/DumpRenderTree.cpp:
              (main):
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::layerTreeAsText):
              * DumpRenderTree/chromium/LayoutTestController.h:
              (LayoutTestController::setShowDebugLayerTree):
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::runFileTest):
              (TestShell::dump):
              * DumpRenderTree/chromium/TestShell.h:
              (TestParams::TestParams):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81094 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      55a0ae11
    • abarth@webkit.org's avatar
      2011-03-14 Adam Barth <abarth@webkit.org> · 75f7839e
      abarth@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Add remaining files to WebCore.gypi
              https://bugs.webkit.org/show_bug.cgi?id=56351
      
              Adding the remaining files to WebCore.gypi required updating the
              include/exclude lists in WebCore.gyp.  These lists aren't overly
              elegant, but we can try to improve them in the future.
      
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * bindings/v8/ScriptCachedFrameData.cpp:
                  - Added ifdefs to this file to match the header.
              * platform/graphics/WOFFFileFormat.cpp:
                  - Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER).
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81093 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      75f7839e
    • antonm@chromium.org's avatar
      2011-03-14 Anton Muhin <antonm@chromium.org> · a4283731
      antonm@chromium.org authored
              Reviewed by Adam Barth.
      
              [v8] Rework object group building.
              https://bugs.webkit.org/show_bug.cgi?id=55399
      
              Instead of going top-down (from owner to owned elements), go up---from objects
              to their group ids.  That fits better to v8's object grouping model and guarantees
              that each wrapper belongs to the single group.
      
              Alas, this cannot be implemented for one kind of objects---CSSProperties.
      
              Part of core GC algorithm and tested extensively by exisiting layout tests.
      
              * platform/chromium/test_expectations.txt: Temporary suppress text differences.
      2011-03-14  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Adam Barth.
      
              [v8] Rework object group building.
              https://bugs.webkit.org/show_bug.cgi?id=55399
      
              Instead of going top-down (from owner to owned elements), go up---from objects
              to their group ids.  That fits better to v8's object grouping model and guarantees
              that each wrapper belongs to the single group.
      
              Alas, this cannot be implemented for one kind of objects---CSSProperties.
      
              Part of core GC algorithm and tested extensively by exisiting layout tests.
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/V8/V8TestInterface.cpp:
              * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
              * bindings/scripts/test/V8/V8TestObj.cpp:
              * bindings/v8/V8GCController.cpp:
              (WebCore::calculateGroupId):
              (WebCore::calculateRootStyleSheet):
              (WebCore::GrouperVisitor::visitDOMWrapper):
              (WebCore::GrouperVisitor::applyGrouping):
              (WebCore::V8GCController::gcPrologue):
              * bindings/v8/WrapperTypeInfo.h:
              (WebCore::WrapperTypeInfo::isSubclass):
              * css/CSSRuleList.h:
              (WebCore::CSSRuleList::styleList):
              * css/StyleSheetList.h:
              (WebCore::StyleSheetList::document):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81092 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a4283731
    • luiz@webkit.org's avatar
      Skipping some tests on Windows due to problems on mouse click handling. · 75369f12
      luiz@webkit.org authored
      See https://bugs.webkit.org/show_bug.cgi?id=56347.
      
      * platform/win/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81091 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      75369f12
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · 374b8ee8
      rniwa@webkit.org authored
              Mac Leopard rebaselines for r81053 (Grabbed off of Chromium bots).
      
              * platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.checksum:
              * platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.png:
              * platform/mac-leopard/editing/selection/drag-select-1-expected.checksum:
              * platform/mac-leopard/editing/selection/drag-select-1-expected.png:
              * platform/mac-leopard/editing/selection/fake-drag-expected.checksum:
              * platform/mac-leopard/editing/selection/fake-drag-expected.png:
              * platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.checksum:
              * platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.png:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81090 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      374b8ee8
    • cfleizach@apple.com's avatar
      CrashTracer: 60 crashes in WebProcess at com.apple.WebKit2:... · 1d960aff
      cfleizach@apple.com authored
      CrashTracer: 60 crashes in WebProcess at com.apple.WebKit2: -[AccessibilityWebPageObject accessibilityHitTest:] + 248
      https://bugs.webkit.org/show_bug.cgi?id=56336
      
      Reviewed by Beth Dakin.
      
      Crash trace indicates a nil pointer access in one of these m_page->mainFrame()->coreFrame()->view()
      pointers.
      
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
      (-[AccessibilityWebPageObject accessibilityHitTest:]):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81089 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1d960aff
    • tkent@chromium.org's avatar
      Assertion failure by form validation message for <select required> with float:left · 2ee266e3
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=55995
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Test: fast/forms/interactive-validation-select-crash.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::canMergeContiguousAnonymousBlocks):
        isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().
      
      LayoutTests:
      
      * fast/forms/interactive-validation-select-crash-expected.txt: Added.
      * fast/forms/interactive-validation-select-crash.html: Added.
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81088 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2ee266e3
    • alice.liu@apple.com's avatar
      Provide API for creating WKImage from CGImageRef · a50849ef
      alice.liu@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56159
      
      Reviewed by Sam Weinig.
      
      Add function for creating a WKImage from CGImage data.
      * Shared/API/c/cg/WKImageCG.cpp:
      (WKImageCreateFromCGImage): Added. Creates a graphics context for the bitmap-backed image and draws into it. 
      * Shared/API/c/cg/WKImageCG.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81087 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a50849ef
    • ggaren@apple.com's avatar
      2011-03-14 Geoffrey Garen <ggaren@apple.com> · 03752250
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Made JSWrapperObject and subclasses moving-GC-safe
              https://bugs.webkit.org/show_bug.cgi?id=56346
              
              SunSpider reports no change.
      
              * runtime/BooleanObject.cpp:
              (JSC::BooleanObject::BooleanObject):
              * runtime/DateInstance.cpp:
              (JSC::DateInstance::DateInstance): No more need for JSGlobalData, since
              we don't initialize the wrapped value in our constructor.
      
              * runtime/DateInstance.h: Don't set the OverridesMarkChildren flag because
              we do not in fact override markChildren.
      
              * runtime/DatePrototype.h: Declare an anonymous slot, since wrapper object
              no longer does so for us. Also added an ASSERT to catch a latent bug,
              where DatePrototype stomped on its base class's anonymous slot. Hard-coded
              anonymous slots are a plague on our code. This doesn't cause any problems
              in our existing code since the base class never reads the anonymous slot
              it declares, but it caused crashes when I tried to start using the slot
              in an initial version of this patch.
      
              * runtime/JSWrapperObject.h:
              (JSC::JSWrapperObject::JSWrapperObject):
              (JSC::JSWrapperObject::internalValue):
              (JSC::JSWrapperObject::setInternalValue): Resolved a problem where
              our internal value was stored in two places: an anonymous slot, and a
              data member which was not always visited during GC. Now, we only use the
              data member, and we always visit it. (Instead of relying on certain
              subclasses to set the OverridesMarkChildren bit, we set it ourselves.)
      
              * runtime/NumberObject.cpp:
              (JSC::NumberObject::NumberObject): No more need for JSGlobalData, since
              we don't initialize the wrapped value in our constructor.
      
              * runtime/NumberObject.h: Removed meaningless declaration.
      
              * runtime/StringObject.cpp:
              (JSC::StringObject::StringObject): No more need for JSGlobalData, since
              we don't initialize the wrapped value in our constructor.
      
              * runtime/StringObject.h: Don't set the OverridesMarkChildren flag because
              we do not in fact override markChildren.
      
              * runtime/StringPrototype.h: Declare an anonymous slot, since wrapper object
              no longer does so for us. Also added an ASSERT to catch a latent bug,
              where DatePrototype stomped on its base class's anonymous slot. Hard-coded
              anonymous slots are a plague on our code.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81086 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      03752250
    • msaboff@apple.com's avatar
      2011-03-14 Michael Saboff <msaboff@apple.com> · 9aa7a0d0
      msaboff@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Look-ahead assertions with back references don’t work as expected
              https://bugs.webkit.org/show_bug.cgi?id=56082
      
              Changed parentheses assertion processing to temporarily back out the 
              number of known characters after the assertion while processing the 
              assertion.  This was done so that assertions don't fail due to 
              checking the number of required characters as additional to the 
              rest of the express since assertions don't "consume" input.
              Added a byte code to uncheck characters to support the change.
      
              * yarr/YarrInterpreter.cpp:
              (JSC::Yarr::Interpreter::matchDisjunction):
              (JSC::Yarr::ByteCompiler::uncheckInput):
              (JSC::Yarr::ByteCompiler::emitDisjunction):
              * yarr/YarrInterpreter.h:
              (JSC::Yarr::ByteTerm::UncheckInput):
      2011-03-14  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Gavin Barraclough.
      
              Look-ahead assertions with back references don’t work as expected
              https://bugs.webkit.org/show_bug.cgi?id=56082
      
              New tests to verify the corresponding changes.
      
              * fast/regex/assertion-expected.txt: Added.
              * fast/regex/assertion.html: Added.
              * fast/regex/script-tests/assertion.js: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81085 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9aa7a0d0
    • kbalazs@webkit.org's avatar
      2011-03-14 Balazs Kelemen <kbalazs@webkit.org> · cce1108b
      kbalazs@webkit.org authored
              Reviewed by Adam Roben.
      
              [Qt][WK2]Unbreak InjectedBundle on Qt
              https://bugs.webkit.org/show_bug.cgi?id=54109
      
              No code changes so no new tests.
      
              Revert the changes that were needed to use KURL
              in WebKitTestRunner.
      
              * Configurations/WebCore.xcconfig:
              * WebCore.exp.in:
      2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
      
              Reviewed by Adam Roben.
      
              [Qt][WK2]Unbreak InjectedBundle on Qt
              https://bugs.webkit.org/show_bug.cgi?id=54109
      
              Add API's to WKURL and WKString to satisfy
              WebKitTestRunner's needs.
      
              * Shared/API/c/WKString.cpp:
              (WKStringIsEqualToUTF8CStringIgnoringCase):
              * Shared/API/c/WKString.h:
              * Shared/API/c/WKURL.cpp:
              (WKURLCopyHostName):
              (WKURLCopyScheme):
              * Shared/API/c/WKURL.h:
              * Shared/WebString.h:
              (WebKit::WebString::equalToUTF8StringIgnoringCase):
              * Shared/WebURL.h: Added OwnPtr<KURL> member to be able
              to lazily parse the URL and store the result.
              (WebKit::WebURL::host):
              (WebKit::WebURL::protocol):
              (WebKit::WebURL::parseURLIfNecessary):
              * win/WebKit2.def: Revert the symbol exports that were
              needed to use KURL in WebKitTestRunner.
      2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
      
              Reviewed by Adam Roben.
      
              [Qt][WK2]Unbreak InjectedBundle on Qt
              https://bugs.webkit.org/show_bug.cgi?id=54109
      
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
              API's instead of KURL to analyze the URL.
              * WebKitTestRunner/StringFunctions.h:
              (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
              in the WebKitTestRunner project.
              (WTR::toWK): Use adoptWK.
              (WTR::operator<<): Added helper for printing a WKURL.
              * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
              against WebCore.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81084 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cce1108b
  2. 14 Mar, 2011 9 commits
    • levin@chromium.org's avatar
      It's the same old song (about the linux debug crash). · f54a6e72
      levin@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81083 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f54a6e72
    • jeffm@apple.com's avatar
      2011-03-14 Jeff Miller <jeffm@apple.com> · 677360be
      jeffm@apple.com authored
              Reviewed by Adam Roben.
      
              Add WKViewSetScrollOffsetOnNextResize() to C API on Windows
              https://bugs.webkit.org/show_bug.cgi?id=56340
      
              * UIProcess/API/C/win/WKView.cpp:
              (WKViewSetScrollOffsetOnNextResize): Added.
              * UIProcess/API/C/win/WKView.h: Added WKViewSetScrollOffsetOnNextResize().
              * UIProcess/win/WebView.cpp:
              (WebKit::WebView::onSizeEvent): Apply any scroll offset when setting the drawing area size.
              (WebKit::WebView::setScrollOffsetOnNextResize): Added.
              * UIProcess/win/WebView.h: Added setScrollOffsetOnNextResize().
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81082 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      677360be
    • commit-queue@webkit.org's avatar
      2011-03-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> · 5c7cd2f5
      commit-queue@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian.
              https://bugs.webkit.org/show_bug.cgi?id=56133
      
              Add condition to not compile webkit internal math round functions on RVCT compiler versions
              from 3.0.0 because they are already defined in compiler math library.
      
              * wtf/MathExtras.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81081 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5c7cd2f5
    • mrowe@apple.com's avatar
      Fix two memory leaks within LayoutTestController's storage support. · 385b541f
      mrowe@apple.com authored
      Reviewed by Adam Roben.
      
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
      by JSStringCreateWithCFString.
      (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
      allocate.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81080 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      385b541f
    • barraclough@apple.com's avatar
      Bug 56284 - Add a dataflow intermediate representation for use in JIT generation. · 5f079f65
      barraclough@apple.com authored
      Reviewed by Geoffrey Garen & Oliver Hunt.
      
      The JSC JIT presently generates code directly from the bytecode used by the interpreter.
      This is not an optimal intermediate representation for JIT code generation, since it does
      not capture liveness information of values, and provides little opportunity to perform
      any static analysis for even primitive types. The JIT currently generates two code paths,
      a fast path handling common cases, and a slower path handling less common operand types.
      However the slow path jumps back into the fast path, meaning that information arising
      from the earlier type checks cannot be propagated to later operations.
      
      This patch adds:
          * a dataflow intermediate representation capable of describing a single basic block
            of operations,
          * a mechanism to convert a simple, single-block bytecode functions to the new IR,
          * and a JIT code generator capable of generating code from this representation.
      
      The JIT generates two code paths, with the slower path not reentering the fast path
      mid-block, allowing speculative optimizations to be made on the hot path, with type
      information arising from these speculative decisions able to be propagated through the
      dataflow. Code generation of both speculative and non-speculative paths exploits the type
      and liveness information represented in the dataflow graph to attempt to avoid redundant
      boxing and type-checking of values, and to remove unnecessary spills of temporary values
      to the RegisterFile.
      
      The dataflow JIT currently can only support a subset of bytecode operations, limited to
      arithmetic, bit-ops, and basic property access. Functions that cannot be compiled by the
      dataflow JIT will be run using the existing JIT. The coverage of the dataflow JIT will be
      expanded to include, control-flow, function calls, and then the long-tail of remaining
      bytecode instructions. The JIT presently only support JSVALUE64, and as a consequence of
      this only supports x86-64.
      
      The status of the dataflow JIT is currently work-in-progress. Limitations of the present
      JIT code generation may cause performance regressions, particularly:
          * the policy to only generate arithmetic code on the speculative path using integer
            instructions, never using floating point.
          * the policy to only generate arithmetic code on the non-speculative path using
            floating point instructions, never using integer.
          * always generating JSValue adds on the non-speculative path as a call out to a
            C-function, never handling this in JIT code.
          * always assuming by-Value property accesses on the speculative path to be array
            accesses.
          * generating all by-Value property accesses from the non-speculative path as a call
            out to a C-function.
          * generating all by-Indentifer property accesses as a call out to a C-function.
      Due to these regressions, the code is landed in a state where it is disabled in most
      cases by the ENABLE_DFG_JIT_RESTRICTIONS guard in Platform.h. As these regressions are
      addressed, the JIT will be allowed to trigger in more cases.
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
          - Added new files to Xcode project.
      * dfg: Added.
          - Added directory for new code.
      * dfg/DFGByteCodeParser.cpp: Added.
      * dfg/DFGByteCodeParser.h: Added.
          - Contruct a DFG::Graph representation from a bytecode CodeBlock.
      * dfg/DFGGenerationInfo.h: Added.
          - Track type & register information for VirtualRegisters during JIT code generation.
      * dfg/DFGGraph.cpp: Added.
      * dfg/DFGGraph.h: Added.
          - Dataflow graph intermediate representation for code generation.
      * dfg/DFGJITCodeGenerator.cpp: Added.
      * dfg/DFGJITCodeGenerator.h: Added.
          - Base class for SpeculativeJIT & NonSpeculativeJIT to share common functionality.
      * dfg/DFGJITCompiler.cpp: Added.
      * dfg/DFGJITCompiler.h: Added.
          - Class responsible for driving code generation of speculativeJIT & non-speculative
            code paths from the dataflow graph.
      * dfg/DFGNonSpeculativeJIT.cpp: Added.
      * dfg/DFGNonSpeculativeJIT.h: Added.
          - Used to generate the non-speculative code path, this make no assumptions
            about operand types.
      * dfg/DFGOperations.cpp: Added.
      * dfg/DFGOperations.h: Added.
          - Helper functions called from the JIT generated code.
      * dfg/DFGRegisterBank.h: Added.
          - Used to track contents of physical registers during JIT code generation.
      * dfg/DFGSpeculativeJIT.cpp: Added.
      * dfg/DFGSpeculativeJIT.h: Added.
          - Used to generate the speculative code path, this make assumptions about
            operand types to enable optimization.
      * runtime/Executable.cpp:
          - Add code to attempt to use the DFG JIT to compile a function, with fallback
            to the existing JIT.
      * wtf/Platform.h:
          - Added compile guards to enable the DFG JIT.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81079 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5f079f65
    • levin@chromium.org's avatar
      Add more linux debug crashers to the sad list. · 2b78f3d5
      levin@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81078 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2b78f3d5
    • kbalazs@webkit.org's avatar
      2011-03-14 Balazs Kelemen <kbalazs@webkit.org> · 2c988bbe
      kbalazs@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
              https://bugs.webkit.org/show_bug.cgi?id=56321
      
              * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
              to the list of exceptions for WebKit2 C API headers.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81077 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2c988bbe
    • mrobinson@webkit.org's avatar
      2011-03-14 Martin Robinson <mrobinson@igalia.com> · df53884d
      mrobinson@webkit.org authored
              Update GTK+ pixel results after r81053.
      
              * platform/gtk/editing/selection/drag-select-1-expected.checksum:
              * platform/gtk/editing/selection/drag-select-1-expected.png:
              * platform/gtk/editing/selection/fake-drag-expected.checksum: Added.
              * platform/gtk/editing/selection/fake-drag-expected.png: Added.
              * platform/gtk/editing/selection/inline-closest-leaf-child-expected.checksum: Added.
              * platform/gtk/editing/selection/inline-closest-leaf-child-expected.png: Added.
              * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
              * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
              * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
              * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81076 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      df53884d
    • aroben@apple.com's avatar
      Show the list of recent leaky builds in reverse chronological order · b15b2069
      aroben@apple.com authored
      Previously they were being shown in a deterministic but surprising order based on
      lexicographically sorting the build offsets (-1, -10, -2, -3...).
      
      Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
      
      Reviewed by Darin Adler.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
      (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
      callback.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81075 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b15b2069