GitLab

The underlying infrastructure isn't ready for this to crash the GPU
process 30 times in a row. Change back to running this test once to
address continued flakiness on the bots.

BUG=365904
NOTRY=true
TBR=bajones@chromium.org

Review URL: https://codereview.chromium.org/252793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266315 0039d316-1c4b-4281-b951-d872f2087c98

Oops.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/257763009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266314 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces static initializers (the two
static const std::string Type constants).

Static strings should be declared as char * instead.

> 1. Handle the case of empty embedder_extension_id in    guestview.h.
> 
> 2. Introduce a template class GuestView<T> to handle the    *guestview-specific functions in guestview.h:
>    . Rename GuestView to GuestViewBase, introduce GuestView<T> class, and move *ViewGuest-specific functions to     GuestView<T>:
>         -- FromWebContents<T>(...)
>         -- From<T>(...).
>    . Introduce a template member function As() in      GuestViewBase to replace all of the As*View functions.
> 
> 3. In each derived *ViewGuest class , e.g., WebViewGuest &    AdViewGuest, define a static variable to show its view type    (string).
> 
> 
> BUG=351824
> 
> Review URL: https://codereview.chromium.org/237533008

TBR=hanxi@chromium.org

Review URL: https://codereview.chromium.org/252773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266313 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=earthdok@chromium.org
BUG=

Review URL: https://codereview.chromium.org/254773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266312 0039d316-1c4b-4281-b951-d872f2087c98

Assuming this might also fix 'Out of Memory' issue on Windows bisect bot
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/253573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/259503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266310 0039d316-1c4b-4281-b951-d872f2087c98

There're web apps served over HTTPS but are using insecure WebSockets.
To improve security, we're going to prohibit that, but should provide
an option to turn off the check until everyone finishes fixing their apps
to get ready for stopping use of insecure WebSockets from HTTPS origin.

The shield page action allows users to manually turn off mixed content
check, but for apps designed to open new windows frequently, this
workaround is too bothering.

So, we'll provide a chrome://flags item which turns off the mixed
content check (only for WebSocket). This flag is scheduled to go away
when everyone should be ready for accepting this security check.

This CL depends on this Blink side CL:
https://codereview.chromium.org/246893014/

BUG=85271

Review URL: https://codereview.chromium.org/248863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266309 0039d316-1c4b-4281-b951-d872f2087c98

Re removed touch resources, but didn't remove the code that changes the layout. This CL removed all touch layouts.

BUG=362633

Review URL: https://codereview.chromium.org/247193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266305 0039d316-1c4b-4281-b951-d872f2087c98

To be consistent with the rest of the artifacts in the component updater,
the non-blocking calls for the CrxDownloader take a callback to be called
when the non-blocking call completes.

This change allows adding further callbacks besides the completion
callback, such as a callback to be called when download progress is made.

This change is a pure refactoring and it should be a NOP in terms of
existing functionality.

BUG=366388

Review URL: https://codereview.chromium.org/250383008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266304 0039d316-1c4b-4281-b951-d872f2087c98

There is no need to explicitly check whether the profile is managed when
trying to start the TiclInvalidationService. The service will refuse to
start up anyway because managed profiles never have a signed-in account.

BUG=358696
TEST=Manual

Review URL: https://codereview.chromium.org/258503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266303 0039d316-1c4b-4281-b951-d872f2087c98

Merged devtools_android_bridge_browsertest.cc logic into adb_client_socket_browser_test.cc.
Made inspect_ui_browsertest.cc use MockAdbServer instead of a mock DeviceProvider.

BUG=None

Review URL: https://codereview.chromium.org/257563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266302 0039d316-1c4b-4281-b951-d872f2087c98

TSan is using instrumented libc++ now, so these false positives aren't reported anymore.

BUG=181502
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/257773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266301 0039d316-1c4b-4281-b951-d872f2087c98

Test videos can be found in chrome/test/data/extensions/api_test/cast_streaming/test_video_*fps.webm

Review URL: https://codereview.chromium.org/257703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:28303

Review URL: https://codereview.chromium.org/250863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266299 0039d316-1c4b-4281-b951-d872f2087c98

Causing failures in browser_tests.

R=rmsousa@chromium.org
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/256763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266298 0039d316-1c4b-4281-b951-d872f2087c98

2. Introduce a template class GuestView<T> to handle the    *guestview-specific functions in guestview.h:
   . Rename GuestView to GuestViewBase, introduce GuestView<T> class, and move *ViewGuest-specific functions to     GuestView<T>:
        -- FromWebContents<T>(...)
        -- From<T>(...).
   . Introduce a template member function As() in      GuestViewBase to replace all of the As*View functions.

3. In each derived *ViewGuest class , e.g., WebViewGuest &    AdViewGuest, define a static variable to show its view type    (string).


BUG=351824

Review URL: https://codereview.chromium.org/237533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266297 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254066

Review URL: https://codereview.chromium.org/253523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266293 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365663

Review URL: https://codereview.chromium.org/254523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342662
TBR=jiayl@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/252563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266291 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=jschuh@chromium.org, sievers@chromium.org

Review URL: https://codereview.chromium.org/256713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266290 0039d316-1c4b-4281-b951-d872f2087c98

There is now a limit on number of events per proto (AggregatedFrameEvent
and BasePacketEvent). There is also a limit on number of packets per
frame (i.e. number of BasePacketEvent in AggregatedPacketEvent). If
either limit is exceeded, a new proto will be created for that frame.

The underlying implementation of EncodingEventSubscriber is also
changed. When the internal map reaches a certain size, its old entries
will be transferred to a vector for storage. This is done to keep the
map small and lookup fast.

A proto will also be
transferred to storage if adding an event to it would result in
exceeding the limit stated above. The scheme is not perfect, but such
situation rarely happens in practice.

Also changed deserialization to be able to merge protos of the same
frame.

This is done to keep protos size in check. Also, LogSerializer will now
fail DCHECK if the protos exceed the maximum size 2^16 - 1. (Because
we encode size as 16 bits).


BUG=

Review URL: https://codereview.chromium.org/241833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266289 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/258563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266288 0039d316-1c4b-4281-b951-d872f2087c98

doesn't pass a third argument to chrome.send('removeException');

R=thestig@chromium.org
BUG=362362

Review URL: https://codereview.chromium.org/243803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266287 0039d316-1c4b-4281-b951-d872f2087c98

Linux Breakpad: Keep reading from the crash upload progress until a complete crash id has been received.

BUG=363660

Review URL: https://codereview.chromium.org/248653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266286 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266285 0039d316-1c4b-4281-b951-d872f2087c98

Chromium NaCl scripts now uses package_version to extract.

Now that we have split up the toolchain into multiple tars, we should
use the package versioning script to manage which tars to extract.
Unfortunately, currently the SDK uses different directory names compared
to what the NaCl toolchain directories normally use, so we also must map
and move the toolchain directories to the SDK ones.

BUG=365817
TEST= trybots

Review URL: https://codereview.chromium.org/249153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266284 0039d316-1c4b-4281-b951-d872f2087c98

wm.gyp:wm depends on aura.gyp:aura, so this ensures that any gyp
use_aura guards also guard wm.gyp. Also fix some toolkit_views/use_aura
gyp usage, and add mac stubs for ui/base/dragdrop so the gyp conditions
don't explode (they will be needed later).

BUG=366007

Review URL: https://codereview.chromium.org/248893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266283 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/250653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266282 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg@chromium.org
BUG=360204

Review URL: https://codereview.chromium.org/255603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266281 0039d316-1c4b-4281-b951-d872f2087c98

To use:
1) Run gyp with GYP_DEFINES="enable_resource_whitelist_generation=1", build.
2) Pipe the build output into find_used_resources.py to generate a whitelist.
3) Run gy with GYP_DEFINES="enable_resource_whitelist_generation=1  repack_options="--whitelist...", build.
4) Pipe the second build output into list_resources_removed_by_repack.py.

Requires grit-i18n r167 to generate the unused resource list in step 3.

BUG=338759
NOTRY=true

Review URL: https://codereview.chromium.org/248173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/259523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266278 0039d316-1c4b-4281-b951-d872f2087c98

As a preparation of thread migration from UI to a worker,
this CL moves the usage of ExtensionService in SyncWorker to UI thread explicitly.

BUG=347425

Review URL: https://codereview.chromium.org/246163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266277 0039d316-1c4b-4281-b951-d872f2087c98

This exports some functions used by tests to fix the following errors:

../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:115: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForHost(quota::StorageType, std::string const&, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'
../../content/browser/indexed_db/indexed_db_quota_client_unittest.cc:101: error: undefined reference to 'content::IndexedDBQuotaClient::GetOriginsForType(quota::StorageType, base::Callback<void (std::set<GURL, std::less<GURL>, std::allocator<GURL> > const&)> const&)'

TBR=jsbell@chromium.org
BUG=none
TEST=ninja -C out/Release aura_builder

Review URL: https://codereview.chromium.org/258893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266276 0039d316-1c4b-4281-b951-d872f2087c98

cleaning up : download, omnibox, settings_overrides, spellcheck, stream_private API.

BUG=354046

Review URL: https://codereview.chromium.org/244473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266275 0039d316-1c4b-4281-b951-d872f2087c98

If the App Launcher has already been installed, this change will have no
effect until chrome is run with the flags:
--reset-app-list-install-state --enable-app-list flags.

BUG=366445
TEST=Run chrome --reset-app-list-install-state --enable-app-list. Chrome
App Launcher shortut should be on "Internet" menu on desktop
environments with an applications menu (eg. Gnome Classic or Cinnamon).

Review URL: https://codereview.chromium.org/253403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367349

Review URL: https://codereview.chromium.org/259873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266273 0039d316-1c4b-4281-b951-d872f2087c98

Looks like perf --call-graph now requires an argument
in the most recent perf binary.  That's probably a bug
in perf, but moving back to -g for now.

I tried running the telemetry tests, but gave up
after several minutes of gorilla videos stealing focus from my browser.

I found
src/tools/telemetry/telemetry/core/platform/profiler/perf_profiler_unittest.py
but it didn't seem to attempt to test this code
(or have a recommended way for instantiating this kind of
PerfProfiler so I could call this instance method) so I
gave up on testing.

BUG=366928

Review URL: https://codereview.chromium.org/257463007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266272 0039d316-1c4b-4281-b951-d872f2087c98

chrome.test.fail cannot be used as ErrorCallback because it throws exception when the number of arguments doesn't match.
This wrong use of chrome.test.fail makes the error output useless when something goes wrong.

BUG=None
TEST=browser_tests

Review URL: https://codereview.chromium.org/258523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266271 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266270 0039d316-1c4b-4281-b951-d872f2087c98

The ui:: cursors constants like ui::kCursorIBeam are gfx::NativeCursors
on aura, but not other platforms.

This change introduces ui/views/native_cursor.h, which provides a set of
functions giving gfx::NativeCursor constants in a platform-independent
way.

BUG=366007

Review URL: https://codereview.chromium.org/248863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266269 0039d316-1c4b-4281-b951-d872f2087c98