- 11 Nov, 2019 38 commits
-
-
Gyuyoung Kim authored
This CL converts remained old Mojo types of WifiDisplayMediaServer interface to new Mojo types. Major changes are as below, - Convert mojom::WifiDisplayMediaServerPtr to mojo::PendingRemote|Remote<mojom::WifiDisplayMediaServer> - Convert mojo::WifiDisplayMediaServerRequest to mojo::PendingReceiver<mojom::WifiDisplayMediaServer> Bug: 955171 Change-Id: Ifd5c9f95eee9bcb505bf308f09ef6828d29bb276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896486 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#714161}
-
Kenichi Ishibashi authored
This is a preparation for moving ServiceWorkerDatabase to components/services/storage. Remove content/{common,browser}/service_worker dependencies. Also remove some third_party/blink dependencies. This CL doesn't have behavioral changes. ServiceWorkerDatabase and the corresponding proto file will be moved to the storage service in a follow-up CL. Bug: 1016064 Change-Id: Iae2b46353b1045239dfa247cc70a3b78698c2cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906861 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714160}
-
Keishi Hattori authored
This reverts commit 2de0ccb8. Reason for revert: Suspecting cause for screenshot test failure. Seems unlikely but this is the only color related CL in regression range. crbug.com/1023255 Original change's description: > Make use of new hex decoding function for extensions color string parser. > > Bug: 1021236 > Change-Id: I1d1b5180048eb36fa78406a02fc3277cba0dcf63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904809 > Commit-Queue: Eric Roman <eroman@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Auto-Submit: Eric Roman <eroman@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713942} TBR=eroman@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1021236 Change-Id: I474f4e07583f571722e4bacf28ae482c071276a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909669Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714159}
-
Abhijeet Kandalkar authored
This CL removes old downcast helpers generated by macro DEFINE_TYPE_CASTS.The primary goal of this CL is to use new downcast helpers implemented using C++11 type traits. Bug: 891908 Change-Id: Ib00118d7419f371124317376076772ef81d41580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906613 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#714158}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::IsLineBreak()| not to crash for non-text type for |NGFragmentItem| as |NGPaintFragment|. This patch makes following test to pass instead of crash: - editing/pasteboard/drag-drop-input-textarea.html - fast/events/remove-target-with-shadow-in-drag.html - http/tests/security/drag-drop-different-origin.html - virtual/mouseevent_fractional/fast/events/remove-target-with-shadow-in-drag.html Bug: 982194 Change-Id: Ib5656688308080e8aede3ca5ffabfa43e32f4019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909060 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714157}
-
Hitoshi Yoshida authored
Generates basic code for accessors of dictionary members. Bug: 839389 Change-Id: I710f090a0cd66bb9821bbe0274cce3f120a93e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900522 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#714156}
-
Findit authored
This reverts commit 5a2bf1a6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 714152 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVhMmJmMWE2MjJlNzVlNDgwNmMyNWFiM2FhOTNmNzQzOGJiZTFjYTcM Sample Failed Build: https://ci.chromium.org/b/8897108652777688192 Sample Failed Step: compile Original change's description: > bind-gen: Implement CodeGenContext.idl_location_and_name > > Implements CodeGenContext.idl_location_and_name in order to pretty- > print a path to an IDL file and IDL definition name being processed. > > Bug: 839389 > Change-Id: I2699f735fd5897206e25364b2b29932bd0177330 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909049 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714152} Change-Id: If40954d80e71c5b10e3e7729befa99ea04ae2447 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909715 Cr-Commit-Position: refs/heads/master@{#714155}
-
Hiroki Nakagawa authored
IsContextAlive() just checks ServiceWorkerProviderHost::context_, and is only called in ServiceWorkerProviderHost. It's not necessary to expose it as a public function. Bug: n/a Change-Id: I33f5b23c4f2bdaaffc7b8b45d99ee7cd84a13c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909053 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#714154}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Iaa5986929e5f758cf3f3ebfaae1a3dfdfb56df85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874996Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#714153}
-
Yuki Shiino authored
Implements CodeGenContext.idl_location_and_name in order to pretty- print a path to an IDL file and IDL definition name being processed. Bug: 839389 Change-Id: I2699f735fd5897206e25364b2b29932bd0177330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909049 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#714152}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ibb15a1d8d27474d0b46af42525958758cc4ac85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906850 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1012114 Test: Verify shutter for different capture mode. Change-Id: I272de6a89b02f72d087b95759ea32aa9d1d3538e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890518 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/56af378833d9..92338b81e5c4 git log 56af378833d9..92338b81e5c4 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 fancl@chromium.org SheriffRedux: Add a sample chromeperf-sheriffs.cfg for testing Created with: gclient setdep -r src/third_party/catapult@92338b81e5c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:953181 Change-Id: I5456e628a67b41d82e2dc79e47027bae58cac877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909271Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714149}
-
Hiroki Nakagawa authored
This CL adds WebFeature::kClassicDedicatedWorker and WebFeature::kModuleDedicatedWorker for WorkerOptions#type. These are recorded in following cases. (1) When a dedicated worker is constructed using classic scripts, kClassicDedicatedWorker is recorded: const worker1 = new Worker('worker.js'); // or const worker2 = new Worker('worker.js', { type: 'classic' }); (2) When a dedicated worker is constructed using module scripts, kModuleDedicatedWorker is recorded: const worker3 = new Worker('worker.js', { type: 'module' }); This CL adds web_tests for these cases. In addition to that, this CL adds tests for existing kWorkerStart and kNestedDedicatedWorker. kWorkerStart is recorded when a dedicated worker is constructed regardless of given options (e.g., 'type') and creator's execution context. kNestedDedicatedWorker is recorded when a dedicated worker is constructed from another dedicated worker: const worker4 = new Worker('nested-worker.js'); // In nested-worker.js const nested_worker = new Worker('worker.js'); Bug: 680046 Change-Id: Ic8aed3f9f43f6ceafeb5eac4a11382c7a21ea9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906855 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: -
Keishi Hattori authored
editing/input/edit-context.html is failing the leak test and needs to be fixed. TBR=yosin@chromium.org Bug: 1023242 Change-Id: I43353324f089f1c1dac80691bde9b295ee40f555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909056Reviewed-by:
-
Yuzu Saijo authored
This CL removes comment for a closed bug. As the bug comments concluded, rfh look up is always safe with render process id and frame id. Thus, we do not need this comment. Bug: 1012238 Change-Id: I3b21ca1faca405a40f3ec7ca5c1b64d410d91592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909054 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Auto-Submit: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Keishi Hattori authored
This reverts commit 74a8f73b. Reason for revert: PageLoadMetricsBrowserTest.PaintInMultipleChildFrames failing on many bots crbug.com/1023235 Original change's description: > Measure FCP of third-party iframes > > What: Measures FCP of third-party iframes on pages. Note that this > will be a bit wonky at times, as lazy-loaded frames will have a very > long FCP. > > Why: So that we can measure the impact of triple-keying the cache on > loading subframes. > > How: Added a third_party_metrics_observer metric. The class records > third-party origin iframes FCP and remembers that the RenderFrameHost > has been recorded so that it's not recorded again. > > Change-Id: Ib4b053eee81210a5ea0a2fec167d4f5995e29967 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890996 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: John Delaney <johnidel@chromium.org> > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714024} TBR=jkarlin@chromium.org,csharrison@chromium.org,johnidel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iad78d3fd005a14486a9e98bfff8935cf599bf0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906860Reviewed-by:
-
Leon Han authored
mediaType does not make any sense for other record types. The spec change: https://github.com/w3c/web-nfc/pull/419 BUG=520391 Change-Id: Icf077c2fea64364f9a799a08d3aa630531590b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900670 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#714144}
-
Noel Gordon authored
SVGO optimize the external link svg, and place it in a 16x16 icon set so it can be used in an <iron-icon icon='files16:external-link'>. Change AndroidAppItem (the only user) to add external link as a child <iron-icon> of the externalLinkIcon container. Update CSS to style the <icon-icon> 16 x 16px, centered in its parent 40 x 40px externalLinkIcon container. Remove external_link.svg file (no longer used). Bug: 992819 Change-Id: I9430848b2f8a3ce9f9d3e4a8f1c9233847ee5921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906853Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#714143}
-
Keishi Hattori authored
This reverts commit 79e07a5d. Reason for revert: crashing unittest GLRendererTest.DontOverlayWithCopyRequests crbug.com/1022911 Original change's description: > viz: Use Build Flags to Maintain A Single Overlay Candidate Type (Reland) > > For each platform, we only use one overlay candidate type. Use build > flags to manage that. This also helps unify different platforms' > ProcessForOverlay API. > > This CL is a kindred spirit with crrev.com/c/1664476, but is rebased on > top of ToT and crrev.com/c/1739980. This is CL 2/? for the overlay > processor refactor. > > R=rjkroege > > Bug: 963597 > Change-Id: I3a560bf8da3c8e86227cb7c43d15ba4c437b8764 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753810 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713453} TBR=rjkroege@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963597 Change-Id: I0a8923bb67d6889b630c967dad6f4a15e4162649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906859Reviewed-by:
-
Christian Biesinger authored
Speculative fix for bug 1023155. Bug: 1023155 Change-Id: Iba77dae882798f2de9dc6c9adfd1346a8f6138c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908059 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#714141}
-
Alan Cutter authored
Bug: 926083 Change-Id: Ibb961ead98be58a3cb9079ca5bf8edf0e86001fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905293 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#714140}
-
Yuki Shiino authored
Accepting None is must-have to support the following use case. seq.extend([ make_maybe_empty_code_node1(...), make_maybe_empty_code_node2(...), ]) Bug: 839389 Change-Id: Ib5b8b5f907d84e7e62b16be2213df8a602b6d0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906689 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: -
Simeon Anfinrud authored
These asserts are no longer actively being used for debugging. When this is compiled on the Android component build, the linker cannot find the extern bool declared by another shared library. This patch disables the InProcessRenderThread checks, which were intended for debugging in production, so that developers can at least attempt to use the component build on Android. Bug: Internal b/64440217 Bug: 514141 Test: chromecast internal Android component build Change-Id: Iac24c87867e218f98c130677e6baff9142a7fe84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898812Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714138}
-
Chih-Yu Huang authored
This CL fixes a compilation error in image_processor_test.cc. Bug: none Test: ninja image_processor_test Change-Id: Ic73e3beb7639a585918184219a1141772252bb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906857 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714137}
-
Stephen Chenney authored
Bug: 1021164 Change-Id: Ifc640896eae412c09cddb3bb70b694cca7e078a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899748 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#714136}
-
Dominic Farolino authored
The V8 CL (crrev.com/c/1902968) fixing console's table and dir method lengths has been rolled into Chromium, so this CL re-enables the tests and removes the IDL expectations now that the tests pass. Bug: 948678 Change-Id: I9fd1719fdc7382747c017876740df5e15c81b18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904335 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#714135}
-
Yuki Shiino authored
The |renderer| argument was introduced in the very early design, but it turned out that it's not often used (except for testing). This patch removes the argument and simplifies CodeNode and its subclasses. Bug: 839389 Change-Id: I434a13f5c4fd6bdc9cdf93ae50ec734f60359d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906611 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
nancy authored
BUG=1011235 Change-Id: Ib717d59170c30ada1613ee2b485d44c961fefa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906852 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#714133}
-
tby authored
We still have one user report that isn't showing zero state files, and this is suspected to be because of a bad model that was saved to disk early in development. This CL prevents loading models on dev, which will help debug the issue. This code will be removed as soon as we have finished debugging. Bug: 955893 Change-Id: Ifef902e98919d166135127c2d8c140743ca5094e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898896Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#714132}
-
Dominick Ng authored
This addresses a bug where visible icons for ARC++ apps "blink" when ARC++ finishes booting after a Chromebook is restarted. BUG=1022847 Change-Id: I563939f0dac0f8c1df1192e90dd5ac15684e0b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906687Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#714131}
-
Timothy Loh authored
Change-Id: Iac811e43639f72801b2de59bfeaaf0ba1b6a66c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905292 Auto-Submit: Timothy Loh <timloh@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#714130}
-
Meredith Lane authored
This change now migrates the existing accessibility code to rely on the attr-associated-elements set via the content attribute or IDL attributes. Followup work to: https://crrev.com/c/1687013, https://crrev.com/c/1781917 Bug: 981423 Change-Id: If004f20d67ec6795ed3e0b54a73ff6999aed0af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826397 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#714129}
-
Yuki Shiino authored
"CodeGeneration" was a bit too long name and space consuming in code. This patch shorten the names. Bug: 839389 Change-Id: Ie1dae9d778c65aa7bb823675f530af7a48a2c6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906688 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia4102c93a9faaf4643448063cfce9c40c21dfc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909451Reviewed-by:
-
Meredith Lane authored
In order to comply with the current version of the spec, elements are no longer validated on retrieval or getting. This means that explicitly set elements are still able to be the attr-associated-element, even if they have been moved into an invalid scope, such as a deeper shadow root, or a different tree scope or removed entirely. This is likely to change in future, but as the spec is still being actively discussed it is better to comply with the current version. BUG=981423 Change-Id: I496c06cfad5f056c49dedb3e9821781c755538b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898889Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#714126}
-
Fergal Daly authored
This is a reland of d6cbc51d. Landing this unblocks others to use this new times. The difference with the reland is that it disables BackForwardCacheBrowserTest.SubframeWithNoStoreCached on win. The cause of the 20ms difference in timestamps is unknown but seems likely to just a platform-difference between linux and windows that just impacts this test. We will investigate that later. The test can be seen failing in patchset 1 (no diff vs the original change) on the win_chromium_dbg_ng trybot and then passing in patchset 2 (both runs have problems with infra and tests that seems entirely unrelated, they are runs 2536 and 2537 on https://ci.chromium.org/p/chromium/builders/try/win_chromium_dbg_ng and they are preceded by a lot of other failures, all that matters to us is the result of this 1 test) Original change's description: > bfcache: Save back-navigation's navigationStart in pageshow event's timestamp > > When a page is restored from the back forward cache, there is > currently no way to know its navigationStart time since we aren't > updating performance.timing.navigationStart (which is undesirable), > even though users of bfcache might want to know the navigationStart > time to measure latency. To solve this, we are modifying the > pageshow event’s timeStamp to correspond to the navigation start of > the history navigation. Note as event.timeStamp is defined as time > elapsed since the beginning of the document lifetime [1], this is > effectively the difference between the initial navigationStart and > the navigation start of the last navigation. > > [1] https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp > > Note that we are only updating this for pageshow events for pages > that were persisted (restored from the back forward cache). > > For more background, see doc at https://docs.google.com/document/d/1XlZhphHW-bNcUPD98T-rfTa-TASI-3xUtxZzThZLJCA/edit?usp=sharing > > Change-Id: I81e399492eaa377ac56c4325e3134b1ff50ae451 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888627 > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Auto-Submit: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Fergal Daly <fergal@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713147} BUG=1022191 Change-Id: Ia916db46c6b5245d22a184d169c94fc0a58bfc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903185 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#714125}
-
Anand K. Mistry authored
When mounting SmbFs through cros-disks, there is currently no ability to pass a file descriptor (eg. for a socket) over the D-Bus Mount() method. Instead, a random string is generated and provided to SmbFs as part of the mount source path. SmbFs will then generate a socket pair and pass one end back to Chrome, along with the random string as an identifier, through this D-Bus service. This service is an exact duplicate of org.chromium.DriveFileStream. Bug: 939235 Change-Id: Ideaec725a50ab7a1dba6e11b152fb08280c3a75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890378Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#714124}
-
- 10 Nov, 2019 2 commits
-
-
Avi Drissman authored
The automatic creation of the distribution XML file yielded a file that when installed was missing user-visible strings. Bug: 1022413 Change-Id: If2ad9bfb1305d2dcd58b6a04d25aa0130216b25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906949 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714123}
-
Chris Mumford authored
Code using testing::CreateFunctor and testing::CallbackToFunctor is usually more easily read if they used C++ lamdas instead. This also avoids the situation where some closures needed to use BindOnce where others BindRepeating. Finally this eliminates a GN dependency issue identified in issue 806952. Bug: 1007833, 806952 Change-Id: I43d103b038465501019b68a3350d1a528d5686cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908708Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#714122}
-
