- 24 Jul, 2019 40 commits
-
-
chrome://webapksckitagawa authored
If a WebAPK isn't backed the browser visiting chrome://webapks then manually triggered updates will not work. To mitigate confusion, the package name of the browser that owns the WebAPK is now displayed. Additionally, an alternate update status message is provided indicating to the user that Chrome doesn't own said WebAPK. Bug: 918898 Change-Id: I6edd05b49e67b01e56caaee6f22d93ae748ba650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710272Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#680548}
-
Ryan Hansberry authored
When scanning begins, a yellow icon with the tooltip "cannot connect..." briefly pops up and is then replaced again by the spinner. This CL prevents that visual jank by making sure |is_performing_initial_scan_| is set to true before fetching lock screen state. Bug: 890047, 921766 Change-Id: Ib41d4744f1eddcb510497b303a8a220716123f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716156 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680547}
-
Vlad Tsyrklevich authored
This is a reland of 5bbaab09 with crashpad_tests disabled on the Linux CFI bots. Original change's description: > Add crashpad_tests to the Linux bots > > crashpad_tests should work on Linux and will help keep MSan, among > other tests, from regressing. > > Bug: 932205 > Change-Id: I488a0c6e0f3c1d51021b4ed7312ab703c53bae92 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684301 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678539} Bug: 932205 Change-Id: I65f42743372e9d3e25d95dfe2e52aef28e862a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716951Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#680546}
-
Guillaume Jenkins authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/1706574 introduced a crash by missing a null check in the case where the OS fails to construct the native spellchecker object. This CL adds null checks in 2 places: 1) Where the null pointer was being dereferenced, to future-proof the method where the crash was actually happening. 2) In the telemetry code path before attempting to use the native spellchecker, since there's no point trying to record native spellchecker data if the native spellchecker doesn't exist. Bug: 987025 Change-Id: I80d289f9299d951a7951a321237a48399587b89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715600Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#680545}
-
sczs authored
- Uses NamedGuides on SnackBarCoordinator to calculate the bottomOffset to present a Snackbar. - Changes the Bookmark Added snackbar so it uses the SnackBarCoordinator and doesn't call MDCSnackbarManager showMessage directly anymore. - As a followup CL I'll make all instances of direct calls to showMessage to use the SnackBarCoordinator. Screenshot: https://drive.google.com/open?id=1EaVLsAfuKuwzB7n2uqJ31-d0_7TJiFh7 Bug: 804656 Change-Id: I3fc50e460b4ddce2157e6215f8d7b19bb8efb071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710857Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#680544}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f640b87f1c64..97321b687b38 git log f640b87f1c64..97321b687b38 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 srte@webrtc.org Adds test for experimental remote estimate SDP negotiation. 2019-07-24 orphis@webrtc.org Don't crash when simulcast layer count is different from RID count 2019-07-24 alessiob@webrtc.org Fix rtp_analyzer tool 2019-07-24 eshr@google.com Report congestion window updates on GoogCC time updates 2019-07-24 orphis@webrtc.org Add a field trial for older applications to reduce the simulcast layer count Created with: gclient setdep -r src/third_party/webrtc@97321b687b38 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I89ed008e12ab07e5098a4e83af57fbec20442c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716596Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680543}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fdf4bfe6d389..fb9acba203f7 git log fdf4bfe6d389..fb9acba203f7 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 brianosman@google.com Skip compositing_images benches on GTX660 and Nexus5x Vulkan Perf bots 2019-07-24 halcanary@google.com experimental/editor: Find nearest possible cursor position when click in whitespace Created with: gclient setdep -r src/third_party/skia@fb9acba203f7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I00dfb3937472509280da92c464051e845a8d98ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715162Reviewed-by:
-
Tanmoy Mollik authored
Update "No Thanks" to "No thanks" per Android UXW style. Bug: 986687 Change-Id: I43bf4a607147423d04873e2aa55a3b9135a3507a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715277Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#680541}
-
Vincent Boisselle authored
Summary of changes: * Piped demographic metrics provider with chrome browser (iOS + others). * Expose user demographics from DemographicMetricsProvider. TBR=treib@chromium.org Bug: 979371 Change-Id: Ib0d1eff9b767cf121fe768a9a46a3ff1fb57dd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687019 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#680540}
-
Wojciech Dzierżanowski authored
Change-Id: I352b0f8bf7f5206fc5846268dcb580b921d4f8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712566 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#680539}
-
Joel Einbinder authored
Local network overrides was turning off automapping, but automapping is needed for snippets to work. Bug: 980083 Change-Id: I90b7043eb7a0ca7e1b8a280e3a5c569d527d2b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713464 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#680538}
-
Simeon Anfinrud authored
This avoids a crash-on-first-boot on some emulators. Bug: Internal b/138228866 Test: install apk on N emulator Change-Id: Ieaf74fffcda20d96ffbc30c1180a137e0a970bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715587Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680537}
-
Nick Burris authored
Only activate the text fragment anchor if the navigation was initiated by the user or browser. This adds a is_browser_initiated bit to CommitNavigationParams to plumb the browser_initiated_ state from the browser to the renderer. Also added TextFragmentAnchorBrowserTests, testing that both user and browser initiated navigations can activate the feature. Bug: 924966 Change-Id: Id262eb6967e0109a06739a27b012466031bbd74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638288Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#680536}
-
Sinan Sahin authored
Bug: 971514 Change-Id: I33ea4ae13e30a6a7e8b25f488d71141c7e8bde7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704855 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#680535}
-
Jordy Greenblatt authored
The enum for the WebUI.Settings.PathVisited histogram recording the visit count for each settings route had two major issues: (1) Almost all of the site settings routes were labelled incorrectly (2) It didn't include several recently added routes, in particular those added as part of the browser/OS settings split (bug 950007). To deal with (1), I replaced all the incorrectly labelled site settings routes with the correct labelling. Generally this meant appending the string '/content' to the beginning of the label because the old label ignored Route.createChild() method's handling of paths that do not start with a slash [1] (the labels just added a slash at the beginning). I dealt with (2) by searching as described in the bug [2] for a comprehensive audit of relevant routes. The search turned up three routes that I believe came from changes that have been migrated away: (1) /help/management (2) /manageAccessibility/tts/googleTtsEngine (3) /parentalControls Because there is little cost to adding a couple unused values, I added them in Patchset 3 in case they are relevant for some edge case. If we need. to remove them again, I can revert it to the state of the CL in Patchset 2. NOTE: The hashes came from following the instructions in [4], following the approach of [5]. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/route.js?rcl=9e4613082bd9a9972a6f5d21cb10f729fe1210bb&l=169 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=952472#c9 [3] https://uma.googleplex.com/p/chrome/histograms/?sid=7c5a1f5262a2ec196167d4546f6448af [4] https://gist.github.com/danbeam/d5fe7b1bcfebc9a94d60c9975b842e97 [5] https://chromium-review.googlesource.com/c/chromium/src/+/1089716/ Bug: 952472, 950007 Change-Id: Iea237f3f7285e520a3ed96f12abeed24911d653b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716215Reviewed-by:May Lippert <maybelle@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#680534}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46593a3742be..42937674ae09 Created with: gclient setdep -r src-internal@42937674ae09 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: None Change-Id: If5639b7a1e0442635eed348541f3ee02f39a1dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716597Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680533}
-
Yuke Liao authored
This CL uses clang coverage instrumentation on linux-rel and turns it off on linux-coverage-rel. Bug: 930364 Change-Id: I1a251a70ede8e4cc9567cbbcab715e0cc5cd2fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709091Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#680532}
-
Rayan Kanso authored
Add a new material UI icon: - https://material.io/tools/icons/?icon=schedule&style=baseline The UI is hidden behind an experiment flag. Screenshot: - https://bugs.chromium.org/p/chromium/issues/detail?id=986437#c1 Bug: 986437 Change-Id: I744df74453e887e2ba61877b5e9e05ef2166add7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713505Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#680531}
-
James Cook authored
This reverts commit ccd95c55. Reason for revert: PM/UX now wants the search engine select menu back in OS settings. We are also changing the section name back to "Search and assistant". Original change's description: > UX updates to OS settings search/assistant section > > Latest revision to PRD specifies: > * Rename section to "Assistant" > * Remove the search engine link to browser settings > * Hide the whole section when assistant isn't available > > See bug for screenshots. > > This CL plumbs "showAssistant" from settings UI to main to page > similarly to how showApps is handled. > > TODO: Once we're sure there won't be other search settings here, > rename the files/section to "os_assistant_page". > > Bug: 960937 > Test: manual on device (with assistant) and on linux-chromeos (without) > Change-Id: I97e4409f6751123bad2ce364230adb17e7d7e9ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650525 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667371} TBR=jamescook@chromium.org,xiyuan@chromium.org Bug: 960937 Change-Id: I8c1a0a34b95beff0dab2f701d9a7d36976dc5d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716965Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#680530}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ec63fbe9c453..ec3039253ab8 git log ec63fbe9c453..ec3039253ab8 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 srisser@google.com Allow the default framebuffer to be an IOSurface Created with: gclient setdep -r src/third_party/swiftshader@ec3039253ab8 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I0b9e359ef9f04172bdb86488480a4603ccf1b68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717084Reviewed-by:
-
Kristi Park authored
Add user actions for clicking on the shortcut options. Bug: 953822 Change-Id: I57835f812a7bf3d5dab6da2e311e25266ad7d263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716152 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#680528}
-
Varun Khaneja authored
R=holte Bug: 975690 Change-Id: I96b102e87aed8b58e8229640fa7ef1ba56fdb7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715579 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#680527}
-
Will Cassella authored
VR mode does not support keyboard accessories, so they should be disallowed from appearing while in VR. This CL adds a check to do that. Bug: 983649 Change-Id: I3fa80224214654060c28ef000bfe5b30ccf82212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707428Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#680526}
-
Anupam Snigdha authored
There were way too many nested if statements which was really confusing and also harder to debug. This change just simplifies it by separating the conditions and have fewer nested ifs. Change-Id: I909c3dcdeab6366140cafe5250e016121e8c8cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716162Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#680525}
-
Xiaohui Chen authored
Bug: None Test: unittests Change-Id: Ia0dd24b72d0ad3d1eebcdd33b1124c97e4ee4365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716170 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680524}
-
Nicolas Ouellet-payeur authored
This CL deleted the annotation, but didn't update annotations.xml due to a broken presubmit check: https://chromium-review.googlesource.com/c/chromium/src/+/1715105 TBR=rhalavati@chromium.org Bug: 949382 Change-Id: I14d17d5323f1199a61ce43f80d339bfa9b695125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716034Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#680523}
-
Weiliang Chen authored
For each platform, we only use one overlay candidate type. Use build flags to manage that. This also helps unify different platform's ProcessForOverlay API. R=rjkroege Bug: 963597 Change-Id: Icf0de8b30928cb4e7c23a3573eb46591191fb804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664476 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#680522}
-
Shimi Zhang authored
WebContents#postMessageToFrame is only used to post message to main frame, all the call sites passed the |frameName| = null. The internal implementation of native MessagePortProvider::PostMessageToFrame is not for all frames either. Renamed postMessageToFrame to postMessageToMainFrame to make that explicit and get rid of the |frameName| parameter. Bug: None. Change-Id: Ib31bf02ad131bc91d10b8936c51e54a03fdf9ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711053Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#680521}
-
Felicia Lim authored
Apply patch from https://git.xiph.org/?p=opus.git;a=commit;h=812ae3fb5c589aaafe761b8ebf86bcbbb8f0ed76 Bug: 946351 Change-Id: I55f2abb3950ff86780a68ef7ee8d28e142c0fd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713325Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#680520}
-
Kyle Milka authored
Bug: 984752 Change-Id: Ibaadf54deaad6078beef2812bfcb84883c82aeb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713296 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#680519}
-
Tim van der Lippe authored
The original behavior of build_debug_applications.py was to traverse all files recursively in the front_end folder and symlink each individual file to the version in third_party/blink/renderer/devtools/front_end. However, this requires rebuilding of Chrome when new files are added to the application. After this CL, the developer experience is more What-You-See-Is-What-You-Get. This CL is also in preparation to remove the logic in C++-land to remove the need for a separate debug folder. A follow-up CL will change the behavior of `debug_devtools` to symlink directly into out/[NAME]/resources/inspector, rather than an explicit sub-directory. As a nice side-effect of this change, we are no longer symlinking the debug folder for every version of the application. Previously, it would iterate through all `application_names` and symlink the full debug folder. This is time-consuming and did not provide any actual benefit. Since we now symlink directly to the local version, we no longer need to build the HTML files directly. Bug: 986365 Change-Id: I7e54ac3af57e0a3941b88a46b71b3ddacd5664f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713344Reviewed-by:
-
Miguel Casas-Sanchez authored
This CL adds a TRACE to measure the time it takes between having an encoded chunk consumed by the VD and the associated VideoFrame being produced, at the level of the MojoVideoDecoder Client (renderer process). Bug: 950183 Change-Id: Ieaa86ee3210fa5ad84d30db4511bf67f4713671e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715231Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#680517}
-
Aleks Totic authored
Update failing tests Remove FlagExpectations/enable-blink-features=LayoutNG Change-Id: I3f096d78a51c22e7a77abd971b9fadfca81179f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714485 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#680516}
-
Yuwei Huang authored
gTalk used to distinguish between gmail and non-gmail accounts, so we hae a host_owner field to track the XMPP JID and a host_owner_email field to track the user's actual email address in the host config file. This logic is no longer needed after the signaling migration since FTL uses the user's actual email address for message routing even for non- gmail accounts. This CL simplifies the host code to only keep track of the host owner's actual email. In the future we should also update the website to always write the user's email address to host_owner and stop writing host_owner_email. Bug: 983282 Change-Id: Ia70f51a9340c01771c84b37fbe0c312bec9a4141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716093 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#680515}
-
Wez authored
Bug: 986544 Change-Id: I2ae6d3198a5ec362aa60aa4e76eba86df49f21b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715762 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680514}
-
Natalie Chouinard authored
These calls to addPreferencesFromResource were moved into onCreatePreferences in https://crrev.com/c/1707429 and https://crrev.com/c/1706540. Moving them back to their original methods, respectively, because the delay between adding and removing preferences was causing animation jank. onCreatePreferences is abstract in the base class, so it is still overridden here with a comment only. Bug: 985734 Change-Id: I53110f199b8fe39ad255273059cd4aee0a7ac83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710806Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#680513}
-
Shakti Sahu authored
Change-Id: I262b617cb35221db0f7dbae73b03502bf6257341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676946 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Jacob DeWitt authored
This code was previously in XRSession and would call many methods on an XRInputSource object. Now, they are methods on the XRInputSource class. XRSession still needs pass-through methods such as OnSelect since the spec defines those event handlers on XRSession. Bug: 974912 Change-Id: Iacd407828faa7fc26dc50db7dc1c4b03bbf10488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716103 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Auto-Submit: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#680511}
-
Sebastien Marchand authored
Bug: 915714 Change-Id: I5fdd7b9a10bd2d8c9ada4f01f12a6a54d21040a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709072Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#680510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1fee49ba988e..b88be03bab49 git log 1fee49ba988e..b88be03bab49 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 yueherngl@google.com jacuzzi: add signing for factory shim Created with: gclient setdep -r src/third_party/chromite@b88be03bab49 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I722c2fdafa7cb6fd954797bb09064dcea6b4cf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716986Reviewed-by:
-
