- 01 Jul, 2020 15 commits
-
-
David Bienvenu authored
Restoring the session should obviate the need for retaining the initial url argument. Also remove the flag switches and their sentinels, because the flag switches will be added by Chrome on restart. Bug: 964541 Change-Id: I70d32c630565ce6f636d18e09b784016eef14d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249379 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#784235}
-
Christopher Cameron authored
Textures that are uploaded as GL_LUMINANCE_ALPHA, GL_LUMINANCE, or GL_ALPHA, are, on some platforms, emulated using glTexParameteri with GL_TEXTURE_SWIZZLE_R/G/B. The call to glTexParameteri needs to be done after the glTexImage2D call that uploads the pixel data. Do this. Remove swizzle from the common parameters because GLImages don't support the formats that require swizzles. Add a DCHECK in case we're trying to do that anyway. Bug: 1096361 Change-Id: I0b58a7ccb803108d0b3b0c43a68a6709d869aea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276578Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#784234}
-
Joshua Bell authored
In the spec[1], a new decoder is created unconditionally on each call to decode() unless the previous call passed {stream:true}, but in the real world that requires an allocation of a TextCodec object. Since the previous TextCodec would be flushed by the previous decode() call *unless* {stream:true} was passed, then we don't need a new TextCodec to match the spec behavior. On a simple test (64k strings, length 16-32, 50 iterations), the change showed an 11% performance improvement (with a standard deviation of 1.3% over 10 runs). [1] https://encoding.spec.whatwg.org/#dom-textdecoder-decode Bug: 1092582 Change-Id: I815a3e4c2885397aaf24ef790b7470c7ed761ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271061 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#784233}
-
Gavin Williams authored
Only use red font when the currently selected destination is a local Chrome OS printer since only local Chrome OS printers display status errors. Bug: 1059607 Change-Id: Ie0462f57f09b8651735bb6c9878946090198ddb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274184 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#784232}
-
Alex Moshchuk authored
In https://crrev.com/c/2250945, we will stop swapping BrowsingInstances on eligible browser-initiated navigations when the affected RenderFrameHost has not committed a navigation, since this is wasteful and prevents the spare process from working correctly with NTP. This affects expectations for some tests which had been relying on this behavior implicitly on Android. This CL adjusts these expectations. Bug: 1094088 Change-Id: I8db951b0194a80c2c9059a0ed81f4570ed4cedb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275146Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#784231}
-
Jimmy Gong authored
- Polymer3 does not require html files in its build resources. - Streamlined adding new resource files for print management. Bug: 1053704 Change-Id: If9c993aec0380315058296cfc83f90623e5b5871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259137 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#784230}
-
David Black authored
This CL also moves the AssistantOnboardingMode enum to be consistent with ConsentStatus. Bug: b:157510970 Change-Id: Ib92e56850cd2f62a073e1927eb9eaadfd390cc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262452 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#784229}
-
Wenbin Zhang authored
The following 6 stories are consistently failing on perf waterfall: * v8.browsing_desktop-future/browse:tools:gmail-labelclick:2020 * v8.browsing_desktop-future/browse:tools:gmail-openconversation:2020 * v8.browsing_desktop-future/browse:tools:gmail-search:2020 * v8.browsing_desktop/browse:tools:gmail-labelclick:2020 * v8.browsing_desktop/browse:tools:gmail-openconversation:2020 * v8.browsing_desktop/browse:tools:gmail-search:2020 This CL disables those stories for now. Bug: chromium:1100138 Change-Id: I372b37eca788aa55a4fa351927fc12fe8931a95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276299Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#784228}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d5b5215a888d..8d3f3b7dac48 2020-06-30 johnkslang@users.noreply.github.com Merge pull request #2302 from KhronosGroup/fix-texture-precision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I98dd45347e8ae3bc39d3d65e82b10fe119ab1a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277022Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784227}
-
dpapad authored
Unlike the old implementation, this one leverages Polymer bindings to hide/show toolbar children, while the document transitions from loading to loaded. Fixed: 1100430 Change-Id: I0d54c69c45687295ad309c9215a6b7d38dcbfd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274861 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#784226}
-
Forrest Fleming authored
Match the rule used in other Google open source projects described at https://opensource.google/docs/thirdparty/documentation/#owners: the first lines in the OWNERS file are * Two committers, OR * A file: directive pointing to another OWNERS file in //third_party (Copied by jrn@ from an internal CL making the same change; fleshed out the commit message.) Change-Id: I4e031684941e90a5d9257d053ca0d36d7da6f67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276813Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#784225}
-
Junbo Ke authored
Bug: internal b/144557463 Bug: 1101110 Test: Build Change-Id: I39549934fb7234b58c664337acd05232d60d0875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265434 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#784224}
-
Abigail Klein authored
Object attributes on text, such as text-align, margin-left, and text-indent allow JAWS to know what the current indentation level is in VSCode. Firefox already exposes them. This CL is part of an effort to expose these object attributes. AX-Relnodes: Expose text-align object attribute to IA2. Bug: 1090995 Change-Id: I88d3ff47e74a9f9d267c952348c655678b72c919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264456 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#784223}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d014422b2085..af04ef2a7d2e 2020-06-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I7d50d2f726e5b8d812c8eb5c74a7dce3375fcfce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277020Reviewed-by:
-
Kenichi Ishibashi authored
ServiceWorkerCacheWriter doesn't use ServiceWorkerResponse{Reader,Writer} any more. Update mock reader/writer to remove implementations for old reader/writer. Mock reader/writer are renamed to ServiceWorkerResource{Reader,Writer} as these only implements new reader/writer. Bug: 1055677 Change-Id: I77c12eeb370e5a84a82431b034b580b8dd913324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275372Reviewed-by:Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#784221}
-
- 30 Jun, 2020 25 commits
-
-
David Black authored
Onboarding mode will be wired up to the feature in a follow up CL. Bug: b:157510970 Change-Id: Ifec0007db64361b00c2cb3451cc579a1aa884431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252926 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#784220}
-
Zach Trudo authored
Reporting will regularly need to do exponential backoff on failed requests. This CL creates a standard BackoffEntry object for managing failed requests. Bug: chromium:1078512 Change-Id: I51e9ac33a344e200e283731a9f98430e86920461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276632Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#784219}
-
David Black authored
This will be used by Assistant to present different onboarding experiences based on policy. Actual client-side usage will be wired up in a follow up CL. Bug: b:159069105 Change-Id: I52fae64681f5ae4113d6b58b0e5d5ecb1bbdaccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250587 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
-
Hazim Mohamed authored
In order to implement Drag & Drop, extend the abstract base class NativeFileSystemTransferToken with an implementation that's not tightly coupled to an origin. When exchanging this token for an NativeFileSystemFileHandle/NativeFileSystemDirectoryHandle, a caller should pass in a BindingContext and the NativeFileSystemManager will lazily create the handle. Bug: 1080811 Change-Id: If6daaf628ec27d2e23339901d3db22d9c0386e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243997Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Cr-Commit-Position: refs/heads/master@{#784217}
-
Xida Chen authored
This CL converts base::Callback in the bookmarks/ folder. This is a code health CL, no behavior change. Bug: 1007635 Change-Id: I5a1564ef948a5f1fb90117906918e65e0c8dc602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274157 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#784216}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6685f320c0ae..c75547d598c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidbienvenu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: davidbienvenu@google.com Change-Id: I39db9499e9398d938e9a97a437396a54f44743a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276550Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
David Bienvenu <davidbienvenu@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784215}
-
Lindsay Pasricha authored
Bug: 1098149 Change-Id: Ibca934c3533bc7dbbb6c8fc1306e46adecd39703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273461Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#784214}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I8254dee2987e32a65e6555c996e47129ef54bd25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276679Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784213}
-
Tommy Steimel authored
This CL modifies CrToolbar to allow users of CrToolbar to not set the autofocus attribute to prevent CrToolbar's search bar from being autofocused. Bug: b:157737119 Change-Id: I449f5784e13323377a8b88261c02a9a6a8d90307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276340 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#784212}
-
Hirokazu Honda authored
video_encode_accelerator_tests can specify h264 high for the output profile. However, it doesn't support actually thanks to the bug. This fixes the bug. Bug: None Test: video_encode_accelerator_tests --codec=h264high on eve Change-Id: I62f87a708ed68f9f1a45a4b8a6ed490602fc5ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269382Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#784211}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I5c47b3c44a7030a8373bee73dbf7551bd88f4c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276657 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784210}
-
inglorion authored
During testing and troubleshooting, it is often useful to have goma_link.py and goma_ld.py perform distributed ThinLTO for targets that are not on the allow list. This change adds an --allowlist option which, when given, causes the scripts to proceed as if the target being built is on the allowlist, regardless of whether it actually is. Bug: 1072888 Change-Id: Ide4f273b022d3451cc2eb5341a3ee5e0be1ff323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275633 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#784209}
-
Kenneth Russell authored
Some high-end web applications need to be able to upload more data to the GPU than the GPU process's current 16 GB sandbox limit allows. (At least some of the data uploaded to the GPU is shadowed in CPU memory.) Bug: 1094750 Change-Id: I3c24584d0723f74df9ad561f34e33478b314bdba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274666Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Rohit Rao authored
This reverts commit 6a309aad. Reason for revert: Downstream CL needs to land first Original change's description: > [iOS] Remove all EG1 test targets and related GN components. > > Removed all test targets, EG1 specific test utils in GN files. > Removed gni files to build EG1 targets. > Removed build files in ios/third_party/earl_grey. > > Bug: 1046369 > Change-Id: Iec1d60fa40d10969c4e6e6840f2983b02c3170dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275353 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784204} TBR=rohitrao@chromium.org,zhaoyangli@chromium.org Change-Id: Ied75d5546cde0ff5c3d605e7c005981a8fc26c3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276812Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#784207}
-
Jonathan Freed authored
This excludes dismiss actions from the FeedQuery request for signed in users. Signed in users' dismiss actions are uploaded via the ActionsUpload endpoint. Bug: 1099056 Change-Id: Ibe12e717c346b9f752cd2026ac2f702cf80bcf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274783 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#784206}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Icb922242c8dbcfc9c4be81b355ca83c1aedd1c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276315 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
zhaoyangli authored
Removed all test targets, EG1 specific test utils in GN files. Removed gni files to build EG1 targets. Removed build files in ios/third_party/earl_grey. Bug: 1046369 Change-Id: Iec1d60fa40d10969c4e6e6840f2983b02c3170dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275353 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4f894cfb70fd..2e401eea3e9a 2020-06-30 sadrul@chromium.org [rendering] Report only the average for thread-times metrics. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1073148 Tbr: wenbinzhang@google.com Change-Id: I9ac4460c2fbe288c4cfc7be9a7b33b0bee864f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277041Reviewed-by:
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I7fae5914dab70e9eb95b25dd15ada370522d3bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274825Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784202}
-
Nidhi Jaju authored
This CL removes the ForTest() functions in service_worker_context.h, specifically: - WaitForRegistrationsInitializedForTest() - AddRegistrationToRegisteredOriginsForTest(const url::Origin& origin) The motivation of this change is to avoid unnecessarily exposing methods from service_worker_context_wrapper.cc, and use the FakeServiceWorkerContext instead of using the real context when it is not needed. This leads to better consistency with the storage as well. Bug: 807440 Change-Id: I01791b82062d8e3c3bef63b029e6f77d1fe02469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262398Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#784201}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I7524ffbefbad42f5ccb1d307c2019320dec37286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276241Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784200}
-
Shengfa Lin authored
Once/Repeating For media_sink_desktop.cc, changed Bind and CancelableClosure to BindOnce and CancelableOnceClosure. Bug: 1007649 Change-Id: Ice7f5ee157f51c3b3a85b59dd92c71f3b188c4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277045Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#784199}
-
Sinan Sahin authored
This CL adds browser controls animations for the tab switcher. As changing the margins in every animation frame would cause a relayout and be expensive, we use the translationY property to animate the page. The margins are applied only once at the start or end of the animation. Bug: 1075640 Change-Id: Ic8af8fa9e043bf24bdedcf87ce2ca793f73baa6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269197 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#784198}
-
Thomas Guilbert authored
When nearing the EOS using a resampler to play audio, we sometimes omit the last few frames. This happens when we send all remaining audio buffers to the resampler and partially fill it with silence, but we don't know if we have completely consumed the non-silence frames. This CL fixes the issue by first checking that we have completely filed the resampler with silence, before declaring there is nothing else to play. By doing so, we play silence after the last valid frames, but we will at least play all valid frames. Change-Id: I8ea4d504907746b2ea170ca55169718aee6d8586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276526 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784197}
-
Parastoo Geranmayeh authored
TBR=rdevlin.cronin@chromium.org Bug: 1101043 Change-Id: I512aa9fa95480212fba8d6e291316b65b8651643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277082 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Auto-Submit: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#784196}
-
